[jira] [Commented] (LUCENE-8549) Tessellator should throw an error if all points were not processed
[
https://issues.apache.org/jira/browse/LUCENE-8549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672651#comment-16672651
]
ASF subversion and git services commented on LUCENE-8549:
-
Commit f7720aad82c6340558728c4fdc4dd716104f05f1 in lucene-solr's branch
refs/heads/master from iverase
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f7720aa ]
LUCENE-8549: Polygon tessellator throws an error if some parts of the shape
could not be processed
> Tessellator should throw an error if all points were not processed
> --
>
> Key: LUCENE-8549
> URL: https://issues.apache.org/jira/browse/LUCENE-8549
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/sandbox
>Affects Versions: 7.6, master (8.0)
>Reporter: Ignacio Vera
>Priority: Blocker
> Attachments: LUCENE-8549.patch
>
>
> Currently, the tessellation in some situations when it has not successfully
> process all points in the polygon, it will still return an incomplete/wrong
> tessellation.
> For example the following code:
> {code:java}
> public void testInvalidPolygon() throws Exception {
> String wkt = "POLYGON((0 0, 1 1, 0 1, 1 0, 0 0))";
> Polygon polygon = (Polygon)SimpleWKTShapeParser.parse(wkt);
> expectThrows( IllegalArgumentException.class, () ->
> {Tessellator.tessellate(polygon); });
> }{code}
> will fail as the tessellator return a wrong tessellation containing one
> triangle.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8549) Tessellator should throw an error if all points were not processed
[
https://issues.apache.org/jira/browse/LUCENE-8549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672653#comment-16672653
]
ASF subversion and git services commented on LUCENE-8549:
-
Commit 68fe3801ea6d5a1bfe8af5fd0646dc19fdd0f420 in lucene-solr's branch
refs/heads/branch_7x from iverase
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=68fe380 ]
LUCENE-8549: Polygon tessellator throws an error if some parts of the shape
could not be processed
> Tessellator should throw an error if all points were not processed
> --
>
> Key: LUCENE-8549
> URL: https://issues.apache.org/jira/browse/LUCENE-8549
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/sandbox
>Affects Versions: 7.6, master (8.0)
>Reporter: Ignacio Vera
>Priority: Blocker
> Attachments: LUCENE-8549.patch
>
>
> Currently, the tessellation in some situations when it has not successfully
> process all points in the polygon, it will still return an incomplete/wrong
> tessellation.
> For example the following code:
> {code:java}
> public void testInvalidPolygon() throws Exception {
> String wkt = "POLYGON((0 0, 1 1, 0 1, 1 0, 0 0))";
> Polygon polygon = (Polygon)SimpleWKTShapeParser.parse(wkt);
> expectThrows( IllegalArgumentException.class, () ->
> {Tessellator.tessellate(polygon); });
> }{code}
> will fail as the tessellator return a wrong tessellation containing one
> triangle.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8549) Tessellator should throw an error if all points were not processed
[
https://issues.apache.org/jira/browse/LUCENE-8549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672177#comment-16672177
]
Nicholas Knize commented on LUCENE-8549:
Nice convenience method, and the patch is small and straightforward.
Can you add the explicit testing to {{TestTessellator}}. Then +1 to commit.
> Tessellator should throw an error if all points were not processed
> --
>
> Key: LUCENE-8549
> URL: https://issues.apache.org/jira/browse/LUCENE-8549
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/sandbox
>Affects Versions: 7.6, master (8.0)
>Reporter: Ignacio Vera
>Priority: Blocker
> Attachments: LUCENE-8549.patch
>
>
> Currently, the tessellation in some situations when it has not successfully
> process all points in the polygon, it will still return an incomplete/wrong
> tessellation.
> For example the following code:
> {code:java}
> public void testInvalidPolygon() throws Exception {
> String wkt = "POLYGON((0 0, 1 1, 0 1, 1 0, 0 0))";
> Polygon polygon = (Polygon)SimpleWKTShapeParser.parse(wkt);
> expectThrows( IllegalArgumentException.class, () ->
> {Tessellator.tessellate(polygon); });
> }{code}
> will fail as the tessellator return a wrong tessellation containing one
> triangle.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
