[jira] [Commented] (LUCENE-8660) Include totalHitsThreshold when tracking total hits in TopDocsCollector
[ https://issues.apache.org/jira/browse/LUCENE-8660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754709#comment-16754709 ] ASF subversion and git services commented on LUCENE-8660: - Commit 93d1e67886e75623f3f72526284bdbc3b1fef7e6 in lucene-solr's branch refs/heads/branch_8x from Jim Ferenczi [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=93d1e67 ] LUCENE-8660: TopDocsCollectors now return an accurate count (instead of a lower bound) if the total hit count is equal to the provided threshold. > Include totalHitsThreshold when tracking total hits in TopDocsCollector > --- > > Key: LUCENE-8660 > URL: https://issues.apache.org/jira/browse/LUCENE-8660 > Project: Lucene - Core > Issue Type: Bug >Reporter: Jim Ferenczi >Priority: Minor > Attachments: LUCENE-8660.patch, LUCENE-8660.patch > > > Today the total hits threshold in the top docs collector is not inclusive, > this means that total hits are tracked up to totalHitsThreshold-1. After > discussing with @jpountz we agreed that this is not intuitive to return a > lower bound that is equal to totalHitsThreshold even if the count is accurate. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8660) Include totalHitsThreshold when tracking total hits in TopDocsCollector
[ https://issues.apache.org/jira/browse/LUCENE-8660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754707#comment-16754707 ] ASF subversion and git services commented on LUCENE-8660: - Commit a269a4d1cb7889e5a69aa042316dffdf2a1050a5 in lucene-solr's branch refs/heads/master from Jim Ferenczi [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=a269a4d ] LUCENE-8660: TopDocsCollectors now return an accurate count (instead of a lower bound) if the total hit count is equal to the provided threshold. > Include totalHitsThreshold when tracking total hits in TopDocsCollector > --- > > Key: LUCENE-8660 > URL: https://issues.apache.org/jira/browse/LUCENE-8660 > Project: Lucene - Core > Issue Type: Bug >Reporter: Jim Ferenczi >Priority: Minor > Attachments: LUCENE-8660.patch, LUCENE-8660.patch > > > Today the total hits threshold in the top docs collector is not inclusive, > this means that total hits are tracked up to totalHitsThreshold-1. After > discussing with @jpountz we agreed that this is not intuitive to return a > lower bound that is equal to totalHitsThreshold even if the count is accurate. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8660) Include totalHitsThreshold when tracking total hits in TopDocsCollector
[ https://issues.apache.org/jira/browse/LUCENE-8660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754076#comment-16754076 ] Adrien Grand commented on LUCENE-8660: -- +1 > Include totalHitsThreshold when tracking total hits in TopDocsCollector > --- > > Key: LUCENE-8660 > URL: https://issues.apache.org/jira/browse/LUCENE-8660 > Project: Lucene - Core > Issue Type: Bug >Reporter: Jim Ferenczi >Priority: Minor > Attachments: LUCENE-8660.patch, LUCENE-8660.patch > > > Today the total hits threshold in the top docs collector is not inclusive, > this means that total hits are tracked up to totalHitsThreshold-1. After > discussing with @jpountz we agreed that this is not intuitive to return a > lower bound that is equal to totalHitsThreshold even if the count is accurate. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8660) Include totalHitsThreshold when tracking total hits in TopDocsCollector
[ https://issues.apache.org/jira/browse/LUCENE-8660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753872#comment-16753872 ] Adrien Grand commented on LUCENE-8660: -- Thanks [~jim.ferenczi]. I think we also need to update javadocs and the range of accepted values from [1, MAX_VALUE] to [0, MAX_VALUE]? > Include totalHitsThreshold when tracking total hits in TopDocsCollector > --- > > Key: LUCENE-8660 > URL: https://issues.apache.org/jira/browse/LUCENE-8660 > Project: Lucene - Core > Issue Type: Bug >Reporter: Jim Ferenczi >Priority: Minor > Attachments: LUCENE-8660.patch > > > Today the total hits threshold in the top docs collector is not inclusive, > this means that total hits are tracked up to totalHitsThreshold-1. After > discussing with @jpountz we agreed that this is not intuitive to return a > lower bound that is equal to totalHitsThreshold even if the count is accurate. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
