[jira] [Commented] (SOLR-10397) Port 'autoAddReplicas' feature to the policy rules framework and make it work with non-shared filesystems
[
https://issues.apache.org/jira/browse/SOLR-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089405#comment-16089405
]
Shalin Shekhar Mangar commented on SOLR-10397:
--
Thanks Dat.
bq. OverseerFailover is not guaranteed ( we should tackle this problem in
another issue )
I've opened SOLR-11085 for improving resiliency of actions against overseer
failures.
bq. AutoAddReplicas is triggered by NodeLost event, so when we switch
autoAddReplicas from off to on nothing happen. I think this is ok.
I'm inclined to remove the quirk in how autoAddReplicas used to work and I
don't think we need to support it. Please ensure that both the deprecation of
the cluster property and the change in this behavior is documented in
CHANGES.txt under the upgrade notes section.
A few things I noticed in the patch:
# Typo in AutoAddReplicasIntergrationTest (intergration instead of integration)
# same as above in HdfsAutoAddReplicasIntergrationTest
# There is a large block of code commented out in
SharedFSAutoReplicaFailoverTest. Please remove it if it is no longer needed.
# The TestPolicy.testMoveReplicasInMultipleCollections does not seem like a
very useful test. All it is testing is that some operation is returned. It
should be testing that only the hinted collections' replicas are moved and that
no operation is returned if there are no replicas belonging to the collection
on the node that went down
# minor nit -- {{autoAddReplicas != null && autoAddReplicas.equals("false")}}
can be simplified to {{!Boolean.parseBoolean(autoAddReplicas)}}
# typo in comment "Waitting" in waitForState calls in
AutoAddReplicasIntergrationTest.testSimple
# The return value for {{waitForAllActiveAndLiveReplicas}} in the tests should
be asserted to be true otherwise even after timeout the test silently proceeds
to succeed.
# I am seeing some thread leak failures in HdfsAutoAddReplicasIntergrationTest:
{code}
NOTE: reproduce with: ant test -Dtestcase=HdfsAutoAddReplicasIntergrationTest
-Dtests.seed=EF1C283E3B67B9EE -Dtests.locale=mk-MK -Dtests.timezone=Etc/GMT-2
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
Test ignored.
com.carrotsearch.randomizedtesting.ThreadLeakError: There are still zombie
threads that couldn't be terminated:
1) Thread[id=685, name=ForkJoinPool.commonPool-worker-0,
state=TIMED_WAITING, group=TGRP-HdfsAutoAddReplicasIntergrationTest]
at sun.misc.Unsafe.park(Native Method)
at java.util.concurrent.ForkJoinPool.awaitWork(ForkJoinPool.java:1824)
at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1693)
at
java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157)
2) Thread[id=686, name=ForkJoinPool.commonPool-worker-7, state=WAITING,
group=TGRP-HdfsAutoAddReplicasIntergrationTest]
at sun.misc.Unsafe.park(Native Method)
at java.util.concurrent.ForkJoinPool.awaitWork(ForkJoinPool.java:1824)
at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1693)
at
java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157)
3) Thread[id=687, name=ForkJoinPool.commonPool-worker-1, state=WAITING,
group=TGRP-HdfsAutoAddReplicasIntergrationTest]
at sun.misc.Unsafe.park(Native Method)
at java.util.concurrent.ForkJoinPool.awaitWork(ForkJoinPool.java:1824)
at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1693)
at
java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157)
at __randomizedtesting.SeedInfo.seed([EF1C283E3B67B9EE]:0)
{code}
> Port 'autoAddReplicas' feature to the policy rules framework and make it work
> with non-shared filesystems
> -
>
> Key: SOLR-10397
> URL: https://issues.apache.org/jira/browse/SOLR-10397
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Cao Manh Dat
> Labels: autoscaling
> Fix For: 7.0
>
> Attachments: SOLR-10397.1.patch, SOLR-10397.2.patch, SOLR-10397.patch
>
>
> Currently 'autoAddReplicas=true' can be specified in the Collection Create
> API to automatically add replicas when a replica becomes unavailable. I
> propose to move this feature to the autoscaling cluster policy rules design.
> This will include the following:
> * Trigger support for ‘nodeLost’ event type
> * Modification of existing implementation of ‘autoAddReplicas’ to
> automatically create the appropriate ‘nodeLost’ trigger.
> * Any such auto-created trigger must be marked internally such that setting
> ‘autoAddReplicas=false’ via the Modify Collection API should delete or
> disable
[jira] [Commented] (SOLR-10397) Port 'autoAddReplicas' feature to the policy rules framework and make it work with non-shared filesystems
[ https://issues.apache.org/jira/browse/SOLR-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083891#comment-16083891 ] Shalin Shekhar Mangar commented on SOLR-10397: -- Linking SOLR-11011 as blocker. > Port 'autoAddReplicas' feature to the policy rules framework and make it work > with non-shared filesystems > - > > Key: SOLR-10397 > URL: https://issues.apache.org/jira/browse/SOLR-10397 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: Shalin Shekhar Mangar >Assignee: Cao Manh Dat > Labels: autoscaling > Fix For: 7.0 > > Attachments: SOLR-10397.1.patch, SOLR-10397.patch > > > Currently 'autoAddReplicas=true' can be specified in the Collection Create > API to automatically add replicas when a replica becomes unavailable. I > propose to move this feature to the autoscaling cluster policy rules design. > This will include the following: > * Trigger support for ‘nodeLost’ event type > * Modification of existing implementation of ‘autoAddReplicas’ to > automatically create the appropriate ‘nodeLost’ trigger. > * Any such auto-created trigger must be marked internally such that setting > ‘autoAddReplicas=false’ via the Modify Collection API should delete or > disable corresponding trigger. > * Support for non-HDFS filesystems while retaining the optimization afforded > by HDFS i.e. the replaced replica can point to the existing data dir of the > old replica. > * Deprecate/remove the feature of enabling/disabling ‘autoAddReplicas’ across > the entire cluster using cluster properties in favor of using the > suspend-trigger/resume-trigger APIs. > This will retain backward compatibility for the most part and keep a common > use-case easy to enable as well as make it available to more people (i.e. > people who don't use HDFS). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10397) Port 'autoAddReplicas' feature to the policy rules framework and make it work with non-shared filesystems
[ https://issues.apache.org/jira/browse/SOLR-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083881#comment-16083881 ] Shalin Shekhar Mangar commented on SOLR-10397: -- We also need to throw exception if cluster properties API is used to enable/disable autoAddReplicas. The response message should indicate that the user must use the suspend-trigger/resume-trigger API for the same. > Port 'autoAddReplicas' feature to the policy rules framework and make it work > with non-shared filesystems > - > > Key: SOLR-10397 > URL: https://issues.apache.org/jira/browse/SOLR-10397 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: Shalin Shekhar Mangar >Assignee: Cao Manh Dat > Labels: autoscaling > Fix For: 7.0 > > Attachments: SOLR-10397.1.patch, SOLR-10397.patch > > > Currently 'autoAddReplicas=true' can be specified in the Collection Create > API to automatically add replicas when a replica becomes unavailable. I > propose to move this feature to the autoscaling cluster policy rules design. > This will include the following: > * Trigger support for ‘nodeLost’ event type > * Modification of existing implementation of ‘autoAddReplicas’ to > automatically create the appropriate ‘nodeLost’ trigger. > * Any such auto-created trigger must be marked internally such that setting > ‘autoAddReplicas=false’ via the Modify Collection API should delete or > disable corresponding trigger. > * Support for non-HDFS filesystems while retaining the optimization afforded > by HDFS i.e. the replaced replica can point to the existing data dir of the > old replica. > * Deprecate/remove the feature of enabling/disabling ‘autoAddReplicas’ across > the entire cluster using cluster properties in favor of using the > suspend-trigger/resume-trigger APIs. > This will retain backward compatibility for the most part and keep a common > use-case easy to enable as well as make it available to more people (i.e. > people who don't use HDFS). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10397) Port 'autoAddReplicas' feature to the policy rules framework and make it work with non-shared filesystems
[ https://issues.apache.org/jira/browse/SOLR-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083878#comment-16083878 ] Shalin Shekhar Mangar commented on SOLR-10397: -- Linking SOLR-11045 as blocker > Port 'autoAddReplicas' feature to the policy rules framework and make it work > with non-shared filesystems > - > > Key: SOLR-10397 > URL: https://issues.apache.org/jira/browse/SOLR-10397 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: Shalin Shekhar Mangar >Assignee: Cao Manh Dat > Labels: autoscaling > Fix For: 7.0 > > Attachments: SOLR-10397.1.patch, SOLR-10397.patch > > > Currently 'autoAddReplicas=true' can be specified in the Collection Create > API to automatically add replicas when a replica becomes unavailable. I > propose to move this feature to the autoscaling cluster policy rules design. > This will include the following: > * Trigger support for ‘nodeLost’ event type > * Modification of existing implementation of ‘autoAddReplicas’ to > automatically create the appropriate ‘nodeLost’ trigger. > * Any such auto-created trigger must be marked internally such that setting > ‘autoAddReplicas=false’ via the Modify Collection API should delete or > disable corresponding trigger. > * Support for non-HDFS filesystems while retaining the optimization afforded > by HDFS i.e. the replaced replica can point to the existing data dir of the > old replica. > * Deprecate/remove the feature of enabling/disabling ‘autoAddReplicas’ across > the entire cluster using cluster properties in favor of using the > suspend-trigger/resume-trigger APIs. > This will retain backward compatibility for the most part and keep a common > use-case easy to enable as well as make it available to more people (i.e. > people who don't use HDFS). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10397) Port 'autoAddReplicas' feature to the policy rules framework and make it work with non-shared filesystems
[ https://issues.apache.org/jira/browse/SOLR-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16072095#comment-16072095 ] Cao Manh Dat commented on SOLR-10397: - Thanks [~noble.paul], I added the test. > Port 'autoAddReplicas' feature to the policy rules framework and make it work > with non-shared filesystems > - > > Key: SOLR-10397 > URL: https://issues.apache.org/jira/browse/SOLR-10397 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: Shalin Shekhar Mangar >Assignee: Cao Manh Dat > Labels: autoscaling > Fix For: master (7.0) > > Attachments: SOLR-10397.1.patch, SOLR-10397.patch > > > Currently 'autoAddReplicas=true' can be specified in the Collection Create > API to automatically add replicas when a replica becomes unavailable. I > propose to move this feature to the autoscaling cluster policy rules design. > This will include the following: > * Trigger support for ‘nodeLost’ event type > * Modification of existing implementation of ‘autoAddReplicas’ to > automatically create the appropriate ‘nodeLost’ trigger. > * Any such auto-created trigger must be marked internally such that setting > ‘autoAddReplicas=false’ via the Modify Collection API should delete or > disable corresponding trigger. > * Support for non-HDFS filesystems while retaining the optimization afforded > by HDFS i.e. the replaced replica can point to the existing data dir of the > old replica. > * Deprecate/remove the feature of enabling/disabling ‘autoAddReplicas’ across > the entire cluster using cluster properties in favor of using the > suspend-trigger/resume-trigger APIs. > This will retain backward compatibility for the most part and keep a common > use-case easy to enable as well as make it available to more people (i.e. > people who don't use HDFS). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10397) Port 'autoAddReplicas' feature to the policy rules framework and make it work with non-shared filesystems
[
https://issues.apache.org/jira/browse/SOLR-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069485#comment-16069485
]
Noble Paul commented on SOLR-10397:
---
changes to {{Policy}} LGTM. Please a dd a relevant testcase to {{TestPolicy}} .
Integration tests are hard to debug
> Port 'autoAddReplicas' feature to the policy rules framework and make it work
> with non-shared filesystems
> -
>
> Key: SOLR-10397
> URL: https://issues.apache.org/jira/browse/SOLR-10397
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Cao Manh Dat
> Labels: autoscaling
> Fix For: master (7.0)
>
> Attachments: SOLR-10397.1.patch, SOLR-10397.patch
>
>
> Currently 'autoAddReplicas=true' can be specified in the Collection Create
> API to automatically add replicas when a replica becomes unavailable. I
> propose to move this feature to the autoscaling cluster policy rules design.
> This will include the following:
> * Trigger support for ‘nodeLost’ event type
> * Modification of existing implementation of ‘autoAddReplicas’ to
> automatically create the appropriate ‘nodeLost’ trigger.
> * Any such auto-created trigger must be marked internally such that setting
> ‘autoAddReplicas=false’ via the Modify Collection API should delete or
> disable corresponding trigger.
> * Support for non-HDFS filesystems while retaining the optimization afforded
> by HDFS i.e. the replaced replica can point to the existing data dir of the
> old replica.
> * Deprecate/remove the feature of enabling/disabling ‘autoAddReplicas’ across
> the entire cluster using cluster properties in favor of using the
> suspend-trigger/resume-trigger APIs.
> This will retain backward compatibility for the most part and keep a common
> use-case easy to enable as well as make it available to more people (i.e.
> people who don't use HDFS).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10397) Port 'autoAddReplicas' feature to the policy rules framework and make it work with non-shared filesystems
[
https://issues.apache.org/jira/browse/SOLR-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069392#comment-16069392
]
Cao Manh Dat commented on SOLR-10397:
-
[~shalinmangar]
1. Yeah, that's a good notice, I will fix that soon.
2. We can not do the integration test if we do not have ExecutePlanAction, and
{{AutoAddReplicasPlanActionTest.testSimple}} is a test for
AutoAddReplicasPlanAction only so I removed created trigger to ensure that in
the future we do not have to touch that test.
> Port 'autoAddReplicas' feature to the policy rules framework and make it work
> with non-shared filesystems
> -
>
> Key: SOLR-10397
> URL: https://issues.apache.org/jira/browse/SOLR-10397
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Reporter: Shalin Shekhar Mangar
>Assignee: Cao Manh Dat
> Labels: autoscaling
> Fix For: master (7.0)
>
> Attachments: SOLR-10397.1.patch, SOLR-10397.patch
>
>
> Currently 'autoAddReplicas=true' can be specified in the Collection Create
> API to automatically add replicas when a replica becomes unavailable. I
> propose to move this feature to the autoscaling cluster policy rules design.
> This will include the following:
> * Trigger support for ‘nodeLost’ event type
> * Modification of existing implementation of ‘autoAddReplicas’ to
> automatically create the appropriate ‘nodeLost’ trigger.
> * Any such auto-created trigger must be marked internally such that setting
> ‘autoAddReplicas=false’ via the Modify Collection API should delete or
> disable corresponding trigger.
> * Support for non-HDFS filesystems while retaining the optimization afforded
> by HDFS i.e. the replaced replica can point to the existing data dir of the
> old replica.
> * Deprecate/remove the feature of enabling/disabling ‘autoAddReplicas’ across
> the entire cluster using cluster properties in favor of using the
> suspend-trigger/resume-trigger APIs.
> This will retain backward compatibility for the most part and keep a common
> use-case easy to enable as well as make it available to more people (i.e.
> people who don't use HDFS).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10397) Port 'autoAddReplicas' feature to the policy rules framework and make it work with non-shared filesystems
[ https://issues.apache.org/jira/browse/SOLR-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16068534#comment-16068534 ] Shalin Shekhar Mangar commented on SOLR-10397: -- Thanks Dat. I looked at the autoscaling branch and reviewed the test mostly. A few comments: # The code which creates the set of coreNodeNames on the lost node isn't correct because multiple cores can have the same coreNodeName if they belong to different collections. Moreover, there is no guarantee that the node we shut down actually had replicas from multiple collections. So we need a better logic to assert that no replica belonging to a collection that has autoAddReplicas=false is moved on nodeLost event. # Why remove the implicitly created trigger in AutoAddReplicasPlanActionTest.testSimple? I presume it is because you want to explicitly create the AutoAddReplicasPlanAction which is fine but in that case, a proper end-to-end integration test is also necessary. I'd appreciate if [~noble.paul] can review the changes to Policy and relevant test coverage. > Port 'autoAddReplicas' feature to the policy rules framework and make it work > with non-shared filesystems > - > > Key: SOLR-10397 > URL: https://issues.apache.org/jira/browse/SOLR-10397 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: Shalin Shekhar Mangar >Assignee: Cao Manh Dat > Labels: autoscaling > Fix For: master (7.0) > > Attachments: SOLR-10397.1.patch, SOLR-10397.patch > > > Currently 'autoAddReplicas=true' can be specified in the Collection Create > API to automatically add replicas when a replica becomes unavailable. I > propose to move this feature to the autoscaling cluster policy rules design. > This will include the following: > * Trigger support for ‘nodeLost’ event type > * Modification of existing implementation of ‘autoAddReplicas’ to > automatically create the appropriate ‘nodeLost’ trigger. > * Any such auto-created trigger must be marked internally such that setting > ‘autoAddReplicas=false’ via the Modify Collection API should delete or > disable corresponding trigger. > * Support for non-HDFS filesystems while retaining the optimization afforded > by HDFS i.e. the replaced replica can point to the existing data dir of the > old replica. > * Deprecate/remove the feature of enabling/disabling ‘autoAddReplicas’ across > the entire cluster using cluster properties in favor of using the > suspend-trigger/resume-trigger APIs. > This will retain backward compatibility for the most part and keep a common > use-case easy to enable as well as make it available to more people (i.e. > people who don't use HDFS). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10397) Port 'autoAddReplicas' feature to the policy rules framework and make it work with non-shared filesystems
[ https://issues.apache.org/jira/browse/SOLR-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066146#comment-16066146 ] Cao Manh Dat commented on SOLR-10397: - Committed to feature/autoscaling branch (https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;a=commit;h=5232e36ce5503b79d635e01db810909ed4d3e40d) > Port 'autoAddReplicas' feature to the policy rules framework and make it work > with non-shared filesystems > - > > Key: SOLR-10397 > URL: https://issues.apache.org/jira/browse/SOLR-10397 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: Shalin Shekhar Mangar >Assignee: Cao Manh Dat > Labels: autoscaling > Fix For: master (7.0) > > Attachments: SOLR-10397.1.patch, SOLR-10397.patch > > > Currently 'autoAddReplicas=true' can be specified in the Collection Create > API to automatically add replicas when a replica becomes unavailable. I > propose to move this feature to the autoscaling cluster policy rules design. > This will include the following: > * Trigger support for ‘nodeLost’ event type > * Modification of existing implementation of ‘autoAddReplicas’ to > automatically create the appropriate ‘nodeLost’ trigger. > * Any such auto-created trigger must be marked internally such that setting > ‘autoAddReplicas=false’ via the Modify Collection API should delete or > disable corresponding trigger. > * Support for non-HDFS filesystems while retaining the optimization afforded > by HDFS i.e. the replaced replica can point to the existing data dir of the > old replica. > * Deprecate/remove the feature of enabling/disabling ‘autoAddReplicas’ across > the entire cluster using cluster properties in favor of using the > suspend-trigger/resume-trigger APIs. > This will retain backward compatibility for the most part and keep a common > use-case easy to enable as well as make it available to more people (i.e. > people who don't use HDFS). -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10397) Port 'autoAddReplicas' feature to the policy rules framework and make it work with non-shared filesystems
[ https://issues.apache.org/jira/browse/SOLR-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972082#comment-15972082 ] Cao Manh Dat commented on SOLR-10397: - This issue depends on SOLR-10396 > Port 'autoAddReplicas' feature to the policy rules framework and make it work > with non-shared filesystems > - > > Key: SOLR-10397 > URL: https://issues.apache.org/jira/browse/SOLR-10397 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: Shalin Shekhar Mangar >Assignee: Cao Manh Dat > Labels: autoscaling > Fix For: master (7.0) > > > Currently 'autoAddReplicas=true' can be specified in the Collection Create > API to automatically add replicas when a replica becomes unavailable. I > propose to move this feature to the autoscaling cluster policy rules design. > This will include the following: > * Trigger support for ‘nodeLost’ event type > * Modification of existing implementation of ‘autoAddReplicas’ to > automatically create the appropriate ‘nodeLost’ trigger. > * Any such auto-created trigger must be marked internally such that setting > ‘autoAddReplicas=false’ via the Modify Collection API should delete or > disable corresponding trigger. > * Support for non-HDFS filesystems while retaining the optimization afforded > by HDFS i.e. the replaced replica can point to the existing data dir of the > old replica. > * Deprecate/remove the feature of enabling/disabling ‘autoAddReplicas’ across > the entire cluster using cluster properties in favor of using the > suspend-trigger/resume-trigger APIs. > This will retain backward compatibility for the most part and keep a common > use-case easy to enable as well as make it available to more people (i.e. > people who don't use HDFS). -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10397) Port 'autoAddReplicas' feature to the policy rules framework and make it work with non-shared filesystems
[ https://issues.apache.org/jira/browse/SOLR-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951121#comment-15951121 ] Mark Miller commented on SOLR-10397: Sounds good to me. > Port 'autoAddReplicas' feature to the policy rules framework and make it work > with non-shared filesystems > - > > Key: SOLR-10397 > URL: https://issues.apache.org/jira/browse/SOLR-10397 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Reporter: Shalin Shekhar Mangar > Labels: autoscaling > Fix For: master (7.0) > > > Currently 'autoAddReplicas=true' can be specified in the Collection Create > API to automatically add replicas when a replica becomes unavailable. I > propose to move this feature to the autoscaling cluster policy rules design. > This will include the following: > * Trigger support for ‘nodeLost’ event type > * Modification of existing implementation of ‘autoAddReplicas’ to > automatically create the appropriate ‘nodeLost’ trigger. > * Any such auto-created trigger must be marked internally such that setting > ‘autoAddReplicas=false’ via the Modify Collection API should delete or > disable corresponding trigger. > * Support for non-HDFS filesystems while retaining the optimization afforded > by HDFS i.e. the replaced replica can point to the existing data dir of the > old replica. > * Deprecate/remove the feature of enabling/disabling ‘autoAddReplicas’ across > the entire cluster using cluster properties in favor of using the > suspend-trigger/resume-trigger APIs. > This will retain backward compatibility for the most part and keep a common > use-case easy to enable as well as make it available to more people (i.e. > people who don't use HDFS). -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
