[jira] [Commented] (SOLR-11464) Unused code in DistributedUpdateProcessor
[ https://issues.apache.org/jira/browse/SOLR-11464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210371#comment-16210371 ] ASF subversion and git services commented on SOLR-11464: Commit d71df4c24a208562738d86c533d73ab9a619933a in lucene-solr's branch refs/heads/branch_7x from [~dsmiley] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d71df4c ] SOLR-11464: SOLR-11493: Minor refactorings to DistributedUpdateProcessor (cherry picked from commit 18c8091da5a35d6b0c19253b181b9e2468cd0a37) > Unused code in DistributedUpdateProcessor > - > > Key: SOLR-11464 > URL: https://issues.apache.org/jira/browse/SOLR-11464 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Affects Versions: master (8.0) >Reporter: Gus Heck >Assignee: David Smiley >Priority: Minor > Attachments: SOLR-11464.patch, > SOLR_11464_SOLR_11493_DistributedUrp.patch, unused.png > > > While reading code I ran across a couple of suspicious unused > values/variables. Thought I would raise this so that folks can consider if > something was lost here, or if perhaps we can eliminate an unnecessary call > to zookeeper and tidy things up a bit. Screenshot and patch to eliminate > shortly... -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11464) Unused code in DistributedUpdateProcessor
[ https://issues.apache.org/jira/browse/SOLR-11464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210363#comment-16210363 ] ASF subversion and git services commented on SOLR-11464: Commit 18c8091da5a35d6b0c19253b181b9e2468cd0a37 in lucene-solr's branch refs/heads/master from [~dsmiley] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=18c8091 ] SOLR-11464: SOLR-11493: Minor refactorings to DistributedUpdateProcessor > Unused code in DistributedUpdateProcessor > - > > Key: SOLR-11464 > URL: https://issues.apache.org/jira/browse/SOLR-11464 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Affects Versions: master (8.0) >Reporter: Gus Heck >Assignee: David Smiley >Priority: Minor > Attachments: SOLR-11464.patch, > SOLR_11464_SOLR_11493_DistributedUrp.patch, unused.png > > > While reading code I ran across a couple of suspicious unused > values/variables. Thought I would raise this so that folks can consider if > something was lost here, or if perhaps we can eliminate an unnecessary call > to zookeeper and tidy things up a bit. Screenshot and patch to eliminate > shortly... -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11464) Unused code in DistributedUpdateProcessor
[ https://issues.apache.org/jira/browse/SOLR-11464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205200#comment-16205200 ] David Smiley commented on SOLR-11464: - bq. Thought I would raise this so that folks can consider if something was lost here Looking at git history -- I don't think so; the original SOLR-4997 commit has this. Only [~shalinmangar] could say if there was work in progress that explains how this code came to be. > Unused code in DistributedUpdateProcessor > - > > Key: SOLR-11464 > URL: https://issues.apache.org/jira/browse/SOLR-11464 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Affects Versions: master (8.0) >Reporter: Gus Heck >Assignee: David Smiley >Priority: Minor > Attachments: SOLR-11464.patch, unused.png > > > While reading code I ran across a couple of suspicious unused > values/variables. Thought I would raise this so that folks can consider if > something was lost here, or if perhaps we can eliminate an unnecessary call > to zookeeper and tidy things up a bit. Screenshot and patch to eliminate > shortly... -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11464) Unused code in DistributedUpdateProcessor
[ https://issues.apache.org/jira/browse/SOLR-11464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205181#comment-16205181 ] Yonik Seeley commented on SOLR-11464: - bq. I'm inclined to think Gus's simple refactoring is safe. Even if it's shown there are no side-effects, Gus's other comment is the more important point IMO: "Thought I would raise this so that folks can consider if something was lost here" > Unused code in DistributedUpdateProcessor > - > > Key: SOLR-11464 > URL: https://issues.apache.org/jira/browse/SOLR-11464 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Affects Versions: master (8.0) >Reporter: Gus Heck >Assignee: David Smiley >Priority: Minor > Attachments: SOLR-11464.patch, unused.png > > > While reading code I ran across a couple of suspicious unused > values/variables. Thought I would raise this so that folks can consider if > something was lost here, or if perhaps we can eliminate an unnecessary call > to zookeeper and tidy things up a bit. Screenshot and patch to eliminate > shortly... -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11464) Unused code in DistributedUpdateProcessor
[ https://issues.apache.org/jira/browse/SOLR-11464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205169#comment-16205169 ] David Smiley commented on SOLR-11464: - The code here hasn't been changed substantially from SOLR-4997 (shard split) by [~shalinmangar]. Shalin do you think there are side effects from these lines or should we just refactor them as Gus suggests? If they need to be there, obviously there should be explicit comments to this effect. Since such comments don't exist, I'm inclined to think Gus's simple refactoring is safe. > Unused code in DistributedUpdateProcessor > - > > Key: SOLR-11464 > URL: https://issues.apache.org/jira/browse/SOLR-11464 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Affects Versions: master (8.0) >Reporter: Gus Heck >Assignee: David Smiley >Priority: Minor > Attachments: SOLR-11464.patch, unused.png > > > While reading code I ran across a couple of suspicious unused > values/variables. Thought I would raise this so that folks can consider if > something was lost here, or if perhaps we can eliminate an unnecessary call > to zookeeper and tidy things up a bit. Screenshot and patch to eliminate > shortly... -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11464) Unused code in DistributedUpdateProcessor
[ https://issues.apache.org/jira/browse/SOLR-11464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16204623#comment-16204623 ] Gus Heck commented on SOLR-11464: - I have since run the core tests (where all the failures occurred) with the default number of processors (4 instead of 30) and they passed on 7 rounds of beast and fail on the 8th .. I had a similar result without the patch. > Unused code in DistributedUpdateProcessor > - > > Key: SOLR-11464 > URL: https://issues.apache.org/jira/browse/SOLR-11464 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Affects Versions: master (8.0) >Reporter: Gus Heck >Assignee: David Smiley >Priority: Minor > Attachments: SOLR-11464.patch, unused.png > > > While reading code I ran across a couple of suspicious unused > values/variables. Thought I would raise this so that folks can consider if > something was lost here, or if perhaps we can eliminate an unnecessary call > to zookeeper and tidy things up a bit. Screenshot and patch to eliminate > shortly... -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11464) Unused code in DistributedUpdateProcessor
[ https://issues.apache.org/jira/browse/SOLR-11464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199691#comment-16199691 ] Gus Heck commented on SOLR-11464: - In the attached screen shot intellij is graying out 2 variables, the first is assigned a value that is never used thereafter, and the second is created and never used. > Unused code in DistributedUpdateProcessor > - > > Key: SOLR-11464 > URL: https://issues.apache.org/jira/browse/SOLR-11464 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud >Affects Versions: master (8.0) >Reporter: Gus Heck >Priority: Minor > Attachments: unused.png > > > While reading code I ran across a couple of suspicious unused > values/variables. Thought I would raise this so that folks can consider if > something was lost here, or if perhaps we can eliminate an unnecessary call > to zookeeper and tidy things up a bit. Screenshot and patch to eliminate > shortly... -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
