[jira] [Commented] (SOLR-4234) Add support for binary files in ZooKeeper.
[ https://issues.apache.org/jira/browse/SOLR-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655697#comment-13655697 ] Commit Tag Bot commented on SOLR-4234: -- [branch_4x commit] markrmiller http://svn.apache.org/viewvc?view=revision&revision=1481676 SOLR-4234: Add support for binary files in ZooKeeper. > Add support for binary files in ZooKeeper. > -- > > Key: SOLR-4234 > URL: https://issues.apache.org/jira/browse/SOLR-4234 > Project: Solr > Issue Type: Bug > Components: SolrCloud >Affects Versions: 4.0 >Reporter: Eric Pugh >Assignee: Mark Miller > Fix For: 4.4 > > Attachments: binary_upload_download.patch, > fix_show_file_handler_with_binaries.patch, SOLR4234_binary_files.patch, > solr.png > > > I was attempting to get the ShowFileHandler to show a .png file, and it was > failing. But in non-ZK mode it worked just fine! It took a while, but it > seems that we upload to zk as a text, and download as well. I've attached a > unit test that demonstrates the problem, and a fix. You have to have a > binary file in the conf directory to make the test work, I put solr.png in > the collection1/conf/velocity directory. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4234) Add support for binary files in ZooKeeper.
[ https://issues.apache.org/jira/browse/SOLR-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655696#comment-13655696 ] Commit Tag Bot commented on SOLR-4234: -- [trunk commit] markrmiller http://svn.apache.org/viewvc?view=revision&revision=1481675 SOLR-4234: Add support for binary files in ZooKeeper. > Add support for binary files in ZooKeeper. > -- > > Key: SOLR-4234 > URL: https://issues.apache.org/jira/browse/SOLR-4234 > Project: Solr > Issue Type: Bug > Components: SolrCloud >Affects Versions: 4.0 >Reporter: Eric Pugh >Assignee: Mark Miller > Fix For: 4.4 > > Attachments: binary_upload_download.patch, > fix_show_file_handler_with_binaries.patch, SOLR4234_binary_files.patch, > solr.png > > > I was attempting to get the ShowFileHandler to show a .png file, and it was > failing. But in non-ZK mode it worked just fine! It took a while, but it > seems that we upload to zk as a text, and download as well. I've attached a > unit test that demonstrates the problem, and a fix. You have to have a > binary file in the conf directory to make the test work, I put solr.png in > the collection1/conf/velocity directory. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4234) Add support for binary files in ZooKeeper.
[ https://issues.apache.org/jira/browse/SOLR-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13595318#comment-13595318 ] Mark Miller commented on SOLR-4234: --- Ping - still interested in this Eric? I'll get to it eventually anyway, but it may take a little longer. > Add support for binary files in ZooKeeper. > -- > > Key: SOLR-4234 > URL: https://issues.apache.org/jira/browse/SOLR-4234 > Project: Solr > Issue Type: Bug > Components: SolrCloud >Affects Versions: 4.0 >Reporter: Eric Pugh >Assignee: Mark Miller > Fix For: 4.2, 5.0 > > Attachments: binary_upload_download.patch, > fix_show_file_handler_with_binaries.patch, SOLR4234_binary_files.patch, > solr.png > > > I was attempting to get the ShowFileHandler to show a .png file, and it was > failing. But in non-ZK mode it worked just fine! It took a while, but it > seems that we upload to zk as a text, and download as well. I've attached a > unit test that demonstrates the problem, and a fix. You have to have a > binary file in the conf directory to make the test work, I put solr.png in > the collection1/conf/velocity directory. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4234) Add support for binary files in ZooKeeper.
[ https://issues.apache.org/jira/browse/SOLR-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13564022#comment-13564022 ] Mark Miller commented on SOLR-4234: --- Let me know if you make any progress Eric - I'd like this to make 4.2. > Add support for binary files in ZooKeeper. > -- > > Key: SOLR-4234 > URL: https://issues.apache.org/jira/browse/SOLR-4234 > Project: Solr > Issue Type: Bug > Components: SolrCloud >Affects Versions: 4.0 >Reporter: Eric Pugh >Assignee: Mark Miller > Fix For: 4.2, 5.0 > > Attachments: binary_upload_download.patch, > fix_show_file_handler_with_binaries.patch, SOLR4234_binary_files.patch, > solr.png > > > I was attempting to get the ShowFileHandler to show a .png file, and it was > failing. But in non-ZK mode it worked just fine! It took a while, but it > seems that we upload to zk as a text, and download as well. I've attached a > unit test that demonstrates the problem, and a fix. You have to have a > binary file in the conf directory to make the test work, I put solr.png in > the collection1/conf/velocity directory. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4234) Add support for binary files in ZooKeeper.
[ https://issues.apache.org/jira/browse/SOLR-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555197#comment-13555197 ] Eric Pugh commented on SOLR-4234: - This isn't worth delaying a release! I am somewhat struggling to figure out why the test is failing. Going to try on a new code checkout. > Add support for binary files in ZooKeeper. > -- > > Key: SOLR-4234 > URL: https://issues.apache.org/jira/browse/SOLR-4234 > Project: Solr > Issue Type: Bug > Components: SolrCloud >Affects Versions: 4.0 >Reporter: Eric Pugh >Assignee: Mark Miller > Fix For: 4.2, 5.0 > > Attachments: binary_upload_download.patch, > fix_show_file_handler_with_binaries.patch, SOLR4234_binary_files.patch, > solr.png > > > I was attempting to get the ShowFileHandler to show a .png file, and it was > failing. But in non-ZK mode it worked just fine! It took a while, but it > seems that we upload to zk as a text, and download as well. I've attached a > unit test that demonstrates the problem, and a fix. You have to have a > binary file in the conf directory to make the test work, I put solr.png in > the collection1/conf/velocity directory. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4234) Add support for binary files in ZooKeeper.
[ https://issues.apache.org/jira/browse/SOLR-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554541#comment-13554541 ] Steve Rowe commented on SOLR-4234: -- Mark, Erik, Eric: can we push this to 4.2? > Add support for binary files in ZooKeeper. > -- > > Key: SOLR-4234 > URL: https://issues.apache.org/jira/browse/SOLR-4234 > Project: Solr > Issue Type: Bug > Components: SolrCloud >Affects Versions: 4.0 >Reporter: Eric Pugh >Assignee: Mark Miller > Fix For: 4.1, 5.0 > > Attachments: binary_upload_download.patch, > fix_show_file_handler_with_binaries.patch, SOLR4234_binary_files.patch, > solr.png > > > I was attempting to get the ShowFileHandler to show a .png file, and it was > failing. But in non-ZK mode it worked just fine! It took a while, but it > seems that we upload to zk as a text, and download as well. I've attached a > unit test that demonstrates the problem, and a fix. You have to have a > binary file in the conf directory to make the test work, I put solr.png in > the collection1/conf/velocity directory. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4234) Add support for binary files in ZooKeeper.
[
https://issues.apache.org/jira/browse/SOLR-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554113#comment-13554113
]
Erik Hatcher commented on SOLR-4234:
I'm not a fan of this change:
{quote}
Index: example/solr/collection1/conf/velocity/header.vm
===
--- example/solr/collection1/conf/velocity/header.vm(revision 1433108)
+++ example/solr/collection1/conf/velocity/header.vm(working copy)
@@ -1,3 +1,3 @@
-
+
{quote}
This means that solr.png needs to be duplicated into every core's configuration
rather than coming from the Solr web app itself. I get this as an example of
serving a binary file from ZK, but let's not bake it into the collection1
example like this.
> Add support for binary files in ZooKeeper.
> --
>
> Key: SOLR-4234
> URL: https://issues.apache.org/jira/browse/SOLR-4234
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
>Affects Versions: 4.0
>Reporter: Eric Pugh
>Assignee: Mark Miller
> Fix For: 4.1, 5.0
>
> Attachments: binary_upload_download.patch,
> fix_show_file_handler_with_binaries.patch, SOLR4234_binary_files.patch,
> solr.png
>
>
> I was attempting to get the ShowFileHandler to show a .png file, and it was
> failing. But in non-ZK mode it worked just fine! It took a while, but it
> seems that we upload to zk as a text, and download as well. I've attached a
> unit test that demonstrates the problem, and a fix. You have to have a
> binary file in the conf directory to make the test work, I put solr.png in
> the collection1/conf/velocity directory.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4234) Add support for binary files in ZooKeeper.
[ https://issues.apache.org/jira/browse/SOLR-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553302#comment-13553302 ] Mark Miller commented on SOLR-4234: --- Hey Eric, I"m seeing the following tests fail: java.lang.AssertionError: Make sure we did download each file in the original configuration at __randomizedtesting.SeedInfo.seed([BB2B109CDBABDCE7:9F4DBD9251646A81]:0) at org.junit.Assert.fail(Assert.java:93) at org.junit.Assert.assertTrue(Assert.java:43) at org.apache.solr.cloud.ZkCLITest.testUpConfigLinkConfigClearZk(ZkCLITest.java:182) > Add support for binary files in ZooKeeper. > -- > > Key: SOLR-4234 > URL: https://issues.apache.org/jira/browse/SOLR-4234 > Project: Solr > Issue Type: Bug > Components: SolrCloud >Affects Versions: 4.0 >Reporter: Eric Pugh >Assignee: Mark Miller > Fix For: 4.1, 5.0 > > Attachments: binary_upload_download.patch, > fix_show_file_handler_with_binaries.patch, SOLR4234_binary_files.patch, > solr.png > > > I was attempting to get the ShowFileHandler to show a .png file, and it was > failing. But in non-ZK mode it worked just fine! It took a while, but it > seems that we upload to zk as a text, and download as well. I've attached a > unit test that demonstrates the problem, and a fix. You have to have a > binary file in the conf directory to make the test work, I put solr.png in > the collection1/conf/velocity directory. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
