[jira] [Commented] (SOLR-7381) Improve Debuggability of SolrCloud using MDC
[ https://issues.apache.org/jira/browse/SOLR-7381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684166#comment-16684166 ] Shalin Shekhar Mangar commented on SOLR-7381: - [~yuzhih...@gmail.com] - No, our implementation explicitly sets MDC context from parent threads and unsets/restores old context once the submitted task finishes. See ExecutorUtil.MDCAwareThreadPoolExecutor for the implementation. > Improve Debuggability of SolrCloud using MDC > > > Key: SOLR-7381 > URL: https://issues.apache.org/jira/browse/SOLR-7381 > Project: Solr > Issue Type: Improvement > Components: SolrCloud >Reporter: Shalin Shekhar Mangar >Assignee: Shalin Shekhar Mangar >Priority: Critical > Fix For: 5.2, 6.0 > > Attachments: SOLR-7381-forbid-threadpoolexecutor.patch, > SOLR-7381-submitter-stacktrace.patch, SOLR-7381-thread-names.patch, > SOLR-7381-thread-names.patch, SOLR-7381-thread-names.patch, SOLR-7381.patch, > SOLR-7381.patch > > > SOLR-6673 added MDC based logging in a few places but we have a lot of ground > to cover. > # Threads created via thread pool executors do not inherit MDC values and > those are some of the most interesting places to log MDC context. > # We must expose node names (in tests) so that we can debug faster > # We can expose more information via thread names so that a thread dump has > enough context to help debug problems in production > This is critical to help debug SolrCloud failures. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7381) Improve Debuggability of SolrCloud using MDC
[ https://issues.apache.org/jira/browse/SOLR-7381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671925#comment-16671925 ] Ted Yu commented on SOLR-7381: -- I was looking at MDCAwareFixedThreadPool and found this JIRA. I wonder if what was stated here is relevant: http://ashtonkemerling.com/blog/2017/09/01/mdc-and-threadpools/ Thanks > Improve Debuggability of SolrCloud using MDC > > > Key: SOLR-7381 > URL: https://issues.apache.org/jira/browse/SOLR-7381 > Project: Solr > Issue Type: Improvement > Components: SolrCloud >Reporter: Shalin Shekhar Mangar >Assignee: Shalin Shekhar Mangar >Priority: Critical > Fix For: 5.2, 6.0 > > Attachments: SOLR-7381-forbid-threadpoolexecutor.patch, > SOLR-7381-submitter-stacktrace.patch, SOLR-7381-thread-names.patch, > SOLR-7381-thread-names.patch, SOLR-7381-thread-names.patch, SOLR-7381.patch, > SOLR-7381.patch > > > SOLR-6673 added MDC based logging in a few places but we have a lot of ground > to cover. > # Threads created via thread pool executors do not inherit MDC values and > those are some of the most interesting places to log MDC context. > # We must expose node names (in tests) so that we can debug faster > # We can expose more information via thread names so that a thread dump has > enough context to help debug problems in production > This is critical to help debug SolrCloud failures. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7381) Improve Debuggability of SolrCloud using MDC
[ https://issues.apache.org/jira/browse/SOLR-7381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14501676#comment-14501676 ] ASF subversion and git services commented on SOLR-7381: --- Commit 1674593 from sha...@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1674593 ] SOLR-7381: Uncaught exceptions thrown by tasks in the pool are logged along with submitter's stack trace Improve Debuggability of SolrCloud using MDC Key: SOLR-7381 URL: https://issues.apache.org/jira/browse/SOLR-7381 Project: Solr Issue Type: Improvement Components: SolrCloud Reporter: Shalin Shekhar Mangar Assignee: Shalin Shekhar Mangar Priority: Critical Fix For: 5.2 Attachments: SOLR-7381-forbid-threadpoolexecutor.patch, SOLR-7381-submitter-stacktrace.patch, SOLR-7381-thread-names.patch, SOLR-7381-thread-names.patch, SOLR-7381-thread-names.patch, SOLR-7381.patch, SOLR-7381.patch SOLR-6673 added MDC based logging in a few places but we have a lot of ground to cover. # Threads created via thread pool executors do not inherit MDC values and those are some of the most interesting places to log MDC context. # We must expose node names (in tests) so that we can debug faster # We can expose more information via thread names so that a thread dump has enough context to help debug problems in production This is critical to help debug SolrCloud failures. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7381) Improve Debuggability of SolrCloud using MDC
[ https://issues.apache.org/jira/browse/SOLR-7381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14501677#comment-14501677 ] ASF subversion and git services commented on SOLR-7381: --- Commit 1674594 from sha...@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1674594 ] SOLR-7381: Uncaught exceptions thrown by tasks in the pool are logged along with submitter's stack trace Improve Debuggability of SolrCloud using MDC Key: SOLR-7381 URL: https://issues.apache.org/jira/browse/SOLR-7381 Project: Solr Issue Type: Improvement Components: SolrCloud Reporter: Shalin Shekhar Mangar Assignee: Shalin Shekhar Mangar Priority: Critical Fix For: 5.2 Attachments: SOLR-7381-forbid-threadpoolexecutor.patch, SOLR-7381-submitter-stacktrace.patch, SOLR-7381-thread-names.patch, SOLR-7381-thread-names.patch, SOLR-7381-thread-names.patch, SOLR-7381.patch, SOLR-7381.patch SOLR-6673 added MDC based logging in a few places but we have a lot of ground to cover. # Threads created via thread pool executors do not inherit MDC values and those are some of the most interesting places to log MDC context. # We must expose node names (in tests) so that we can debug faster # We can expose more information via thread names so that a thread dump has enough context to help debug problems in production This is critical to help debug SolrCloud failures. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7381) Improve Debuggability of SolrCloud using MDC
[ https://issues.apache.org/jira/browse/SOLR-7381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493685#comment-14493685 ] ASF subversion and git services commented on SOLR-7381: --- Commit 1673372 from sha...@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1673372 ] SOLR-7381: Usages of Executors#newFixedThreadPool, #newSingleThreadExecutor, #newCachedThreadPool as well as ThreadPoolExecutor directly is now forbidden in Solr Improve Debuggability of SolrCloud using MDC Key: SOLR-7381 URL: https://issues.apache.org/jira/browse/SOLR-7381 Project: Solr Issue Type: Improvement Components: SolrCloud Reporter: Shalin Shekhar Mangar Assignee: Shalin Shekhar Mangar Priority: Critical Fix For: 5.2 Attachments: SOLR-7381-forbid-threadpoolexecutor.patch, SOLR-7381-thread-names.patch, SOLR-7381.patch, SOLR-7381.patch SOLR-6673 added MDC based logging in a few places but we have a lot of ground to cover. # Threads created via thread pool executors do not inherit MDC values and those are some of the most interesting places to log MDC context. # We must expose node names (in tests) so that we can debug faster # We can expose more information via thread names so that a thread dump has enough context to help debug problems in production This is critical to help debug SolrCloud failures. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7381) Improve Debuggability of SolrCloud using MDC
[ https://issues.apache.org/jira/browse/SOLR-7381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493687#comment-14493687 ] ASF subversion and git services commented on SOLR-7381: --- Commit 1673373 from sha...@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1673373 ] SOLR-7381: Usages of Executors#newFixedThreadPool, #newSingleThreadExecutor, #newCachedThreadPool as well as ThreadPoolExecutor directly is now forbidden in Solr Improve Debuggability of SolrCloud using MDC Key: SOLR-7381 URL: https://issues.apache.org/jira/browse/SOLR-7381 Project: Solr Issue Type: Improvement Components: SolrCloud Reporter: Shalin Shekhar Mangar Assignee: Shalin Shekhar Mangar Priority: Critical Fix For: 5.2 Attachments: SOLR-7381-forbid-threadpoolexecutor.patch, SOLR-7381-thread-names.patch, SOLR-7381.patch, SOLR-7381.patch SOLR-6673 added MDC based logging in a few places but we have a lot of ground to cover. # Threads created via thread pool executors do not inherit MDC values and those are some of the most interesting places to log MDC context. # We must expose node names (in tests) so that we can debug faster # We can expose more information via thread names so that a thread dump has enough context to help debug problems in production This is critical to help debug SolrCloud failures. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7381) Improve Debuggability of SolrCloud using MDC
[ https://issues.apache.org/jira/browse/SOLR-7381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14494005#comment-14494005 ] ASF subversion and git services commented on SOLR-7381: --- Commit 1673412 from sha...@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1673412 ] SOLR-7381: Set node name in MDC inside ZkController as soon as we discover it Improve Debuggability of SolrCloud using MDC Key: SOLR-7381 URL: https://issues.apache.org/jira/browse/SOLR-7381 Project: Solr Issue Type: Improvement Components: SolrCloud Reporter: Shalin Shekhar Mangar Assignee: Shalin Shekhar Mangar Priority: Critical Fix For: 5.2 Attachments: SOLR-7381-forbid-threadpoolexecutor.patch, SOLR-7381-thread-names.patch, SOLR-7381.patch, SOLR-7381.patch SOLR-6673 added MDC based logging in a few places but we have a lot of ground to cover. # Threads created via thread pool executors do not inherit MDC values and those are some of the most interesting places to log MDC context. # We must expose node names (in tests) so that we can debug faster # We can expose more information via thread names so that a thread dump has enough context to help debug problems in production This is critical to help debug SolrCloud failures. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7381) Improve Debuggability of SolrCloud using MDC
[ https://issues.apache.org/jira/browse/SOLR-7381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14494004#comment-14494004 ] ASF subversion and git services commented on SOLR-7381: --- Commit 1673411 from sha...@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1673411 ] SOLR-7381: Set node name in MDC inside ZkController as soon as we discover it Improve Debuggability of SolrCloud using MDC Key: SOLR-7381 URL: https://issues.apache.org/jira/browse/SOLR-7381 Project: Solr Issue Type: Improvement Components: SolrCloud Reporter: Shalin Shekhar Mangar Assignee: Shalin Shekhar Mangar Priority: Critical Fix For: 5.2 Attachments: SOLR-7381-forbid-threadpoolexecutor.patch, SOLR-7381-thread-names.patch, SOLR-7381.patch, SOLR-7381.patch SOLR-6673 added MDC based logging in a few places but we have a lot of ground to cover. # Threads created via thread pool executors do not inherit MDC values and those are some of the most interesting places to log MDC context. # We must expose node names (in tests) so that we can debug faster # We can expose more information via thread names so that a thread dump has enough context to help debug problems in production This is critical to help debug SolrCloud failures. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7381) Improve Debuggability of SolrCloud using MDC
[ https://issues.apache.org/jira/browse/SOLR-7381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14494404#comment-14494404 ] ASF subversion and git services commented on SOLR-7381: --- Commit 1673471 from sha...@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1673471 ] SOLR-7381: MDC keys are now exposed in thread names automatically so that a thread dump can give hints on what the thread was doing Improve Debuggability of SolrCloud using MDC Key: SOLR-7381 URL: https://issues.apache.org/jira/browse/SOLR-7381 Project: Solr Issue Type: Improvement Components: SolrCloud Reporter: Shalin Shekhar Mangar Assignee: Shalin Shekhar Mangar Priority: Critical Fix For: 5.2 Attachments: SOLR-7381-forbid-threadpoolexecutor.patch, SOLR-7381-thread-names.patch, SOLR-7381-thread-names.patch, SOLR-7381-thread-names.patch, SOLR-7381.patch, SOLR-7381.patch SOLR-6673 added MDC based logging in a few places but we have a lot of ground to cover. # Threads created via thread pool executors do not inherit MDC values and those are some of the most interesting places to log MDC context. # We must expose node names (in tests) so that we can debug faster # We can expose more information via thread names so that a thread dump has enough context to help debug problems in production This is critical to help debug SolrCloud failures. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7381) Improve Debuggability of SolrCloud using MDC
[ https://issues.apache.org/jira/browse/SOLR-7381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14494402#comment-14494402 ] ASF subversion and git services commented on SOLR-7381: --- Commit 1673469 from sha...@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1673469 ] SOLR-7381: MDC keys are now exposed in thread names automatically so that a thread dump can give hints on what the thread was doing Improve Debuggability of SolrCloud using MDC Key: SOLR-7381 URL: https://issues.apache.org/jira/browse/SOLR-7381 Project: Solr Issue Type: Improvement Components: SolrCloud Reporter: Shalin Shekhar Mangar Assignee: Shalin Shekhar Mangar Priority: Critical Fix For: 5.2 Attachments: SOLR-7381-forbid-threadpoolexecutor.patch, SOLR-7381-thread-names.patch, SOLR-7381-thread-names.patch, SOLR-7381-thread-names.patch, SOLR-7381.patch, SOLR-7381.patch SOLR-6673 added MDC based logging in a few places but we have a lot of ground to cover. # Threads created via thread pool executors do not inherit MDC values and those are some of the most interesting places to log MDC context. # We must expose node names (in tests) so that we can debug faster # We can expose more information via thread names so that a thread dump has enough context to help debug problems in production This is critical to help debug SolrCloud failures. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
