[jira] [Commented] (SOLR-9681) add filter to any facet
[ https://issues.apache.org/jira/browse/SOLR-9681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15630964#comment-15630964 ] ASF subversion and git services commented on SOLR-9681: --- Commit 359f981b0e2737c3d019d0097e5be3bf76874407 in lucene-solr's branch refs/heads/apiv2 from [~yo...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=359f981 ] SOLR-9681: move "filter" inside "domain" block > add filter to any facet > --- > > Key: SOLR-9681 > URL: https://issues.apache.org/jira/browse/SOLR-9681 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Yonik Seeley >Assignee: Yonik Seeley > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9681.patch, SOLR-9681.patch > > > For the JSON Facet API, we should be able to add a list of filters to any > facet. These would be applied after any domain changes, hence useful for > parent->child mapping that would otherwise match all children of any parent > (SOLR-9510) > The API should also be consistent with "filter" at the top level of the JSON > Request API (examples at http://yonik.com/solr-json-request-api/ ) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9681) add filter to any facet
[ https://issues.apache.org/jira/browse/SOLR-9681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15625857#comment-15625857 ] ASF subversion and git services commented on SOLR-9681: --- Commit 8c42045f2781e44b22bf9ac8faca0b32346e5cc3 in lucene-solr's branch refs/heads/branch_6x from [~yo...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8c42045 ] SOLR-9681: move "filter" inside "domain" block > add filter to any facet > --- > > Key: SOLR-9681 > URL: https://issues.apache.org/jira/browse/SOLR-9681 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Yonik Seeley >Assignee: Yonik Seeley > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9681.patch, SOLR-9681.patch > > > For the JSON Facet API, we should be able to add a list of filters to any > facet. These would be applied after any domain changes, hence useful for > parent->child mapping that would otherwise match all children of any parent > (SOLR-9510) > The API should also be consistent with "filter" at the top level of the JSON > Request API (examples at http://yonik.com/solr-json-request-api/ ) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9681) add filter to any facet
[ https://issues.apache.org/jira/browse/SOLR-9681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15625803#comment-15625803 ] ASF subversion and git services commented on SOLR-9681: --- Commit 359f981b0e2737c3d019d0097e5be3bf76874407 in lucene-solr's branch refs/heads/master from [~yo...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=359f981 ] SOLR-9681: move "filter" inside "domain" block > add filter to any facet > --- > > Key: SOLR-9681 > URL: https://issues.apache.org/jira/browse/SOLR-9681 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Yonik Seeley >Assignee: Yonik Seeley > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9681.patch, SOLR-9681.patch > > > For the JSON Facet API, we should be able to add a list of filters to any > facet. These would be applied after any domain changes, hence useful for > parent->child mapping that would otherwise match all children of any parent > (SOLR-9510) > The API should also be consistent with "filter" at the top level of the JSON > Request API (examples at http://yonik.com/solr-json-request-api/ ) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9681) add filter to any facet
[ https://issues.apache.org/jira/browse/SOLR-9681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622448#comment-15622448 ] Yonik Seeley commented on SOLR-9681: OK, unless there are objections, I'll move "filter" to be within "domain". > add filter to any facet > --- > > Key: SOLR-9681 > URL: https://issues.apache.org/jira/browse/SOLR-9681 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Yonik Seeley >Assignee: Yonik Seeley > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9681.patch > > > For the JSON Facet API, we should be able to add a list of filters to any > facet. These would be applied after any domain changes, hence useful for > parent->child mapping that would otherwise match all children of any parent > (SOLR-9510) > The API should also be consistent with "filter" at the top level of the JSON > Request API (examples at http://yonik.com/solr-json-request-api/ ) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9681) add filter to any facet
[ https://issues.apache.org/jira/browse/SOLR-9681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622300#comment-15622300 ] David Smiley commented on SOLR-9681: I think I like "filter" underneath "domain". It's clearer *what* is being filtered -- the domain. Granted that raises the question to users as to what the "domain" is but it's something. > add filter to any facet > --- > > Key: SOLR-9681 > URL: https://issues.apache.org/jira/browse/SOLR-9681 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Yonik Seeley >Assignee: Yonik Seeley > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9681.patch > > > For the JSON Facet API, we should be able to add a list of filters to any > facet. These would be applied after any domain changes, hence useful for > parent->child mapping that would otherwise match all children of any parent > (SOLR-9510) > The API should also be consistent with "filter" at the top level of the JSON > Request API (examples at http://yonik.com/solr-json-request-api/ ) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9681) add filter to any facet
[ https://issues.apache.org/jira/browse/SOLR-9681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622219#comment-15622219 ] Yonik Seeley commented on SOLR-9681: Now that you've made me think about it... I'm definitely on the fence, and perhaps closer to the "just put it in domain" side. Anyone else have thoughts? This is the right time to think about this minor API stuff, and then stick to it for the long haul! "domain" is only for non-narrowing domain changes: - If filtering will be used a lot by itself, then it's simpler not to have to enclose it in an extra "domain" "domain" is for *all* domain changes prior to faceting: - If filtering will primarily be used with things like blockChildren, "domain" will already exist, and it's natural for the additional child filters to go right there. - The *only* "narrowing" way to change the domain (other than faceting itself), is "filter". There are unlikely to be others in the future, and thus having a separate class/distinction at the syntactic level does not seem important. > add filter to any facet > --- > > Key: SOLR-9681 > URL: https://issues.apache.org/jira/browse/SOLR-9681 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Yonik Seeley >Assignee: Yonik Seeley > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9681.patch > > > For the JSON Facet API, we should be able to add a list of filters to any > facet. These would be applied after any domain changes, hence useful for > parent->child mapping that would otherwise match all children of any parent > (SOLR-9510) > The API should also be consistent with "filter" at the top level of the JSON > Request API (examples at http://yonik.com/solr-json-request-api/ ) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9681) add filter to any facet
[
https://issues.apache.org/jira/browse/SOLR-9681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622180#comment-15622180
]
Mikhail Khludnev commented on SOLR-9681:
ok. Agree. Now it can be seen as {{domain}} executed strictly before filtering
and faceting.
> add filter to any facet
> ---
>
> Key: SOLR-9681
> URL: https://issues.apache.org/jira/browse/SOLR-9681
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Facet Module
>Reporter: Yonik Seeley
>Assignee: Yonik Seeley
> Fix For: master (7.0), 6.4
>
> Attachments: SOLR-9681.patch
>
>
> For the JSON Facet API, we should be able to add a list of filters to any
> facet. These would be applied after any domain changes, hence useful for
> parent->child mapping that would otherwise match all children of any parent
> (SOLR-9510)
> The API should also be consistent with "filter" at the top level of the JSON
> Request API (examples at http://yonik.com/solr-json-request-api/ )
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9681) add filter to any facet
[ https://issues.apache.org/jira/browse/SOLR-9681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622147#comment-15622147 ] Yonik Seeley commented on SOLR-9681: I could go either way... I was sort of viewing "domain" to be just about non-narrowing domain switches (filter exclusions, parent/child, block join) > add filter to any facet > --- > > Key: SOLR-9681 > URL: https://issues.apache.org/jira/browse/SOLR-9681 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Yonik Seeley >Assignee: Yonik Seeley > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9681.patch > > > For the JSON Facet API, we should be able to add a list of filters to any > facet. These would be applied after any domain changes, hence useful for > parent->child mapping that would otherwise match all children of any parent > (SOLR-9510) > The API should also be consistent with "filter" at the top level of the JSON > Request API (examples at http://yonik.com/solr-json-request-api/ ) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9681) add filter to any facet
[
https://issues.apache.org/jira/browse/SOLR-9681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15621857#comment-15621857
]
Mikhail Khludnev commented on SOLR-9681:
[~ysee...@gmail.com], wouldn't be better to nest {{filter}} under {{domain}} as
well it impacts input docset for faceting?
> add filter to any facet
> ---
>
> Key: SOLR-9681
> URL: https://issues.apache.org/jira/browse/SOLR-9681
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Facet Module
>Reporter: Yonik Seeley
>Assignee: Yonik Seeley
> Fix For: master (7.0), 6.4
>
> Attachments: SOLR-9681.patch
>
>
> For the JSON Facet API, we should be able to add a list of filters to any
> facet. These would be applied after any domain changes, hence useful for
> parent->child mapping that would otherwise match all children of any parent
> (SOLR-9510)
> The API should also be consistent with "filter" at the top level of the JSON
> Request API (examples at http://yonik.com/solr-json-request-api/ )
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9681) add filter to any facet
[ https://issues.apache.org/jira/browse/SOLR-9681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15618765#comment-15618765 ] ASF subversion and git services commented on SOLR-9681: --- Commit 3ada3421cda4c9d5275b559f084dbc886eee4d72 in lucene-solr's branch refs/heads/branch_6x from [~yo...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3ada342 ] SOLR-9681:tests: add filter after block join test > add filter to any facet > --- > > Key: SOLR-9681 > URL: https://issues.apache.org/jira/browse/SOLR-9681 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Yonik Seeley >Assignee: Yonik Seeley > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9681.patch > > > For the JSON Facet API, we should be able to add a list of filters to any > facet. These would be applied after any domain changes, hence useful for > parent->child mapping that would otherwise match all children of any parent > (SOLR-9510) > The API should also be consistent with "filter" at the top level of the JSON > Request API (examples at http://yonik.com/solr-json-request-api/ ) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9681) add filter to any facet
[ https://issues.apache.org/jira/browse/SOLR-9681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15618763#comment-15618763 ] ASF subversion and git services commented on SOLR-9681: --- Commit d8d3a8b9b8e7345c4a02a62f7e321c4e9a2440bf in lucene-solr's branch refs/heads/master from [~yo...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d8d3a8b ] SOLR-9681:tests: add filter after block join test > add filter to any facet > --- > > Key: SOLR-9681 > URL: https://issues.apache.org/jira/browse/SOLR-9681 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Yonik Seeley >Assignee: Yonik Seeley > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9681.patch > > > For the JSON Facet API, we should be able to add a list of filters to any > facet. These would be applied after any domain changes, hence useful for > parent->child mapping that would otherwise match all children of any parent > (SOLR-9510) > The API should also be consistent with "filter" at the top level of the JSON > Request API (examples at http://yonik.com/solr-json-request-api/ ) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9681) add filter to any facet
[ https://issues.apache.org/jira/browse/SOLR-9681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15618623#comment-15618623 ] ASF subversion and git services commented on SOLR-9681: --- Commit 05ea64a665d390d4ebbb985d0505941ef15f6d85 in lucene-solr's branch refs/heads/branch_6x from [~yo...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=05ea64a ] SOLR-9681: add filters to any facet command > add filter to any facet > --- > > Key: SOLR-9681 > URL: https://issues.apache.org/jira/browse/SOLR-9681 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Yonik Seeley > Attachments: SOLR-9681.patch > > > For the JSON Facet API, we should be able to add a list of filters to any > facet. These would be applied after any domain changes, hence useful for > parent->child mapping that would otherwise match all children of any parent > (SOLR-9510) > The API should also be consistent with "filter" at the top level of the JSON > Request API (examples at http://yonik.com/solr-json-request-api/ ) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9681) add filter to any facet
[ https://issues.apache.org/jira/browse/SOLR-9681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15618602#comment-15618602 ] ASF subversion and git services commented on SOLR-9681: --- Commit 650276e14bd85cdd12a77956f2403369ff3465ac in lucene-solr's branch refs/heads/master from [~yo...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=650276e ] SOLR-9681: add filters to any facet command > add filter to any facet > --- > > Key: SOLR-9681 > URL: https://issues.apache.org/jira/browse/SOLR-9681 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module >Reporter: Yonik Seeley > Attachments: SOLR-9681.patch > > > For the JSON Facet API, we should be able to add a list of filters to any > facet. These would be applied after any domain changes, hence useful for > parent->child mapping that would otherwise match all children of any parent > (SOLR-9510) > The API should also be consistent with "filter" at the top level of the JSON > Request API (examples at http://yonik.com/solr-json-request-api/ ) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
