[jira] [Commented] (SOLR-9777) IndexFingerprinting: use getCombinedCoreAndDeletesKey() instead of getCoreCacheKey() for per-segment caching
[ https://issues.apache.org/jira/browse/SOLR-9777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15810507#comment-15810507 ] ASF subversion and git services commented on SOLR-9777: --- Commit b0177312032e039673bfbbd42cd1dca09fb93833 in lucene-solr's branch refs/heads/master from [~ichattopadhyaya] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b017731 ] SOLR-9777: IndexFingerprinting should use getCombinedCoreAndDeletesKey() instead of getCoreCacheKey() for per-segment caching > IndexFingerprinting: use getCombinedCoreAndDeletesKey() instead of > getCoreCacheKey() for per-segment caching > - > > Key: SOLR-9777 > URL: https://issues.apache.org/jira/browse/SOLR-9777 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Ishan Chattopadhyaya >Assignee: Ishan Chattopadhyaya > Attachments: SOLR-9777.patch > > > [Note: Had initially posted to SOLR-9506, but now moved here] > While working on SOLR-5944, I realized that the current per segment caching > logic works fine for deleted documents (due to comparison of numDocs in a > segment for the criterion of cache hit/miss). However, if a segment has > docValues updates, the same logic is insufficient. It is my understanding > that changing the key for caching from reader().getCoreCacheKey() to > reader().getCombinedCoreAndDeletesKey() would work here, since the docValues > updates are internally handled using deletion queue and hence the "combined" > core and deletes key would work here. Attaching a patch for the same. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9777) IndexFingerprinting: use getCombinedCoreAndDeletesKey() instead of getCoreCacheKey() for per-segment caching
[ https://issues.apache.org/jira/browse/SOLR-9777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15810508#comment-15810508 ] ASF subversion and git services commented on SOLR-9777: --- Commit 1c943be5ed2894baa37f69b6273e1fbe15e72d5d in lucene-solr's branch refs/heads/branch_6x from [~ichattopadhyaya] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1c943be ] SOLR-9777: IndexFingerprinting should use getCombinedCoreAndDeletesKey() instead of getCoreCacheKey() for per-segment caching > IndexFingerprinting: use getCombinedCoreAndDeletesKey() instead of > getCoreCacheKey() for per-segment caching > - > > Key: SOLR-9777 > URL: https://issues.apache.org/jira/browse/SOLR-9777 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Ishan Chattopadhyaya >Assignee: Ishan Chattopadhyaya > Attachments: SOLR-9777.patch > > > [Note: Had initially posted to SOLR-9506, but now moved here] > While working on SOLR-5944, I realized that the current per segment caching > logic works fine for deleted documents (due to comparison of numDocs in a > segment for the criterion of cache hit/miss). However, if a segment has > docValues updates, the same logic is insufficient. It is my understanding > that changing the key for caching from reader().getCoreCacheKey() to > reader().getCombinedCoreAndDeletesKey() would work here, since the docValues > updates are internally handled using deletion queue and hence the "combined" > core and deletes key would work here. Attaching a patch for the same. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9777) IndexFingerprinting: use getCombinedCoreAndDeletesKey() instead of getCoreCacheKey() for per-segment caching
[ https://issues.apache.org/jira/browse/SOLR-9777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15809478#comment-15809478 ] Mark Miller commented on SOLR-9777: --- +1 > IndexFingerprinting: use getCombinedCoreAndDeletesKey() instead of > getCoreCacheKey() for per-segment caching > - > > Key: SOLR-9777 > URL: https://issues.apache.org/jira/browse/SOLR-9777 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Ishan Chattopadhyaya >Assignee: Ishan Chattopadhyaya > Attachments: SOLR-9777.patch > > > [Note: Had initially posted to SOLR-9506, but now moved here] > While working on SOLR-5944, I realized that the current per segment caching > logic works fine for deleted documents (due to comparison of numDocs in a > segment for the criterion of cache hit/miss). However, if a segment has > docValues updates, the same logic is insufficient. It is my understanding > that changing the key for caching from reader().getCoreCacheKey() to > reader().getCombinedCoreAndDeletesKey() would work here, since the docValues > updates are internally handled using deletion queue and hence the "combined" > core and deletes key would work here. Attaching a patch for the same. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9777) IndexFingerprinting: use getCombinedCoreAndDeletesKey() instead of getCoreCacheKey() for per-segment caching
[ https://issues.apache.org/jira/browse/SOLR-9777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15804572#comment-15804572 ] Ishan Chattopadhyaya commented on SOLR-9777: I'm planning to commit this soon. So, if someone has the time to review this change, would be great. > IndexFingerprinting: use getCombinedCoreAndDeletesKey() instead of > getCoreCacheKey() for per-segment caching > - > > Key: SOLR-9777 > URL: https://issues.apache.org/jira/browse/SOLR-9777 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Ishan Chattopadhyaya >Assignee: Noble Paul > Attachments: SOLR-9777.patch > > > [Note: Had initially posted to SOLR-9506, but now moved here] > While working on SOLR-5944, I realized that the current per segment caching > logic works fine for deleted documents (due to comparison of numDocs in a > segment for the criterion of cache hit/miss). However, if a segment has > docValues updates, the same logic is insufficient. It is my understanding > that changing the key for caching from reader().getCoreCacheKey() to > reader().getCombinedCoreAndDeletesKey() would work here, since the docValues > updates are internally handled using deletion queue and hence the "combined" > core and deletes key would work here. Attaching a patch for the same. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
