[jira] [Commented] (SOLR-9947) Miscellaneous metrics cleanup
[ https://issues.apache.org/jira/browse/SOLR-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839457#comment-15839457 ] Jan Høydahl commented on SOLR-9947: --- The renamings in 6.4 already seem to have caused back-compat problems, see SOLR-10035 and Shawn's comment about external tools that will break. Should we not treat the mbeans API in the same way as other APIs and not change before 7.x? We still have time to revert in 6.4.1 (or register same metrics double up under old and new paths?) > Miscellaneous metrics cleanup > - > > Key: SOLR-9947 > URL: https://issues.apache.org/jira/browse/SOLR-9947 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Reporter: Shalin Shekhar Mangar >Assignee: Andrzej Bialecki >Priority: Minor > Fix For: master (7.0), 6.4 > > Attachments: screenshot-1.png, SOLR-9947.patch, SOLR-9947.patch, > SOLR-9947.patch, SOLR-9947-with-mbeans.patch > > > Misc cleanup in metrics API to fix: > # metrics reporting themselves under the wrong category > # core container metrics are without a category -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9947) Miscellaneous metrics cleanup
[ https://issues.apache.org/jira/browse/SOLR-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821265#comment-15821265 ] Andrzej Bialecki commented on SOLR-9947: - bq. Ok I guess my opinion that SEARCHHANDLER is more specific than QUERY isn't shared by you. :) David, if you have strong feelings about this, let's create a separate issue and discuss this. I wanted to complete this round of cleanup before 6.4 is out to avoid leaving some obvious mistakes and omissions that resulted from incremental work across several Jira issues. As I explained above, I tried to minimize the number of categories, and at the same time I wanted to reflect the functionality of components... SEARCHHANDLER reflects IMHO an implementation detail, whereas QUERY (I admit, it may sound too generic at first) tries to encompass an idea of components that users use for query / response interaction. bq. On master branch, we should not register the old names as well... I'll create a separate blocker issue for 7.0. There's a lot of cleanup that still needs to be done in the naming of eg. QPlugin-s, Highlighter-s etc, but that would break back-compat in 6.x, so 7.0 seems like the right place to do it. > Miscellaneous metrics cleanup > - > > Key: SOLR-9947 > URL: https://issues.apache.org/jira/browse/SOLR-9947 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Reporter: Shalin Shekhar Mangar >Assignee: Andrzej Bialecki >Priority: Minor > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9947-with-mbeans.patch, SOLR-9947.patch, > SOLR-9947.patch, SOLR-9947.patch, screenshot-1.png > > > Misc cleanup in metrics API to fix: > # metrics reporting themselves under the wrong category > # core container metrics are without a category -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9947) Miscellaneous metrics cleanup
[ https://issues.apache.org/jira/browse/SOLR-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821241#comment-15821241 ] ASF subversion and git services commented on SOLR-9947: --- Commit bd80359debc343c1f4969472c6cf30b69639f045 in lucene-solr's branch refs/heads/branch_6x from [~shalinmangar] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=bd80359 ] SOLR-9947: Fix CloudSolrClientTest.testNonRetryableRequests failure (cherry picked from commit dee7709) > Miscellaneous metrics cleanup > - > > Key: SOLR-9947 > URL: https://issues.apache.org/jira/browse/SOLR-9947 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Reporter: Shalin Shekhar Mangar >Assignee: Andrzej Bialecki >Priority: Minor > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9947-with-mbeans.patch, SOLR-9947.patch, > SOLR-9947.patch, SOLR-9947.patch, screenshot-1.png > > > Misc cleanup in metrics API to fix: > # metrics reporting themselves under the wrong category > # core container metrics are without a category -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9947) Miscellaneous metrics cleanup
[ https://issues.apache.org/jira/browse/SOLR-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821236#comment-15821236 ] ASF subversion and git services commented on SOLR-9947: --- Commit dee7709dd86c64529ee0455d05805ab41b34c736 in lucene-solr's branch refs/heads/master from [~shalinmangar] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dee7709 ] SOLR-9947: Fix CloudSolrClientTest.testNonRetryableRequests failure > Miscellaneous metrics cleanup > - > > Key: SOLR-9947 > URL: https://issues.apache.org/jira/browse/SOLR-9947 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Reporter: Shalin Shekhar Mangar >Assignee: Andrzej Bialecki >Priority: Minor > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9947-with-mbeans.patch, SOLR-9947.patch, > SOLR-9947.patch, SOLR-9947.patch, screenshot-1.png > > > Misc cleanup in metrics API to fix: > # metrics reporting themselves under the wrong category > # core container metrics are without a category -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9947) Miscellaneous metrics cleanup
[ https://issues.apache.org/jira/browse/SOLR-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821185#comment-15821185 ] David Smiley commented on SOLR-9947: Ok I guess my opinion that SEARCHHANDLER is more specific than QUERY isn't shared by you. On master branch, we should not register the old names as well... we will likely forget about this in the coming days/weeks and then one day 7.0 will arrive with this cruft still present making it harder to justify removing later. It could be a separate issue marked as blocker for 7.0, or just do in this issue. > Miscellaneous metrics cleanup > - > > Key: SOLR-9947 > URL: https://issues.apache.org/jira/browse/SOLR-9947 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Reporter: Shalin Shekhar Mangar >Assignee: Andrzej Bialecki >Priority: Minor > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9947-with-mbeans.patch, SOLR-9947.patch, > SOLR-9947.patch, SOLR-9947.patch, screenshot-1.png > > > Misc cleanup in metrics API to fix: > # metrics reporting themselves under the wrong category > # core container metrics are without a category -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9947) Miscellaneous metrics cleanup
[ https://issues.apache.org/jira/browse/SOLR-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821017#comment-15821017 ] ASF subversion and git services commented on SOLR-9947: --- Commit 16452a9f207a8555c3f7870e22dc566c520cbad8 in lucene-solr's branch refs/heads/branch_6x from [~ab] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=16452a9 ] SOLR-9947 Clean up metrics and SolrInfoMBean categories. Add a hierarhical view of SolrInfoMBeans in JMX. (cherry-picked from 6c6c077435bcc5bd3f4520a70a4c678d4b3f7661) > Miscellaneous metrics cleanup > - > > Key: SOLR-9947 > URL: https://issues.apache.org/jira/browse/SOLR-9947 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Reporter: Shalin Shekhar Mangar >Assignee: Andrzej Bialecki >Priority: Minor > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9947-with-mbeans.patch, SOLR-9947.patch, > SOLR-9947.patch, SOLR-9947.patch, screenshot-1.png > > > Misc cleanup in metrics API to fix: > # metrics reporting themselves under the wrong category > # core container metrics are without a category -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9947) Miscellaneous metrics cleanup
[ https://issues.apache.org/jira/browse/SOLR-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820929#comment-15820929 ] ASF subversion and git services commented on SOLR-9947: --- Commit 6c6c077435bcc5bd3f4520a70a4c678d4b3f7661 in lucene-solr's branch refs/heads/master from [~ab] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6c6c077 ] SOLR-9947 Clean up metrics and SolrInfoMBean categories. Add a hierarhical view of SolrInfoMBeans in JMX. > Miscellaneous metrics cleanup > - > > Key: SOLR-9947 > URL: https://issues.apache.org/jira/browse/SOLR-9947 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Reporter: Shalin Shekhar Mangar >Assignee: Andrzej Bialecki >Priority: Minor > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9947-with-mbeans.patch, SOLR-9947.patch, > SOLR-9947.patch, SOLR-9947.patch, screenshot-1.png > > > Misc cleanup in metrics API to fix: > # metrics reporting themselves under the wrong category > # core container metrics are without a category -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9947) Miscellaneous metrics cleanup
[ https://issues.apache.org/jira/browse/SOLR-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819076#comment-15819076 ] David Smiley commented on SOLR-9947: HANDLER may be a bit too succinct. I suggest REQUESTHANDLER and specifically SEARCHHANDLER (when subclassing SearchHandler) which are actually fairly specific and meaningful. QUERY though I dunno what to think of it; one has to guess. RE renaming in a subsequent release: ok. I see your patch now; ok. > Miscellaneous metrics cleanup > - > > Key: SOLR-9947 > URL: https://issues.apache.org/jira/browse/SOLR-9947 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Reporter: Shalin Shekhar Mangar >Assignee: Andrzej Bialecki >Priority: Minor > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9947-with-mbeans.patch, SOLR-9947.patch, > SOLR-9947.patch, SOLR-9947.patch, screenshot-1.png > > > Misc cleanup in metrics API to fix: > # metrics reporting themselves under the wrong category > # core container metrics are without a category -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9947) Miscellaneous metrics cleanup
[
https://issues.apache.org/jira/browse/SOLR-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818873#comment-15818873
]
Andrzej Bialecki commented on SOLR-9947:
-
bq. I don't think we should rush the naming on the eve of a feature freeze.
As I mentioned above, this mainly affects the new API, with a very limited
impact on the old API, so I think we should be fine. I'd rather make a couple
renames in the next release than to withhold the dozens of renames in this
patch that really make the new API much cleaner.
bq. how the patch retains both the old and new hierarchy
The same instances of {{SolrInfoMBean}}-s are registered under the old names
and new hierarchical names. This way we preserve the back-compat, and at the
same time we provide an alternative, improved view of the same information.
bq. though perhaps at the base level a generic simply HANDLER (I dunno).
Yeah, naming is hard :) On one hand it needs to be specific enough to be
informative, on the other hand it needs to be generic enough to limit the total
number of categories, and on the third hand ;) if it's too generic then it
becomes meaningless.
I discussed this with Shalin, we considered and rejected HANDLER, PLUGIN and
the like as too generic, after all all these components are handlers and
plugins. In the latest patch I moved quite a few components from QUERY to other
categories, leaving only those that actually support query-response interaction
with users.
> Miscellaneous metrics cleanup
> -
>
> Key: SOLR-9947
> URL: https://issues.apache.org/jira/browse/SOLR-9947
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
>Reporter: Shalin Shekhar Mangar
>Assignee: Andrzej Bialecki
>Priority: Minor
> Fix For: master (7.0), 6.4
>
> Attachments: SOLR-9947-with-mbeans.patch, SOLR-9947.patch,
> SOLR-9947.patch, screenshot-1.png
>
>
> Misc cleanup in metrics API to fix:
> # metrics reporting themselves under the wrong category
> # core container metrics are without a category
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9947) Miscellaneous metrics cleanup
[ https://issues.apache.org/jira/browse/SOLR-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818818#comment-15818818 ] David Smiley commented on SOLR-9947: I don't think we should rush the naming on the eve of a feature freeze. Thanks for the screenshot; though it's not clear how the patch retains both the old and new hierarchy; can you clarify? I don't like "QUERY" nor "QUERYHANDLER" before it. I suggest "SEARCHHANDLER", leaving "Query" terminology across Solr for literally either a Query object or query string to be parsed, but not as a synonym for searching generally. Then SearchHandler could return SEARCHHANDLER... though perhaps at the base level a generic simply HANDLER (I dunno). > Miscellaneous metrics cleanup > - > > Key: SOLR-9947 > URL: https://issues.apache.org/jira/browse/SOLR-9947 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Reporter: Shalin Shekhar Mangar >Assignee: Andrzej Bialecki >Priority: Minor > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9947-with-mbeans.patch, SOLR-9947.patch, > SOLR-9947.patch, screenshot-1.png > > > Misc cleanup in metrics API to fix: > # metrics reporting themselves under the wrong category > # core container metrics are without a category -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9947) Miscellaneous metrics cleanup
[ https://issues.apache.org/jira/browse/SOLR-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818381#comment-15818381 ] Shalin Shekhar Mangar commented on SOLR-9947: - +1 to commit > Miscellaneous metrics cleanup > - > > Key: SOLR-9947 > URL: https://issues.apache.org/jira/browse/SOLR-9947 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Reporter: Shalin Shekhar Mangar >Assignee: Andrzej Bialecki >Priority: Minor > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9947-with-mbeans.patch, SOLR-9947.patch, > SOLR-9947.patch, screenshot-1.png > > > Misc cleanup in metrics API to fix: > # metrics reporting themselves under the wrong category > # core container metrics are without a category -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9947) Miscellaneous metrics cleanup
[ https://issues.apache.org/jira/browse/SOLR-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818313#comment-15818313 ] Andrzej Bialecki commented on SOLR-9947: - It turned out that it's not a major change - I attached a screenshot of what it looks like in JConsole. > Miscellaneous metrics cleanup > - > > Key: SOLR-9947 > URL: https://issues.apache.org/jira/browse/SOLR-9947 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Reporter: Shalin Shekhar Mangar >Assignee: Andrzej Bialecki >Priority: Minor > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9947.patch, SOLR-9947.patch, screenshot-1.png > > > Misc cleanup in metrics API to fix: > # metrics reporting themselves under the wrong category > # core container metrics are without a category -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9947) Miscellaneous metrics cleanup
[ https://issues.apache.org/jira/browse/SOLR-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818263#comment-15818263 ] David Smiley commented on SOLR-9947: bq. Or do you mean that we should register them both at the legacy and new locations? Yes that's what I mean. > Miscellaneous metrics cleanup > - > > Key: SOLR-9947 > URL: https://issues.apache.org/jira/browse/SOLR-9947 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Reporter: Shalin Shekhar Mangar >Assignee: Andrzej Bialecki >Priority: Minor > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9947.patch, SOLR-9947.patch > > > Misc cleanup in metrics API to fix: > # metrics reporting themselves under the wrong category > # core container metrics are without a category -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9947) Miscellaneous metrics cleanup
[
https://issues.apache.org/jira/browse/SOLR-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817784#comment-15817784
]
Andrzej Bialecki commented on SOLR-9947:
-
These changes only marginally affect the legacy mbeans, in that their
"category" attribute may be different than before but their hierarchy (such as
it is) remains unchanged.
Or do you mean that we should register them both at the legacy and new
locations? I can see that could be useful - {{SolrInfoMBean}} interface
provides many useful non-numeric data, which the new metrics API doesn't cover
at all. Let me see how much work it would take, maybe this should be done in a
separate issue.
> Miscellaneous metrics cleanup
> -
>
> Key: SOLR-9947
> URL: https://issues.apache.org/jira/browse/SOLR-9947
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
>Reporter: Shalin Shekhar Mangar
>Assignee: Andrzej Bialecki
>Priority: Minor
> Fix For: master (7.0), 6.4
>
> Attachments: SOLR-9947.patch
>
>
> Misc cleanup in metrics API to fix:
> # metrics reporting themselves under the wrong category
> # core container metrics are without a category
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9947) Miscellaneous metrics cleanup
[ https://issues.apache.org/jira/browse/SOLR-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817069#comment-15817069 ] David Smiley commented on SOLR-9947: The existing SolrInfoMBeans hierarchy isn't what we want them to be if we were to start over. It's good to see a refactor like this. Is it possible to register beans in the legacy location and the new location as a transition? And then in the UI we'd not show the legacy ones. > Miscellaneous metrics cleanup > - > > Key: SOLR-9947 > URL: https://issues.apache.org/jira/browse/SOLR-9947 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Reporter: Shalin Shekhar Mangar >Assignee: Andrzej Bialecki >Priority: Minor > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9947.patch > > > Misc cleanup in metrics API to fix: > # metrics reporting themselves under the wrong category > # core container metrics are without a category -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9947) Miscellaneous metrics cleanup
[
https://issues.apache.org/jira/browse/SOLR-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815089#comment-15815089
]
Andrzej Bialecki commented on SOLR-9947:
-
We can put "infrastructure" handlers into other categories, especially those
that weren't previously reported via JMX anyway.
Moving {{SolrConfigHandler}} from OTHER would slightly break back-compat, since
this value is also reported in the old JMX interface as a bean attribute,
similarly moving /update or /replication handlers from QUERYHANDLER. I'm not
sure whether it's a big deal or not - maybe [~otis] or [~wunder] could comment
on this?
> Miscellaneous metrics cleanup
> -
>
> Key: SOLR-9947
> URL: https://issues.apache.org/jira/browse/SOLR-9947
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
>Reporter: Shalin Shekhar Mangar
>Assignee: Shalin Shekhar Mangar
>Priority: Minor
> Fix For: master (7.0), 6.4
>
>
> Misc cleanup in metrics API to fix:
> # metrics reporting themselves under the wrong category
> # core container metrics are without a category
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9947) Miscellaneous metrics cleanup
[ https://issues.apache.org/jira/browse/SOLR-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814835#comment-15814835 ] Shalin Shekhar Mangar commented on SOLR-9947: - A few of the things to fix: # Config handler is under "OTHERS" category # The /update/* handlers are under "QUERYHANDLER" # The container level metrics such as "core.*" gauges, threadPool.coreContainerWorkExecutor and threadPool.coreLoadExecutor are without a category unlike other metrics. Perhaps we can introduce a CONTAINER category? # InfoHandler which is created in CoreContainer and has sub-handler such as /admin/logging, /admin/threads etc which show up in each core. I am not sure why. I think we are too tied with SolrInfoMBean and the categories that exist already. It feels wrong for a new API to use outdated category names. For example, "/replication" is not a query handler, it is something else entirely. Same for core admin handlers and other such stuff. I am not sure how to fix this without breaking back-compat with existing monitoring solutions. What do you think [~ab]? > Miscellaneous metrics cleanup > - > > Key: SOLR-9947 > URL: https://issues.apache.org/jira/browse/SOLR-9947 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics >Reporter: Shalin Shekhar Mangar >Assignee: Shalin Shekhar Mangar >Priority: Minor > Fix For: master (7.0), 6.4 > > > Misc cleanup in metrics API to fix: > # metrics reporting themselves under the wrong category > # core container metrics are without a category -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
