[jira] [Updated] (LUCENE-3969) Use all (non-deprecated) analysis ctors in TestRandomChains
[ https://issues.apache.org/jira/browse/LUCENE-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-3969: Fix Version/s: 3.6.1 4.0 Use all (non-deprecated) analysis ctors in TestRandomChains --- Key: LUCENE-3969 URL: https://issues.apache.org/jira/browse/LUCENE-3969 Project: Lucene - Java Issue Type: Bug Components: modules/analysis Reporter: Robert Muir Fix For: 4.0, 3.6.1 Attachments: LUCENE-3969.patch, LUCENE-3969.patch, LUCENE-3969.patch, LUCENE-3969.patch, LUCENE-3969.patch, LUCENE-3969.patch We made TestRandomChains in LUCENE-3919, which reflects all analysis components from the classpath and builds analyzers from them, then checks consistency. but currently it only supports some tokenizers/tokenfilters/charfilters, because it hardcodes at certain ctors e.g. Tokenizer(Reader) and Tokenizer(Version+Reader). Instead we should use all ctors, just filling them in with random data of whatever argument type they take. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-3969) Use all (non-deprecated) analysis ctors in TestRandomChains
[ https://issues.apache.org/jira/browse/LUCENE-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-3969: -- Attachment: LUCENE-3969.patch Patch with the above mentioned cleanups. I also changed some code to be more consistent (isAnnotationPresent also for classes, Class.getName instead toString). This thing fails almost always, in most cases with too many tokens. Use all (non-deprecated) analysis ctors in TestRandomChains --- Key: LUCENE-3969 URL: https://issues.apache.org/jira/browse/LUCENE-3969 Project: Lucene - Java Issue Type: Bug Components: modules/analysis Reporter: Robert Muir Attachments: LUCENE-3969.patch, LUCENE-3969.patch, LUCENE-3969.patch We made TestRandomChains in LUCENE-3919, which reflects all analysis components from the classpath and builds analyzers from them, then checks consistency. but currently it only supports some tokenizers/tokenfilters/charfilters, because it hardcodes at certain ctors e.g. Tokenizer(Reader) and Tokenizer(Version+Reader). Instead we should use all ctors, just filling them in with random data of whatever argument type they take. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-3969) Use all (non-deprecated) analysis ctors in TestRandomChains
[ https://issues.apache.org/jira/browse/LUCENE-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-3969: -- Attachment: LUCENE-3969.patch New patch: - I now have found out where the UOE comes from, it's the random parameter generator. But this is nasty and should be solved better. I readded the catch block with a comment. In general, the code should be refactored to not call getConstrcutors all the time. Instead the global list of ListClassT should be replaced by ListConstructorT, then we only have one list where to choose the ctor from (the class is implicit). Will work on a patch. Use all (non-deprecated) analysis ctors in TestRandomChains --- Key: LUCENE-3969 URL: https://issues.apache.org/jira/browse/LUCENE-3969 Project: Lucene - Java Issue Type: Bug Components: modules/analysis Reporter: Robert Muir Attachments: LUCENE-3969.patch, LUCENE-3969.patch, LUCENE-3969.patch, LUCENE-3969.patch We made TestRandomChains in LUCENE-3919, which reflects all analysis components from the classpath and builds analyzers from them, then checks consistency. but currently it only supports some tokenizers/tokenfilters/charfilters, because it hardcodes at certain ctors e.g. Tokenizer(Reader) and Tokenizer(Version+Reader). Instead we should use all ctors, just filling them in with random data of whatever argument type they take. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-3969) Use all (non-deprecated) analysis ctors in TestRandomChains
[ https://issues.apache.org/jira/browse/LUCENE-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-3969: -- Attachment: LUCENE-3969.patch New patch with the Constructors moved up the chain to be top-level citizens, analysis classes are no longer explicitely used. It would be goot to fix the randomParameter generator to never fail but instead the reflection code in beforClass() to check the constructor args against a SetClass? validArgs of valid parameters and throw away all invalid ctors from the beginning: validArgs.containsAll(Arrays.asList(ctor.getParameterTypes())) Use all (non-deprecated) analysis ctors in TestRandomChains --- Key: LUCENE-3969 URL: https://issues.apache.org/jira/browse/LUCENE-3969 Project: Lucene - Java Issue Type: Bug Components: modules/analysis Reporter: Robert Muir Attachments: LUCENE-3969.patch, LUCENE-3969.patch, LUCENE-3969.patch, LUCENE-3969.patch, LUCENE-3969.patch We made TestRandomChains in LUCENE-3919, which reflects all analysis components from the classpath and builds analyzers from them, then checks consistency. but currently it only supports some tokenizers/tokenfilters/charfilters, because it hardcodes at certain ctors e.g. Tokenizer(Reader) and Tokenizer(Version+Reader). Instead we should use all ctors, just filling them in with random data of whatever argument type they take. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-3969) Use all (non-deprecated) analysis ctors in TestRandomChains
[ https://issues.apache.org/jira/browse/LUCENE-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-3969: -- Attachment: LUCENE-3969.patch Here a patch with a more flexible argument generator. Its still a little bit ugly how the three special cases are handled (and the Sets need to be kept in sync!), but at least the standard types are created very simple. Use all (non-deprecated) analysis ctors in TestRandomChains --- Key: LUCENE-3969 URL: https://issues.apache.org/jira/browse/LUCENE-3969 Project: Lucene - Java Issue Type: Bug Components: modules/analysis Reporter: Robert Muir Attachments: LUCENE-3969.patch, LUCENE-3969.patch, LUCENE-3969.patch, LUCENE-3969.patch, LUCENE-3969.patch, LUCENE-3969.patch We made TestRandomChains in LUCENE-3919, which reflects all analysis components from the classpath and builds analyzers from them, then checks consistency. but currently it only supports some tokenizers/tokenfilters/charfilters, because it hardcodes at certain ctors e.g. Tokenizer(Reader) and Tokenizer(Version+Reader). Instead we should use all ctors, just filling them in with random data of whatever argument type they take. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-3969) Use all (non-deprecated) analysis ctors in TestRandomChains
[ https://issues.apache.org/jira/browse/LUCENE-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-3969: Attachment: LUCENE-3969.patch First cut at a patch: supports all of our analysis components, which means basically every time you run this test now, it finds a bug. The test ignores any invocations of UOE or IAE, and i fixed most/all trivial issues related to that, but there are serious problems... Use all (non-deprecated) analysis ctors in TestRandomChains --- Key: LUCENE-3969 URL: https://issues.apache.org/jira/browse/LUCENE-3969 Project: Lucene - Java Issue Type: Bug Components: modules/analysis Reporter: Robert Muir Attachments: LUCENE-3969.patch We made TestRandomChains in LUCENE-3919, which reflects all analysis components from the classpath and builds analyzers from them, then checks consistency. but currently it only supports some tokenizers/tokenfilters/charfilters, because it hardcodes at certain ctors e.g. Tokenizer(Reader) and Tokenizer(Version+Reader). Instead we should use all ctors, just filling them in with random data of whatever argument type they take. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (LUCENE-3969) Use all (non-deprecated) analysis ctors in TestRandomChains
[ https://issues.apache.org/jira/browse/LUCENE-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-3969: Attachment: LUCENE-3969.patch updated patch... just fixing some more bugs. Use all (non-deprecated) analysis ctors in TestRandomChains --- Key: LUCENE-3969 URL: https://issues.apache.org/jira/browse/LUCENE-3969 Project: Lucene - Java Issue Type: Bug Components: modules/analysis Reporter: Robert Muir Attachments: LUCENE-3969.patch, LUCENE-3969.patch We made TestRandomChains in LUCENE-3919, which reflects all analysis components from the classpath and builds analyzers from them, then checks consistency. but currently it only supports some tokenizers/tokenfilters/charfilters, because it hardcodes at certain ctors e.g. Tokenizer(Reader) and Tokenizer(Version+Reader). Instead we should use all ctors, just filling them in with random data of whatever argument type they take. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
