[jira] [Commented] (SOLR-2276) Support for cologne phonetic
[ https://issues.apache.org/jira/browse/SOLR-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018330#comment-13018330 ] Uwe Schindler commented on SOLR-2276: - One addition about the registry: The registry is not synchronized, but now it is lazy updated as soon as a new encoder class occurs - registry.put() could be called from different threads and break the HashMap. > Support for cologne phonetic > > > Key: SOLR-2276 > URL: https://issues.apache.org/jira/browse/SOLR-2276 > Project: Solr > Issue Type: Improvement > Components: Schema and Analysis >Affects Versions: 1.4.1 > Environment: Apache Commons Codec 1.5 >Reporter: Marc Pompl > Fix For: 4.0 > > Attachments: ColognePhonetic-patch-with-reflection.txt > > Original Estimate: 2h > Remaining Estimate: 2h > > As soon as Apache Commons Codec 1.5 is released, support new encoder > "ColognePhonetic" please. > See JIRA for CODEC-106. > It is fundamental for phonetic searches if you are indexing german names. > Other indexers are optimizied for english (words). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2276) Support for cologne phonetic
[ https://issues.apache.org/jira/browse/SOLR-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018326#comment-13018326 ] Robert Muir commented on SOLR-2276: --- hi Marc, thanks for notifying us of the commons codec release. Uwe: I agree with your suggestions, I just want to mention i think we should still keep the registry map, because for example Caverphone is deprecated in the 1.5 release (and there is Caverphone1 and Caverphone2). So the map is useful for us to shield our users from changes (we can map Caverphone to Caverphone2 or whichever one is equivalent). Even if this one is removed in commons codec 1.6 this string value can still work. > Support for cologne phonetic > > > Key: SOLR-2276 > URL: https://issues.apache.org/jira/browse/SOLR-2276 > Project: Solr > Issue Type: Improvement > Components: Schema and Analysis >Affects Versions: 1.4.1 > Environment: Apache Commons Codec 1.5 >Reporter: Marc Pompl > Fix For: 4.0 > > Attachments: ColognePhonetic-patch-with-reflection.txt > > Original Estimate: 2h > Remaining Estimate: 2h > > As soon as Apache Commons Codec 1.5 is released, support new encoder > "ColognePhonetic" please. > See JIRA for CODEC-106. > It is fundamental for phonetic searches if you are indexing german names. > Other indexers are optimizied for english (words). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2276) Support for cologne phonetic
[
https://issues.apache.org/jira/browse/SOLR-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018217#comment-13018217
]
Uwe Schindler commented on SOLR-2276:
-
Hi Marc,
to remove the unneeded cast leading to an unchecked warning, also calling
static methods on instances is a no-go:
Replace:
{code}
clazz = (Class) this.getClass().forName(name);
{code}
By:
{code}
clazz = Class.forName(name).asSubclass(Encoder.class);
{code}
> Support for cologne phonetic
>
>
> Key: SOLR-2276
> URL: https://issues.apache.org/jira/browse/SOLR-2276
> Project: Solr
> Issue Type: Improvement
> Components: Schema and Analysis
>Affects Versions: 1.4.1
> Environment: Apache Commons Codec 1.5
>Reporter: Marc Pompl
> Fix For: 4.0
>
> Attachments: ColognePhonetic-patch-with-reflection.txt
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> As soon as Apache Commons Codec 1.5 is released, support new encoder
> "ColognePhonetic" please.
> See JIRA for CODEC-106.
> It is fundamental for phonetic searches if you are indexing german names.
> Other indexers are optimizied for english (words).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2276) Support for cologne phonetic
[ https://issues.apache.org/jira/browse/SOLR-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985458#action_12985458 ] Marc Pompl commented on SOLR-2276: -- Hi Robert, I wasn't able to find any release date for Apacahe Commons Codec 1.4.1 or 1.5. I agree with your concept of supporting a static map and---if a not supported string is identified---a fallback via reflection, additionally. > Support for cologne phonetic > > > Key: SOLR-2276 > URL: https://issues.apache.org/jira/browse/SOLR-2276 > Project: Solr > Issue Type: Improvement > Components: Schema and Analysis >Affects Versions: 1.4.1 > Environment: Apache Commons Codec 1.5 >Reporter: Marc Pompl > Fix For: 4.0 > > Attachments: ColognePhonetic-patch.txt > > Original Estimate: 2h > Remaining Estimate: 2h > > As soon as Apache Commons Codec 1.5 is released, support new encoder > "ColognePhonetic" please. > See JIRA for CODEC-106. > It is fundamental for phonetic searches if you are indexing german names. > Other indexers are optimizied for english (words). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2276) Support for cologne phonetic
[
https://issues.apache.org/jira/browse/SOLR-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975510#action_12975510
]
Robert Muir commented on SOLR-2276:
---
bq. Seems ColognePhonetic will be supported in Apache Commons Codec 1.4.1.
Thanks for your patch Marc. Has there been any discussion on a tentative
release date for 1.4.1?
When this happens I'll be happy to add it.
{quote}
Besides, do you think it is a good idea to allow a fully qualified class name
as "encoder" in PhoneticFilterFactory? Extending solr by a custom phonetic
filter could be much easier for developers.
{quote}
I think the reason its not done with reflection might be historical, before all
tokenstreams were reused?
But I still think its a good idea to avoid reflection when possible, so I think
we should keep the statically built map.
However, if you supply a string thats not in this map, I don't think it would
hurt to try to reflect the name
before throwing an exception, as in this case you would only get an exception
anyway.
> Support for cologne phonetic
>
>
> Key: SOLR-2276
> URL: https://issues.apache.org/jira/browse/SOLR-2276
> Project: Solr
> Issue Type: Improvement
> Components: Schema and Analysis
>Affects Versions: 1.4.1
> Environment: Apache Commons Codec 1.5
>Reporter: Marc Pompl
> Fix For: 4.0
>
> Attachments: ColognePhonetic-patch.txt
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> As soon as Apache Commons Codec 1.5 is released, support new encoder
> "ColognePhonetic" please.
> See JIRA for CODEC-106.
> It is fundamental for phonetic searches if you are indexing german names.
> Other indexers are optimizied for english (words).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
