[jira] Commented: (SOLR-2365) DIH should not be in the Solr war
[ https://issues.apache.org/jira/browse/SOLR-2365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12995540#comment-12995540 ] David Smiley commented on SOLR-2365: Uwe; are you willing to put fix-for of 3.1 on this or is that a touchy subject? ;-P DIH should not be in the Solr war - Key: SOLR-2365 URL: https://issues.apache.org/jira/browse/SOLR-2365 Project: Solr Issue Type: Improvement Components: Build Reporter: David Smiley Priority: Minor Attachments: SOLR-2365_DIH_should_not_be_in_war.patch The DIH has a build.xml that puts itself into the Solr war file. This is the only contrib module that does this, and I don't think it should be this way. Granted there is a small dataimport.jsp file that would be most convenient to remain included, but the jar should not be. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2365) DIH should not be in the Solr war
[ https://issues.apache.org/jira/browse/SOLR-2365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12995583#comment-12995583 ] Uwe Schindler commented on SOLR-2365: - +1; who wants to set the touchy fix version? DIH should not be in the Solr war - Key: SOLR-2365 URL: https://issues.apache.org/jira/browse/SOLR-2365 Project: Solr Issue Type: Improvement Components: Build Reporter: David Smiley Priority: Minor Attachments: SOLR-2365_DIH_should_not_be_in_war.patch The DIH has a build.xml that puts itself into the Solr war file. This is the only contrib module that does this, and I don't think it should be this way. Granted there is a small dataimport.jsp file that would be most convenient to remain included, but the jar should not be. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2365) DIH should not be in the Solr war
[
https://issues.apache.org/jira/browse/SOLR-2365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12995591#comment-12995591
]
Hoss Man commented on SOLR-2365:
+1
we need to make sure to call this out at the top of CHANGES.txt so people
upgrading from 1.x know they *must* modify their solrconfig.xml (to add the
{{lib/}} directive) if they use DIH ... but yeah, if it doesn't need to be in
hte war for that JSP to work, then let's keep it as an isolated contrib jar.
DIH should not be in the Solr war
-
Key: SOLR-2365
URL: https://issues.apache.org/jira/browse/SOLR-2365
Project: Solr
Issue Type: Improvement
Components: Build
Reporter: David Smiley
Priority: Minor
Fix For: 3.1, 4.0
Attachments: SOLR-2365_DIH_should_not_be_in_war.patch
The DIH has a build.xml that puts itself into the Solr war file. This is the
only contrib module that does this, and I don't think it should be this way.
Granted there is a small dataimport.jsp file that would be most convenient to
remain included, but the jar should not be.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2365) DIH should not be in the Solr war
[ https://issues.apache.org/jira/browse/SOLR-2365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12995198#comment-12995198 ] Erik Hatcher commented on SOLR-2365: Since DIH worked out of the box with Solr 1.4.x, we probably want to keep it that way moving forward (for now). We should put the lib directive into Solr's main example solrconfig.xml (just we do with clustering, Solr Cell, etc) also. Other than that, no objections to this. [tangent, but ideally we can eventually get all Solr UI to be Velocity generated, and plugins can then ship with their own .vm files in the JAR file to add in something like a dataimport.jsp] DIH should not be in the Solr war - Key: SOLR-2365 URL: https://issues.apache.org/jira/browse/SOLR-2365 Project: Solr Issue Type: Improvement Components: Build Reporter: David Smiley Priority: Minor Attachments: SOLR-2365_DIH_should_not_be_in_war.patch The DIH has a build.xml that puts itself into the Solr war file. This is the only contrib module that does this, and I don't think it should be this way. Granted there is a small dataimport.jsp file that would be most convenient to remain included, but the jar should not be. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2365) DIH should not be in the Solr war
[ https://issues.apache.org/jira/browse/SOLR-2365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12995206#comment-12995206 ] Uwe Schindler commented on SOLR-2365: - +1 for remove from war file! DIH should not be in the Solr war - Key: SOLR-2365 URL: https://issues.apache.org/jira/browse/SOLR-2365 Project: Solr Issue Type: Improvement Components: Build Reporter: David Smiley Priority: Minor Attachments: SOLR-2365_DIH_should_not_be_in_war.patch The DIH has a build.xml that puts itself into the Solr war file. This is the only contrib module that does this, and I don't think it should be this way. Granted there is a small dataimport.jsp file that would be most convenient to remain included, but the jar should not be. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
