[GitHub] madlib pull request #211: Change madlib gppkg version string

[jingyimei]

Github user jingyimei commented on a diff in the pull request:

https://github.com/apache/madlib/pull/211#discussion_r155683583
  
--- Diff: cmake/LinuxUtils.cmake ---
@@ -9,3 +9,14 @@ macro(rh_version OUT_VERSION)
 set(${OUT_VERSION} "${OUT_VERSION}-NOTFOUND")
 endif(EXISTS "/etc/redhat-release")
 endmacro(rh_version)
+
--- End diff --

yes, I can use a regex to grep RH_MAJOR_VERSION from RH_VERSION after 
running`rh_version(RH_VERSION)`.


---

[GitHub] madlib pull request #211: Change madlib gppkg version string

[iyerr3]

Github user iyerr3 commented on a diff in the pull request:

https://github.com/apache/madlib/pull/211#discussion_r155598266
  
--- Diff: cmake/LinuxUtils.cmake ---
@@ -9,3 +9,14 @@ macro(rh_version OUT_VERSION)
 set(${OUT_VERSION} "${OUT_VERSION}-NOTFOUND")
 endif(EXISTS "/etc/redhat-release")
 endmacro(rh_version)
+
--- End diff --

Would it be possible to get the major version from the above macro instead 
of a new macro? Maybe after running `rh_version(RH_VERSION)`?



---

[GitHub] madlib pull request #211: Change madlib gppkg version string

[iyerr3]

Github user iyerr3 commented on a diff in the pull request:

https://github.com/apache/madlib/pull/211#discussion_r155597507
  
--- Diff: CMakeLists.txt ---
@@ -275,4 +275,3 @@ install(CODE "
${CMAKE_MADLIB_ROOT}/doc
)
 ")
--- End diff --

Let's put the newline back. 


---

[GitHub] madlib pull request #211: Change madlib gppkg version string

[iyerr3]

Github user iyerr3 commented on a diff in the pull request:

https://github.com/apache/madlib/pull/211#discussion_r155599007
  
--- Diff: src/ports/greenplum/cmake/GreenplumUtils.cmake ---
@@ -17,6 +17,9 @@ function(add_gppkg GPDB_VERSION GPDB_VARIANT 
GPDB_VARIANT_SHORT UPGRADE_SUPPORT)
 string(TOLOWER ${GPDB_VERSION} GPDB_VERSION_LC)
 string(REPLACE "." "_" VERSION_ "${GPDB_VERSION}")
 
+# Get information about the rhel version
+rh_major_version(RH_VERSION)
--- End diff --

`RPM/cmakelists.txt` is also setting `RH_VERSION`. How about we call this 
RH_MAJOR_VERSION?


---

[GitHub] madlib pull request #211: Change madlib gppkg version string

[iyerr3]

Github user iyerr3 commented on a diff in the pull request:

https://github.com/apache/madlib/pull/211#discussion_r155598556
  
--- Diff: deploy/CMakeLists.txt ---
@@ -82,4 +82,4 @@ cpack_add_component_group(ports
 file(GLOB PORT_COMPONENTS "${CMAKE_CURRENT_BINARY_DIR}/Component_*.cmake")
 foreach(PORT_COMPONENT ${PORT_COMPONENTS})
 include("${PORT_COMPONENT}")
-endforeach(PORT_COMPONENT)
+endforeach(PORT_COMPONENT)
--- End diff --

Let's add the newline back. 


---

[GitHub] madlib pull request #211: Change madlib gppkg version string

[jingyimei]

GitHub user jingyimei opened a pull request:

https://github.com/apache/madlib/pull/211

Change madlib gppkg  version string

This commit changes the naming convention for madlib gppkg,
after renaming, the format of madlib gppkg will look like:
madlib-1.13_dev-gp5-rhel6-x86_64.gppkg
madlib-1.12_dev-gp4.3orca-rhel5-x86_64.gppkg

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jingyimei/madlib gppkg_rename

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/madlib/pull/211.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #211


commit 192e7208e2cab2845642eb0995e277382c2af250
Author: Jingyi Mei 
Date:   2017-12-06T04:13:34Z

Change madlib gppkg  version string

This commit changes the naming convention for madlib gppkg,
after renaming, the format of madlib gppkg will look like:
madlib-1.13_dev-gp5-rhel6-x86_64.gppkg
madlib-1.12_dev-gp4.3orca-rhel5-x86_64.gppkg




---