Re: A Maven plugin to power up your Maven builds with custom java code
Hi Mark, I agree with you it would be better not to add the dependencies to compile or test scope, but Eclipse does not understand and complains about compile errors in build classes. I think it will be the same with any IDE. So for now I think adding the dependencies to test scope is our best option. On 9 May 2016, at 1:40, Hervé BOUTEMY wrote: Some little questions: 1. on https://javabuild.java.net/builder-maven-plugin/usage.html can the dependency on builder-api be test scope? (to avoid polluting the component dependencies with build requirements) I was thinking including the dependency INSIDE the declaration might also be useful, if you wanted/needed to depend on extra libraries that should be build specific, they could also go there - and not pollute compile OR test scopes. Plugin looks kinda neat. Mark -- Mark Derricutt http://www.theoryinpractice.net http://www.chaliceofblood.net http://plus.google.com/+MarkDerricutt http://twitter.com/talios http://facebook.com/mderricutt
Re: Maven Core - Release 3.4.0?
On 8 May 2016, at 6:05, Karl Heinz Marbaise wrote: > based on the number issues which have been fixed in the current 3.4.0... Just gave 3.4.0-SNAPSHOT a spin and interestingly, simply running a project ( that passes with 3.3.9 ) under 3.4.0 I get: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.6:single (assembly) on project com.smxemail.appsuite.vacationservice: Assembly is incorrectly configured: null: Assembly is incorrectly configured: null: [ERROR] Assembly: null is not configured correctly: Assembly ID must be present and non-empty. Adding an appropriate `` to my assembly solves the problem, I do note that I hadn't locked down the assembly plugin version, and 3.4.0-SNAPHOT uses 2.6, and 3.3.9 uses 2.2-beta-5 - I guess these versions have been updated in the supermom. Should we document what plugins versions were updated? Mark -- Mark Derricutt http://www.theoryinpractice.net http://www.chaliceofblood.net http://plus.google.com/+MarkDerricutt http://twitter.com/talios http://facebook.com/mderricutt signature.asc Description: OpenPGP digital signature
Re: A Maven plugin to power up your Maven builds with custom java code
If it were something structured I’d probably start with GMaven. I can write Java in an IDE faster than ad-hoc Groovy so I really only thought of the one-off cases and custom logic vis-a-vis the in-line plugins. > On May 8, 2016, at 5:49 PM, Francois-Xavier Bonnet > wrote: > > Romain, Jason, > > I have already looked at polyglot maven and unless I missed something you > can execute some specific code but it has to be inside the pom. This should > be ok for simple cases but to do more complex things I find it more > convenient to be able to structure the code as classes in a specific source > folder. > In the exemples of polyglot maven I have seen only some hello world > specific code exemples. Do you have other exemples with more complex things? > Le 8 mai 2016 20:47, "Jason van Zyl" a écrit : >> >> It has worked out of the box since 3.3.1 and the Maven Wrapper stuff. But > the fact is most users don’t really care, developers are looking at the > build all that often that it matters much. I think it’s pretty cool that it > works but in the grand scheme of things most things should work with a > plugin the exception being building runtimes. There I agree a DSL of sorts > would be useful, but for the main build I think most find in practice there > isn’t a huge win in a large organization. >> > > On mvn side yes, not on the whole ecosystem side and tools mimicing mvn > meta read process like a lot of companie did. Main issue is for frontend > stuff which is often custom by project and should be integrated with > pre-package phase. Often got a hard time with groovy task to order front > steps. Also having a src/build makes any of custom doc+build possible which > is more and more common - workaround is mvn exec today but miss its build > scope. Of course custom mojo are always possible but a lot of effort for > nothing in final artifacts when not a big company. > > Just my 2cts > >>> On May 8, 2016, at 12:43 PM, Romain Manni-Bucau > wrote: >>> >>> Well having it working ootb everywhere - including ideS - is a must and > why >>> polyglot maven didnt get as must market as it should IMHO. >>> >>> Also being able to order in the pom itself execution by reference would >>> solve a lot of headaches. >>> Le 8 mai 2016 17:04, "Jason van Zyl" a écrit : >>> There is also: > https://github.com/takari/polyglot-maven-examples/blob/master/groovy/pom.groovy and the equivalent for ruby: > https://github.com/takari/polyglot-maven-examples/blob/master/ruby/hello/pom.rb Both the Groovy and Ruby dialect allow inline of plugins. Similar ideas but you might be able to reuse code in such a way it > meshes with what exists. > On May 6, 2016, at 3:55 AM, Francois-Xavier Bonnet < > fx.bon...@gmail.com> wrote: > > Hi, > > I wrote a Maven plugin that lets you execute java code directly from > the > project and bind it to build cycle phases. I believe this can be > helpful > when you want to do something specific in your project without having > to > develop your own custom plugin (or before spending time packaging it > as a > plugin if it happens to be reusable). > > I will be happy if this plugin can be useful to other people. Also if > someone wants to help me improve it, any thought or advice would be greatly > appreciated. > The plugin is released on Maven central and already used on a few projects. > It is on Github under Apache 2 License. > > https://javabuild.java.net/ > https://github.com/javabuild/builder-maven-plugin > > Regards, > Francois-Xavier Bonnet Thanks, Jason -- Jason van Zyl Founder, Takari and Apache Maven http://twitter.com/jvanzyl http://twitter.com/takari_io - - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org >> >> Thanks, >> >> Jason >> >> -- >> Jason van Zyl >> Founder, Takari and Apache Maven >> http://twitter.com/jvanzyl >> http://twitter.com/takari_io >> - >> >> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org >> Thanks, Jason -- Jason van Zyl Founder, Takari and Apache Maven http://twitter.com/jvanzyl http://twitter.com/takari_io - - To un
Re: A Maven plugin to power up your Maven builds with custom java code
On 9 May 2016, at 1:40, Hervé BOUTEMY wrote: > Some little questions: > 1. on https://javabuild.java.net/builder-maven-plugin/usage.html > can the dependency on builder-api be test scope? (to avoid polluting the > component dependencies with build requirements) I was thinking including the dependency INSIDE the `` declaration might also be useful, if you wanted/needed to depend on extra libraries that should be build specific, they could also go there - and not pollute compile OR test scopes. Plugin looks kinda neat. Mark -- Mark Derricutt http://www.theoryinpractice.net http://www.chaliceofblood.net http://plus.google.com/+MarkDerricutt http://twitter.com/talios http://facebook.com/mderricutt signature.asc Description: OpenPGP digital signature
Re: A Maven plugin to power up your Maven builds with custom java code
Romain, Jason, I have already looked at polyglot maven and unless I missed something you can execute some specific code but it has to be inside the pom. This should be ok for simple cases but to do more complex things I find it more convenient to be able to structure the code as classes in a specific source folder. In the exemples of polyglot maven I have seen only some hello world specific code exemples. Do you have other exemples with more complex things? Le 8 mai 2016 20:47, "Jason van Zyl" a écrit : > > It has worked out of the box since 3.3.1 and the Maven Wrapper stuff. But the fact is most users don’t really care, developers are looking at the build all that often that it matters much. I think it’s pretty cool that it works but in the grand scheme of things most things should work with a plugin the exception being building runtimes. There I agree a DSL of sorts would be useful, but for the main build I think most find in practice there isn’t a huge win in a large organization. > On mvn side yes, not on the whole ecosystem side and tools mimicing mvn meta read process like a lot of companie did. Main issue is for frontend stuff which is often custom by project and should be integrated with pre-package phase. Often got a hard time with groovy task to order front steps. Also having a src/build makes any of custom doc+build possible which is more and more common - workaround is mvn exec today but miss its build scope. Of course custom mojo are always possible but a lot of effort for nothing in final artifacts when not a big company. Just my 2cts > > On May 8, 2016, at 12:43 PM, Romain Manni-Bucau wrote: > > > > Well having it working ootb everywhere - including ideS - is a must and why > > polyglot maven didnt get as must market as it should IMHO. > > > > Also being able to order in the pom itself execution by reference would > > solve a lot of headaches. > > Le 8 mai 2016 17:04, "Jason van Zyl" a écrit : > > > >> There is also: > >> https://github.com/takari/polyglot-maven-examples/blob/master/groovy/pom.groovy > >> > >> and the equivalent for ruby: > >> https://github.com/takari/polyglot-maven-examples/blob/master/ruby/hello/pom.rb > >> > >> Both the Groovy and Ruby dialect allow inline of plugins. > >> > >> Similar ideas but you might be able to reuse code in such a way it meshes > >> with what exists. > >> > >>> On May 6, 2016, at 3:55 AM, Francois-Xavier Bonnet < fx.bon...@gmail.com> > >> wrote: > >>> > >>> Hi, > >>> > >>> I wrote a Maven plugin that lets you execute java code directly from the > >>> project and bind it to build cycle phases. I believe this can be helpful > >>> when you want to do something specific in your project without having to > >>> develop your own custom plugin (or before spending time packaging it as a > >>> plugin if it happens to be reusable). > >>> > >>> I will be happy if this plugin can be useful to other people. Also if > >>> someone wants to help me improve it, any thought or advice would be > >> greatly > >>> appreciated. > >>> The plugin is released on Maven central and already used on a few > >> projects. > >>> It is on Github under Apache 2 License. > >>> > >>> https://javabuild.java.net/ > >>> https://github.com/javabuild/builder-maven-plugin > >>> > >>> Regards, > >>> Francois-Xavier Bonnet > >> > >> Thanks, > >> > >> Jason > >> > >> -- > >> Jason van Zyl > >> Founder, Takari and Apache Maven > >> http://twitter.com/jvanzyl > >> http://twitter.com/takari_io > >> - > >> > >> > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> For additional commands, e-mail: dev-h...@maven.apache.org > >> > >> > > Thanks, > > Jason > > -- > Jason van Zyl > Founder, Takari and Apache Maven > http://twitter.com/jvanzyl > http://twitter.com/takari_io > - > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org >
Re: A Maven plugin to power up your Maven builds with custom java code
Hi Hervé, You are right, builder-api dependency should definitely be in test scope. I will get this fixed. I am not very used to plugins integration tests. I will test your suggestion. If it can work this way, a single multimodule project would certainly make things more simple. Thank you for your feedback. Le 8 mai 2016 3:40 PM, "Hervé BOUTEMY" a écrit : > Hi FX, > > Interesting for people who don't want to write such code in Groovy, which > would be my initial bet on such scenario. > > Some little questions: > 1. on https://javabuild.java.net/builder-maven-plugin/usage.html > can the dependency on builder-api be test scope? (to avoid polluting the > component dependencies with build requirements) > > 2. on https://github.com/javabuild/builder-maven-plugin-test > instead of a separate project, did you try to make this as IT of builder- > maven-plugin? This would do the same work as documentation, but in addition > would be run when building builder-maven-plugin > And in the end, your 4 git repos could be only one multi-module project: > >builder-parent >|- builder-api >|- builder-maven-plugin > |- src/it/builder-maven-plugin-test > > Regards, > > Hervé > > Le vendredi 6 mai 2016 09:55:43 Francois-Xavier Bonnet a écrit : > > Hi, > > > > I wrote a Maven plugin that lets you execute java code directly from the > > project and bind it to build cycle phases. I believe this can be helpful > > when you want to do something specific in your project without having to > > develop your own custom plugin (or before spending time packaging it as a > > plugin if it happens to be reusable). > > > > I will be happy if this plugin can be useful to other people. Also if > > someone wants to help me improve it, any thought or advice would be > greatly > > appreciated. > > The plugin is released on Maven central and already used on a few > projects. > > It is on Github under Apache 2 License. > > > > https://javabuild.java.net/ > > https://github.com/javabuild/builder-maven-plugin > > > > Regards, > > Francois-Xavier Bonnet > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: A Maven plugin to power up your Maven builds with custom java code
Le 8 mai 2016 20:47, "Jason van Zyl" a écrit : > > It has worked out of the box since 3.3.1 and the Maven Wrapper stuff. But the fact is most users don’t really care, developers are looking at the build all that often that it matters much. I think it’s pretty cool that it works but in the grand scheme of things most things should work with a plugin the exception being building runtimes. There I agree a DSL of sorts would be useful, but for the main build I think most find in practice there isn’t a huge win in a large organization. > On mvn side yes, not on the whole ecosystem side and tools mimicing mvn meta read process like a lot of companie did. Main issue is for frontend stuff which is often custom by project and should be integrated with pre-package phase. Often got a hard time with groovy task to order front steps. Also having a src/build makes any of custom doc+build possible which is more and more common - workaround is mvn exec today but miss its build scope. Of course custom mojo are always possible but a lot of effort for nothing in final artifacts when not a big company. Just my 2cts > > On May 8, 2016, at 12:43 PM, Romain Manni-Bucau wrote: > > > > Well having it working ootb everywhere - including ideS - is a must and why > > polyglot maven didnt get as must market as it should IMHO. > > > > Also being able to order in the pom itself execution by reference would > > solve a lot of headaches. > > Le 8 mai 2016 17:04, "Jason van Zyl" a écrit : > > > >> There is also: > >> https://github.com/takari/polyglot-maven-examples/blob/master/groovy/pom.groovy > >> > >> and the equivalent for ruby: > >> https://github.com/takari/polyglot-maven-examples/blob/master/ruby/hello/pom.rb > >> > >> Both the Groovy and Ruby dialect allow inline of plugins. > >> > >> Similar ideas but you might be able to reuse code in such a way it meshes > >> with what exists. > >> > >>> On May 6, 2016, at 3:55 AM, Francois-Xavier Bonnet < fx.bon...@gmail.com> > >> wrote: > >>> > >>> Hi, > >>> > >>> I wrote a Maven plugin that lets you execute java code directly from the > >>> project and bind it to build cycle phases. I believe this can be helpful > >>> when you want to do something specific in your project without having to > >>> develop your own custom plugin (or before spending time packaging it as a > >>> plugin if it happens to be reusable). > >>> > >>> I will be happy if this plugin can be useful to other people. Also if > >>> someone wants to help me improve it, any thought or advice would be > >> greatly > >>> appreciated. > >>> The plugin is released on Maven central and already used on a few > >> projects. > >>> It is on Github under Apache 2 License. > >>> > >>> https://javabuild.java.net/ > >>> https://github.com/javabuild/builder-maven-plugin > >>> > >>> Regards, > >>> Francois-Xavier Bonnet > >> > >> Thanks, > >> > >> Jason > >> > >> -- > >> Jason van Zyl > >> Founder, Takari and Apache Maven > >> http://twitter.com/jvanzyl > >> http://twitter.com/takari_io > >> - > >> > >> > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> For additional commands, e-mail: dev-h...@maven.apache.org > >> > >> > > Thanks, > > Jason > > -- > Jason van Zyl > Founder, Takari and Apache Maven > http://twitter.com/jvanzyl > http://twitter.com/takari_io > - > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org >
Re: A Maven plugin to power up your Maven builds with custom java code
It has worked out of the box since 3.3.1 and the Maven Wrapper stuff. But the fact is most users don’t really care, developers are looking at the build all that often that it matters much. I think it’s pretty cool that it works but in the grand scheme of things most things should work with a plugin the exception being building runtimes. There I agree a DSL of sorts would be useful, but for the main build I think most find in practice there isn’t a huge win in a large organization. > On May 8, 2016, at 12:43 PM, Romain Manni-Bucau wrote: > > Well having it working ootb everywhere - including ideS - is a must and why > polyglot maven didnt get as must market as it should IMHO. > > Also being able to order in the pom itself execution by reference would > solve a lot of headaches. > Le 8 mai 2016 17:04, "Jason van Zyl" a écrit : > >> There is also: >> https://github.com/takari/polyglot-maven-examples/blob/master/groovy/pom.groovy >> >> and the equivalent for ruby: >> https://github.com/takari/polyglot-maven-examples/blob/master/ruby/hello/pom.rb >> >> Both the Groovy and Ruby dialect allow inline of plugins. >> >> Similar ideas but you might be able to reuse code in such a way it meshes >> with what exists. >> >>> On May 6, 2016, at 3:55 AM, Francois-Xavier Bonnet >> wrote: >>> >>> Hi, >>> >>> I wrote a Maven plugin that lets you execute java code directly from the >>> project and bind it to build cycle phases. I believe this can be helpful >>> when you want to do something specific in your project without having to >>> develop your own custom plugin (or before spending time packaging it as a >>> plugin if it happens to be reusable). >>> >>> I will be happy if this plugin can be useful to other people. Also if >>> someone wants to help me improve it, any thought or advice would be >> greatly >>> appreciated. >>> The plugin is released on Maven central and already used on a few >> projects. >>> It is on Github under Apache 2 License. >>> >>> https://javabuild.java.net/ >>> https://github.com/javabuild/builder-maven-plugin >>> >>> Regards, >>> Francois-Xavier Bonnet >> >> Thanks, >> >> Jason >> >> -- >> Jason van Zyl >> Founder, Takari and Apache Maven >> http://twitter.com/jvanzyl >> http://twitter.com/takari_io >> - >> >> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org >> >> Thanks, Jason -- Jason van Zyl Founder, Takari and Apache Maven http://twitter.com/jvanzyl http://twitter.com/takari_io - - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: A Maven plugin to power up your Maven builds with custom java code
Well having it working ootb everywhere - including ideS - is a must and why polyglot maven didnt get as must market as it should IMHO. Also being able to order in the pom itself execution by reference would solve a lot of headaches. Le 8 mai 2016 17:04, "Jason van Zyl" a écrit : > There is also: > https://github.com/takari/polyglot-maven-examples/blob/master/groovy/pom.groovy > > and the equivalent for ruby: > https://github.com/takari/polyglot-maven-examples/blob/master/ruby/hello/pom.rb > > Both the Groovy and Ruby dialect allow inline of plugins. > > Similar ideas but you might be able to reuse code in such a way it meshes > with what exists. > > > On May 6, 2016, at 3:55 AM, Francois-Xavier Bonnet > wrote: > > > > Hi, > > > > I wrote a Maven plugin that lets you execute java code directly from the > > project and bind it to build cycle phases. I believe this can be helpful > > when you want to do something specific in your project without having to > > develop your own custom plugin (or before spending time packaging it as a > > plugin if it happens to be reusable). > > > > I will be happy if this plugin can be useful to other people. Also if > > someone wants to help me improve it, any thought or advice would be > greatly > > appreciated. > > The plugin is released on Maven central and already used on a few > projects. > > It is on Github under Apache 2 License. > > > > https://javabuild.java.net/ > > https://github.com/javabuild/builder-maven-plugin > > > > Regards, > > Francois-Xavier Bonnet > > Thanks, > > Jason > > -- > Jason van Zyl > Founder, Takari and Apache Maven > http://twitter.com/jvanzyl > http://twitter.com/takari_io > - > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: A Maven plugin to power up your Maven builds with custom java code
There is also: https://github.com/takari/polyglot-maven-examples/blob/master/groovy/pom.groovy and the equivalent for ruby: https://github.com/takari/polyglot-maven-examples/blob/master/ruby/hello/pom.rb Both the Groovy and Ruby dialect allow inline of plugins. Similar ideas but you might be able to reuse code in such a way it meshes with what exists. > On May 6, 2016, at 3:55 AM, Francois-Xavier Bonnet > wrote: > > Hi, > > I wrote a Maven plugin that lets you execute java code directly from the > project and bind it to build cycle phases. I believe this can be helpful > when you want to do something specific in your project without having to > develop your own custom plugin (or before spending time packaging it as a > plugin if it happens to be reusable). > > I will be happy if this plugin can be useful to other people. Also if > someone wants to help me improve it, any thought or advice would be greatly > appreciated. > The plugin is released on Maven central and already used on a few projects. > It is on Github under Apache 2 License. > > https://javabuild.java.net/ > https://github.com/javabuild/builder-maven-plugin > > Regards, > Francois-Xavier Bonnet Thanks, Jason -- Jason van Zyl Founder, Takari and Apache Maven http://twitter.com/jvanzyl http://twitter.com/takari_io - - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: A Maven plugin to power up your Maven builds with custom java code
Hi all I love that. Only missing thing to kill gradle in my use cases is a full control on plugin order from the pom and not rely on easy to break convention - a change in a parent can do today. Le 8 mai 2016 15:40, "Hervé BOUTEMY" a écrit : > Hi FX, > > Interesting for people who don't want to write such code in Groovy, which > would be my initial bet on such scenario. > > Some little questions: > 1. on https://javabuild.java.net/builder-maven-plugin/usage.html > can the dependency on builder-api be test scope? (to avoid polluting the > component dependencies with build requirements) > > 2. on https://github.com/javabuild/builder-maven-plugin-test > instead of a separate project, did you try to make this as IT of builder- > maven-plugin? This would do the same work as documentation, but in addition > would be run when building builder-maven-plugin > And in the end, your 4 git repos could be only one multi-module project: > >builder-parent >|- builder-api >|- builder-maven-plugin > |- src/it/builder-maven-plugin-test > > Regards, > > Hervé > > Le vendredi 6 mai 2016 09:55:43 Francois-Xavier Bonnet a écrit : > > Hi, > > > > I wrote a Maven plugin that lets you execute java code directly from the > > project and bind it to build cycle phases. I believe this can be helpful > > when you want to do something specific in your project without having to > > develop your own custom plugin (or before spending time packaging it as a > > plugin if it happens to be reusable). > > > > I will be happy if this plugin can be useful to other people. Also if > > someone wants to help me improve it, any thought or advice would be > greatly > > appreciated. > > The plugin is released on Maven central and already used on a few > projects. > > It is on Github under Apache 2 License. > > > > https://javabuild.java.net/ > > https://github.com/javabuild/builder-maven-plugin > > > > Regards, > > Francois-Xavier Bonnet > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: A Maven plugin to power up your Maven builds with custom java code
Hi FX, Interesting for people who don't want to write such code in Groovy, which would be my initial bet on such scenario. Some little questions: 1. on https://javabuild.java.net/builder-maven-plugin/usage.html can the dependency on builder-api be test scope? (to avoid polluting the component dependencies with build requirements) 2. on https://github.com/javabuild/builder-maven-plugin-test instead of a separate project, did you try to make this as IT of builder- maven-plugin? This would do the same work as documentation, but in addition would be run when building builder-maven-plugin And in the end, your 4 git repos could be only one multi-module project: builder-parent |- builder-api |- builder-maven-plugin |- src/it/builder-maven-plugin-test Regards, Hervé Le vendredi 6 mai 2016 09:55:43 Francois-Xavier Bonnet a écrit : > Hi, > > I wrote a Maven plugin that lets you execute java code directly from the > project and bind it to build cycle phases. I believe this can be helpful > when you want to do something specific in your project without having to > develop your own custom plugin (or before spending time packaging it as a > plugin if it happens to be reusable). > > I will be happy if this plugin can be useful to other people. Also if > someone wants to help me improve it, any thought or advice would be greatly > appreciated. > The plugin is released on Maven central and already used on a few projects. > It is on Github under Apache 2 License. > > https://javabuild.java.net/ > https://github.com/javabuild/builder-maven-plugin > > Regards, > Francois-Xavier Bonnet - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven JAR Plugin version 3.0.0 (Take 3)
Right, there is no IT in m-jar-plugun to check this. The tests are in the library/component that handles this. /Anders (mobile) On May 7, 2016 23:06, "Robert Scholte" wrote: > I'm using Win10 > > The funny thing: > Manifest-Version: 1.0 > Implementation-Vendor: The Apache Software Foundation > Implementation-Title: Apache Maven JAR Plugin > Implementation-Version: 3.0.0 > Implementation-Vendor-Id: org.apache.maven.plugins > Built-By: Robert Scholte > Build-Jdk: 1.7.0_55 > Specification-Vendor: The Apache Software Foundation > Specification-Title: Apache Maven JAR Plugin > Created-By: Apache Maven 3.3.9 > Specification-Version: 3.0.0 > Archiver-Version: Plexus Archiver > > So the version is set correctly in the plugin jar. > > At least one IT-project should have failed because of the missing version, > so it seems there was no additional IT written to check the value of > Created-By: > > Where should this maven.version come from? > > Robert > > On Sat, 07 May 2016 22:54:34 +0200, Karl Heinz Marbaise > wrote: > > Hi Robert, >> >> On 5/7/16 10:24 PM, Robert Scholte wrote: >> >>> This is my content of >>> >>> maven-jar-plugin-3.0.0\target\it\manifest-content\target\manifest-content-1.0-SNAPSHOT.jar!/META-INF/MANIFEST.MF >>> >>> >>> Manifest-Version: 1.0 >>> Implementation-Vendor: jar plugin it >>> Implementation-Title: manifest-content-it >>> Implementation-Version: 1.0-SNAPSHOT >>> Implementation-Vendor-Id: org.apache.maven.plugins >>> Built-By: Robert Scholte >>> Build-Jdk: 1.7.0_55 >>> Specification-Vendor: jar plugin it >>> Specification-Title: manifest-content-it >>> Created-By: Apache Maven >>> Specification-Version: 1.0 >>> Main-Class: myproject.HelloWorld >>> Archiver-Version: Plexus Archiver >>> >>> build.log show >>> [DEBUG] Populating class realm >>> plugin>org.apache.maven.plugins:maven-jar-plugin:3.0.0 >>> [DEBUG] Included: org.apache.maven.plugins:maven-jar-plugin:jar:3.0.0 >>> [DEBUG] Included: org.sonatype.sisu:sisu-inject-bean:jar:1.4.2 >>> [DEBUG] Included: org.sonatype.sisu:sisu-guice:jar:noaop:2.1.7 >>> [DEBUG] Included: org.sonatype.aether:aether-util:jar:1.7 >>> [DEBUG] Included: org.codehaus.plexus:plexus-interpolation:jar:1.14 >>> [DEBUG] Included: >>> org.codehaus.plexus:plexus-component-annotations:jar:1.5.5 >>> [DEBUG] Included: org.sonatype.plexus:plexus-sec-dispatcher:jar:1.3 >>> [DEBUG] Included: org.sonatype.plexus:plexus-cipher:jar:1.4 >>> [DEBUG] Included: org.apache.maven:maven-archiver:jar:3.0.2 >>> [DEBUG] Included: org.apache.maven.shared:maven-shared-utils:jar:3.0.0 >>> [DEBUG] Included: commons-io:commons-io:jar:2.4 >>> [DEBUG] Included: com.google.code.findbugs:jsr305:jar:2.0.1 >>> [DEBUG] Included: org.codehaus.plexus:plexus-archiver:jar:3.1.1 >>> [DEBUG] Included: org.codehaus.plexus:plexus-io:jar:2.7.1 >>> [DEBUG] Included: org.apache.commons:commons-compress:jar:1.10 >>> [DEBUG] Included: org.iq80.snappy:snappy:jar:0.4 >>> [DEBUG] Included: org.codehaus.plexus:plexus-utils:jar:3.0.22 >>> >> >> Hm...the list is exactly the same i have here on Mac OS >> so the components are there...so only the behaviour in the components can >> make the difference... >> >> So i have tested on Windows XP with Maven 3.2.1 and 3.3.9 and it works >> correctly... >> >> Manifest-Version: 1.0 >> Implementation-Vendor: jar plugin it >> Implementation-Title: manifest-content-it >> Implementation-Version: 1.0-SNAPSHOT >> Implementation-Vendor-Id: org.apache.maven.plugins >> Built-By: kama >> Build-Jdk: 1.7.0_55 >> Specification-Vendor: jar plugin it >> Specification-Title: manifest-content-it >> Created-By: Apache Maven 3.3.9 >> Specification-Version: 1.0 >> Main-Class: myproject.HelloWorld >> Archiver-Version: Plexus Archiver >> >> >> Hm... >> >> >> >> >> >> >> >>> I haven't installed the plugin in my repository. >>> >>> Could it be a Windows issue? >>> >>> Robert >>> >>> On Sat, 07 May 2016 21:04:19 +0200, Karl Heinz Marbaise >>> wrote: >>> >>> Hi Robert, On 5/7/16 8:35 PM, Robert Scholte wrote: > https://issues.apache.org/jira/browse/MJAR-218 > is this really fixed? > > I still see a versionless Apache Maven in the MANIFEST.MF > Hm...I tested with Maven 3.0.5 and 3.3.9 via mvn -Prun-its clean verify and checked the generated JAR files which are Ok Furthermore i run Maven 3.3.9 and also: mvn -Prun-its clean verify -Dinvoker.mavenHome=/usr/share/java/apache-maven-3.0.5 which produces correct artifacts Unfortunately i can not reproduce this at the moment...But it if is not..So it means making a 3.0.1 release very soon... Can you give some examples of files which do not contain the correct: "Created-By: " entry? Kind regards Karl Heinz Marbaise > Executed as > d:\apache-maven-3.3.9\bin\mvn clean verify -Prun-its > -Dinvoker.mavenHome=d:\apache-maven-3.0 > > thank
