[GitHub] maven pull request #99: [MNG-6127] Fix plugin execution configuration interf...

2016-11-23 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/maven/pull/99


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] maven-integration-testing pull request #16: [MNG-6127] Add plugin execution ...

2016-11-23 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/maven-integration-testing/pull/16


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] maven issue #99: [MNG-6127] Fix plugin execution configuration interference

2016-11-23 Thread mkrizmanic
Github user mkrizmanic commented on the issue:

https://github.com/apache/maven/pull/99
  
@ChristianSchulte PR already provided: 
https://github.com/apache/maven-integration-testing/pull/16


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] maven-wagon issue #24: [wagon-ftp] support for secure FTP connection

2016-11-23 Thread dantran
Github user dantran commented on the issue:

https://github.com/apache/maven-wagon/pull/24
  
@wiiitek could you squash the commits?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] maven-wagon issue #29: [WAGON-467] Allow customisation of some SSH options

2016-11-23 Thread nfalco79
Github user nfalco79 commented on the issue:

https://github.com/apache/maven-wagon/pull/29
  
closed by this ffa7fc8830e916e9d3d91a222b641cd5363ffafe


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] maven-wagon pull request #29: [WAGON-467] Allow customisation of some SSH op...

2016-11-23 Thread nfalco79
Github user nfalco79 closed the pull request at:

https://github.com/apache/maven-wagon/pull/29


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: MRESOURCES-231

2016-11-23 Thread Dan Tran
 ?

On Wed, Nov 23, 2016 at 3:37 PM, Christian Schulte  wrote:

> If there is
>
> @Parameter( defaultValue = "\\" )
> protected String escapeString;
>
> in a plugin, how can I set the field to null or an empty string?
> I tried '' and '' but that
> still leads to the field being set to the default value. I am sure this
> has been possible in the past.
>
> Regards,
> --
> Christian
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


[GitHub] maven-wagon issue #29: [WAGON-467] Allow customisation of some SSH options

2016-11-23 Thread dantran
Github user dantran commented on the issue:

https://github.com/apache/maven-wagon/pull/29
  
@nfalco79, since i used the patch method and push this change. Git cant 
close this PR. Please close it yourself


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



https://builds.apache.org/job/maven-wagon-windows - No Maven

2016-11-23 Thread Dan Tran
this build job has no maven to run

ERROR: Maven Home \home\jenkins\tools\maven\apache-maven-3.0.5 doesnt exist


can someone with right access fix this?

Thanks

-Dan


MRESOURCES-231

2016-11-23 Thread Christian Schulte
If there is

@Parameter( defaultValue = "\\" )
protected String escapeString;

in a plugin, how can I set the field to null or an empty string?
I tried '' and '' but that
still leads to the field being set to the default value. I am sure this
has been possible in the past.

Regards,
-- 
Christian

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] maven issue #99: [MNG-6127] Fix plugin execution configuration interference

2016-11-23 Thread ChristianSchulte
Github user ChristianSchulte commented on the issue:

https://github.com/apache/maven/pull/99
  
Could you please also provide an integration test against 
[maven-integration-testing](https://github.com/apache/maven-integration-testing).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Need to change a test case in 'maven-filtering'.

2016-11-23 Thread Christian Schulte
Am 11/22/16 um 20:40 schrieb Guillaume Boué:
> Hi Christian,
> 
> This test looks normal to me. When loading the properties, through load 
> https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader-,
>  
> the backslash indicates the line terminator, so it needs to be escaped, 
> otherwise the method would (silently) ignore it (if it doesn't represent 
> a valid escape sequence). So having
> 
> edge.escape.hanging=\\
> 
> 
> in the properties file means that you'll read "\" for the 
> "edge.escape.hanging" property on the Java side. So it's testing that a 
> lone escape character doesn't cause any issues during filtering.
>

I am not questioning the way the properties are loaded. I am questioning
the filtering itself. If the input is '\\', that is an escaped escape
string. So the output needs to be '\' after filtering. It isn't because
the escape string cannot be escaped. That's the issue I am fixing. I
cannot fix that without changing that test case. Looking at this, there
are cases where escaping the escape string leads to different output
than before I don't know how to handle.

IN = '\\'
OUT = '\\'

That's the issue. This needs to look like

IN = '\\'
OUT = '\'

if the escape string is the backslash. There is this test case testing
that the escape string does not get escaped. That may be intentionally.
I don't know.

Regards,
-- 
Christian


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] maven-integration-testing pull request #16: [MNG-6127] Add plugin execution ...

2016-11-23 Thread mkrizmanic
GitHub user mkrizmanic opened a pull request:

https://github.com/apache/maven-integration-testing/pull/16

[MNG-6127] Add plugin execution configuration interference test



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mkrizmanic/maven-integration-testing MNG-6127

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-integration-testing/pull/16.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #16


commit 1e7fa29ef3d8feb8c6de4a0849e0abda942ec440
Author: Mario Krizmanic 
Date:   2016-11-23T21:25:34Z

[MNG-6127] Add plugin execution configuration interference test




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] maven pull request #99: [MNG-6127] Fix plugin execution configuration interf...

2016-11-23 Thread mkrizmanic
GitHub user mkrizmanic opened a pull request:

https://github.com/apache/maven/pull/99

[MNG-6127] Fix plugin execution configuration interference



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mkrizmanic/maven MNG-6127

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/99.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #99


commit 546eb980a843c72630cdb0448a95c17cbab6f059
Author: Mario Krizmanic 
Date:   2016-11-23T21:11:56Z

[MNG-6127] Fix plugin execution configuration interference




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Logging for 3.0.x and >=3.1.0

2016-11-23 Thread Martin Gainty



From: Jason Pyeron 
Sent: Wednesday, November 23, 2016 2:59 PM
To: dev@maven.apache.org
Subject: Logging for 3.0.x and >=3.1.0

Working on a plugin right now and it needs to work in 3.0 as well as 3.3.

Scratching my head on can we use slf4j in 3.0 or is there a backwards 
compatibility logic to put in.

MG>AFAIK SLF4J 1.5.6 changed StaticLoggerBinder.SINGLETON from public static to 
private

IllegalAccessError exceptions when using SLF4J. Why is that?

Here are the exception details.

Exception in thread "main" java.lang.IllegalAccessError: tried to access field
org.slf4j.impl.StaticLoggerBinder.SINGLETON from class org.slf4j.LoggerFactory
   at org.slf4j.LoggerFactory.(LoggerFactory.java:60)

This error is caused by the static initializer of the LoggerFactory class 
attempting to directly access the SINGLETON field of 
org.slf4j.impl.StaticLoggerBinder. While this was allowed in SLF4J 1.5.5 and 
earlier, in 1.5.6 and later the SINGLETON field has been marked as private 
access.

If you get the exception shown above, then you are using an older version of 
slf4j-api, e.g. 1.4.3, with a new version of a slf4j binding, e.g. 1.5.6. 
Typically, this occurs when your Maven pom.ml file incorporates hibernate 3.3.0 
which declares a dependency on slf4j-api version 1.4.2. If your pom.xml 
declares a dependency on an slf4j binding, say slf4j-log4j12 version 1.5.6, 
then you will get illegal access errors.

To see which version of slf4j-api is pulled in by Maven, use the maven 
dependency plugin as follows.

mvn dependency:tree

http://slf4j.org/faq.html
SLF4J FAQ
slf4j.org
Binding Requirements; slf4j-nop: JDK 1.5: slf4j-simple: JDK 1.5: slf4j-log4j12: 
JDK 1.5, plus any other library dependencies required by the log4j appenders in 
use



MG>does this help?

-Jason
MG>enjoy your holiday

--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
-   -
- Jason Pyeron  PD Inc. http://www.pdinc.us -
PD Inc.
www.pdinc.us
PD Inc is a business solutions provider with expert solutions tailored to 
consulting projects on an enterprise-wide scale. We have been able to leverage 
our vast ...



- Principal Consultant  10 West 24th Street #100-
- +1 (443) 269-1555 x333Baltimore, Maryland 21218   -
-   -
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] maven issue #97: .travis and SonarQube.com support

2016-11-23 Thread trajano
Github user trajano commented on the issue:

https://github.com/apache/maven/pull/97
  
Going to simplify this PR to a single commit


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Logging for 3.0.x and >=3.1.0

2016-11-23 Thread Jason Pyeron
Working on a plugin right now and it needs to work in 3.0 as well as 3.3.

Scratching my head on can we use slf4j in 3.0 or is there a backwards 
compatibility logic to put in.

-Jason

--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
-   -
- Jason Pyeron  PD Inc. http://www.pdinc.us -
- Principal Consultant  10 West 24th Street #100-
- +1 (443) 269-1555 x333Baltimore, Maryland 21218   -
-   -
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- 



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] maven-wagon pull request #29: [WAGON-467] Allow customisation of some SSH op...

2016-11-23 Thread nfalco79
GitHub user nfalco79 opened a pull request:

https://github.com/apache/maven-wagon/pull/29

[WAGON-467] Allow customisation of some SSH options

This commit add StrictHostKeyChecking and PreferredAuthentications custom 
fields that together allow you to perform, the command scp enough to remove any 
user interaction (username, password and add host key to know_hosts file).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nfalco79/maven-wagon feature/WAGON-467

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-wagon/pull/29.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #29


commit b5f312c5dca59b745662fd81a9e24401d1322ebc
Author: Nikolas Falco 
Date:   2016-11-23T19:24:41Z

[WAGON-467] Allow customisation of some SSH options

This commit add StrictHostKeyChecking and PreferredAuthentications custom 
fields that together allow you to perform, the command scp enough to remove any 
user interaction (username, password and add host key to know_hosts file).




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org