Re: Welcome the new Maven committers: Maarten Mulders en Martin Kanters

2020-07-10 Thread Christian Stein
Happy coding and testing, Maarten and Martin!

On Fri, Jul 10, 2020 at 9:13 PM Robert Scholte  wrote:

> Hi,
>
> On behalf of the Apache Maven PMC I am pleased to announce that
> Maarten Mulders en Martin Kanters has been voted in as new Apache Maven
> committers
> and they've both accepted this invitation.
>
> Welcome on board and have a lot of fun!
>
> Thanks,
> Robert Scholte
>


Re: Welcome the new Maven committers: Maarten Mulders en Martin Kanters

2020-07-10 Thread Hervé BOUTEMY
welcome Maarten en/and Martin :)

When is the next Apachecon, to meet everybody?

Regards,

Hervé

Le vendredi 10 juillet 2020, 21:12:59 CEST Robert Scholte a écrit :
> Hi,
> 
> On behalf of the Apache Maven PMC I am pleased to announce that
> Maarten Mulders en Martin Kanters has been voted in as new Apache Maven
> committers and they've both accepted this invitation.
> 
> Welcome on board and have a lot of fun!
> 
> Thanks,
> Robert Scholte





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Reproducible builds, jars, bundles

2020-07-10 Thread Hervé BOUTEMY
yes, it has to be sorted at plugin level
And even more precisely at each goal level: it seems only some goal produce 
non-reproducible content, or even only some options of some goals

I Felix could produce a doc on how to configure for Reproducible Builds, that 
would be awesome, since this plugin is one of the most complex to configure: 
I'd happily update to link to that documentation in the table from 
https://maven.apache.org/guides/mini/guide-reproducible-builds.html

Regards,

Hervé

Le vendredi 10 juillet 2020, 22:20:39 CEST Romain Manni-Bucau a écrit :
> So maybe ask on felix@ instead of maven@ - that said pretty sure you can
> sort it, one fun hack to test can be to use maven shade with a custom
> transformer to do it.
> 
> Le ven. 10 juil. 2020 à 21:29, Gary Gregory  a
> 
> écrit :
> > Romain,
> > 
> > Yeah, I found the same code fragment but it is not clear to me if keeping
> > that set sorted would have unintended consequences.
> > 
> > I pointed folks in the PRs to this thread so I am hopping a plugin
> > maintainer will opine here.
> > 
> > Gary
> > 
> > On Fri, Jul 10, 2020, 10:53 Romain Manni-Bucau 
> > 
> > wrote:
> > > Hi Gary,
> > > 
> > > Maybe I misunderstood something but isn't it that felix bundle plugin
> > 
> > does
> > 
> > > not sort the maven resources ([1]?
> > > 
> > > [1]
> > 
> > https://github.com/apache/felix-dev/blob/7f4d31b384d9d83c772680a8627df18ff
> > 078eaa4/tools/maven-bundle-plugin/src/main/java/org/apache/felix/bundleplu
> > gin/BundlePlugin.java#L2036> 
> > > Romain Manni-Bucau
> > > @rmannibucau  |  Blog
> > >  | Old Blog
> > >  | Github <
> > > https://github.com/rmannibucau> |
> > > LinkedIn  | Book
> > > <
> > 
> > https://www.packtpub.com/application-development/java-ee-8-high-performanc
> > e
> > 
> > > Le ven. 10 juil. 2020 à 16:44, Gary Gregory  a
> > > 
> > > écrit :
> > > > Hi All,
> > > > 
> > > > Over at Apache Commons, we are looking at creating reproducible builds
> > > 
> > > via:
> > > > https://github.com/apache/commons-parent/pull/9
> > > > 
> > > > As discussed in that thread, a bundle's "Include-Resource" manifest
> > > 
> > > header
> > > 
> > > > has a value with file system elements in different orders depending on
> > > 
> > > file
> > > 
> > > > system used to generate the jar, IOW, not bit by bit reproducible.
> > > > 
> > > > Folks in that discussion and in another here
> > > > https://github.com/apache/commons-lang/pull/578, suggested that the
> > > 
> > > issue
> > > 
> > > > might reside in Maven relying on the file system order and not in
> > > > maven-bundle-plugin or the bnd library as initially considered.
> > > > 
> > > > May you please provide any guidance?
> > > > 
> > > > Thank you,
> > > > Gary





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Welcome the new Maven committers: Maarten Mulders en Martin Kanters

2020-07-10 Thread Olivier Lamy
welcome!

On Sat, 11 Jul 2020 at 08:04, Karl Heinz Marbaise  wrote:

> Hi,
>
> On 10.07.20 21:12, Robert Scholte wrote:
> > Hi,
> >
> > On behalf of the Apache Maven PMC I am pleased to announce that
> > Maarten Mulders en Martin Kanters has been voted in as new Apache Maven
> committers
> > and they've both accepted this invitation.
> >
> > Welcome on board and have a lot of fun!
>
> Welcome on board to both of you.
>
> Welcome Maarten Mulders.
> Welcome Martin Kanters.
>
>
> Kind regards
> Karl Heinz Marbaise
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

-- 
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy


Re: Welcome the new Maven committers: Maarten Mulders en Martin Kanters

2020-07-10 Thread Martin Gainty
welkom martin!

martin


From: Karl Heinz Marbaise 
Sent: Friday, July 10, 2020 6:04 PM
To: Maven Developers List 
Subject: Re: Welcome the new Maven committers: Maarten Mulders en Martin Kanters

Hi,

On 10.07.20 21:12, Robert Scholte wrote:
> Hi,
>
> On behalf of the Apache Maven PMC I am pleased to announce that
> Maarten Mulders en Martin Kanters has been voted in as new Apache Maven 
> committers
> and they've both accepted this invitation.
>
> Welcome on board and have a lot of fun!

Welcome on board to both of you.

Welcome Maarten Mulders.
Welcome Martin Kanters.


Kind regards
Karl Heinz Marbaise

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Welcome the new Maven committers: Maarten Mulders en Martin Kanters

2020-07-10 Thread Karl Heinz Marbaise

Hi,

On 10.07.20 21:12, Robert Scholte wrote:

Hi,

On behalf of the Apache Maven PMC I am pleased to announce that
Maarten Mulders en Martin Kanters has been voted in as new Apache Maven 
committers
and they've both accepted this invitation.

Welcome on board and have a lot of fun!


Welcome on board to both of you.

Welcome Maarten Mulders.
Welcome Martin Kanters.


Kind regards
Karl Heinz Marbaise

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Reproducible builds, jars, bundles

2020-07-10 Thread Romain Manni-Bucau
So maybe ask on felix@ instead of maven@ - that said pretty sure you can
sort it, one fun hack to test can be to use maven shade with a custom
transformer to do it.

Le ven. 10 juil. 2020 à 21:29, Gary Gregory  a
écrit :

> Romain,
>
> Yeah, I found the same code fragment but it is not clear to me if keeping
> that set sorted would have unintended consequences.
>
> I pointed folks in the PRs to this thread so I am hopping a plugin
> maintainer will opine here.
>
> Gary
>
> On Fri, Jul 10, 2020, 10:53 Romain Manni-Bucau 
> wrote:
>
> > Hi Gary,
> >
> > Maybe I misunderstood something but isn't it that felix bundle plugin
> does
> > not sort the maven resources ([1]?
> >
> > [1]
> >
> >
> https://github.com/apache/felix-dev/blob/7f4d31b384d9d83c772680a8627df18ff078eaa4/tools/maven-bundle-plugin/src/main/java/org/apache/felix/bundleplugin/BundlePlugin.java#L2036
> >
> > Romain Manni-Bucau
> > @rmannibucau  |  Blog
> >  | Old Blog
> >  | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn  | Book
> > <
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
> >
> >
> > Le ven. 10 juil. 2020 à 16:44, Gary Gregory  a
> > écrit :
> >
> > > Hi All,
> > >
> > > Over at Apache Commons, we are looking at creating reproducible builds
> > via:
> > >
> > > https://github.com/apache/commons-parent/pull/9
> > >
> > > As discussed in that thread, a bundle's "Include-Resource" manifest
> > header
> > > has a value with file system elements in different orders depending on
> > file
> > > system used to generate the jar, IOW, not bit by bit reproducible.
> > >
> > > Folks in that discussion and in another here
> > > https://github.com/apache/commons-lang/pull/578, suggested that the
> > issue
> > > might reside in Maven relying on the file system order and not in
> > > maven-bundle-plugin or the bnd library as initially considered.
> > >
> > > May you please provide any guidance?
> > >
> > > Thank you,
> > > Gary
> > >
> >
>


Re: Welcome the new Maven committers: Maarten Mulders en Martin Kanters

2020-07-10 Thread Sylwester Lachiewicz
Welcome!

pt., 10 lip 2020, 21:42 użytkownik Enrico Olivelli 
napisał:

> Welcome aboard!
>
> Enrico
>
> Il Ven 10 Lug 2020, 21:13 Robert Scholte  ha
> scritto:
>
> > Hi,
> >
> > On behalf of the Apache Maven PMC I am pleased to announce that
> > Maarten Mulders en Martin Kanters has been voted in as new Apache Maven
> > committers
> > and they've both accepted this invitation.
> >
> > Welcome on board and have a lot of fun!
> >
> > Thanks,
> > Robert Scholte
> >
>


Re: Welcome the new Maven committers: Maarten Mulders en Martin Kanters

2020-07-10 Thread Enrico Olivelli
Welcome aboard!

Enrico

Il Ven 10 Lug 2020, 21:13 Robert Scholte  ha scritto:

> Hi,
>
> On behalf of the Apache Maven PMC I am pleased to announce that
> Maarten Mulders en Martin Kanters has been voted in as new Apache Maven
> committers
> and they've both accepted this invitation.
>
> Welcome on board and have a lot of fun!
>
> Thanks,
> Robert Scholte
>


Re: Reproducible builds, jars, bundles

2020-07-10 Thread Gary Gregory
Romain,

Yeah, I found the same code fragment but it is not clear to me if keeping
that set sorted would have unintended consequences.

I pointed folks in the PRs to this thread so I am hopping a plugin
maintainer will opine here.

Gary

On Fri, Jul 10, 2020, 10:53 Romain Manni-Bucau 
wrote:

> Hi Gary,
>
> Maybe I misunderstood something but isn't it that felix bundle plugin does
> not sort the maven resources ([1]?
>
> [1]
>
> https://github.com/apache/felix-dev/blob/7f4d31b384d9d83c772680a8627df18ff078eaa4/tools/maven-bundle-plugin/src/main/java/org/apache/felix/bundleplugin/BundlePlugin.java#L2036
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github <
> https://github.com/rmannibucau> |
> LinkedIn  | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>
>
> Le ven. 10 juil. 2020 à 16:44, Gary Gregory  a
> écrit :
>
> > Hi All,
> >
> > Over at Apache Commons, we are looking at creating reproducible builds
> via:
> >
> > https://github.com/apache/commons-parent/pull/9
> >
> > As discussed in that thread, a bundle's "Include-Resource" manifest
> header
> > has a value with file system elements in different orders depending on
> file
> > system used to generate the jar, IOW, not bit by bit reproducible.
> >
> > Folks in that discussion and in another here
> > https://github.com/apache/commons-lang/pull/578, suggested that the
> issue
> > might reside in Maven relying on the file system order and not in
> > maven-bundle-plugin or the bnd library as initially considered.
> >
> > May you please provide any guidance?
> >
> > Thank you,
> > Gary
> >
>


Welcome the new Maven committers: Maarten Mulders en Martin Kanters

2020-07-10 Thread Robert Scholte
Hi,

On behalf of the Apache Maven PMC I am pleased to announce that
Maarten Mulders en Martin Kanters has been voted in as new Apache Maven 
committers
and they've both accepted this invitation.

Welcome on board and have a lot of fun!

Thanks,
Robert Scholte


Re: custom default lifecycle per project

2020-07-10 Thread Romain Manni-Bucau
Looked a bit on how to impl this kind of extension and it would help if
maven wouldn't assume everything is hardcoded in components.xml (or eq) or
if sisu would enable to reuse its plexus scanner which has a very low
visibility today. It is also weird to not have access to the guice injector
in components and have to go through the plexuscontainer to lookup beans.

As code often says more than words, here a small hello world showing that
reusing this part of maven "core" is not that trivial:

@Component(role = AbstractMavenLifecycleParticipant.class)
public class CustomLifecycleExtension extends
AbstractMavenLifecycleParticipant {
@Inject
private PlexusContainer container;

@Override
public void afterProjectsRead(final MavenSession session) throws
MavenExecutionException {
final Path root =
session.getRequest().getMultiModuleProjectDirectory().toPath();
final Path configFolder = root.resolve(".extensions/custom");

final Path mappings = configFolder.resolve("mappings.xml");
if (Files.exists(mappings)) {
final ComponentSetDescriptor componentSet =
readAs(mappings, ComponentSetDescriptor.class, null);
System.out.println(componentSet);
}

super.afterProjectsRead(session);
}

private  T readAs(final Path path, final Class type, final
String wrapper) {
try {
final ClassRealm container = this.container.getContainerRealm();
final Class converterType = container
.loadClass("org.eclipse.sisu.plexus.PlexusBeanConverter");
final Class typeLiteralType = container
.loadClass("com.google.inject.TypeLiteral");
final Object converter = this.container.lookup(converterType);
return type.cast(converterType.getMethod("convert",
typeLiteralType, String.class).invoke(
converter,
typeLiteralType.getMethod("get",
Class.class).invoke(null, type),
(wrapper != null ? "<" + wrapper + ">" : "") +
new String(Files.readAllBytes(path),
StandardCharsets.UTF_8)
.replaceFirst("<\\?[^>]+\\?>", "").trim() +
(wrapper != null ? "" : "")));
} catch (final Exception e) {
throw new IllegalStateException(e);
}
}
}

Indeed it can't work since componentsetdescriptor uses plexusconfiguration
which is not instantiable but it shows the workarounds needed to just
lookup plexus converter and reuse plexus xml binding.

The code should just look like that IMHO:

@Component(role = AbstractMavenLifecycleParticipant.class)
public class CustomLifecycleExtension extends
AbstractMavenLifecycleParticipant {
@Inject
private PlexusBeanConverter converter;

@Override
public void afterProjectsRead(final MavenSession session) throws
MavenExecutionException {
final Path root =
session.getRequest().getMultiModuleProjectDirectory().toPath();
final Path configFolder = root.resolve(".extensions/custom");

final Path mappings = configFolder.resolve("mappings.xml");
if (Files.exists(mappings)) {
final ComponentSetDescriptor componentSet =
readAs(mappings, ComponentSetDescriptor.class, null);
System.out.println(componentSet);
}

super.afterProjectsRead(session);
}

private  T readAs(final Path path, final Class type, final
String wrapper) {
try {
return type.cast(
converter.convert(TypeLiteral.get(type),
(wrapper != null ? "<" + wrapper + ">" : "") +
new
String(Files.readAllBytes(path), StandardCharsets.UTF_8)

.replaceFirst("<\\?[^>]+\\?>", "").trim() +
(wrapper != null ? "" : "")));
} catch (final Exception e) {
throw new IllegalStateException(e);
}
}
}

Once this part is fixed (using a custom parser) the next one is how to
contribute global components from an extension.

I'll ignore the parsing - currently I have a custom sax parser but I hope
to be able to drop it soon - it is quite easy to contribute back the new
mapping - note i dropped the lifecycle particupant which does not really
help there cause only contributing mappings when the extension is created
makes sense:

@Component(role = StartupContributor.class, instantiationStrategy =
Strategies.LOAD_ON_START)
public class StartupContributor {
@Inject
private MavenSession session;

@Inject
private PlexusContainer container;

@PostConstruct
public void init() {
final Path root =
session.getRequest().getMultiModuleProjectDirectory().toPath();
final Path configFolder = root.resolve(".extensions/custom");

final Path mappings = configFolder.resolve("mappings.xml");
if (Files.exists(mappings)) {
final DefaultLifec

Re: Reproducible builds, jars, bundles

2020-07-10 Thread Romain Manni-Bucau
Hi Gary,

Maybe I misunderstood something but isn't it that felix bundle plugin does
not sort the maven resources ([1]?

[1]
https://github.com/apache/felix-dev/blob/7f4d31b384d9d83c772680a8627df18ff078eaa4/tools/maven-bundle-plugin/src/main/java/org/apache/felix/bundleplugin/BundlePlugin.java#L2036

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le ven. 10 juil. 2020 à 16:44, Gary Gregory  a
écrit :

> Hi All,
>
> Over at Apache Commons, we are looking at creating reproducible builds via:
>
> https://github.com/apache/commons-parent/pull/9
>
> As discussed in that thread, a bundle's "Include-Resource" manifest header
> has a value with file system elements in different orders depending on file
> system used to generate the jar, IOW, not bit by bit reproducible.
>
> Folks in that discussion and in another here
> https://github.com/apache/commons-lang/pull/578, suggested that the issue
> might reside in Maven relying on the file system order and not in
> maven-bundle-plugin or the bnd library as initially considered.
>
> May you please provide any guidance?
>
> Thank you,
> Gary
>


Reproducible builds, jars, bundles

2020-07-10 Thread Gary Gregory
Hi All,

Over at Apache Commons, we are looking at creating reproducible builds via:

https://github.com/apache/commons-parent/pull/9

As discussed in that thread, a bundle's "Include-Resource" manifest header
has a value with file system elements in different orders depending on file
system used to generate the jar, IOW, not bit by bit reproducible.

Folks in that discussion and in another here
https://github.com/apache/commons-lang/pull/578, suggested that the issue
might reside in Maven relying on the file system order and not in
maven-bundle-plugin or the bnd library as initially considered.

May you please provide any guidance?

Thank you,
Gary


Re: No git tags?

2020-07-10 Thread Gary Gregory
Thank you!
Gary

On Fri, Jul 10, 2020 at 10:02 AM Maarten Mulders  wrote:

> Hi Gary,
>
> That repository contains meta-information about all Apache Maven version
> control repositories. Its README.md tells you how to use it using Google
> repo [1].
>
> Alternatively, you can manually clone Apache Maven repositories.
> For Maven core, you would need [2]. Please be aware that a lot of Mavens
> functionality comes through plugins, so you may need to clone some of
> them as well. Each of them lives under the Apache umbrella [3] at Github.
>
> Hope this helps,
>
> Maarten
>
> [1] https://source.android.com/source/using-repo
> [2] https://github.com/apache/maven
> [3] https://github.com/apache
>
> On 10/07/2020 15:57, Gary Gregory wrote:
> > Hi All:
> >
> > I do not see git tags here https://github.com/apache/maven-sources/tags
> > Am I in the right repo?
> >
> > Thank you,
> > Gary
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


Re: No git tags?

2020-07-10 Thread Maarten Mulders
Hi Gary,

That repository contains meta-information about all Apache Maven version
control repositories. Its README.md tells you how to use it using Google
repo [1].

Alternatively, you can manually clone Apache Maven repositories.
For Maven core, you would need [2]. Please be aware that a lot of Mavens
functionality comes through plugins, so you may need to clone some of
them as well. Each of them lives under the Apache umbrella [3] at Github.

Hope this helps,

Maarten

[1] https://source.android.com/source/using-repo
[2] https://github.com/apache/maven
[3] https://github.com/apache

On 10/07/2020 15:57, Gary Gregory wrote:
> Hi All:
> 
> I do not see git tags here https://github.com/apache/maven-sources/tags
> Am I in the right repo?
> 
> Thank you,
> Gary
> 

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



No git tags?

2020-07-10 Thread Gary Gregory
Hi All:

I do not see git tags here https://github.com/apache/maven-sources/tags
Am I in the right repo?

Thank you,
Gary


Re: [VOTE] Release Apache Maven WAR Plugin version 3.3.1

2020-07-10 Thread Romain Manni-Bucau
+1

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le ven. 10 juil. 2020 à 14:58, Enrico Olivelli  a
écrit :

> +1 (non binding)
> Built and run ITS on Mac + JDK14
>
> Enrico
>
> Il giorno ven 10 lug 2020 alle ore 12:39  ha
> scritto:
>
> > Hi,
> >
> > We solved 4 issues:
> >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318121&version=12348374&styleName=Text
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1593/
> >
> >
> https://repository.apache.org/content/repositories/maven-1593/org/apache/maven/plugins/maven-war-plugin/3.3.1/maven-war-plugin-3.3.1-source-release.zip
> >
> > Source release checksum(s):
> > maven-war-plugin-3.3.1-source-release.zip sha512:
> >
> d59079cc8b8fbc48d624be97806db9f1f9a42945735e57197ee80197275208f591cfc0fe5ed6b0c0576c76ece85a4b5e0b94cf84ab3cf4b69fc278d6cbfecc32
> >
> >
> > Staging site:
> > https://maven.apache.org/plugins-archives/maven-war-plugin-LATEST/
> >
> > Guide to testing staged releases:
> > https://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for at least 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> >
> >
>


Re: [VOTE] Release Apache Maven WAR Plugin version 3.3.1

2020-07-10 Thread Enrico Olivelli
+1 (non binding)
Built and run ITS on Mac + JDK14

Enrico

Il giorno ven 10 lug 2020 alle ore 12:39  ha scritto:

> Hi,
>
> We solved 4 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318121&version=12348374&styleName=Text
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1593/
>
> https://repository.apache.org/content/repositories/maven-1593/org/apache/maven/plugins/maven-war-plugin/3.3.1/maven-war-plugin-3.3.1-source-release.zip
>
> Source release checksum(s):
> maven-war-plugin-3.3.1-source-release.zip sha512:
> d59079cc8b8fbc48d624be97806db9f1f9a42945735e57197ee80197275208f591cfc0fe5ed6b0c0576c76ece85a4b5e0b94cf84ab3cf4b69fc278d6cbfecc32
>
>
> Staging site:
> https://maven.apache.org/plugins-archives/maven-war-plugin-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


[VOTE] Release Apache Maven WAR Plugin version 3.3.1

2020-07-10 Thread herve . boutemy
Hi, 

We solved 4 issues: 
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318121&version=12348374&styleName=Text
 

Staging repo: 
https://repository.apache.org/content/repositories/maven-1593/ 
https://repository.apache.org/content/repositories/maven-1593/org/apache/maven/plugins/maven-war-plugin/3.3.1/maven-war-plugin-3.3.1-source-release.zip
 

Source release checksum(s): 
maven-war-plugin-3.3.1-source-release.zip sha512: 
d59079cc8b8fbc48d624be97806db9f1f9a42945735e57197ee80197275208f591cfc0fe5ed6b0c0576c76ece85a4b5e0b94cf84ab3cf4b69fc278d6cbfecc32
 

Staging site: 
https://maven.apache.org/plugins-archives/maven-war-plugin-LATEST/ 

Guide to testing staged releases: 
https://maven.apache.org/guides/development/guide-testing-releases.html 

Vote open for at least 72 hours. 

[ ] +1 
[ ] +0 
[ ] -1

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Second MRESOLVER-123

2020-07-10 Thread Michael Osipov

Folks,

MRESOLVER-123 [1] solves a very long standing issue in Resolver: Thread 
concurrency in a single JVM while downloading artifacts/metadata. It has 
been verified to work with several usecases provided by reporters. This 
approach has one drawback: Since it is a global lock it introduces 
somwhat of a lock contention. The slower your connection link the longer 
the lock is held. Ideally, folks use repo managers in private networks 
to solve this issue. Also, read/write reeentrancy seems to work fine 
based on the logs provided. At the end I prefer build stability over 
performance.


Please have a look and raise objects if you have any. If you don't hear 
any I will merge next week and start release process of Resolver 1.5.0.


A midterm goal would be to provide a group id based locking which should 
drastically reduce contention, but no promises here for an ETA. As for 
the multi JVM safety, Takari local repository failed to provide a 
working solution, project seems to be abandoned. I have considered to 
investigate a Redisson-based approach for this. Though, this solely 
depends on the community how necessary this really is.


Michael

[1] https://github.com/apache/maven-resolver/pull/65

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org