Re: Maven Code Style and imports layouts

[Benjamin Marwell]

+1!

 Sandra and I tried similar Suggestions a while back.
This will help new contributors a lot.

Thanks for your efforts!

On Mon, 18 Oct 2021, 07:10 Slawomir Jaranowski, 
wrote:

> Hi,
>
> In order to help make decisions, I prepared PR [1] with the most used order
> layout in Maven Core.
>
> Please look and vote / approve / choose another proposition.
>
> [1] https://github.com/apache/maven-site/pull/269
>
>
> czw., 23 wrz 2021 o 23:47 Slawomir Jaranowski 
> napisał(a):
>
> > Hi
> >
> > I checked the maven core project to see how many files don't meet the
> > proposed layout.
> >
> > All imports in each group are alphabetically sorted.
> >
> >
> > 1,
> > - import javax.*
> > - import java.*
> > - blank line
> > - all other imports
> > - blank line
> > - import static all other imports
> >
> > -> 285 files to change
> >
> > 2.
> > - static imports
> > - blank line
> > - all other imports alphabetically
> >
> > -> 673 files to change
> >
> > 3.
> > - import javax.*
> > - blank line
> > - import java.*
> > - blank line
> > - all other imports
> > - blank line
> > - import static all other imports
> >
> > -> 196 files to change
> >
> > 3.
> > - import static all other imports
> > - blank line
> > - import javax.*
> > - blank line
> > - import java.*
> > - blank line
> > - all other imports
> >
> > -> 302 files to change
> >
> >
> > So option 3 seems the most popular in maven , but it is easy to change
> for
> > all files, or only looks in changed files.
> > In the first step, preparing documentation is most important - may be
> > enough.
> >
> > I've created issue for it [1]
> >
> > Please vote for a proposition or give another one.
> >
> >
> > [1] https://issues.apache.org/jira/browse/MNGSITE-465
> >
> >
> >
> > sob., 18 wrz 2021 o 20:38 Elliotte Rusty Harold 
> > napisał(a):
> >
> >> simpler is better, though perhaps the fundamental rule should be don't
> >> reporter what's already there. That is, avoid needless churn.
> >>
> >> My preferred style is:
> >>
> >> static imports
> >> blank line
> >> all other imports alphabetically
> >>
> >>
> >> On Fri, Sep 17, 2021 at 9:19 PM Slawomir Jaranowski
> >>  wrote:
> >> >
> >> > Hi,
> >> >
> >> > We have described many rules about code style on Maven Code Style And
> >> Code
> >> > Conventions [1].
> >> >
> >> > One item missing for me is how java imports should be ordered and
> >> groped.
> >> > I can setup it in IDE and it is very useful to use code formatting
> with
> >> > tools.
> >> > I think that all propositions in this case will be ok - the most
> >> important
> >> > is to have one standard.
> >> > At the end we can even use checkstyle to verify it ... [2]
> >> >
> >> > So first proposition:
> >> >
> >> > - import javax.*
> >> > - import java.*
> >> >
> >> > - blank line
> >> >
> >> > - all other imports
> >> >
> >> > - blank line
> >> >
> >> > - import static all other imports
> >> >
> >> >
> >> > [1] https://maven.apache.org/developers/conventions/code.html
> >> > [2] https://checkstyle.sourceforge.io/config_imports.html#ImportOrder
> >> >
> >> > --
> >> > Sławomir Jaranowski
> >> >
> >> > https://twitter.com/SlawekJaran
> >> > https://github.com/slawekjaranowski
> >> > https://linkedin.com/in/slawomirjaranowski
> >>
> >>
> >>
> >> --
> >> Elliotte Rusty Harold
> >> elh...@ibiblio.org
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> >> For additional commands, e-mail: dev-h...@maven.apache.org
> >>
> >>
> >
> > --
> > Sławomir Jaranowski
> >
>
>
> --
> Sławomir Jaranowski
>

[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on pull request #4: Exclude os,jdk,distributions used in ff from matrix build

[GitBox]

slawekjaranowski commented on pull request #4:
URL: 
https://github.com/apache/maven-gh-actions-shared/pull/4#issuecomment-945373669


   my vote for #7 - In this case we release additional node asap


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] slawekjaranowski commented on pull request #269: [MNGSITE-465] Java Code Convention - import layouts

[GitBox]

slawekjaranowski commented on pull request #269:
URL: https://github.com/apache/maven-site/pull/269#issuecomment-945371761


   @elharo - you are right ... I send post with reminder to dev list .. 
   I waiting long time so to help with decision I prepare this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Maven Code Style and imports layouts

[Slawomir Jaranowski]

Hi,

In order to help make decisions, I prepared PR [1] with the most used order
layout in Maven Core.

Please look and vote / approve / choose another proposition.

[1] https://github.com/apache/maven-site/pull/269


czw., 23 wrz 2021 o 23:47 Slawomir Jaranowski 
napisał(a):

> Hi
>
> I checked the maven core project to see how many files don't meet the
> proposed layout.
>
> All imports in each group are alphabetically sorted.
>
>
> 1,
> - import javax.*
> - import java.*
> - blank line
> - all other imports
> - blank line
> - import static all other imports
>
> -> 285 files to change
>
> 2.
> - static imports
> - blank line
> - all other imports alphabetically
>
> -> 673 files to change
>
> 3.
> - import javax.*
> - blank line
> - import java.*
> - blank line
> - all other imports
> - blank line
> - import static all other imports
>
> -> 196 files to change
>
> 3.
> - import static all other imports
> - blank line
> - import javax.*
> - blank line
> - import java.*
> - blank line
> - all other imports
>
> -> 302 files to change
>
>
> So option 3 seems the most popular in maven , but it is easy to change for
> all files, or only looks in changed files.
> In the first step, preparing documentation is most important - may be
> enough.
>
> I've created issue for it [1]
>
> Please vote for a proposition or give another one.
>
>
> [1] https://issues.apache.org/jira/browse/MNGSITE-465
>
>
>
> sob., 18 wrz 2021 o 20:38 Elliotte Rusty Harold 
> napisał(a):
>
>> simpler is better, though perhaps the fundamental rule should be don't
>> reporter what's already there. That is, avoid needless churn.
>>
>> My preferred style is:
>>
>> static imports
>> blank line
>> all other imports alphabetically
>>
>>
>> On Fri, Sep 17, 2021 at 9:19 PM Slawomir Jaranowski
>>  wrote:
>> >
>> > Hi,
>> >
>> > We have described many rules about code style on Maven Code Style And
>> Code
>> > Conventions [1].
>> >
>> > One item missing for me is how java imports should be ordered and
>> groped.
>> > I can setup it in IDE and it is very useful to use code formatting with
>> > tools.
>> > I think that all propositions in this case will be ok - the most
>> important
>> > is to have one standard.
>> > At the end we can even use checkstyle to verify it ... [2]
>> >
>> > So first proposition:
>> >
>> > - import javax.*
>> > - import java.*
>> >
>> > - blank line
>> >
>> > - all other imports
>> >
>> > - blank line
>> >
>> > - import static all other imports
>> >
>> >
>> > [1] https://maven.apache.org/developers/conventions/code.html
>> > [2] https://checkstyle.sourceforge.io/config_imports.html#ImportOrder
>> >
>> > --
>> > Sławomir Jaranowski
>> >
>> > https://twitter.com/SlawekJaran
>> > https://github.com/slawekjaranowski
>> > https://linkedin.com/in/slawomirjaranowski
>>
>>
>>
>> --
>> Elliotte Rusty Harold
>> elh...@ibiblio.org
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>> For additional commands, e-mail: dev-h...@maven.apache.org
>>
>>
>
> --
> Sławomir Jaranowski
>


-- 
Sławomir Jaranowski

[GitHub] [maven-gh-actions-shared] olamy commented on pull request #4: Exclude os,jdk,distributions used in ff from matrix build

[GitBox]

olamy commented on pull request #4:
URL: 
https://github.com/apache/maven-gh-actions-shared/pull/4#issuecomment-945317807


   I will be happy with #7 or #8 :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] slawekjaranowski opened a new pull request #269: [MNGSITE-465] Java Code Convention - import layouts

[GitBox]

slawekjaranowski opened a new pull request #269:
URL: https://github.com/apache/maven-site/pull/269


   It is the most used layout in Maven core project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] slawekjaranowski opened a new pull request #268: IntelliJ IDEA - code style for Groovy

[GitBox]

slawekjaranowski opened a new pull request #268:
URL: https://github.com/apache/maven-site/pull/268


   Based on Java style - Useful eg for preparing scripts for 
maven-invoker-plugin 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on pull request #4: Exclude os,jdk,distributions used in ff from matrix build

[GitBox]

slawekjaranowski commented on pull request #4:
URL: 
https://github.com/apache/maven-gh-actions-shared/pull/4#issuecomment-945159754


   I prepared three propositions - maybe a one will be ok #6, #7, #8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-gh-actions-shared] slawekjaranowski opened a new pull request #8: Simplify fail fast configuration - 3

[GitBox]

slawekjaranowski opened a new pull request #8:
URL: https://github.com/apache/maven-gh-actions-shared/pull/8


   ## it is draft - please don't merge - we have 3 propositions to choose
   
   - add fail-fast input parameters
   - no condition on job in matrix, the same job - fatst-build  and in matrix 
will be run, we will have the same job run twice sometime it can be long job 
especially for a plugin with plenty of its


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-gh-actions-shared] slawekjaranowski opened a new pull request #7: Simplify fail fast configuration - 2

[GitBox]

slawekjaranowski opened a new pull request #7:
URL: https://github.com/apache/maven-gh-actions-shared/pull/7


   ## it is draft - please don't merge - we have 3 propositions to choose
   
   - add fail-fast input parameters
   - use conditions on steps to exclude job from matrix, (on job level matrix 
context is not available) ... runner will be reserved but for a short time 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-gh-actions-shared] slawekjaranowski opened a new pull request #6: Simplify fail fast configuration - 1

[GitBox]

slawekjaranowski opened a new pull request #6:
URL: https://github.com/apache/maven-gh-actions-shared/pull/6


   ## it is draft - please don't merge - we have 3 propositions to choose
   
   - only add fail-fast input parameters
   - excludes for matrix are still generated in setup job


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Follow up of MNG-6354 (cdi-api)

[Romain Manni-Bucau]

Le dim. 17 oct. 2021 à 13:36, Tamás Cservenák  a
écrit :

> Agreee, maven stuff should use sisu @Typed annotation as core does.
>
> T
>
> On Sun, Oct 17, 2021, 12:41 Michael Osipov  wrote:
>
> > Am 2021-10-12 um 08:11 schrieb Romain Manni-Bucau:
> > > Hi all,
> > >
> > > Michael wonders if we drop cdi-api from maven 3.8.x in
> > > https://issues.apache.org/jira/browse/MNG-6354.
> > > The topic is worth it since it creates several issues and some quite
> > hidden
> > > by mojo.
> > > The only expected impact is to not provide @Typed anymore and have to
> > > replace it by an alternative. If not done the plugin will run but an
> > > injection can become ambiguous but not sure how much real case we can
> get
> > > out there - none in maven itself but maybe in a few mojo.
> > >
> > > So questio is: do we backport it or not with this very low risk or not.
> > >
> > > I'm +0.99 to do it due to the risk but the quite common benefit.
> >
> > As far as I understand the Sisu/Guice version of @Typed must be used
> > right? I think we can make this one for 4.0.0. For 3.8.x, am not sure,
> > for 3.9.0 very likely. The most important thing is to document this in
> > the release notes what people need to do.
> >
> > Questions:
> > * Is the fix in Maven trivial?
>

Yes, same as for v4.

> * Is the fix in components and plugins trivial and backwards compatible?
>

Trivial yes, backward compat no until we do more and complicated stuff (for
a few usage).
This is why for 3.8 it is not obvious if we include it IMHO.
Think delaying for 3.9 can be a wise proposal so I join you on this one.


>
> > M
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> >
> >
>

Re: Follow up of MNG-6354 (cdi-api)

[Tamás Cservenák]

Agreee, maven stuff should use sisu @Typed annotation as core does.

T

On Sun, Oct 17, 2021, 12:41 Michael Osipov  wrote:

> Am 2021-10-12 um 08:11 schrieb Romain Manni-Bucau:
> > Hi all,
> >
> > Michael wonders if we drop cdi-api from maven 3.8.x in
> > https://issues.apache.org/jira/browse/MNG-6354.
> > The topic is worth it since it creates several issues and some quite
> hidden
> > by mojo.
> > The only expected impact is to not provide @Typed anymore and have to
> > replace it by an alternative. If not done the plugin will run but an
> > injection can become ambiguous but not sure how much real case we can get
> > out there - none in maven itself but maybe in a few mojo.
> >
> > So questio is: do we backport it or not with this very low risk or not.
> >
> > I'm +0.99 to do it due to the risk but the quite common benefit.
>
> As far as I understand the Sisu/Guice version of @Typed must be used
> right? I think we can make this one for 4.0.0. For 3.8.x, am not sure,
> for 3.9.0 very likely. The most important thing is to document this in
> the release notes what people need to do.
>
> Questions:
> * Is the fix in Maven trivial?
> * Is the fix in components and plugins trivial and backwards compatible?
>
> M
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

Re: Follow up of MNG-6354 (cdi-api)

[Michael Osipov]

Am 2021-10-12 um 08:11 schrieb Romain Manni-Bucau:

Hi all,

Michael wonders if we drop cdi-api from maven 3.8.x in
https://issues.apache.org/jira/browse/MNG-6354.
The topic is worth it since it creates several issues and some quite hidden
by mojo.
The only expected impact is to not provide @Typed anymore and have to
replace it by an alternative. If not done the plugin will run but an
injection can become ambiguous but not sure how much real case we can get
out there - none in maven itself but maybe in a few mojo.

So questio is: do we backport it or not with this very low risk or not.

I'm +0.99 to do it due to the risk but the quite common benefit.


As far as I understand the Sisu/Guice version of @Typed must be used 
right? I think we can make this one for 4.0.0. For 3.8.x, am not sure, 
for 3.9.0 very likely. The most important thing is to document this in 
the release notes what people need to do.


Questions:
* Is the fix in Maven trivial?
* Is the fix in components and plugins trivial and backwards compatible?

M

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-gh-actions-shared] olamy commented on pull request #4: Exclude os,jdk,distributions used in ff from matrix build

[GitBox]

olamy commented on pull request #4:
URL: 
https://github.com/apache/maven-gh-actions-shared/pull/4#issuecomment-945082627


   even with using `fail-fast: true` gh will schedule the use of some nodes and 
reduce the number available for the org `apache`.
   if this happen for long build such a plugin with plenty of its it will still 
takes time and use a lot of nodes for nothing.
   just use some input args with default values (jdk8, ubuntu) for running the 
`fail-fast-build` and voila do not think too much complicated ;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] slawekjaranowski commented on pull request #267: [MPLUGIN-375] Unsupported Mojo descriptor items

[GitBox]

slawekjaranowski commented on pull request #267:
URL: https://github.com/apache/maven-site/pull/267#issuecomment-945081187


   Continue for https://github.com/apache/maven-plugin-tools/pull/43


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Another take on [MRESOLVER-7] Download dependency POMs in parallel

[Michael Osipov]

Hi Ivan,

Am 2021-10-16 um 17:21 schrieb Ivan Babiankou:

I would love to prepare decent PR

for the MRESOLVER-7 issue, so that it makes it to one of the upcoming
releases. But I could definitely use some guidance, given the history of
the ticket

and the fact that it’s my first contribution to Maven and OSS in general.
Is there anyone willing to point me in the right direction (in email or a
quick 15-30min call)?  I would really appreciate it.

For now I’m reading the general things about contributing to Maven and
looking at the old branch that was merged and then reverted.


There is absolutely nothing special in providing a PR:

* Add a comment in the ticket about your intentions
* Fork repo
* Create branch based on the ticket name
* Do your magic
* Create PR

The above issue is sensible because many have tried and failed.


I see the master branch of Maven Resolver corresponds to v1.7.x, which
requires Maven 4, however I would love to target the current Maven 3.x.
Where should I start my PR off master or  maven-resolver-1.6.x?


Please go back a few weeks in history on the dev list. There is a 
discussion about Maven 3.9.0 with Resolver 1.7+. I have no intentions to 
introduce any more changes, but fixes to Resolver 1.6.x. If you are able 
to provide a proper fix for MRESOLVER-7 I'd even cut Resolver 1.8.0 for 
this.


Michael


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on pull request #4: Exclude os,jdk,distributions used in ff from matrix build

[GitBox]

slawekjaranowski commented on pull request #4:
URL: 
https://github.com/apache/maven-gh-actions-shared/pull/4#issuecomment-945063486


   A other way is not introduce special build `"fast-fail"` but let matrix to 
run everything 
   ... in this case we have `fail-fast: true` on matrix so GH will break / 
don't run next job from matrix
   
   I think it will be the clear and simple.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org