[GitHub] slachiewicz opened a new pull request #5: [DOXIA-534] Migrate logging to Sl4j

[GitBox]

slachiewicz opened a new pull request #5: [DOXIA-534] Migrate logging to Sl4j
URL: https://github.com/apache/maven-doxia/pull/5
 
 
   Please check. 
   
   Current build fails with cirr error - due to interfaces change.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] michael-o commented on a change in pull request #5: [DOXIA-534] Migrate logging to Sl4j

[GitBox]

michael-o commented on a change in pull request #5: [DOXIA-534] Migrate logging 
to Sl4j
URL: https://github.com/apache/maven-doxia/pull/5#discussion_r153050104
 
 

 ##
 File path: doxia-modules/doxia-module-fo/pom.xml
 ##
 @@ -78,7 +72,7 @@ under the License.
 
   commons-collections
   commons-collections
-  3.2.1
+  3.2.2
 
 Review comment:
   This should be a seperate issue if not necesary for this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] michael-o commented on a change in pull request #5: [DOXIA-534] Migrate logging to Sl4j

[GitBox]

michael-o commented on a change in pull request #5: [DOXIA-534] Migrate logging 
to Sl4j
URL: https://github.com/apache/maven-doxia/pull/5#discussion_r153050140
 
 

 ##
 File path: pom.xml
 ##
 @@ -185,15 +180,33 @@ under the License.
   
 org.codehaus.plexus
 plexus-utils
-3.0.24
+3.1.0
+  
+
+  
+org.slf4j
+slf4j-api
+${sl4j.version}
+  
+  
+org.slf4j
+slf4j-simple
+${sl4j.version}
+test
+  
+  
+org.slf4j
+log4j-over-slf4j
+${sl4j.version}
+test
   
 
   
   
 
   junit
   junit
-  4.11
+  4.12
 
 Review comment:
   Same as commons-collections


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] michael-o commented on a change in pull request #5: [DOXIA-534] Migrate logging to Sl4j

[GitBox]

michael-o commented on a change in pull request #5: [DOXIA-534] Migrate logging 
to Sl4j
URL: https://github.com/apache/maven-doxia/pull/5#discussion_r153050158
 
 

 ##
 File path: 
doxia-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoAggregateSink.java
 ##
 @@ -1322,12 +1322,12 @@ private SinkEventAttributeSet getGraphicsAttributes( 
String logo )
 }
 catch ( IOException e )
 {
-getLog().debug( e );
+getLog().debug( e.getMessage() );
 
 Review comment:
   Leave it as `e`, SFL4J and backends will do the rest for us.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] michael-o commented on issue #5: [DOXIA-534] Migrate logging to Sl4j

[GitBox]

michael-o commented on issue #5: [DOXIA-534] Migrate logging to Sl4j
URL: https://github.com/apache/maven-doxia/pull/5#issuecomment-346953287
 
 
   @hboutemy Looks good to me. Tests pending...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] hboutemy commented on issue #5: [DOXIA-534] Migrate logging to Sl4j

[GitBox]

hboutemy commented on issue #5: [DOXIA-534] Migrate logging to Sl4j
URL: https://github.com/apache/maven-doxia/pull/5#issuecomment-346954321
 
 
   I'm not in favor of removing doxia-logging: deprecating and modifying it to 
use slf4j would be more compatible
   I know there are not so much Doxia extensions in the wild: there is at least 
asciidoc I know of. I didn't check, but would be useful to not break this one 
at least


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] michael-o commented on issue #5: [DOXIA-534] Migrate logging to Sl4j

[GitBox]

michael-o commented on issue #5: [DOXIA-534] Migrate logging to Sl4j
URL: https://github.com/apache/maven-doxia/pull/5#issuecomment-346955331
 
 
   Why not deprecate in 1.8 and remove with 2.0?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] hboutemy commented on issue #5: [DOXIA-534] Migrate logging to Sl4j

[GitBox]

hboutemy commented on issue #5: [DOXIA-534] Migrate logging to Sl4j
URL: https://github.com/apache/maven-doxia/pull/5#issuecomment-346957484
 
 
   +1


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] michael-o commented on issue #5: [DOXIA-534] Migrate logging to Sl4j

[GitBox]

michael-o commented on issue #5: [DOXIA-534] Migrate logging to Sl4j
URL: https://github.com/apache/maven-doxia/pull/5#issuecomment-346960574
 
 
   @slachiewicz Can you spawn another ticket and create a new PR? We will leave 
this one open.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] slachiewicz commented on a change in pull request #5: [DOXIA-534] Migrate logging to Sl4j

[GitBox]

slachiewicz commented on a change in pull request #5: [DOXIA-534] Migrate 
logging to Sl4j
URL: https://github.com/apache/maven-doxia/pull/5#discussion_r153053853
 
 

 ##
 File path: pom.xml
 ##
 @@ -185,15 +180,33 @@ under the License.
   
 org.codehaus.plexus
 plexus-utils
-3.0.24
+3.1.0
+  
+
+  
+org.slf4j
+slf4j-api
+${sl4j.version}
+  
+  
+org.slf4j
+slf4j-simple
+${sl4j.version}
+test
+  
+  
+org.slf4j
+log4j-over-slf4j
+${sl4j.version}
+test
   
 
   
   
 
   junit
   junit
-  4.11
+  4.12
 
 Review comment:
   ok, will be diffret pull - only with dependences


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] slachiewicz commented on a change in pull request #5: [DOXIA-534] Migrate logging to Sl4j

[GitBox]

slachiewicz commented on a change in pull request #5: [DOXIA-534] Migrate 
logging to Sl4j
URL: https://github.com/apache/maven-doxia/pull/5#discussion_r153053842
 
 

 ##
 File path: 
doxia-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoAggregateSink.java
 ##
 @@ -1322,12 +1322,12 @@ private SinkEventAttributeSet getGraphicsAttributes( 
String logo )
 }
 catch ( IOException e )
 {
-getLog().debug( e );
+getLog().debug( e.getMessage() );
 
 Review comment:
   there is no constructor with Exception, i will change to e.getMessage(), e


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] slachiewicz opened a new pull request #6: [DOXIA-535] Upgrade dependences and plugin versions

[GitBox]

slachiewicz opened a new pull request #6: [DOXIA-535] Upgrade dependences and 
plugin versions
URL: https://github.com/apache/maven-doxia/pull/6
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] hboutemy commented on issue #6: [DOXIA-566] Upgrade dependences and plugin versions

[GitBox]

hboutemy commented on issue #6: [DOXIA-566] Upgrade dependences and plugin 
versions
URL: https://github.com/apache/maven-doxia/pull/6#issuecomment-347043431
 
 
   please don't update plugins: this will happen with parent pom. AFAIK, no 
hurry.
   
   upgrade of dependencies is what I'd like to merge only: can you update the 
PR, please?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] bhav0904 opened a new pull request #2: [JXR-100] Fix cross reference generation where there are spaces befor..

[GitBox]

bhav0904 opened a new pull request #2: [JXR-100] Fix cross reference generation 
where there are spaces befor..
URL: https://github.com/apache/maven-jxr/pull/2
 
 
   ?e or after parantheses.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] rfscholte commented on a change in pull request #2: [JXR-100] Fix cross reference generation where there are spaces befor..

[GitBox]

rfscholte commented on a change in pull request #2: [JXR-100] Fix cross 
reference generation where there are spaces befor..
URL: https://github.com/apache/maven-jxr/pull/2#discussion_r153211196
 
 

 ##
 File path: maven-jxr/src/main/java/org/apache/maven/jxr/JavaCodeTransform.java
 ##
 @@ -676,25 +676,6 @@ public final String xrLine( String line, String 
packageName, ClassType classType
 return buff.toString();
 }
 
-/**
- * Highlight the package in this line.
- *
- * @param line input line
- * @param packageName package name
- * @return input line with linked package
- */
-public final String xrLine( String line, String packageName )
 
 Review comment:
   I don't think the removal of this method is part of the issue


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] bhav0904 commented on issue #2: [JXR-100] Fix cross reference generation where there are spaces befor..

[GitBox]

bhav0904 commented on issue #2: [JXR-100] Fix cross reference generation where 
there are spaces befor..
URL: https://github.com/apache/maven-jxr/pull/2#issuecomment-347204846
 
 
   It?s not, it was an unused method that I found and wanted to clean up.
   
   On Mon, 27 Nov 2017 at 9:31 AM, Robert Scholte 
   wrote:
   
   > *@rfscholte* commented on this pull request.
   > --
   >
   > In maven-jxr/src/main/java/org/apache/maven/jxr/JavaCodeTransform.java
   > :
   >
   > > @@ -676,25 +676,6 @@ public final String xrLine( String line, String 
packageName, ClassType classType
   >  return buff.toString();
   >  }
   >
   > -/**
   > - * Highlight the package in this line.
   > - *
   > - * @param line input line
   > - * @param packageName package name
   > - * @return input line with linked package
   > - */
   > -public final String xrLine( String line, String packageName )
   >
   > I don't think the removal of this method is part of the issue
   >
   > ?
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > ,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] slachiewicz commented on issue #6: [DOXIA-566] Upgrade dependences and plugin versions

[GitBox]

slachiewicz commented on issue #6: [DOXIA-566] Upgrade dependences and plugin 
versions
URL: https://github.com/apache/maven-doxia/pull/6#issuecomment-348937905
 
 
   ok, plugin updates removed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] hboutemy commented on issue #6: [DOXIA-566] Upgrade dependences and plugin versions

[GitBox]

hboutemy commented on issue #6: [DOXIA-566] Upgrade dependences and plugin 
versions
URL: https://github.com/apache/maven-doxia/pull/6#issuecomment-349487617
 
 
   PR merged
   thank you


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] hboutemy closed pull request #6: [DOXIA-566] Upgrade dependences and plugin versions

[GitBox]

hboutemy closed pull request #6: [DOXIA-566] Upgrade dependences and plugin 
versions
URL: https://github.com/apache/maven-doxia/pull/6
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/doxia-core/pom.xml b/doxia-core/pom.xml
index 7b3ce1fc..371e56af 100644
--- a/doxia-core/pom.xml
+++ b/doxia-core/pom.xml
@@ -72,9 +72,14 @@ under the License.
 
 
 
-  xmlunit
-  xmlunit
-  1.5
+  org.xmlunit
+  xmlunit-core
+  test
+
+
+  org.xmlunit
+  xmlunit-matchers
+  test
 
 
   
diff --git 
a/doxia-core/src/test/java/org/apache/maven/doxia/AbstractModuleTest.java 
b/doxia-core/src/test/java/org/apache/maven/doxia/AbstractModuleTest.java
index 997d3b42..b583a630 100644
--- a/doxia-core/src/test/java/org/apache/maven/doxia/AbstractModuleTest.java
+++ b/doxia-core/src/test/java/org/apache/maven/doxia/AbstractModuleTest.java
@@ -102,6 +102,14 @@ protected Writer getXmlTestWriter( String baseName )
 return getXmlTestWriter( baseName, outputExtension() );
 }
 
+protected static String normalizeLineEnds(String s) {
+if ( s != null) {
+return s.replaceAll("\r\n", "\n" )
+.replaceAll("\r", "\n");
+} else {
+return null;
+}
+}
 /**
  * Returns an XML FileWriter to write to a file with the given name
  * in the test target output directory.
diff --git 
a/doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/AbstractSinkTest.java
 
b/doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/AbstractSinkTest.java
index 4a5baca3..4fb1d7fd 100644
--- 
a/doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/AbstractSinkTest.java
+++ 
b/doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/AbstractSinkTest.java
@@ -27,11 +27,11 @@
 import org.apache.maven.doxia.logging.PlexusLoggerWrapper;
 import org.apache.maven.doxia.sink.Sink;
 import org.apache.maven.doxia.sink.SinkEventAttributes;
-import org.apache.maven.doxia.sink.impl.SinkEventAttributeSet;
 import org.codehaus.plexus.DefaultPlexusContainer;
 import org.codehaus.plexus.util.IOUtil;
-import org.custommonkey.xmlunit.Diff;
-import org.custommonkey.xmlunit.XMLUnit;
+import org.xmlunit.matchers.CompareMatcher;
+
+import static org.junit.Assert.assertThat;
 
 /**
  * Abstract base class to test sinks.
@@ -207,8 +207,8 @@ public void testHead()
 sink.flush();
 sink.close();
 
-String actual = testWriter.toString();
-String expected = getHeadBlock();
+String actual = normalizeLineEnds( testWriter.toString() );
+String expected = normalizeLineEnds( getHeadBlock() );
 
 assertEquals( "Wrong head!", expected, actual );
 }
@@ -470,12 +470,11 @@ public void testFigure() throws Exception
 
 if ( isXmlSink() )
 {
-Diff diff = XMLUnit.compareXML( wrapXml( expected ), wrapXml( 
actual ) );
-assertTrue( "Wrong figure!", diff.identical() );
+assertThat ( wrapXml( actual ), CompareMatcher.isIdenticalTo( 
wrapXml( expected ) ));
 }
 else
 {
-assertEquals( "Wrong figure!", expected, actual );
+assertEquals( actual, expected );
 }
 }
 
@@ -494,12 +493,11 @@ public void testFigureWithoutCaption() throws Exception
 
 if ( isXmlSink() )
 {
-Diff diff = XMLUnit.compareXML( wrapXml( expected ), wrapXml( 
actual ) );
-assertTrue( "Wrong figure!", diff.identical() );
+assertThat ( wrapXml( actual ), CompareMatcher.isIdenticalTo( 
wrapXml( expected ) ));
 }
 else
 {
-assertEquals( "Wrong figure!", expected, actual );
+assertEquals( actual, expected );
 }
 }
 
@@ -536,12 +534,11 @@ public void testTable() throws Exception
 
 if ( isXmlSink() )
 {
-Diff diff = XMLUnit.compareXML( wrapXml( expected ), wrapXml( 
actual ) );
-assertTrue( "Wrong table!", diff.identical() );
+assertThat ( wrapXml( actual ), CompareMatcher.isIdenticalTo( 
wrapXml( expected ) ));
 }
 else
 {
-assertEquals( "Wrong table!", expected, actual );
+assertEquals( actual, expected );
 }
 }
 
diff --git a/doxia-modules/doxia-module-apt/pom.xml 
b/doxia-modules/doxia-module-apt/pom.xml
index c3e5a049..4e9308df 100644
--- a/doxia-modules/doxia-module-apt/pom.xml
+++ b/doxia-modules/doxia-module-apt/pom.xml
@@ -46,5 +46,15 @@ under the License.
   org.codehaus.plexus
   plexus-utils
 
+
+  org.xmlunit
+  xmlunit-core
+  test
+
+
+  org.xmlunit
+  xmlunit-matchers
+  test
+
   
 
\ No newline at end of

[GitHub] don-vip opened a new pull request #9: upgrade to ASM 6.0 (final)

[GitBox]

don-vip opened a new pull request #9: upgrade to ASM 6.0 (final)
URL: https://github.com/apache/maven-plugin-tools/pull/9
 
 
   The ALPHA dependency causes problems to projects using Enforcer rules, see 
https://github.com/jenkinsci/jacoco-plugin/pull/92#issuecomment-349457441


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] hazendaz commented on a change in pull request #5: [DOXIA-534] Migrate logging to Sl4j

[GitBox]

hazendaz commented on a change in pull request #5: [DOXIA-534] Migrate logging 
to Sl4j
URL: https://github.com/apache/maven-doxia/pull/5#discussion_r159147868
 
 

 ##
 File path: 
doxia-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoAggregateSink.java
 ##
 @@ -1322,12 +1322,12 @@ private SinkEventAttributeSet getGraphicsAttributes( 
String logo )
 }
 catch ( IOException e )
 {
-getLog().debug( e );
+getLog().debug( e.getMessage() );
 
 Review comment:
   @slachiewicz @michael-o Proper code here would be ```getLog().debug("", 
e)```.  That assumes you want the full stack trace and not just the message.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] slachiewicz opened a new pull request #7: [DOXIA-409] Upgrade to FOP 2.2

[GitBox]

slachiewicz opened a new pull request #7: [DOXIA-409] Upgrade to FOP 2.2
URL: https://github.com/apache/maven-doxia/pull/7
 
 
   Fix by: Michael Simacek http://pkgs.fedoraproject.org/cgit/rpms/maven-doxia.git/tree/0004-Port-to-fop-2.0.patch


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] hboutemy commented on issue #7: [DOXIA-409] Upgrade to FOP 2.2

[GitBox]

hboutemy commented on issue #7: [DOXIA-409] Upgrade to FOP 2.2
URL: https://github.com/apache/maven-doxia/pull/7#issuecomment-357500503
 
 
   interesting: did you try the result of this change with maven-pdf-plugin or 
other tools/plugins that produce pdf using FO?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] slachiewicz commented on issue #7: [DOXIA-409] Upgrade to FOP 2.2

[GitBox]

slachiewicz commented on issue #7: [DOXIA-409] Upgrade to FOP 2.2
URL: https://github.com/apache/maven-doxia/pull/7#issuecomment-363521508
 
 
   Yes, i run tests inside doxia (some minor warnings) and today also tests 
with maven-pdf-plugin and all looks good.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] hboutemy closed pull request #7: [DOXIA-409] Upgrade to FOP 2.2

[GitBox]

hboutemy closed pull request #7: [DOXIA-409] Upgrade to FOP 2.2
URL: https://github.com/apache/maven-doxia/pull/7
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/doxia-modules/doxia-module-fo/pom.xml 
b/doxia-modules/doxia-module-fo/pom.xml
index 74e3bb2d..428753ac 100644
--- a/doxia-modules/doxia-module-fo/pom.xml
+++ b/doxia-modules/doxia-module-fo/pom.xml
@@ -85,7 +85,7 @@ under the License.
 
   org.apache.xmlgraphics
   fop
-  0.95
+  2.2
 
 
   log4j
diff --git 
a/doxia-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoUtils.java
 
b/doxia-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoUtils.java
index a1e3efae..41a76c18 100644
--- 
a/doxia-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoUtils.java
+++ 
b/doxia-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoUtils.java
@@ -24,6 +24,7 @@
 import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.OutputStream;
+import java.net.URI;
 import java.util.Date;
 
 import javax.xml.transform.Result;
@@ -38,6 +39,7 @@
 import org.apache.fop.apps.FOUserAgent;
 import org.apache.fop.apps.Fop;
 import org.apache.fop.apps.FopFactory;
+import org.apache.fop.apps.FopFactoryBuilder;
 import org.apache.fop.apps.MimeConstants;
 import org.apache.maven.doxia.document.DocumentModel;
 import org.codehaus.plexus.util.IOUtil;
@@ -52,28 +54,11 @@
  */
 public class FoUtils
 {
-/** To reuse the FopFactory **/
-private static final FopFactory FOP_FACTORY = FopFactory.newInstance();
-
 /** To reuse the TransformerFactory **/
 private static final TransformerFactory TRANSFORMER_FACTORY = 
TransformerFactory.newInstance();
 
-/**
- * Converts an FO file to a PDF file using FOP.
- *
- * @param fo the FO file, not null.
- * @param pdf the target PDF file, not null.
- * @param resourceDir The base directory for relative path resolution, 
could be null.
- * If null, defaults to the parent directory of fo.
- * @param documentModel the document model to add PDF metadatas like 
author, title and keywords, could be null.
- * @throws javax.xml.transform.TransformerException In case of a 
conversion problem.
- * @since 1.1.1
- */
-public static void convertFO2PDF( File fo, File pdf, String resourceDir, 
DocumentModel documentModel )
-throws TransformerException
-{
-FOUserAgent foUserAgent = getDefaultUserAgent( fo, resourceDir );
 
+private static void prepareUserAgent( FOUserAgent foUserAgent, 
DocumentModel documentModel ) {
 if ( documentModel != null && documentModel.getMeta() != null )
 {
 // http://xmlgraphics.apache.org/fop/embedding.html#user-agent
@@ -113,8 +98,6 @@ public static void convertFO2PDF( File fo, File pdf, String 
resourceDir, Documen
 {
 foUserAgent.setCreationDate( new Date() );
 }
-
-convertFO2PDF( fo, pdf, resourceDir, foUserAgent );
 }
 
 /**
@@ -124,16 +107,13 @@ public static void convertFO2PDF( File fo, File pdf, 
String resourceDir, Documen
  * @param pdf the target PDF file, not null.
  * @param resourceDir The base directory for relative path resolution, 
could be null.
  * If null, defaults to the parent directory of fo.
- * @param foUserAgent the FOUserAgent to use.
- *  May be null, in which case a default user agent will be used.
+ * @param documentModel the document model to add PDF metadatas like 
author, title and keywords, could be null.
  * @throws javax.xml.transform.TransformerException In case of a 
conversion problem.
  * @since 1.1.1
  */
-public static void convertFO2PDF( File fo, File pdf, String resourceDir, 
FOUserAgent foUserAgent )
+public static void convertFO2PDF( File fo, File pdf, String resourceDir, 
DocumentModel documentModel )
 throws TransformerException
 {
-FOUserAgent userAgent = ( foUserAgent == null ? getDefaultUserAgent( 
fo, resourceDir ) : foUserAgent );
-
 OutputStream out = null;
 try
 {
@@ -149,7 +129,11 @@ public static void convertFO2PDF( File fo, File pdf, 
String resourceDir, FOUserA
 Result res = null;
 try
 {
-Fop fop = FOP_FACTORY.newFop( MimeConstants.MIME_PDF, 
userAgent, out );
+URI baseURI = getBaseURI( fo, resourceDir );
+FopFactory fopFactory = new FopFactoryBuilder( baseURI 
).build();
+FOUserAgent userAgent = fopFactory.newFOUserAgent();
+prepareUserAgent( userAgent, documentModel );
+Fop fop = fopFactory.newFop( MimeConstants.MIME_PDF, 
userA

[GitHub] hboutemy commented on issue #7: [DOXIA-409] Upgrade to FOP 2.2

[GitBox]

hboutemy commented on issue #7: [DOXIA-409] Upgrade to FOP 2.2
URL: https://github.com/apache/maven-doxia/pull/7#issuecomment-363692292
 
 
   ok, let's have a try
   I merged this PR and will update maven-pdf-plugin to use the new SNAPSHOT
   then please ask on the dev mailing list for people to test maven-pdf-plugin 
or any other tool using this component to check that everything works well: we 
need to engage as many testers as possible


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] slachiewicz opened a new pull request #8: [DOXIA-534] Migrate logging to slf4j and deprecate doxia-logging-api

[GitBox]

slachiewicz opened a new pull request #8: [DOXIA-534] Migrate logging to slf4j 
and deprecate doxia-logging-api
URL: https://github.com/apache/maven-doxia/pull/8
 
 
   New version that deprecates doxia-logging 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] slachiewicz commented on issue #5: [DOXIA-534] Migrate logging to Sl4j

[GitBox]

slachiewicz commented on issue #5: [DOXIA-534] Migrate logging to Sl4j
URL: https://github.com/apache/maven-doxia/pull/5#issuecomment-364775373
 
 
   New version with deprecation in #8 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] slachiewicz closed pull request #5: [DOXIA-534] Migrate logging to Sl4j

[GitBox]

slachiewicz closed pull request #5: [DOXIA-534] Migrate logging to Sl4j
URL: https://github.com/apache/maven-doxia/pull/5
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/doxia-core/pom.xml b/doxia-core/pom.xml
index 371e56af..cb6cc4c9 100644
--- a/doxia-core/pom.xml
+++ b/doxia-core/pom.xml
@@ -39,8 +39,13 @@ under the License.
   doxia-sink-api
 
 
-  org.apache.maven.doxia
-  doxia-logging-api
+  org.slf4j
+  slf4j-api
+
+
+   org.slf4j
+   slf4j-simple
+   test
 
 
   org.codehaus.plexus
diff --git a/doxia-core/src/main/java/org/apache/maven/doxia/DefaultDoxia.java 
b/doxia-core/src/main/java/org/apache/maven/doxia/DefaultDoxia.java
index b39e026c..f3144a56 100644
--- a/doxia-core/src/main/java/org/apache/maven/doxia/DefaultDoxia.java
+++ b/doxia-core/src/main/java/org/apache/maven/doxia/DefaultDoxia.java
@@ -19,7 +19,6 @@
  * under the License.
  */
 
-import org.apache.maven.doxia.logging.PlexusLoggerWrapper;
 import org.apache.maven.doxia.parser.ParseException;
 import org.apache.maven.doxia.parser.Parser;
 import org.apache.maven.doxia.parser.manager.ParserManager;
@@ -28,7 +27,6 @@
 
 import org.codehaus.plexus.component.annotations.Component;
 import org.codehaus.plexus.component.annotations.Requirement;
-import org.codehaus.plexus.logging.AbstractLogEnabled;
 
 import java.io.Reader;
 
@@ -42,7 +40,6 @@
  */
 @Component( role = Doxia.class )
 public class DefaultDoxia
-extends AbstractLogEnabled
 implements Doxia
 {
 @Requirement
@@ -60,8 +57,6 @@ public void parse( Reader source, String parserId, Sink sink )
 {
 Parser parser = parserManager.getParser( parserId );
 
-parser.enableLogging( new PlexusLoggerWrapper( getLogger() ) );
-
 parser.parse( source, sink );
 }
 
diff --git 
a/doxia-core/src/main/java/org/apache/maven/doxia/macro/AbstractMacro.java 
b/doxia-core/src/main/java/org/apache/maven/doxia/macro/AbstractMacro.java
index 79b88fad..65dd35e2 100644
--- a/doxia-core/src/main/java/org/apache/maven/doxia/macro/AbstractMacro.java
+++ b/doxia-core/src/main/java/org/apache/maven/doxia/macro/AbstractMacro.java
@@ -21,11 +21,11 @@
 
 import java.util.Map;
 
-import org.apache.maven.doxia.logging.Log;
-import org.apache.maven.doxia.logging.SystemStreamLog;
 import org.apache.maven.doxia.sink.SinkEventAttributes;
 import org.apache.maven.doxia.sink.impl.SinkEventAttributeSet;
 import org.codehaus.plexus.util.StringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /**
  * Abstract base class to execute Macro.
@@ -38,13 +38,7 @@
 implements Macro
 {
 /** Log instance. */
-private Log logger;
-
-/** {@inheritDoc} */
-public void enableLogging( Log log )
-{
-this.logger = log;
-}
+private Logger logger;
 
 /**
  * Returns a logger for this macro.
@@ -53,11 +47,11 @@ public void enableLogging( Log log )
  * @return Log
  * @since 1.1
  */
-protected Log getLog()
+protected Logger getLog()
 {
 if ( logger == null )
 {
-logger = new SystemStreamLog();
+logger = LoggerFactory.getLogger( this.getClass() );
 }
 
 return logger;
diff --git a/doxia-core/src/main/java/org/apache/maven/doxia/macro/Macro.java 
b/doxia-core/src/main/java/org/apache/maven/doxia/macro/Macro.java
index 1c8e37b5..c1d7d7b6 100644
--- a/doxia-core/src/main/java/org/apache/maven/doxia/macro/Macro.java
+++ b/doxia-core/src/main/java/org/apache/maven/doxia/macro/Macro.java
@@ -19,7 +19,6 @@
  * under the License.
  */
 
-import org.apache.maven.doxia.logging.LogEnabled;
 import org.apache.maven.doxia.sink.Sink;
 
 /**
@@ -30,7 +29,6 @@
  * @since 1.0
  */
 public interface Macro
-extends LogEnabled
 {
 /** The Plexus lookup role. */
 String ROLE = Macro.class.getName();
diff --git 
a/doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractParser.java 
b/doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractParser.java
index cf5599d5..77c76b45 100644
--- a/doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractParser.java
+++ b/doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractParser.java
@@ -27,8 +27,6 @@
 
 import java.util.Properties;
 
-import org.apache.maven.doxia.logging.Log;
-import org.apache.maven.doxia.logging.SystemStreamLog;
 import org.apache.maven.doxia.macro.Macro;
 import org.apache.maven.doxia.macro.MacroExecutionException;
 import org.apache.maven.doxia.macro.MacroRequest;
@@ -36,6 +34,8 @@
 import org.apache.maven.doxia.macro.manager.MacroNotFoundException;
 import org.apache.maven.doxia.sink.Sink;
 import org.codehaus.plexus.component.annotations.Requirement;
+import org.slf4j.Logger;

[GitHub] slachiewicz opened a new pull request #9: [DOXIA-570] Escape links to xml based figureGraphics image elements

[GitBox]

slachiewicz opened a new pull request #9: [DOXIA-570] Escape links to xml based 
figureGraphics image elements
URL: https://github.com/apache/maven-doxia/pull/9
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] minfrin opened a new pull request #10: XHTML5 support for maven-doxia

[GitBox]

minfrin opened a new pull request #10: XHTML5 support for maven-doxia
URL: https://github.com/apache/maven-doxia/pull/10
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] ghilainm opened a new pull request #11: Propagate exceptions to caller

[GitBox]

ghilainm opened a new pull request #11: Propagate exceptions to caller
URL: https://github.com/apache/maven-doxia/pull/11
 
 
   The exceptions are swallowed this is really unpractical when using the 
library (example building a site using mvn-site plugin).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] slachiewicz opened a new pull request #12: DOXIA-576 Upgrade Http Components to 4.4.5

[GitBox]

slachiewicz opened a new pull request #12: DOXIA-576 Upgrade Http Components to 
4.4.5
URL: https://github.com/apache/maven-doxia/pull/12
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] comtention commented on issue #11: Propagate exceptions to caller

[GitBox]

comtention commented on issue #11: Propagate exceptions to caller
URL: https://github.com/apache/maven-doxia/pull/11#issuecomment-398056960
 
 
   I have exactly the same issue, it is really blocking for me.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] slachiewicz opened a new pull request #13: [DOXIA-497] Fix rendering links and paragraphs inside tables

[GitBox]

slachiewicz opened a new pull request #13: [DOXIA-497] Fix rendering links and 
paragraphs inside tables
URL: https://github.com/apache/maven-doxia/pull/13
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] asfgit closed pull request #13: [DOXIA-497] Fix rendering links and paragraphs inside tables

[GitBox]

asfgit closed pull request #13: [DOXIA-497] Fix rendering links and paragraphs 
inside tables
URL: https://github.com/apache/maven-doxia/pull/13
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptSink.java
 
b/doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptSink.java
index 97467476..3747370f 100644
--- 
a/doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptSink.java
+++ 
b/doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptSink.java
@@ -65,6 +65,9 @@
 /**  tableCaptionFlag. */
 private boolean tableCaptionFlag;
 
+/**  tableCellFlag. */
+private boolean tableCellFlag;
+
 /**  headerFlag. */
 private boolean headerFlag;
 
@@ -164,6 +167,7 @@ protected void init()
 this.date = null;
 this.startFlag = true;
 this.tableCaptionFlag = false;
+this.tableCellFlag = false;
 this.headerFlag = false;
 this.bufferFlag = false;
 this.itemFlag = false;
@@ -518,7 +522,11 @@ public void pageBreak()
 /** {@inheritDoc} */
 public void paragraph()
 {
-if ( itemFlag )
+if ( tableCellFlag )
+{
+// ignore paragraphs in table cells
+}
+else if ( itemFlag )
 {
 write( EOL + EOL + "  " + listNestingIndent );
 }
@@ -531,7 +539,14 @@ public void paragraph()
 /** {@inheritDoc} */
 public void paragraph_()
 {
-write( EOL + EOL );
+   if ( tableCellFlag )
+   {
+   // ignore paragraphs in table cells
+   }
+   else
+   {
+   write( EOL + EOL );
+   }
 }
 
 /** {@inheritDoc} */
@@ -696,6 +711,7 @@ public void tableCell( boolean headerRow )
 {
 buffer.append( TABLE_CELL_SEPARATOR_MARKUP );
 }
+tableCellFlag = true;
 }
 
 /** {@inheritDoc} */
@@ -715,6 +731,7 @@ public void tableHeaderCell_()
  */
 private void endTableCell()
 {
+tableCellFlag = false;
 buffer.append( TABLE_CELL_SEPARATOR_MARKUP );
 cellCount++;
 }
@@ -928,7 +945,14 @@ public void unknown( String name, Object[] requiredParams, 
SinkEventAttributes a
 protected void write( String text )
 {
 startFlag = false;
-writer.write( unifyEOLs( text ) );
+if ( tableCellFlag )
+{
+   buffer.append( text );
+   }
+else
+{
+   writer.write( unifyEOLs( text ) );
+   }
 }
 
 /**
diff --git 
a/doxia-modules/doxia-module-apt/src/test/java/org/apache/maven/doxia/module/apt/AptSinkTest.java
 
b/doxia-modules/doxia-module-apt/src/test/java/org/apache/maven/doxia/module/apt/AptSinkTest.java
index af310e9a..812f4965 100644
--- 
a/doxia-modules/doxia-module-apt/src/test/java/org/apache/maven/doxia/module/apt/AptSinkTest.java
+++ 
b/doxia-modules/doxia-module-apt/src/test/java/org/apache/maven/doxia/module/apt/AptSinkTest.java
@@ -275,4 +275,58 @@ protected String getCommentBlock( String text )
 {
 return "~~" + text;
 }
+
+/**
+ * test for DOXIA-497.
+ */
+public void testLinksAndParagraphsInTableCells()
+{
+final String linkTarget = "target";
+final String linkText = "link";
+final String paragraphText = "paragraph text";
+final Sink sink = getSink();
+sink.table();
+sink.tableRow();
+sink.tableCell();
+sink.link(linkTarget);
+sink.text(linkText);
+sink.link_();
+sink.tableCell_();
+sink.tableCell();
+sink.paragraph();
+sink.text(paragraphText);
+sink.paragraph_();
+sink.tableCell_();
+sink.tableRow_();
+sink.table_();
+sink.flush();
+sink.close();
+
+String expected = EOL + AptMarkup.TABLE_ROW_START_MARKUP +
+AptMarkup.MINUS +
+AptMarkup.MINUS +
+AptMarkup.TABLE_ROW_START_MARKUP +
+AptMarkup.STAR +
+EOL +
+AptMarkup.LEFT_CURLY_BRACKET +
+AptMarkup.LEFT_CURLY_BRACKET +
+AptMarkup.LEFT_CURLY_BRACKET +
+linkTarget +
+AptMarkup.RIGHT_CURLY_BRACKET +
+linkText +
+AptMarkup.RIGHT_CURLY_BRACKET +
+AptMarkup.RIGHT_CURLY_BRACKET +
+AptMarkup.TABLE_CELL_SEPARATOR_MARKUP +
+paragraphText +
+AptMarkup.TABLE_CELL_SEPARATOR_MARKUP +
+EOL +
+AptMarkup.TABLE_ROW_START_MARKUP +
+AptM

[GitHub] michael-o commented on issue #11: Propagate exceptions to caller

[GitBox]

michael-o commented on issue #11: Propagate exceptions to caller
URL: https://github.com/apache/maven-doxia/pull/11#issuecomment-415997595
 
 
   A JIRA issue please and I will merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] hboutemy commented on a change in pull request #11: Propagate exceptions to caller

[GitBox]

hboutemy commented on a change in pull request #11: Propagate exceptions to 
caller
URL: https://github.com/apache/maven-doxia/pull/11#discussion_r249714608
 
 

 ##
 File path: 
doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlParser.java
 ##
 @@ -269,11 +269,11 @@ private void processMacro( String text, Sink sink )
 }
 catch ( MacroExecutionException e )
 {
-throw new XmlPullParserException( "Unable to execute macro in the 
document: " + macroName );
+throw new XmlPullParserException( "Unable to execute macro in the 
document: " + macroName , null, e );
 }
 catch ( MacroNotFoundException me )
 {
-throw new XmlPullParserException( "Macro not found: " + macroName 
);
+throw new XmlPullParserException( "Macro not found: " + macroName, 
null, me );
 
 Review comment:
   is the original exception really useful in the context of a macro not found?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] hboutemy commented on a change in pull request #11: Propagate macro related exceptions to caller in xhtml parser

[GitBox]

hboutemy commented on a change in pull request #11: Propagate macro related 
exceptions to caller in xhtml parser
URL: https://github.com/apache/maven-doxia/pull/11#discussion_r249715464
 
 

 ##
 File path: 
doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlParser.java
 ##
 @@ -269,11 +269,11 @@ private void processMacro( String text, Sink sink )
 }
 catch ( MacroExecutionException e )
 {
-throw new XmlPullParserException( "Unable to execute macro in the 
document: " + macroName );
+throw new XmlPullParserException( "Unable to execute macro in the 
document: " + macroName , null, e );
 
 Review comment:
   can you provide an example of failing macro for me to test in real 
conditions how the failure renders without and with the update, please?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] hboutemy commented on issue #11: Propagate macro related exceptions to caller in xhtml parser

[GitBox]

hboutemy commented on issue #11: Propagate macro related exceptions to caller 
in xhtml parser
URL: https://github.com/apache/maven-doxia/pull/11#issuecomment-456344828
 
 
   FYI, Jira issue created: https://issues.apache.org/jira/browse/DOXIA-585


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] ghilainm commented on a change in pull request #11: Propagate macro related exceptions to caller in xhtml parser

[GitBox]

ghilainm commented on a change in pull request #11: Propagate macro related 
exceptions to caller in xhtml parser
URL: https://github.com/apache/maven-doxia/pull/11#discussion_r249834594
 
 

 ##
 File path: 
doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlParser.java
 ##
 @@ -269,11 +269,11 @@ private void processMacro( String text, Sink sink )
 }
 catch ( MacroExecutionException e )
 {
-throw new XmlPullParserException( "Unable to execute macro in the 
document: " + macroName );
+throw new XmlPullParserException( "Unable to execute macro in the 
document: " + macroName , null, e );
 }
 catch ( MacroNotFoundException me )
 {
-throw new XmlPullParserException( "Macro not found: " + macroName 
);
+throw new XmlPullParserException( "Macro not found: " + macroName, 
null, me );
 
 Review comment:
   @hboutemy  I have no time doing that. I have used the plugin in the context 
of another project and I don't have any example atm. What I can tell is that to 
find the cause of the issue I had to debug the plugin code to see the 
exception. So yes, in my case, the exception was totally useful. It is also for 
me anyway a bad practice to swallow exceptions.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] ghilainm commented on a change in pull request #11: Propagate macro related exceptions to caller in xhtml parser

[GitBox]

ghilainm commented on a change in pull request #11: Propagate macro related 
exceptions to caller in xhtml parser
URL: https://github.com/apache/maven-doxia/pull/11#discussion_r249834862
 
 

 ##
 File path: 
doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlParser.java
 ##
 @@ -269,11 +269,11 @@ private void processMacro( String text, Sink sink )
 }
 catch ( MacroExecutionException e )
 {
-throw new XmlPullParserException( "Unable to execute macro in the 
document: " + macroName );
+throw new XmlPullParserException( "Unable to execute macro in the 
document: " + macroName , null, e );
 
 Review comment:
   @hboutemy  See my comment above :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] hboutemy commented on a change in pull request #11: Propagate macro related exceptions to caller in xhtml parser

[GitBox]

hboutemy commented on a change in pull request #11: Propagate macro related 
exceptions to caller in xhtml parser
URL: https://github.com/apache/maven-doxia/pull/11#discussion_r249863748
 
 

 ##
 File path: 
doxia-modules/doxia-module-xhtml/src/main/java/org/apache/maven/doxia/module/xhtml/XhtmlParser.java
 ##
 @@ -269,11 +269,11 @@ private void processMacro( String text, Sink sink )
 }
 catch ( MacroExecutionException e )
 {
-throw new XmlPullParserException( "Unable to execute macro in the 
document: " + macroName );
+throw new XmlPullParserException( "Unable to execute macro in the 
document: " + macroName , null, e );
 }
 catch ( MacroNotFoundException me )
 {
-throw new XmlPullParserException( "Macro not found: " + macroName 
);
+throw new XmlPullParserException( "Macro not found: " + macroName, 
null, me );
 
 Review comment:
   > It is also for me anyway a bad practice to swallow exceptions
   unless you know why: let's not make it a pure dogma
   for macro not found, it'll be easy to reproduce, I'll do it myself
   that's more for execution exception that I don't know yet how to easily 
cause a failure: I'll find
   
   thank you for the report, for sure, it has to be improved
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] hboutemy commented on issue #11: Propagate macro related exceptions to caller in xhtml parser

[GitBox]

hboutemy commented on issue #11: Propagate macro related exceptions to caller 
in xhtml parser
URL: https://github.com/apache/maven-doxia/pull/11#issuecomment-456790819
 
 
   fixed in d977f4e4f4a9f7d5549f25daa56d3cd0f756023a
   this not only keeps the exception in case of macro execution failure but 
also keep parser in every case to keep a link with the original document 
location


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] hboutemy closed pull request #11: Propagate macro related exceptions to caller in xhtml parser

[GitBox]

hboutemy closed pull request #11: Propagate macro related exceptions to caller 
in xhtml parser
URL: https://github.com/apache/maven-doxia/pull/11
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] jmones opened a new pull request #14: [DOXIA-584] Rewrite .md and .markdown links to .html

[GitBox]

jmones opened a new pull request #14: [DOXIA-584] Rewrite .md and .markdown 
links to .html
URL: https://github.com/apache/maven-doxia/pull/14
 
 
   This implementation supports rewriting the following types of links:
   (link to a)[a.md]
   (link to xxx section in a)[a.md#xxx]
   (link to a)[a.markdown]
   (link to xxx section in a)[a.markdown#xxx]


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] jmones commented on issue #14: [DOXIA-584] Rewrite .md and .markdown links to .html

[GitBox]

jmones commented on issue #14: [DOXIA-584] Rewrite .md and .markdown links to 
.html
URL: https://github.com/apache/maven-doxia/pull/14#issuecomment-457496406
 
 
   I'm improving the solution a little bit more. Will create another pull 
request.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] jmones closed pull request #14: [DOXIA-584] Rewrite .md and .markdown links to .html

[GitBox]

jmones closed pull request #14: [DOXIA-584] Rewrite .md and .markdown links to 
.html
URL: https://github.com/apache/maven-doxia/pull/14
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] hboutemy commented on issue #14: [DOXIA-584] Rewrite .md and .markdown links to .html

[GitBox]

hboutemy commented on issue #14: [DOXIA-584] Rewrite .md and .markdown links to 
.html
URL: https://github.com/apache/maven-doxia/pull/14#issuecomment-457497988
 
 
   notice: you can do this by just updating your branch, without closing this 
PR :)
   
   if you can add a little unit test, that would be awesome


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] jmones opened a new pull request #14: [DOXIA-584] Rewrite .md and .markdown links to .html

[GitBox]

jmones opened a new pull request #14: [DOXIA-584] Rewrite .md and .markdown 
links to .html
URL: https://github.com/apache/maven-doxia/pull/14
 
 
   This implementation supports rewriting the following types of links:
   (link to a)[a.md]
   (link to xxx section in a)[a.md#xxx]
   (link to a)[a.markdown]
   (link to xxx section in a)[a.markdown#xxx]


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] jmones commented on issue #14: [DOXIA-584] Rewrite .md and .markdown links to .html

[GitBox]

jmones commented on issue #14: [DOXIA-584] Rewrite .md and .markdown links to 
.html
URL: https://github.com/apache/maven-doxia/pull/14#issuecomment-457609189
 
 
   Hi Hervé. Now you can look at it. I implemented it as a regex and added some 
unit tests, as requested.
   Don't hesitate to request any modifications.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] hboutemy commented on issue #14: [DOXIA-584] Rewrite .md and .markdown links to .html

[GitBox]

hboutemy commented on issue #14: [DOXIA-584] Rewrite .md and .markdown links to 
.html
URL: https://github.com/apache/maven-doxia/pull/14#issuecomment-457638840
 
 
   great work!!!
   please merge the PR I just sent on your clone for unit tests formatting
   then squash the commits
   then I'll merge


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] jmones commented on issue #14: [DOXIA-584] Rewrite .md and .markdown links to .html

[GitBox]

jmones commented on issue #14: [DOXIA-584] Rewrite .md and .markdown links to 
.html
URL: https://github.com/apache/maven-doxia/pull/14#issuecomment-457651728
 
 
   Done. I hope it's ok (no much experience on this).
   Please note that I had to update flexmark dependency in POM, as I needed 
newer version (i hope that's ok).
   Finally, do you have plans to release soon?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] hboutemy merged pull request #14: [DOXIA-584] Rewrite .md and .markdown links to .html

[GitBox]

hboutemy merged pull request #14: [DOXIA-584] Rewrite .md and .markdown links 
to .html
URL: https://github.com/apache/maven-doxia/pull/14
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] hboutemy commented on issue #14: [DOXIA-584] Rewrite .md and .markdown links to .html

[GitBox]

hboutemy commented on issue #14: [DOXIA-584] Rewrite .md and .markdown links to 
.html
URL: https://github.com/apache/maven-doxia/pull/14#issuecomment-457747717
 
 
   merged, thank you: great job
   new Flexmark version still requires Java 7, then it's perfect
   on releasing, there is no precise plan for the moment: I'll review in a few 
weeks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] slachiewicz commented on issue #8: [DOXIA-534] Migrate logging to slf4j and deprecate doxia-logging-api

[GitBox]

slachiewicz commented on issue #8: [DOXIA-534] Migrate logging to slf4j and 
deprecate doxia-logging-api
URL: https://github.com/apache/maven-doxia/pull/8#issuecomment-457848628
 
 
   @hboutemy ping?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] michael-o commented on a change in pull request #10: XHTML5 support for maven-doxia

[GitBox]

michael-o commented on a change in pull request #10: XHTML5 support for 
maven-doxia
URL: https://github.com/apache/maven-doxia/pull/10#discussion_r257521658
 
 

 ##
 File path: 
doxia-core/src/main/java/org/apache/maven/doxia/markup/HtmlMarkup.java
 ##
 @@ -25,11 +25,13 @@
 /**
  * List of Html tags.
  * 
- *   This should contain all valid XHTML 1.0 tags, comprising the tags in
- *   {@link javax.swing.text.html.HTML.Tag} plus several others.
+ * This should contain all valid XHTML 1.0 and HTML5 tags, comprising the tags
 
 Review comment:
   Does it really contain XHTML 1.0?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] michael-o commented on a change in pull request #10: XHTML5 support for maven-doxia

[GitBox]

michael-o commented on a change in pull request #10: XHTML5 support for 
maven-doxia
URL: https://github.com/apache/maven-doxia/pull/10#discussion_r257521658
 
 

 ##
 File path: 
doxia-core/src/main/java/org/apache/maven/doxia/markup/HtmlMarkup.java
 ##
 @@ -25,11 +25,13 @@
 /**
  * List of Html tags.
  * 
- *   This should contain all valid XHTML 1.0 tags, comprising the tags in
- *   {@link javax.swing.text.html.HTML.Tag} plus several others.
+ * This should contain all valid XHTML 1.0 and HTML5 tags, comprising the tags
 
 Review comment:
   Does it really contain XHTML 1.0?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] michael-o commented on a change in pull request #10: XHTML5 support for maven-doxia

[GitBox]

michael-o commented on a change in pull request #10: XHTML5 support for 
maven-doxia
URL: https://github.com/apache/maven-doxia/pull/10#discussion_r257522186
 
 

 ##
 File path: 
doxia-core/src/main/java/org/apache/maven/doxia/parser/XhtmlBaseParser.java
 ##
 @@ -77,9 +77,6 @@
 /** Used to wrap the definedTerm with its definition, even when one is 
omitted */
 boolean hasDefinitionListItem = false;
 
-/** Decoration properties, eg for texts. */
-private final SinkEventAttributeSet decoration = new 
SinkEventAttributeSet();
 
 Review comment:
   Can you please explain why this is gone and most has been turned into 
`sink#inline()`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] michael-o commented on a change in pull request #10: XHTML5 support for maven-doxia

[GitBox]

michael-o commented on a change in pull request #10: XHTML5 support for 
maven-doxia
URL: https://github.com/apache/maven-doxia/pull/10#discussion_r257522353
 
 

 ##
 File path: 
doxia-core/src/test/java/org/apache/maven/doxia/parser/XhtmlBaseParserTest.java
 ##
 @@ -555,42 +520,72 @@ public void testLists()
 }
 
 /** @throws Exception  */
-public void testStyles()
+public void testSimpleTags()
 throws Exception
 
 Review comment:
   Why is this test gone?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] minfrin commented on issue #10: XHTML5 support for maven-doxia

[GitBox]

minfrin commented on issue #10: XHTML5 support for maven-doxia
URL: https://github.com/apache/maven-doxia/pull/10#issuecomment-469780778
 
 
   > * Why have specialized items replaced with inline? What is the purpose?
   
   They were all almost identical variations of what would otherwise have been 
the "span" tag. As I recall (this patch was written 10 months ago) it extended 
an existing pattern in the code.
   
   > * Several `@since` tag value are wrong
   > * There is a merge conflict, please resolve
   
   Unfortunately this PR bit-rotted, the most recent patch is at 
   https://jira.apache.org/jira/secure/attachment/12945908/DOXIA-575.patch


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] michael-o commented on issue #10: XHTML5 support for maven-doxia

[GitBox]

michael-o commented on issue #10: XHTML5 support for maven-doxia
URL: https://github.com/apache/maven-doxia/pull/10#issuecomment-478115447
 
 
   Please perform the requested changes by applying your patch and I will 
re-review.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] michael-o commented on issue #16: XHTML5 support for maven-doxia (redux)

[GitBox]

michael-o commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487394681
 
 
   I have now pushed a branch and get this error:
   
   ```
   [ERROR] Failures:
   [ERROR]   Xhtml5BaseSinkTest.testContent:518 expected:<[]
   ]div class="content...> but was:<[
   

[GitHub] [maven-doxia] minfrin commented on issue #16: XHTML5 support for maven-doxia (redux)

[GitBox]

minfrin commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487409020
 
 
   I built the project on a different VM with a completely clean .m2 directory 
and uncovered a non-checked-in part of the code.
   
   I currently get this:
   
   [INFO] 

   [INFO] Reactor Summary:
   [INFO] 
   [INFO] Doxia . SUCCESS [19.979s]
   [INFO] Doxia :: Logging API .. SUCCESS [5.326s]
   [INFO] Doxia :: Sink API . SUCCESS [3.187s]
   [INFO] Doxia :: Test Documents ... SUCCESS [3.101s]
   [INFO] Doxia :: Core . SUCCESS [32.218s]
   [INFO] Doxia :: Modules .. SUCCESS [1.805s]
   [INFO] Doxia :: APT Module ... SUCCESS [11.825s]
   [INFO] Doxia :: Confluence Module  SUCCESS [9.403s]
   [INFO] Doxia :: Simplified DocBook Module  SUCCESS [8.694s]
   [INFO] Doxia :: FML Module ... SUCCESS [5.062s]
   [INFO] Doxia :: FO Module  SUCCESS [20.860s]
   [INFO] Doxia :: iText Module . SUCCESS [7.074s]
   [INFO] Doxia :: Latex Module . SUCCESS [4.978s]
   [INFO] Doxia :: RTF Module ... SUCCESS [9.964s]
   [INFO] Doxia :: TWiki Module . SUCCESS [7.848s]
   [INFO] Doxia :: XDoc Module .. SUCCESS [5.734s]
   [INFO] Doxia :: XHTML Module . SUCCESS [5.810s]
   [INFO] Doxia :: XHTML5 Module  SUCCESS [6.334s]
   [INFO] Doxia :: Markdown Module .. SUCCESS [22.975s]
   [INFO] 

   [INFO] BUILD SUCCESS
   [INFO] 

   [INFO] Total time: 3:15.044s
   [INFO] Finished at: Sun Apr 28 19:25:00 UTC 2019
   [INFO] Final Memory: 55M/225M
   [INFO] 

   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] michael-o commented on issue #16: XHTML5 support for maven-doxia (redux)

[GitBox]

michael-o commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487410626
 
 
   Please rebase your latest changes against the branch I have pushed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] minfrin commented on issue #16: XHTML5 support for maven-doxia (redux)

[GitBox]

minfrin commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487416967
 
 
   I've been googling how to rebase a branch for the last hour, and it has me 
stumped. The closest I got was an attempt that saw me trying to push to 
apache/maven-doxia instead of minfrin/maven-doxia, and obviously that won't 
work.
   
   Can you confirm what I need to do?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] michael-o commented on issue #16: XHTML5 support for maven-doxia (redux)

[GitBox]

michael-o commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487417796
 
 
   Checkout my branch, and perform a cherry pick on your two subsequent 
commits, that's it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] michael-o commented on issue #16: XHTML5 support for maven-doxia (redux)

[GitBox]

michael-o commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487417872
 
 
   I have force-pushed an updated branch. The issue still persists:
   
   ```
   
   [INFO]   
[INFO] Results: 
 [INFO] 
  [ERROR] Failures: 
   [ERROR]   Xhtml5BaseSinkTest.testContent:518 expected:<[]
  ]div class="content...> but was:<[
   --
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] minfrin commented on issue #16: XHTML5 support for maven-doxia (redux)

[GitBox]

minfrin commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487419827
 
 
   Thanks for this.
   
   I checked out a completely clean copy of the DOXIA-575 branch, then deleted 
my .m2 directory and ran "mvn clean install", and got success again:
   
   [INFO] 

   [INFO] Reactor Summary:
   [INFO] 
   [INFO] Doxia . SUCCESS [33.764s]
   [INFO] Doxia :: Logging API .. SUCCESS [9.715s]
   [INFO] Doxia :: Sink API . SUCCESS [3.800s]
   [INFO] Doxia :: Test Documents ... SUCCESS [3.060s]
   [INFO] Doxia :: Core . SUCCESS 
[1:21.713s]
   [INFO] Doxia :: Modules .. SUCCESS [1.836s]
   [INFO] Doxia :: APT Module ... SUCCESS [8.084s]
   [INFO] Doxia :: Confluence Module  SUCCESS [7.457s]
   [INFO] Doxia :: Simplified DocBook Module  SUCCESS [9.265s]
   [INFO] Doxia :: FML Module ... SUCCESS [5.685s]
   [INFO] Doxia :: FO Module  SUCCESS [21.917s]
   [INFO] Doxia :: iText Module . SUCCESS [7.573s]
   [INFO] Doxia :: Latex Module . SUCCESS [6.841s]
   [INFO] Doxia :: RTF Module ... SUCCESS [9.115s]
   [INFO] Doxia :: TWiki Module . SUCCESS [9.661s]
   [INFO] Doxia :: XDoc Module .. SUCCESS [6.364s]
   [INFO] Doxia :: XHTML Module . SUCCESS [6.522s]
   [INFO] Doxia :: XHTML5 Module  SUCCESS [6.516s]
   [INFO] Doxia :: Markdown Module .. SUCCESS [12.388s]
   [INFO] 

   [INFO] BUILD SUCCESS
   [INFO] 

   [INFO] Total time: 4:15.348s
   [INFO] Finished at: Sun Apr 28 22:08:47 UTC 2019
   [INFO] Final Memory: 58M/217M
   [INFO] 

   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] minfrin commented on issue #16: XHTML5 support for maven-doxia (redux)

[GitBox]

minfrin commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487419995
 
 
   Code was developed on MacOS Mojave, testing above done on CentOS7:
   
   [minfrin@localhost maven-doxia-DOXIA-575]$ rpm -q -a | grep release
   epel-release-7-11.noarch
   centos-release-7-5.1804.5.el7.centos.x86_64
   [minfrin@localhost maven-doxia-DOXIA-575]$ rpm -q -a | grep maven-3
   maven-3.0.5-17.el7.noarch
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] michael-o commented on issue #16: XHTML5 support for maven-doxia (redux)

[GitBox]

michael-o commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487420147
 
 
   It also fails on Jenkins: 
https://builds.apache.org/job/maven-box/job/maven-doxia/job/DOXIA-575/2/testReport/junit/org.apache.maven.doxia.sink.impl/Xhtml5BaseSinkTest/windows_jdk8___Build_windows_jdk8___testContent/


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] minfrin commented on issue #16: XHTML5 support for maven-doxia (redux)

[GitBox]

minfrin commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487420628
 
 
   Works on MacOS Mojave:
   
   [INFO] 

   [INFO] Reactor Summary for Doxia 1.9-SNAPSHOT:
   [INFO] 
   [INFO] Doxia .. SUCCESS [  2.845 
s]
   [INFO] Doxia :: Logging API ... SUCCESS [  2.731 
s]
   [INFO] Doxia :: Sink API .. SUCCESS [  1.285 
s]
   [INFO] Doxia :: Test Documents  SUCCESS [  1.372 
s]
   [INFO] Doxia :: Core .. SUCCESS [01:09 
min]
   [INFO] Doxia :: Modules ... SUCCESS [  0.418 
s]
   [INFO] Doxia :: APT Module  SUCCESS [  2.534 
s]
   [INFO] Doxia :: Confluence Module . SUCCESS [  2.665 
s]
   [INFO] Doxia :: Simplified DocBook Module . SUCCESS [  2.696 
s]
   [INFO] Doxia :: FML Module  SUCCESS [  2.221 
s]
   [INFO] Doxia :: FO Module . SUCCESS [  4.131 
s]
   [INFO] Doxia :: iText Module .. SUCCESS [  2.421 
s]
   [INFO] Doxia :: Latex Module .. SUCCESS [  2.199 
s]
   [INFO] Doxia :: RTF Module  SUCCESS [  2.644 
s]
   [INFO] Doxia :: TWiki Module .. SUCCESS [  2.439 
s]
   [INFO] Doxia :: XDoc Module ... SUCCESS [  2.525 
s]
   [INFO] Doxia :: XHTML Module .. SUCCESS [  2.514 
s]
   [INFO] Doxia :: XHTML5 Module . SUCCESS [  2.075 
s]
   [INFO] Doxia :: Markdown Module ... SUCCESS [  2.992 
s]
   [INFO] 

   [INFO] BUILD SUCCESS
   [INFO] 

   [INFO] Total time:  01:52 min
   [INFO] Finished at: 2019-04-29T00:18:24+02:00
   [INFO] 

   Little-Net:maven-doxia-DOXIA-575 minfrin$ mvn -v
   Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 
2018-10-24T20:41:47+02:00)
   Maven home: /Users/minfrin/src/apache/sandbox/maven/apache-maven-3.6.0
   Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
/Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
   Default locale: en_ZA, platform encoding: UTF-8
   OS name: "mac os x", version: "10.14.4", arch: "x86_64", family: "mac"
   
   I see the Jenkins job refers to a Windows build, I don't have any access to 
Windows alas.
   
   Looking at the test failure, it looks like there is an additional 0a 
character (linefeed) that has ended up in there, but can't reproduce it my side.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] michael-o commented on issue #16: XHTML5 support for maven-doxia (redux)

[GitBox]

michael-o commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487421589
 
 
   you can simulate this by changing {{line.separator}}.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] minfrin commented on issue #16: XHTML5 support for maven-doxia (redux)

[GitBox]

minfrin commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487423150
 
 
   Can you try with the attached patch? There were some hard coded line feeds 
in the test that didn't fit the pattern, this uses the EOL variable as appears 
elsewhere in the code.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] michael-o commented on issue #16: XHTML5 support for maven-doxia (redux)

[GitBox]

michael-o commented on issue #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16#issuecomment-487516043
 
 
   Pushed more changes. If Jenkins is happy, I will merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] asfgit closed pull request #16: XHTML5 support for maven-doxia (redux)

[GitBox]

asfgit closed pull request #16: XHTML5 support for maven-doxia (redux)
URL: https://github.com/apache/maven-doxia/pull/16
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] asfgit merged pull request #12: DOXIA-576 Upgrade HttpComponents: httpclient to 4.5.8 and httpcore to 4.4.11

[GitBox]

asfgit merged pull request #12: DOXIA-576 Upgrade HttpComponents: httpclient to 
4.5.8 and httpcore to 4.4.11
URL: https://github.com/apache/maven-doxia/pull/12
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] harawata opened a new pull request #17: [DOXIA-583] Avoid over-escaping table captions

[GitBox]

harawata opened a new pull request #17: [DOXIA-583] Avoid over-escaping table 
captions
URL: https://github.com/apache/maven-doxia/pull/17
 
 
   Please see https://issues.apache.org/jira/browse/DOXIA-583 for details.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] harawata commented on issue #17: [DOXIA-583] Avoid over-escaping table captions

[GitBox]

harawata commented on issue #17: [DOXIA-583] Avoid over-escaping table captions
URL: https://github.com/apache/maven-doxia/pull/17#issuecomment-496582698
 
 
   There seems to be the same issue in Xhtml5Sink indeed.
   I have already committed the fix.
   
   By the way, I noticed that the existing assertions don't work as expected.
   
   
https://github.com/apache/maven-doxia/blob/e005c348ddd4367de8871f2e38d698b615db7dce/doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSinkTest.java#L175-L186
   
   They do `indexOf(...) != 1`, but the value should be `-1`, I think.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] slachiewicz commented on issue #17: [DOXIA-583] Avoid over-escaping table captions

[GitBox]

slachiewicz commented on issue #17: [DOXIA-583] Avoid over-escaping table 
captions
URL: https://github.com/apache/maven-doxia/pull/17#issuecomment-496611474
 
 
   That's exactly what I had in mind. Your changes are consistent with my local 
changes.
   
   Good catch with `indexOf` - we can replace it with just `contains` here in 
xhtml5 but also XHtmlBaseSink.
   Could you also fix this issues and squash commits?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] harawata commented on issue #17: [DOXIA-583] Avoid over-escaping table captions

[GitBox]

harawata commented on issue #17: [DOXIA-583] Avoid over-escaping table captions
URL: https://github.com/apache/maven-doxia/pull/17#issuecomment-496616990
 
 
   Sure! =)
   However, simply replacing `!= 1` with `contains` made some (?) assertions 
fail, so I'll take a deeper look at the literal parts tomorrow night.
   Thanks for the review, @slachiewicz !


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] asfgit merged pull request #9: [DOXIA-570] Escape links to xml based figureGraphics image elements

[GitBox]

asfgit merged pull request #9: [DOXIA-570] Escape links to xml based 
figureGraphics image elements
URL: https://github.com/apache/maven-doxia/pull/9
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] harawata commented on issue #17: [DOXIA-583] Avoid over-escaping table captions

[GitBox]

harawata commented on issue #17: [DOXIA-583] Avoid over-escaping table captions
URL: https://github.com/apache/maven-doxia/pull/17#issuecomment-496907294
 
 
   Hi again,
   
   As I mentioned, the 'expected value' of the assertions had to be modified to 
pass the tests after replacing `indexOf(...) != 1` with `contains()`.
   Does the commit c8e834b649f7f7d5ee2b51c0f210c20c8e9bebdd look OK to you?
   Or could it be related to 
[DOXIA-588](https://issues.apache.org/jira/projects/DOXIA/issues/DOXIA-588) 
maybe?
   
   If it looks OK to you, please let me know and I'll do the squash & 
force-push.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] slachiewicz commented on issue #17: [DOXIA-583] Avoid over-escaping table captions

[GitBox]

slachiewicz commented on issue #17: [DOXIA-583] Avoid over-escaping table 
captions
URL: https://github.com/apache/maven-doxia/pull/17#issuecomment-496932864
 
 
   looks good to me. Please squash commits related to table caption to one and 
separate only related to .contains. Thx for time spent on verification!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] harawata commented on issue #17: [DOXIA-583] Avoid over-escaping table captions

[GitBox]

harawata commented on issue #17: [DOXIA-583] Avoid over-escaping table captions
URL: https://github.com/apache/maven-doxia/pull/17#issuecomment-496942515
 
 
   Updated. Please let me know if there is anything you want me to change.
   Thanks again for your time! =)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] asfgit closed pull request #17: [DOXIA-583] Avoid over-escaping table captions

[GitBox]

asfgit closed pull request #17: [DOXIA-583] Avoid over-escaping table captions
URL: https://github.com/apache/maven-doxia/pull/17
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] slachiewicz removed a comment on issue #8: [DOXIA-534] Migrate logging to slf4j and deprecate doxia-logging-api

[GitBox]

slachiewicz removed a comment on issue #8: [DOXIA-534] Migrate logging to slf4j 
and deprecate doxia-logging-api
URL: https://github.com/apache/maven-doxia/pull/8#issuecomment-457848628
 
 
   @hboutemy ping?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] JLLeitschuh opened a new pull request #18: [SECURITY] Use HTTPS to resolve dependencies in Maven Build

[GitBox]

JLLeitschuh opened a new pull request #18: [SECURITY] Use HTTPS to resolve 
dependencies in Maven Build
URL: https://github.com/apache/maven-doxia/pull/18
 
 
   
[![mitm_build](https://user-images.githubusercontent.com/1323708/59226671-90645200-8ba1-11e9-8ab3-39292bef99e9.jpeg)](https://medium.com/@jonathan.leitschuh/want-to-take-over-the-java-ecosystem-all-you-need-is-a-mitm-1fc329d898fb?source=friends_link&sk=3c99970c55a899ad9ef41f126efcde0e)
   
   - [Want to take over the Java ecosystem? All you need is a 
MITM!](https://medium.com/@jonathan.leitschuh/want-to-take-over-the-java-ecosystem-all-you-need-is-a-mitm-1fc329d898fb?source=friends_link&sk=3c99970c55a899ad9ef41f126efcde0e)
   - [Update: Want to take over the Java ecosystem? All you need is a 
MITM!](https://medium.com/bugbountywriteup/update-want-to-take-over-the-java-ecosystem-all-you-need-is-a-mitm-d069d253fe23?source=friends_link&sk=8c8e52a7d57b98d0b7e541665688b454)
   
   ---
   
   This is a security fix for a  vulnerability in your [Apache 
Maven](https://maven.apache.org/) `pom.xml` file(s).
   
   The build files indicate that this project is resolving dependencies over 
HTTP instead of HTTPS.
   This leaves your build vulnerable to allowing a [Man in the 
Middle](https://en.wikipedia.org/wiki/Man-in-the-middle_attack) (MITM) 
attackers to execute arbitrary code on your or your computer or CI/CD system.
   
   This vulnerability has a CVSS v3.0 Base Score of 
[8.1/10](https://nvd.nist.gov/vuln-metrics/cvss/v3-calculator?vector=AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:H).
   
   [POC 
code](https://max.computer/blog/how-to-take-over-the-computer-of-any-java-or-clojure-or-scala-developer/)
 has existed since 2014 to maliciously compromise a JAR file in-flight.
   MITM attacks against HTTP are [increasingly 
common](https://security.stackexchange.com/a/12050), for example [Comcast is 
known to have done it to their own 
users](https://thenextweb.com/insights/2017/12/11/comcast-continues-to-inject-its-own-code-into-websites-you-visit/#).
   
   This contribution is a part of a submission to the [GitHub Security 
Lab](https://securitylab.github.com/) Bug Bounty program.
   
   ## Detecting this and Future Vulnerabilities
   
   This vulnerability was automatically detected by 
[LGTM.com](https://lgtm.com) using this [CodeQL 
Query](https://lgtm.com/rules/155648721/).
   
   As of September 2019 LGTM.com and Semmle are [officially a part of 
GitHub](https://github.blog/2019-09-18-github-welcomes-semmle/).
   
   You can automatically detect future vulnerabilities like this by enabling 
the free (for open-source) [LGTM App](https://github.com/marketplace/lgtm).
   
   I'm not an employee of GitHub nor of Semmle, I'm simply a user of 
[LGTM.com](https://lgtm.com) and an open-source security researcher.
   
   ## Source
   
   Yes, this contribution was automatically generated, however, the code to 
generate this PR was lovingly hand crafted to bring this security fix to your 
repository.
   
   The source code that generated and submitted this PR can be found here:
   
[JLLeitschuh/bulk-security-pr-generator](https://github.com/JLLeitschuh/bulk-security-pr-generator)
   
   ## Opting-Out
   
   If you'd like to opt-out of future automated security vulnerability fixes 
like this, please consider adding a file called
   `.github/GH-ROBOTS.txt` to your repository with the line:
   
   ```
   User-agent: JLLeitschuh/bulk-security-pr-generator
   Disallow: *
   ```
   
   This bot will respect the [ROBOTS.txt](https://moz.com/learn/seo/robotstxt) 
format for future contributions.
   
   Alternatively, if this project is no longer actively maintained, consider 
[archiving](https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-archiving-repositories)
 the repository.
   
   ## CLA Requirements
   
   _This section is only relevant if your project requires contributors to sign 
a Contributor License Agreement (CLA) for external contributions._
   
   It is unlikely that I'll be able to directly sign CLAs. However, all 
contributed commits are already automatically signed-off.
   
   > The meaning of a signoff depends on the project, but it typically 
certifies that committer has the rights to submit this work under the same 
license and agrees to a Developer Certificate of Origin 
   > (see 
[https://developercertificate.org/](https://developercertificate.org/) for more 
information).
   >
   > \- [Git Commit Signoff documentation](https://developercertificate.org/)
   
   If signing your organization's CLA is a strict-requirement for merging this 
contribution, please feel free to close this PR.
   
   ## Tracking
   
   All PR's generated as part of this fix are tracked here: 
   https://github.com/JLLeitschuh/bulk-security-pr-generator/issues/2


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use

[GitHub] [maven-doxia] elharo merged pull request #18: [SECURITY] Use HTTPS to resolve dependencies in Maven Build

[GitBox]

elharo merged pull request #18: [SECURITY] Use HTTPS to resolve dependencies in 
Maven Build
URL: https://github.com/apache/maven-doxia/pull/18
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] minfrin opened a new pull request #19: [DOXIA-607] Add support for Xhtml5 keygen tag

[GitBox]

minfrin opened a new pull request #19: [DOXIA-607] Add support for Xhtml5 
keygen tag
URL: https://github.com/apache/maven-doxia/pull/19
 
 
   This will allow maven generated documentation to include a demo of the 
keygen tag, as with other form elements.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] michael-o commented on issue #19: [DOXIA-607] Add support for Xhtml5 keygen tag

[GitBox]

michael-o commented on issue #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19#issuecomment-593087315
 
 
   Mozilla says this is obsolete: 
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/keygen


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] minfrin commented on issue #19: [DOXIA-607] Add support for Xhtml5 keygen tag

[GitBox]

minfrin commented on issue #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19#issuecomment-593088806
 
 
   The tag is a formal part of the html5 spec as follows: 
https://www.w3.org/TR/2014/REC-html5-20141028/single-page.html#the-keygen-element
   
   The need to both document and provide examples of the tag in use is in an 
attempt to bring the tag up to date with respect to current crypto standards. 
Not being able to include the  tag in doxia generated documentation is making 
our lives hard.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] elharo commented on a change in pull request #19: [DOXIA-607] Add support for Xhtml5 keygen tag

[GitBox]

elharo commented on a change in pull request #19: [DOXIA-607] Add support for 
Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19#discussion_r386104912
 
 

 ##
 File path: 
doxia-core/src/main/java/org/apache/maven/doxia/markup/HtmlMarkup.java
 ##
 @@ -473,6 +473,17 @@ public String toString()
 /** Xhtml tag for kbd. */
 Tag KBD = Tag.KBD;
 
+/** Html5 tag for keygen. */
 
 Review comment:
   Html5 --> HTML 5


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] michael-o commented on a change in pull request #19: [DOXIA-607] Add support for Xhtml5 keygen tag

[GitBox]

michael-o commented on a change in pull request #19: [DOXIA-607] Add support 
for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19#discussion_r386105109
 
 

 ##
 File path: 
doxia-core/src/main/java/org/apache/maven/doxia/markup/HtmlMarkup.java
 ##
 @@ -473,6 +473,17 @@ public String toString()
 /** Xhtml tag for kbd. */
 Tag KBD = Tag.KBD;
 
+/** Html5 tag for keygen. */
 
 Review comment:
   It is actually HTML5. See 
https://html.spec.whatwg.org/multipage/introduction.html#is-this-html5?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] michael-o commented on issue #19: [DOXIA-607] Add support for Xhtml5 keygen tag

[GitBox]

michael-o commented on issue #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19#issuecomment-593093142
 
 
   Surprinsingly, the most recent version does not mention a deprecation: 
https://html.spec.whatwg.org/#keygen


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] michael-o commented on issue #19: [DOXIA-607] Add support for Xhtml5 keygen tag

[GitBox]

michael-o commented on issue #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19#issuecomment-593093527
 
 
   Branch pushed, awaiting tests...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] asfgit closed pull request #19: [DOXIA-607] Add support for Xhtml5 keygen tag

[GitBox]

asfgit closed pull request #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to slf4j and deprecate doxia-logging-api

[GitBox]

elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to 
slf4j and deprecate doxia-logging-api
URL: https://github.com/apache/maven-doxia/pull/8#discussion_r395993290
 
 

 ##
 File path: 
doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractParser.java
 ##
 @@ -151,6 +153,7 @@ public void executeMacro( String macroId, MacroRequest 
request, Sink sink )
  * @return The base directory.
  * @deprecated this does not work in multi-module builds, see DOXIA-373
  */
+@Deprecated
 protected File getBasedir()
 {
 // TODO: This is baaad, it should come in with the request.
 
 Review comment:
   delete now irrelevant todo


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to slf4j and deprecate doxia-logging-api

[GitBox]

elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to 
slf4j and deprecate doxia-logging-api
URL: https://github.com/apache/maven-doxia/pull/8#discussion_r395993269
 
 

 ##
 File path: 
doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractParser.java
 ##
 @@ -54,8 +56,10 @@
 private MacroManager macroManager;
 
 /** Log instance. */
-private Log logger;
+@Deprecated
+private Log log;
 
+protected Logger logger = LoggerFactory.getLogger(  getClass() );
 
 Review comment:
   final?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-doxia] elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to slf4j and deprecate doxia-logging-api

[GitBox]

elharo commented on a change in pull request #8: [DOXIA-534] Migrate logging to 
slf4j and deprecate doxia-logging-api
URL: https://github.com/apache/maven-doxia/pull/8#discussion_r395993498
 
 

 ##
 File path: 
doxia-logging-api/src/main/java/org/apache/maven/doxia/logging/Slf4jLoggerWrapper.java
 ##
 @@ -0,0 +1,143 @@
+package org.apache.maven.doxia.logging;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.slf4j.Logger;
+
+/**
+ * Wrap a Slf4j logger into a Doxia logger.
+ *
+ * @since 1.7
+ * @deprecated use directly slf4j
+ */
+@Deprecated
+public class Slf4jLoggerWrapper implements Log
+{
+
+private Logger logger;
+
+public Slf4jLoggerWrapper( Logger log )
+{
+logger = log;
+}
+
+public void setLogLevel( int level )
+{
+// ignore - managed outside
+}
+
+public void debug( CharSequence content )
+{
+if ( logger.isDebugEnabled() )
 
 Review comment:
   use braces in multiline ifs


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org