[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-46524647 First of all - thanks for your email. I understand, that this will ruin current ORing technique, but at least it could be fixed with copying for a while. What about complex conditions - it's my next step, I see that people needs complicated conditions, so definitely me or somebody else could provide it . 4565 was the first step, to try how it will going. So, next step would be formalizing task for AND and OR in activation section and then it could be fixed too. Konstantin On Jun 19, 2014 8:45 AM, "FredipusRex" wrote: > You do realize that the current OR condition is actually out in use right > now in many POM files, right? This was previously the subject of a patch > (MNG-3106) - originally only one condition was accepted which was patched > to allow for ORing of conditions - arguably the wrong thing to do, but it's > pretty well understood out in the Maven community. While this patch finally > matches Maven to the Sonatype book, it will break a lot of POMs without > recourse other than multiple, near duplicate activations. > > The right way to fix this would have been to add the ability to specify > the condition (AND, OR), perhaps through a set of tag attributes. > > > > JDKCheck > true > > > NeedsJava4or5 > > > Linux > > 1.6 > 1.4 > 1.5 > > All conditions now belong to a group - either the default group or a named > group attribute. Members of the default group have no attributes and are > AND'd together (keeping the functionality of your patch). There do not need > to be any members of the default group - in which case, it acts purely as > glue to named groups. > > One member of each named group must indicate how the group relates to the > default group via the condition attribute and how the members of the group > are related to each other via the group-condition attribute. > > This allows compact but complex relationships. The above example is > activated when the JDKCheck property is true and the NeedsJava4or5 property > exists and the JDK is 1.4 or 1.5, or when compiling under Linux and the JDK > is 1.6. It does not allow infinite numbers of levels and parenthetical > statements, but does provide for most common build scenarios. When there > are no members of the default group, it should be assumed to be not > activated and the first group (if any) with the AND condition should be > considered the default group. This allows something like group 1-OR with > group 2-AND to act like an either/or choice. > > â > Reply to this email directly or view it on GitHub > <https://github.com/apache/maven/pull/20#issuecomment-46523185>. > --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
Github user MysterionRise closed the pull request at: https://github.com/apache/maven/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-45826259 @jvanzyl Looks correct, please close this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-45825613 Let me check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-45731774 Hm, probably you are correct. I've just have strong feeling, when somebody said 'Sonatype' - think about 'Maven' and vice-versa. Regarding PR, let me know, if I need to fix something or anything else. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-45731386 http://jira.codehaus.org/browse/MNG-4565 - take a look here. It have link for reference http://books.sonatype.com/mvnref-book/reference/profiles-sect-activation.html#profiles-sect-activation-config Quote: "Activations can contain one of more selectors including JDK versions, Operating System parameters, files, and properties. A profile is activated when all activation criteria has been satisfied." --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-45704618 I've implement this patch, only cause it's 100% relates with official documentation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
GitHub user MysterionRise opened a pull request: https://github.com/apache/maven/pull/20 [MNG-4565] Multiple profile activation conditions does not work Add possibilty to use multiple activators and have AND between them You can merge this pull request into a Git repository by running: $ git pull https://github.com/MysterionRise/maven MNG-4565 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/20.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-45643803 I'm sorry, I don't understand, why you close this PR? Does it bad? I miss something? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-45431277 Just wonder, is there anything I could do? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-45134460 I've update pull request. I change my approach, so it will not now a platform dependable. But ITs are still failing at weird place. I'm 100% sure, that it's not my fault --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44831587 Good stuff. I will try it today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44757042 I'm 100% don't wanna rush. I will think about special activator for testing purpose (It could be _AlwaysTrueActivator_). I will try to give it a try tomorrow. Also, the way which is used now in 4 activators isn't best (I'm talking about condition for checking) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44756590 Not understand your point about failing against master. I agree that platform activators is not good idea. So same with JDK activator, right? I'm only left with existing/missing file (what I've already use) and property activator (which is tricky for testing) So, how we could resolve it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44755927 Awesome,this is the only platform, I couldn't test against.Could you specify your _mvn -version_ output? I will try to fix test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44751378 Could you tell me, what did you use? I've run tests on Linux: mvn -version Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 17:51:28+0400) Maven home: /home/mysterion/Downloads/apache-maven-3.0.5 Java version: 1.7.0_25, vendor: Oracle Corporation Java home: /home/mysterion/Downloads/jdk1.7.0_25/jre Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "3.13.0-27-generic", arch: "amd64", family: "unix" also, i've try with windows mvn -version Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 2014-02-14T21:37:5 2+04:00) Maven home: C:\Users\User\Downloads\apache-maven-3.2.1-bin\apache-maven-3.2.1\bi n\.. Java version: 1.7.0_55, vendor: Oracle Corporation Java home: C:\Program Files (x86)\Java\jdk1.7.0_55\jre Default locale: ru_RU, platform encoding: Cp1251 OS name: "windows 8", version: "6.2", arch: "x86", family: "windows" and all tests are also passed. Did you use anything that isn't from family: windows or unix? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44749028 Any updates on my pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: http://jira.codehaus.org/browse/MNG-4565
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/15#issuecomment-44268726 Create new pull request with squashed commits https://github.com/apache/maven/pull/16, plz take a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: http://jira.codehaus.org/browse/MNG-4565
Github user MysterionRise closed the pull request at: https://github.com/apache/maven/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...
GitHub user MysterionRise opened a pull request: https://github.com/apache/maven/pull/16 [MNG-4565] Multiple profile activation conditions does not work You can merge this pull request into a Git repository by running: $ git pull https://github.com/MysterionRise/maven MNG-4565 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/16.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #16 commit 0bdb276b36ee4532cb0b57e62591ded647cf0ca2 Author: Mysterion Date: 2014-05-26T20:18:08Z Add solution to http://jira.codehaus.org/browse/MNG-4565 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: http://jira.codehaus.org/browse/MNG-4565
GitHub user MysterionRise opened a pull request: https://github.com/apache/maven/pull/15 http://jira.codehaus.org/browse/MNG-4565 Simple solution to this bug. Add possibility to have multiple condition in profile activation. Add simple test with positive and negative case. http://jira.codehaus.org/browse/MNG-4565 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MysterionRise/maven master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/15.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #15 commit 2074bcad5fc534678bdc98dde23602c9596ef111 Author: Mysterion Date: 2014-05-26T20:18:08Z Add solution to http://jira.codehaus.org/browse/MNG-4565 commit 58f2254d5cd0e1a2d9408ed58234c9e8e8c6b94a Author: Konstantin Perikov Date: 2014-05-27T07:05:18Z Add more test coverage for http://jira.codehaus.org/browse/MNG-4565 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
