[jira] Commented: (MNG-1113) Plugin does not support using custom checkstyle XML config file
[ http://jira.codehaus.org/browse/MNG-1113?page=comments#action_52395 ] Dave Sag commented on MNG-1113: --- this all looks to be excellent - and the new docs are a vast imporvement. any idea on how quickly this will actually be released? > Plugin does not support using custom checkstyle XML config file > --- > > Key: MNG-1113 > URL: http://jira.codehaus.org/browse/MNG-1113 > Project: Maven 2 > Type: Bug > Components: maven-checkstyle-plugin > Versions: 2.0-beta-3 > Reporter: Vincent Massol > Assignee: John Casey > Attachments: CheckstyleReport.java, MNG-1113-maven-checkstyle-plugin.patch, > checkstyle-config-file.patch, checkstyle-config-location-and-docs.tar.bz2, > recommended.txt > > > The plugin source code says: > /** > * Specifies the location of the checkstyle properties that will be used > to check the source. > * > * @parameter > */ > private File propertiesFile; > But in practice it's only loading *properties* and not the XML. The > getConfigFile() method is not right and needs to be modified to take into > account a custom checkstyle config file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1113) Plugin does not support using custom checkstyle XML config file
[ http://jira.codehaus.org/browse/MNG-1113?page=comments#action_52378 ] Joakim Erdfelt commented on MNG-1113: - Update to last comment. Live (err Static) site can be found at http://joakim.erdfelt.com/checkstyle/ for easy perusal. > Plugin does not support using custom checkstyle XML config file > --- > > Key: MNG-1113 > URL: http://jira.codehaus.org/browse/MNG-1113 > Project: Maven 2 > Type: Bug > Components: maven-checkstyle-plugin > Versions: 2.0-beta-3 > Reporter: Vincent Massol > Assignee: John Casey > Attachments: CheckstyleReport.java, MNG-1113-maven-checkstyle-plugin.patch, > checkstyle-config-file.patch, checkstyle-config-location-and-docs.tar.bz2, > recommended.txt > > > The plugin source code says: > /** > * Specifies the location of the checkstyle properties that will be used > to check the source. > * > * @parameter > */ > private File propertiesFile; > But in practice it's only loading *properties* and not the XML. The > getConfigFile() method is not right and needs to be modified to take into > account a custom checkstyle config file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1113) Plugin does not support using custom checkstyle XML config file
[ http://jira.codehaus.org/browse/MNG-1113?page=comments#action_52277 ] Dave Sag commented on MNG-1113: --- sounds good to me - could you make sure the documentation of the variuous input params gets updated too as there were some undocumented inputs with weird outcomes - eg what is useFile for? whatever you specify there gets turned into a blank file, which seems like wrong behaviour to me. > Plugin does not support using custom checkstyle XML config file > --- > > Key: MNG-1113 > URL: http://jira.codehaus.org/browse/MNG-1113 > Project: Maven 2 > Type: Bug > Components: maven-checkstyle-plugin > Versions: 2.0-beta-3 > Reporter: Vincent Massol > Assignee: John Casey > Attachments: CheckstyleReport.java, MNG-1113-maven-checkstyle-plugin.patch, > checkstyle-config-file.patch, recommended.txt > > > The plugin source code says: > /** > * Specifies the location of the checkstyle properties that will be used > to check the source. > * > * @parameter > */ > private File propertiesFile; > But in practice it's only loading *properties* and not the XML. The > getConfigFile() method is not right and needs to be modified to take into > account a custom checkstyle config file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1113) Plugin does not support using custom checkstyle XML config file
[ http://jira.codehaus.org/browse/MNG-1113?page=comments#action_52271 ] Indrajit Raychaudhuri commented on MNG-1113: They appear similar (can be linked as 'related' if not 'duplicate'). The description of MNG-587 is more appropriate than the description of this one. +1 with John's plan of action (IMHO, true for MNG-587 as well). For anything else, new issues can be filed appropriately. > Plugin does not support using custom checkstyle XML config file > --- > > Key: MNG-1113 > URL: http://jira.codehaus.org/browse/MNG-1113 > Project: Maven 2 > Type: Bug > Components: maven-checkstyle-plugin > Versions: 2.0-beta-3 > Reporter: Vincent Massol > Assignee: John Casey > Attachments: CheckstyleReport.java, MNG-1113-maven-checkstyle-plugin.patch, > checkstyle-config-file.patch, recommended.txt > > > The plugin source code says: > /** > * Specifies the location of the checkstyle properties that will be used > to check the source. > * > * @parameter > */ > private File propertiesFile; > But in practice it's only loading *properties* and not the XML. The > getConfigFile() method is not right and needs to be modified to take into > account a custom checkstyle config file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1113) Plugin does not support using custom checkstyle XML config file
[ http://jira.codehaus.org/browse/MNG-1113?page=comments#action_52268 ] John Casey commented on MNG-1113: - What's the difference between this issue and MNG-587? > Plugin does not support using custom checkstyle XML config file > --- > > Key: MNG-1113 > URL: http://jira.codehaus.org/browse/MNG-1113 > Project: Maven 2 > Type: Bug > Components: maven-checkstyle-plugin > Versions: 2.0-beta-3 > Reporter: Vincent Massol > Assignee: John Casey > Attachments: CheckstyleReport.java, MNG-1113-maven-checkstyle-plugin.patch, > checkstyle-config-file.patch, recommended.txt > > > The plugin source code says: > /** > * Specifies the location of the checkstyle properties that will be used > to check the source. > * > * @parameter > */ > private File propertiesFile; > But in practice it's only loading *properties* and not the XML. The > getConfigFile() method is not right and needs to be modified to take into > account a custom checkstyle config file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1113) Plugin does not support using custom checkstyle XML config file
[ http://jira.codehaus.org/browse/MNG-1113?page=comments#action_52266 ]
John Casey commented on MNG-1113:
-
I'm trying to make sense of this whole thing...patch #3
(checkstyle-config-file.patch) would seem to make the most sense to me, if our
goal here is to make the checkstyle plugin work with a project-defined custom
configuration file. I believe it's consistent with our approach in other
plugins, and it would of course be bad form to specify a config file outside of
${basedir}. This will maximize portability, as it's unreasonable to say that
any custom config file be reachable from an HTTP server or other external,
location-independent source (which may present its own portability concerns).
If we have other issues with the checkstyle plugin than custom XML
configuration files, can we please make sure they are filed in separate issues,
against the maven-checkstyle-plugin component? Otherwise, it'll be hard to know
what we're trying to achieve here, or when it's really fixed.
So, my plan: apply checkstyle-config-file.patch and close this issue. Is this
alright with everyone?
> Plugin does not support using custom checkstyle XML config file
> ---
>
> Key: MNG-1113
> URL: http://jira.codehaus.org/browse/MNG-1113
> Project: Maven 2
> Type: Bug
> Components: maven-checkstyle-plugin
> Versions: 2.0-beta-3
> Reporter: Vincent Massol
> Assignee: Edwin Punzalan
> Attachments: CheckstyleReport.java, MNG-1113-maven-checkstyle-plugin.patch,
> checkstyle-config-file.patch, recommended.txt
>
>
> The plugin source code says:
> /**
> * Specifies the location of the checkstyle properties that will be used
> to check the source.
> *
> * @parameter
> */
> private File propertiesFile;
> But in practice it's only loading *properties* and not the XML. The
> getConfigFile() method is not right and needs to be modified to take into
> account a custom checkstyle config file.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1113) Plugin does not support using custom checkstyle XML config file
[ http://jira.codehaus.org/browse/MNG-1113?page=comments#action_51309 ] Michael Böckling commented on MNG-1113: --- I second that, also it would be really nice if checkstyle-4.0.beta6 could be used. The Eclipse checkstyle plugin uses that since some time now. Of course the above was just a quick proof-of-concept, I certainly wouldn't use an absolute path in a production build. Besides, the presence of a checkstyle config could easily be checked by the verifier plugin in the entry-test phase. > Plugin does not support using custom checkstyle XML config file > --- > > Key: MNG-1113 > URL: http://jira.codehaus.org/browse/MNG-1113 > Project: Maven 2 > Type: Bug > Components: maven-checkstyle-plugin > Versions: 2.0-beta-3 > Reporter: Vincent Massol > Assignee: Edwin Punzalan > Attachments: CheckstyleReport.java, MNG-1113-maven-checkstyle-plugin.patch, > checkstyle-config-file.patch, recommended.txt > > > The plugin source code says: > /** > * Specifies the location of the checkstyle properties that will be used > to check the source. > * > * @parameter > */ > private File propertiesFile; > But in practice it's only loading *properties* and not the XML. The > getConfigFile() method is not right and needs to be modified to take into > account a custom checkstyle config file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1113) Plugin does not support using custom checkstyle XML config file
[ http://jira.codehaus.org/browse/MNG-1113?page=comments#action_51303 ] Dave Sag commented on MNG-1113: --- Edwin I am a little confused by your reasoning there. surely the format file specified could be part of the project and thus available for any developer checking out the source and building. this is how we work anyway. this plugin is quite a mess it seems right now - could someone please take all of the supplied patches / discussion on provision of a custom config file and build a new release? it's been a month and half now since these issues were raised. > Plugin does not support using custom checkstyle XML config file > --- > > Key: MNG-1113 > URL: http://jira.codehaus.org/browse/MNG-1113 > Project: Maven 2 > Type: Bug > Components: maven-checkstyle-plugin > Versions: 2.0-beta-3 > Reporter: Vincent Massol > Assignee: Edwin Punzalan > Attachments: CheckstyleReport.java, MNG-1113-maven-checkstyle-plugin.patch, > checkstyle-config-file.patch, recommended.txt > > > The plugin source code says: > /** > * Specifies the location of the checkstyle properties that will be used > to check the source. > * > * @parameter > */ > private File propertiesFile; > But in practice it's only loading *properties* and not the XML. The > getConfigFile() method is not right and needs to be modified to take into > account a custom checkstyle config file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1113) Plugin does not support using custom checkstyle XML config file
[ http://jira.codehaus.org/browse/MNG-1113?page=comments#action_51282 ] Edwin Punzalan commented on MNG-1113: - Actually, adding the custom checkers is not currently the problem. The reason why this is still not fixed is bec if that configuration is to be checked in an SCM, the user who'd checkout your build would fail bec the location of the formatFile will not be the same. Thus the configuration will not be very effective. > Plugin does not support using custom checkstyle XML config file > --- > > Key: MNG-1113 > URL: http://jira.codehaus.org/browse/MNG-1113 > Project: Maven 2 > Type: Bug > Components: maven-checkstyle-plugin > Versions: 2.0-beta-3 > Reporter: Vincent Massol > Assignee: Edwin Punzalan > Attachments: CheckstyleReport.java, MNG-1113-maven-checkstyle-plugin.patch, > checkstyle-config-file.patch, recommended.txt > > > The plugin source code says: > /** > * Specifies the location of the checkstyle properties that will be used > to check the source. > * > * @parameter > */ > private File propertiesFile; > But in practice it's only loading *properties* and not the XML. The > getConfigFile() method is not right and needs to be modified to take into > account a custom checkstyle config file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1113) Plugin does not support using custom checkstyle XML config file
[ http://jira.codehaus.org/browse/MNG-1113?page=comments#action_51253 ] Michael Böckling commented on MNG-1113: --- Ok, I found out how to add your own checker classes and use them from whithin the custom XML configuration. The trick is to add a Jar containing your custom extensions as plugin dependency (didn't realize that was possible, i'm more and more in awe of M2). Wouldn't hurt to add it to the documentation, too. Here is a sample plugin entry from my POM, maybe it will help someone (this assumes the above modificationst to CheckstyleReport were made): org.apache.maven.plugins maven-checkstyle-plugin 2.0-beta-3-SNAPSHOT com.giniality.maven.checkstyle checkstyle-extensions 1.0-SNAPSHOT validate checkstyle C:/DEVELOPMENT/Workspaces/Standard/TAJ-1-CodingStandardsConfig/conf/TAJ-1-CheckstyleProfile_v1.0.xml > Plugin does not support using custom checkstyle XML config file > --- > > Key: MNG-1113 > URL: http://jira.codehaus.org/browse/MNG-1113 > Project: Maven 2 > Type: Bug > Components: maven-checkstyle-plugin > Versions: 2.0-beta-3 > Reporter: Vincent Massol > Assignee: Edwin Punzalan > Attachments: CheckstyleReport.java, MNG-1113-maven-checkstyle-plugin.patch, > checkstyle-config-file.patch, recommended.txt > > > The plugin source code says: > /** > * Specifies the location of the checkstyle properties that will be used > to check the source. > * > * @parameter > */ > private File propertiesFile; > But in practice it's only loading *properties* and not the XML. The > getConfigFile() method is not right and needs to be modified to take into > account a custom checkstyle config file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1113) Plugin does not support using custom checkstyle XML config file
[ http://jira.codehaus.org/browse/MNG-1113?page=comments#action_51249 ] Michael Böckling commented on MNG-1113: --- Same problem here - never imagined that one would actually hack a Checkstyle plugin whithout offering this possibility. I tried the attachment "recommended.txt" with the latest SVN checkout, but it doesn't even compile. I fixed the errors (and a bug) and uploaded it. To make the File property work, it is necessary to upgrade the commons-beanutils dependency in the POM to 1.7.0, else it won't work. Updating the checkstyle dependency to 4.0-beta6 won't hurt either, I use it since some time now and there are no problems. Anybody got an idea how to make custom checker classes work? I know its not yet implemented, but if somebody could point me into the right direction... I wrote quite a few custom checks, adding them as dependency to the project POM won't do the trick... > Plugin does not support using custom checkstyle XML config file > --- > > Key: MNG-1113 > URL: http://jira.codehaus.org/browse/MNG-1113 > Project: Maven 2 > Type: Bug > Components: maven-checkstyle-plugin > Versions: 2.0-beta-3 > Reporter: Vincent Massol > Assignee: Edwin Punzalan > Attachments: MNG-1113-maven-checkstyle-plugin.patch, > checkstyle-config-file.patch, recommended.txt > > > The plugin source code says: > /** > * Specifies the location of the checkstyle properties that will be used > to check the source. > * > * @parameter > */ > private File propertiesFile; > But in practice it's only loading *properties* and not the XML. The > getConfigFile() method is not right and needs to be modified to take into > account a custom checkstyle config file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1113) Plugin does not support using custom checkstyle XML config file
[ http://jira.codehaus.org/browse/MNG-1113?page=comments#action_49798 ] Dave Sag commented on MNG-1113: --- so what is the useFile field for? would it be too much trouble to change the mojo such that the property is called configFile and add some documentation explainin that it's an optional config file. then the propertiesFile can be used for its real purpose, (as per the comment from Mark Kuzmycz above). and please document what useFile is actually for :-) where i work our coding standards diverge quite a bit from the sun standard. (something I am trying to fix) cheers dave > Plugin does not support using custom checkstyle XML config file > --- > > Key: MNG-1113 > URL: http://jira.codehaus.org/browse/MNG-1113 > Project: Maven 2 > Type: Bug > Components: maven-checkstyle-plugin > Versions: 2.0-beta-3 > Reporter: Vincent Massol > Assignee: Edwin Punzalan > Attachments: MNG-1113-maven-checkstyle-plugin.patch, recommended.txt > > > The plugin source code says: > /** > * Specifies the location of the checkstyle properties that will be used > to check the source. > * > * @parameter > */ > private File propertiesFile; > But in practice it's only loading *properties* and not the XML. The > getConfigFile() method is not right and needs to be modified to take into > account a custom checkstyle config file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1113) Plugin does not support using custom checkstyle XML config file
[ http://jira.codehaus.org/browse/MNG-1113?page=comments#action_49792 ] Brett Porter commented on MNG-1113: --- Vincent, what do you think of this patch? > Plugin does not support using custom checkstyle XML config file > --- > > Key: MNG-1113 > URL: http://jira.codehaus.org/browse/MNG-1113 > Project: Maven 2 > Type: Bug > Components: maven-checkstyle-plugin > Versions: 2.0-beta-3 > Reporter: Vincent Massol > Assignee: Edwin Punzalan > Attachments: MNG-1113-maven-checkstyle-plugin.patch, recommended.txt > > > The plugin source code says: > /** > * Specifies the location of the checkstyle properties that will be used > to check the source. > * > * @parameter > */ > private File propertiesFile; > But in practice it's only loading *properties* and not the XML. The > getConfigFile() method is not right and needs to be modified to take into > account a custom checkstyle config file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1113) Plugin does not support using custom checkstyle XML config file
[ http://jira.codehaus.org/browse/MNG-1113?page=comments#action_49788 ] Edwin Punzalan commented on MNG-1113: - Hi David. The patch will make the propertiesFile kind'a incorrectly named bec it would be accepting XML configurations. To use your custom configuration, the patch should be applied first. Then you can put your XML configuration into propertiesFile. > Plugin does not support using custom checkstyle XML config file > --- > > Key: MNG-1113 > URL: http://jira.codehaus.org/browse/MNG-1113 > Project: Maven 2 > Type: Bug > Components: maven-checkstyle-plugin > Versions: 2.0-beta-3 > Reporter: Vincent Massol > Assignee: Edwin Punzalan > Attachments: MNG-1113-maven-checkstyle-plugin.patch, recommended.txt > > > The plugin source code says: > /** > * Specifies the location of the checkstyle properties that will be used > to check the source. > * > * @parameter > */ > private File propertiesFile; > But in practice it's only loading *properties* and not the XML. The > getConfigFile() method is not right and needs to be modified to take into > account a custom checkstyle config file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1113) Plugin does not support using custom checkstyle XML config file
[ http://jira.codehaus.org/browse/MNG-1113?page=comments#action_49779 ] David Parry commented on MNG-1113: -- But it's not a "Properties" file that's needed here, it's the Checkstyle XML configuration file, which contains XML, not key-value pairs. Either this needs to be renamed (to configFile or similar), or you're talking about the wrong thing. The default configuration files, (e.g. "sun") have some quite wrong-headed settings in them that are just plain wrong in certain circumstances. For instance, it checks for trailing white spaces on blank lines... yet, my editor's auto-indenting works by inserting spaces to the current indent level, regardless of whether it's a blank line or not. A lot of editors behave this way. Trying to run Checkstyle over my otherwise-checkstyle-correct code with this setting on produces 1000s of errors. And, as Dave Sag mentions, requesting Javadoc comments for private fields is crazy overkill. So, we need to have a custom configuration. Can i assume that there is NO WAY to do this at the moment? > Plugin does not support using custom checkstyle XML config file > --- > > Key: MNG-1113 > URL: http://jira.codehaus.org/browse/MNG-1113 > Project: Maven 2 > Type: Bug > Components: maven-checkstyle-plugin > Versions: 2.0-beta-3 > Reporter: Vincent Massol > Assignee: Edwin Punzalan > Attachments: MNG-1113-maven-checkstyle-plugin.patch, recommended.txt > > > The plugin source code says: > /** > * Specifies the location of the checkstyle properties that will be used > to check the source. > * > * @parameter > */ > private File propertiesFile; > But in practice it's only loading *properties* and not the XML. The > getConfigFile() method is not right and needs to be modified to take into > account a custom checkstyle config file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1113) Plugin does not support using custom checkstyle XML config file
[ http://jira.codehaus.org/browse/MNG-1113?page=comments#action_49773 ] Edwin Punzalan commented on MNG-1113: - you should use propertiesFile instead > Plugin does not support using custom checkstyle XML config file > --- > > Key: MNG-1113 > URL: http://jira.codehaus.org/browse/MNG-1113 > Project: Maven 2 > Type: Bug > Components: maven-checkstyle-plugin > Versions: 2.0-beta-3 > Reporter: Vincent Massol > Assignee: Edwin Punzalan > Attachments: MNG-1113-maven-checkstyle-plugin.patch, recommended.txt > > > The plugin source code says: > /** > * Specifies the location of the checkstyle properties that will be used > to check the source. > * > * @parameter > */ > private File propertiesFile; > But in practice it's only loading *properties* and not the XML. The > getConfigFile() method is not right and needs to be modified to take into > account a custom checkstyle config file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1113) Plugin does not support using custom checkstyle XML config file
[ http://jira.codehaus.org/browse/MNG-1113?page=comments#action_49660 ] Dave Sag commented on MNG-1113: --- okay using the latest released plugin i got rid of the propertyFile tag and replaced it with a useFile tag (as seen in http://maven.apache.org/plugins/maven-checkstyle-plugin/checkstyle-mojo.html) this had the effect of erasing my checkstyle-src.xml config file and replaceing it with the follwing text: Starting audit... Audit done. this is a bit hopeless. could you please tell me exactly what I need to do to get checkstyle to use a custom config file. i see on the users list there are a few people moaning about this. > Plugin does not support using custom checkstyle XML config file > --- > > Key: MNG-1113 > URL: http://jira.codehaus.org/browse/MNG-1113 > Project: Maven 2 > Type: Bug > Components: maven-checkstyle-plugin > Versions: 2.0-beta-3 > Reporter: Vincent Massol > Assignee: Edwin Punzalan > Attachments: MNG-1113-maven-checkstyle-plugin.patch, recommended.txt > > > The plugin source code says: > /** > * Specifies the location of the checkstyle properties that will be used > to check the source. > * > * @parameter > */ > private File propertiesFile; > But in practice it's only loading *properties* and not the XML. The > getConfigFile() method is not right and needs to be modified to take into > account a custom checkstyle config file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1113) Plugin does not support using custom checkstyle XML config file
[ http://jira.codehaus.org/browse/MNG-1113?page=comments#action_48020 ] Dave Sag commented on MNG-1113: --- Hi Vincent, okay i see what you mean. I had overlooked that second option. I can confirm however that the issue at hand for me is the 1st, namely being able to configure a specific rule set. cheer dave > Plugin does not support using custom checkstyle XML config file > --- > > Key: MNG-1113 > URL: http://jira.codehaus.org/browse/MNG-1113 > Project: Maven 2 > Type: Bug > Components: maven-checkstyle-plugin > Versions: 2.0-beta-3 > Reporter: Vincent Massol > > > The plugin source code says: > /** > * Specifies the location of the checkstyle properties that will be used > to check the source. > * > * @parameter > */ > private File propertiesFile; > But in practice it's only loading *properties* and not the XML. The > getConfigFile() method is not right and needs to be modified to take into > account a custom checkstyle config file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1113) Plugin does not support using custom checkstyle XML config file
[ http://jira.codehaus.org/browse/MNG-1113?page=comments#action_48015 ] Vincent Massol commented on MNG-1113: - Dave, In checkstyle there are 2 things that you could configure as a user of checkstyle: - the list of rules you want to apply on your projects and their parameters. See http://checkstyle.sourceforge.net/config.html - custom rules that you can write in java and apply on your projects. Checkstyle comes bundled with hundreds of existing rules but you can add your own. See http://checkstyle.sourceforge.net/writingchecks.html I thought MNG-587 was about this second point but I may have misunderstood.;. > Plugin does not support using custom checkstyle XML config file > --- > > Key: MNG-1113 > URL: http://jira.codehaus.org/browse/MNG-1113 > Project: Maven 2 > Type: Bug > Components: maven-checkstyle-plugin > Versions: 2.0-beta-3 > Reporter: Vincent Massol > > > The plugin source code says: > /** > * Specifies the location of the checkstyle properties that will be used > to check the source. > * > * @parameter > */ > private File propertiesFile; > But in practice it's only loading *properties* and not the XML. The > getConfigFile() method is not right and needs to be modified to take into > account a custom checkstyle config file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1113) Plugin does not support using custom checkstyle XML config file
[ http://jira.codehaus.org/browse/MNG-1113?page=comments#action_48012 ] Dave Sag commented on MNG-1113: --- I am a little confused - what is there to configure in checkstyle apart from the rules? let me restate what i am trying to achieve. I have two checkstyle.xml files - one is checkstyle-src.xml which has very strict rules for the main source code, and checkstyle-test.xml which has a more relaxed set of rules for the test code - ie i don't care about package.html files or javadocs on private fields. i discovered recently that no matter what xml file i set as the propertiesFile in my config i get the default sun format. but if i refer to a properties file that is not actually there I get aa build failure when generating a checkstyle report. other than the rules set expressed in xml, i can't think what other checkstyle properties file i might wish to point to. > Plugin does not support using custom checkstyle XML config file > --- > > Key: MNG-1113 > URL: http://jira.codehaus.org/browse/MNG-1113 > Project: Maven 2 > Type: Bug > Components: maven-checkstyle-plugin > Versions: 2.0-beta-3 > Reporter: Vincent Massol > > > The plugin source code says: > /** > * Specifies the location of the checkstyle properties that will be used > to check the source. > * > * @parameter > */ > private File propertiesFile; > But in practice it's only loading *properties* and not the XML. The > getConfigFile() method is not right and needs to be modified to take into > account a custom checkstyle config file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1113) Plugin does not support using custom checkstyle XML config file
[ http://jira.codehaus.org/browse/MNG-1113?page=comments#action_48003 ] Vincent Massol commented on MNG-1113: - Brett: No it's not. A custom ruleset is a set of custom checkstyle rules. Whereas here we are talking about checkstyle configuration (not rules). > Plugin does not support using custom checkstyle XML config file > --- > > Key: MNG-1113 > URL: http://jira.codehaus.org/browse/MNG-1113 > Project: Maven 2 > Type: Bug > Components: maven-checkstyle-plugin > Versions: 2.0-beta-3 > Reporter: Vincent Massol > > > The plugin source code says: > /** > * Specifies the location of the checkstyle properties that will be used > to check the source. > * > * @parameter > */ > private File propertiesFile; > But in practice it's only loading *properties* and not the XML. The > getConfigFile() method is not right and needs to be modified to take into > account a custom checkstyle config file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1113) Plugin does not support using custom checkstyle XML config file
[ http://jira.codehaus.org/browse/MNG-1113?page=comments#action_47992 ] Brett Porter commented on MNG-1113: --- is this a duplicate of MNG-587? > Plugin does not support using custom checkstyle XML config file > --- > > Key: MNG-1113 > URL: http://jira.codehaus.org/browse/MNG-1113 > Project: Maven 2 > Type: Bug > Components: maven-checkstyle-plugin > Versions: 2.0-beta-3 > Reporter: Vincent Massol > > > The plugin source code says: > /** > * Specifies the location of the checkstyle properties that will be used > to check the source. > * > * @parameter > */ > private File propertiesFile; > But in practice it's only loading *properties* and not the XML. The > getConfigFile() method is not right and needs to be modified to take into > account a custom checkstyle config file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
