[jira] Commented: (MPECLIPSE-56) Only create .classpath and javabuilder if sources are present

2004-11-16 Thread jira
The following comment has been added to this issue:

 Author: David Eric Pugh
Created: Tue, 16 Nov 2004 5:53 AM
   Body:
I have applied the patch, and refactored the unit tests to use multiproject, so 
eclipse is now a good example!  I also added some tests for this patch.
-
View this comment:
  http://jira.codehaus.org/browse/MPECLIPSE-56?page=comments#action_26459

-
View the issue:
  http://jira.codehaus.org/browse/MPECLIPSE-56

Here is an overview of the issue:
-
Key: MPECLIPSE-56
Summary: Only create .classpath and javabuilder if sources are present
   Type: Bug

 Status: Unassigned
   Priority: Major

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

Project: maven-eclipse-plugin
   Versions:
 1.9

   Assignee: 
   Reporter: Archimedes Trajano

Created: Wed, 10 Nov 2004 2:13 AM
Updated: Tue, 16 Nov 2004 5:53 AM

Description:
Only create .classpath and javabuilder if sources are present


-
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: Writing plugin testcases (WAS Re: [jira] Commented: (MPECLIPSE-56)Only create .classpath and javabuilder if sources are present)

2004-11-12 Thread Eric Pugh

- what layout should we use by default? should we use the 'single
 project with one goal per testcase' or the 'multi-project with one
 project per testcase'?
I think that a good first place is even just letting people know that it is
possible, and linking to some good examples.  Unless you are actually
writing some sort of test framework generator, I think that there isn't a
default layout.   I would suggest that if you have lots of different types
of POM's whose differing structure affects the plugin, then go with
multiproject.  But it's easy to move from single-project to multi-project,
so start with single project.

 - should we keep the test0? on the multi-project testcases or should we
 use a meaningful name for the directories?
Meaningful names.  If I am adding a new testcase, I should be able to divine
which project to add it to, or to create a new project testcase.  test0,
test1 doesn't help me at all.

 - once we migrate a single-project to the multi-project, should we use a
 standard name for the project with most of the testcases (i.e., with the
 maven.xml that was originally in the plugin)?
I don't think it really matters.  They all get run anyway.

Eric


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (MPECLIPSE-56) Only create .classpath and javabuilder if sources are present

2004-11-11 Thread jira
The following comment has been added to this issue:

 Author: Felipe Leme
Created: Thu, 11 Nov 2004 8:23 AM
   Body:
Archimedes/Eric,

I'd like to add a test case for this fix. The test case per se wouldn't be 
hard, but it would require a new project.xml (without a source), which would in 
turn require that we break the test cases structure into multi-project.

So, any better idea on how to test it?

-- Felipe

-
View this comment:
  http://jira.codehaus.org/browse/MPECLIPSE-56?page=comments#action_26326

-
View the issue:
  http://jira.codehaus.org/browse/MPECLIPSE-56

Here is an overview of the issue:
-
Key: MPECLIPSE-56
Summary: Only create .classpath and javabuilder if sources are present
   Type: Bug

 Status: Unassigned
   Priority: Major

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

Project: maven-eclipse-plugin
   Versions:
 1.9

   Assignee: 
   Reporter: Archimedes Trajano

Created: Wed, 10 Nov 2004 2:13 AM
Updated: Thu, 11 Nov 2004 8:23 AM

Description:
Only create .classpath and javabuilder if sources are present


-
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (MPECLIPSE-56) Only create .classpath and javabuilder if sources are present

2004-11-11 Thread jira
The following comment has been added to this issue:

 Author: David Eric Pugh
Created: Thu, 11 Nov 2004 8:31 AM
   Body:
to be honest, we need to make it a multiproject setup anyway for the tests..  
there are too many different project.xml structures, our tests are becoming 
more and more intertwined..  For instance, if you have cactus plugin or not.. 

Feel free to break them up (see hibernate plugin for an example).

Eric
-
View this comment:
  http://jira.codehaus.org/browse/MPECLIPSE-56?page=comments#action_26327

-
View the issue:
  http://jira.codehaus.org/browse/MPECLIPSE-56

Here is an overview of the issue:
-
Key: MPECLIPSE-56
Summary: Only create .classpath and javabuilder if sources are present
   Type: Bug

 Status: Unassigned
   Priority: Major

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

Project: maven-eclipse-plugin
   Versions:
 1.9

   Assignee: 
   Reporter: Archimedes Trajano

Created: Wed, 10 Nov 2004 2:13 AM
Updated: Thu, 11 Nov 2004 8:31 AM

Description:
Only create .classpath and javabuilder if sources are present


-
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (MPECLIPSE-56) Only create .classpath and javabuilder if sources are present

2004-11-11 Thread jira
The following comment has been added to this issue:

 Author: Archimedes Trajano
Created: Thu, 11 Nov 2004 9:55 AM
   Body:
Is there any documentation on how to create non-java plugin test cases?  I am 
still confused on how to write them.
-
View this comment:
  http://jira.codehaus.org/browse/MPECLIPSE-56?page=comments#action_26330

-
View the issue:
  http://jira.codehaus.org/browse/MPECLIPSE-56

Here is an overview of the issue:
-
Key: MPECLIPSE-56
Summary: Only create .classpath and javabuilder if sources are present
   Type: Bug

 Status: Unassigned
   Priority: Major

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

Project: maven-eclipse-plugin
   Versions:
 1.9

   Assignee: 
   Reporter: Archimedes Trajano

Created: Wed, 10 Nov 2004 2:13 AM
Updated: Thu, 11 Nov 2004 9:55 AM

Description:
Only create .classpath and javabuilder if sources are present


-
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (MPECLIPSE-56) Only create .classpath and javabuilder if sources are present

2004-11-11 Thread jira
The following comment has been added to this issue:

 Author: David Eric Pugh
Created: Thu, 11 Nov 2004 10:54 AM
   Body:
It's mostly a matter of learning by example.  If you look at 
maven-plugins/hibernate/src/test-plugin/ there is a good example of using 
multiproject to test a collection of seperate projects and testcases.  Most of 
the plugins have testcases to look at in maven-plugins/[PLUGIN]/src/test-plugin.

Eric
-
View this comment:
  http://jira.codehaus.org/browse/MPECLIPSE-56?page=comments#action_26333

-
View the issue:
  http://jira.codehaus.org/browse/MPECLIPSE-56

Here is an overview of the issue:
-
Key: MPECLIPSE-56
Summary: Only create .classpath and javabuilder if sources are present
   Type: Bug

 Status: Unassigned
   Priority: Major

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

Project: maven-eclipse-plugin
   Versions:
 1.9

   Assignee: 
   Reporter: Archimedes Trajano

Created: Wed, 10 Nov 2004 2:13 AM
Updated: Thu, 11 Nov 2004 10:54 AM

Description:
Only create .classpath and javabuilder if sources are present


-
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Writing plugin testcases (WAS Re: [jira] Commented: (MPECLIPSE-56) Only create .classpath and javabuilder if sources are present)

2004-11-11 Thread Felipe Leme
Archimedes,

Unfortunately, Eric is right - you gotta 'learn by examples', at least
for now. I will comment how to do it in that Jira issue - let's use this
thread for generic testcase layout issue.

BTW, I think it's time to write a documentation about it, including how
to write the test cases, what to test and Jelly tips. I could write such
doc, but first we need to define some stuff:

- what layout should we use by default? should we use the 'single
project with one goal per testcase' or the 'multi-project with one
project per testcase'? 
  Let me explain better: usually, the single-project is more elegant and
simpler. But in cases where we need diferent POMs for each tests, we
need the multi-project setup. 
  So the question really is: should we start with a single-project and
migrate to multi-project only when we need to or should we start with a
multi-project?
- should we keep the test0? on the multi-project testcases or should we
use a meaningful name for the directories?
- once we migrate a single-project to the multi-project, should we use a
standard name for the project with most of the testcases (i.e., with the
maven.xml that was originally in the plugin)?

These questions are not hard to answer, but we need to reach a consensus
(and refactor the current testcases) before we write such documentation.

-- Felipe



On Thu, 2004-11-11 at 13:55, [EMAIL PROTECTED] wrote:
 The following comment has been added to this issue:
 
  Author: David Eric Pugh
 Created: Thu, 11 Nov 2004 10:54 AM
Body:
 It's mostly a matter of learning by example.  If you look at 
 maven-plugins/hibernate/src/test-plugin/ there is a good example of using 
 multiproject to test a collection of seperate projects and testcases.  Most 
 of the plugins have testcases to look at in 
 maven-plugins/[PLUGIN]/src/test-plugin.
 
 Eric



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (MPECLIPSE-56) Only create .classpath and javabuilder if sources are present

2004-11-11 Thread jira
The following comment has been added to this issue:

 Author: Felipe Leme
Created: Thu, 11 Nov 2004 11:24 PM
   Body:
Archimedes,

Basically, what you have to do in this case is setup a project that doesn't 
have the source defined, run the eclipse goal and then parse the generated 
.classpath/.project to see if it was generated correctly (and failing if it 
doesn't).

As Eric mentioned, the best way to understand how to achieve that is looking 
through other testcases. Also, you would need to create a new directory for 
this testcase, as it would require changing the current testcases POM.

-- Felipe
 
-
View this comment:
  http://jira.codehaus.org/browse/MPECLIPSE-56?page=comments#action_26345

-
View the issue:
  http://jira.codehaus.org/browse/MPECLIPSE-56

Here is an overview of the issue:
-
Key: MPECLIPSE-56
Summary: Only create .classpath and javabuilder if sources are present
   Type: Bug

 Status: Unassigned
   Priority: Major

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

Project: maven-eclipse-plugin
   Versions:
 1.9

   Assignee: 
   Reporter: Archimedes Trajano

Created: Wed, 10 Nov 2004 2:13 AM
Updated: Thu, 11 Nov 2004 11:24 PM

Description:
Only create .classpath and javabuilder if sources are present


-
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]