Re: API changes - was [VOTE] Release Apache Maven 4.0.0-alpha-2
On 21/10/2022 at 12:41:54 AM, Mark Derricutt wrote: > Merged and I’ll release in the morning - and run our main projects thru > with Maven 4.0.0 and see how it fares. > Doh - released the new tiles this morning ( should really have tested it again $work’s main project first tho) ): When running under 4.0.0-alpha-2 I now get: org.apache.maven.InternalErrorException: Internal error: com.google.inject.ProvisionException: Unable to provision, see the following errors: 1) [Guice/ErrorInjectingConstructor]: NoSuchMethodError: DefaultProjectBuilder: method 'void ()' not found at TilesProjectBuilder.(TilesProjectBuilder.groovy:29) while locating TilesProjectBuilder at ClassRealm[extension>io.repaint.maven:tiles-maven-plugin:2.31, parent: ClassLoaders$AppClassLoader@5b37e0d2] \_ installed by: WireModule -> PlexusBindingModule while locating ProjectBuilder at LocatorWiring at TilesMavenLifecycleParticipant.projectBuilder(TilesMavenLifecycleParticipant.groovy:105) \_ for field projectBuilder while locating TilesMavenLifecycleParticipant while locating Object annotated with * Larger trace: at com.google.inject.internal.InternalProvisionException.toProvisionException (InternalProvisionException.java:251) at com.google.inject.internal.InjectorImpl$1.get (InjectorImpl.java:1104) at org.eclipse.sisu.inject.Guice4$1.get (Guice4.java:162) at org.eclipse.sisu.inject.LazyBeanEntry.getValue (LazyBeanEntry.java:81) at org.eclipse.sisu.plexus.LazyPlexusBean.getValue (LazyPlexusBean.java:51) at org.eclipse.sisu.wire.EntryListAdapter$ValueIterator.next (EntryListAdapter.java:111) at java.util.AbstractCollection.addAll (AbstractCollection.java:337) at org.apache.maven.DefaultMaven.getProjectScopedExtensionComponents (DefaultMaven.java:543) at org.apache.maven.DefaultMaven.getExtensionComponents (DefaultMaven.java:518) at org.apache.maven.DefaultMaven.afterProjectsRead (DefaultMaven.java:420) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:297) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:248) at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:158) at org.apache.maven.cli.MavenCli.execute (MavenCli.java:1004) at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:307) at org.apache.maven.cli.MavenCli.main (MavenCli.java:204) at jdk.internal.reflect.DirectMethodHandleAccessor.invoke (DirectMethodHandleAccessor.java:104) at java.lang.reflect.Method.invoke (Method.java:578) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282) at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406) at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347) Caused by: java.lang.NoSuchMethodError: org.apache.maven.project.DefaultProjectBuilder: method 'void ()' not found at io.repaint.maven.tiles.TilesProjectBuilder. (TilesProjectBuilder.groovy) at io.repaint.maven.tiles.TilesProjectBuilder$$FastClassByGuice$$272625146.GUICE$TRAMPOLINE () at io.repaint.maven.tiles.TilesProjectBuilder$$FastClassByGuice$$272625146.apply () at com.google.inject.internal.DefaultConstructionProxyFactory$FastClassProxy.newInstance (DefaultConstructionProxyFactory.java:82) at com.google.inject.internal.ConstructorInjector.provision (ConstructorInjector.java:114) at com.google.inject.internal.ConstructorInjector.access$000 (ConstructorInjector.java:33) at com.google.inject.internal.ConstructorInjector$1.call (ConstructorInjector.java:98) at com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision (ProvisionListenerStackCallback.java:109) I actually see the IT tests in the repo failing with the 4.0.0 release (built via: ~/Applications/apache-maven-4.0.0-alpha-2/bin/mvn clean install -Prun-its I should set up GH action jobs for running with 4.x builds as well the 3.x version. Hrm -- "Great artists are extremely selfish and arrogant things" — Steven Wilson, Porcupine Tree
Re: API changes - was [VOTE] Release Apache Maven 4.0.0-alpha-2
On 20/10/2022 at 11:49:48 PM, Tamás Cservenák wrote: > created PR that should restore compatibility, moreover, it remains mvn 3 > and 4 compatible > (and some little cosmetic change to plexus xml) > Oh sweet! Kudos. Just triggered the build jobs with IT tests and all passed. Merged and I’ll release in the morning - and run our main projects thru with Maven 4.0.0 and see how it fares. Cheers Mark -- "Great artists are extremely selfish and arrogant things" — Steven Wilson, Porcupine Tree
Re: API changes - was [VOTE] Release Apache Maven 4.0.0-alpha-2
Howdy, created PR that should restore compatibility, moreover, it remains mvn 3 and 4 compatible (and some little cosmetic change to plexus xml) https://github.com/repaint-io/maven-tiles/pull/133 Thanks T On Thu, Oct 20, 2022 at 1:37 AM Mark Derricutt wrote: > Trying out the new 4.0.0-alpha-2 release I see our tiles-maven-plugin > doesn’t work: > > Caused by: java.lang.NoSuchMethodError: > org.apache.maven.project.DefaultProjectBuilder: method ()V not found > at io.repaint.maven.tiles.TilesProjectBuilder. > (TilesProjectBuilder.groovy) > at > > io.repaint.maven.tiles.TilesProjectBuilder$$FastClassByGuice$$257858534.GUICE$TRAMPOLINE > () > > Totally not a blocker for the release and will do additional tests on a > normal, but more a heads up of anyone with Mojos doing Project stuff - > guess I’ll be looking at a supporting version of tiles shortly. > > > > -- > "Great artists are extremely selfish and arrogant things" — Steven Wilson, > Porcupine Tree > > > On 15/10/2022 at 1:18:52 PM, Guillaume Nodet wrote: > > > I've staged a release candidate at > > https://repository.apache.org/content/repositories/maven-1811 > > > > The binaries are available at: > > > > > > > https://repository.apache.org/service/local/repositories/maven-1811/content/org/apache/maven/apache-maven/4.0.0-alpha-2/ > > > > The tag is available at: > > https://github.com/apache/maven/tree/maven-4.0.0-alpha-2 > > > > Please review and vote ! > > > > Cheers, > > Guillaume Nodet > > >
API changes - was [VOTE] Release Apache Maven 4.0.0-alpha-2
Trying out the new 4.0.0-alpha-2 release I see our tiles-maven-plugin doesn’t work: Caused by: java.lang.NoSuchMethodError: org.apache.maven.project.DefaultProjectBuilder: method ()V not found at io.repaint.maven.tiles.TilesProjectBuilder. (TilesProjectBuilder.groovy) at io.repaint.maven.tiles.TilesProjectBuilder$$FastClassByGuice$$257858534.GUICE$TRAMPOLINE () Totally not a blocker for the release and will do additional tests on a normal, but more a heads up of anyone with Mojos doing Project stuff - guess I’ll be looking at a supporting version of tiles shortly. -- "Great artists are extremely selfish and arrogant things" — Steven Wilson, Porcupine Tree On 15/10/2022 at 1:18:52 PM, Guillaume Nodet wrote: > I've staged a release candidate at > https://repository.apache.org/content/repositories/maven-1811 > > The binaries are available at: > > > https://repository.apache.org/service/local/repositories/maven-1811/content/org/apache/maven/apache-maven/4.0.0-alpha-2/ > > The tag is available at: > https://github.com/apache/maven/tree/maven-4.0.0-alpha-2 > > Please review and vote ! > > Cheers, > Guillaume Nodet >
