RE: Problems of EJB plugin and Dependencies download

2003-06-18 Thread Vincent Massol
Ok cool... pfeww... I'm lucky as I've implemented 2/ yesterday night
(now in CVS) :-)

Thanks
-Vincent

> -Original Message-
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
> Sent: 19 June 2003 08:03
> To: Maven Developers List
> Subject: Re: Problems of EJB plugin and Dependencies download
> 
> I'm +0 on 2/ and -1 on 1/
> --
> dIon Gillard, Multitask Consulting
> Blog:  http://blogs.codehaus.org/people/dion/
> Work:  http://www.multitask.com.au
> 
> 
> "Vincent Massol" <[EMAIL PROTECTED]> wrote on 19/06/2003 02:01:04
AM:
> 
> > Hi,
> >
> > The EJB plugin ejb:install goal installs its artifacts in
> > /ejbs/-.jar (note the "jar"
extension").
> >
> > However, the maven dependency resolver looks for a file named:
> > /ejbs/-.ejb (not the "ejb" extension)
> >
> > Thus it fails to find the artifact...
> >
> > Several solutions:
> >
> > 1/ All jar files (.ear, .jar, .war are considered of the "jar" type)
> >
> > 2/ The dependency resolver supports .jar extensions when using the
"ejb"
> > type. In other words there is mapping between "artifact type" and
> > "artifact extension" instead of assuming extension = .
> >
> > Currently the EJB, WAR and EAR plugins put their artifacts in
> > **/ejbs/**, **/wars/** and **/ears/**.
> >
> > What do we do?
> >
> > Thanks
> > -Vincent
> >
> >
> >
-
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Problems of EJB plugin and Dependencies download

2003-06-18 Thread dion
I'm +0 on 2/ and -1 on 1/
--
dIon Gillard, Multitask Consulting
Blog:  http://blogs.codehaus.org/people/dion/
Work:  http://www.multitask.com.au


"Vincent Massol" <[EMAIL PROTECTED]> wrote on 19/06/2003 02:01:04 AM:

> Hi,
> 
> The EJB plugin ejb:install goal installs its artifacts in
> /ejbs/-.jar (note the "jar" extension").
> 
> However, the maven dependency resolver looks for a file named:
> /ejbs/-.ejb (not the "ejb" extension)
> 
> Thus it fails to find the artifact...
> 
> Several solutions:
> 
> 1/ All jar files (.ear, .jar, .war are considered of the "jar" type)
> 
> 2/ The dependency resolver supports .jar extensions when using the "ejb"
> type. In other words there is mapping between "artifact type" and
> "artifact extension" instead of assuming extension = .
> 
> Currently the EJB, WAR and EAR plugins put their artifacts in
> **/ejbs/**, **/wars/** and **/ears/**.
> 
> What do we do?
> 
> Thanks
> -Vincent
> 
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 


RE: Problems of EJB plugin and Dependencies download

2003-06-18 Thread Vincent Massol
Michal,

I have committed a quick patch for EJB dependency handling so that
extensions for the EJB type artifacts is ".jar" and not ".ejb".

I hope I haven't broken anything. I have tested it successfully on my
current project.

Thanks
-Vincent

> -Original Message-
> From: Michal Maczka [mailto:[EMAIL PROTECTED]
> Sent: 18 June 2003 22:52
> To: Maven Developers List
> Subject: RE: Problems of EJB plugin and Dependencies download
> 
> > I see 2 solutions:
> >
> > 1/ Add a property called false and if found
the
> > said dependency is not added to the Classpath?
> >
> > or
> >
> > 2/ Define a list of well known artifact types. That would server 2
> > purposes:
> > a- to know if the said dependency type should be added to the
classpath
> > b- to know what extension this type has
> >
> > I prefer 2.
> >
> > -Vincent
> 
> Jason was saying that it will be possible to reuse some components of
> maven-new.
> 
> If we are not going to make I can also propose two other options:
> 
> 1) Add all artifacts to class path. I don't think people are using too
> many
> non "jar like" artifacts. Too many things in classspath makes no harm.
> 
> 
> Regarding your propositions:
> ad 1) -1 :  I think that option with marking deps in POM..is bad.  -1
> ad 2) +1   I did it already with XML based configuration files
sometimes
> ago. But think XML or even java properties are too heavy there.
>  Why just not put it to Java code?
> 
> Michal
> 
> P.S.
> 
> I would not rush with those changes for rc1.
> 
> 
> 
> 
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: Problems of EJB plugin and Dependencies download

2003-06-18 Thread Michal Maczka
> I see 2 solutions:
>
> 1/ Add a property called false and if found the
> said dependency is not added to the Classpath?
>
> or
>
> 2/ Define a list of well known artifact types. That would server 2
> purposes:
> a- to know if the said dependency type should be added to the classpath
> b- to know what extension this type has
>
> I prefer 2.
>
> -Vincent

Jason was saying that it will be possible to reuse some components of
maven-new.

If we are not going to make I can also propose two other options:

1) Add all artifacts to class path. I don't think people are using too many
non "jar like" artifacts. Too many things in classspath makes no harm.


Regarding your propositions:
ad 1) -1 :  I think that option with marking deps in POM..is bad.  -1
ad 2) +1   I did it already with XML based configuration files sometimes
ago. But think XML or even java properties are too heavy there.
 Why just not put it to Java code?

Michal

P.S.

I would not rush with those changes for rc1.





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: Problems of EJB plugin and Dependencies download

2003-06-18 Thread Vincent Massol


> -Original Message-
> From: Michal Maczka [mailto:[EMAIL PROTECTED]
> Sent: 18 June 2003 19:53
> To: Maven Developers List
> Subject: RE: Problems of EJB plugin and Dependencies download
> 
> This is partially fixed in maven-new (Repository Layout Service)
> So you can assign different layouts for different types.
> 
> E.g. for ejb it is (see layout-properties in maven-new/core/src/conf)
> # EJB
> ejb=${groupId}/ejbs/${artifactId}-${version}.jar
> 

ok. That's cool to know. However, my belief is that it still needs to be
fixed for Maven 1.0.

> There is one more problem with ejbs.
> 
> There are not added to build class path.
> 
> 
> This will be also fixed in maven-new (ArtifactHandlers)
> but I would propose a temporary hack in maven-old and to hard code
more
> artifact type
> which should be added to class path.
> 
> 
> see org.apache.maven.DependencyClasspathBuilder.
> 
> Michal
> 
> P.S.
> 
> 
> A workaround for 1st problem for ejbs is:
> 
> 
> ejb
> actual file name 
> 
> 
> AFAIK There is no workaround for 2nd problem,

I see 2 solutions:

1/ Add a property called false and if found the
said dependency is not added to the Classpath?

or

2/ Define a list of well known artifact types. That would server 2
purposes:
a- to know if the said dependency type should be added to the classpath
b- to know what extension this type has

I prefer 2.

-Vincent



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: Problems of EJB plugin and Dependencies download

2003-06-18 Thread Michal Maczka
This is partially fixed in maven-new (Repository Layout Service)
So you can assign different layouts for different types.

E.g. for ejb it is (see layout-properties in maven-new/core/src/conf)
# EJB
ejb=${groupId}/ejbs/${artifactId}-${version}.jar

There is one more problem with ejbs.

There are not added to build class path.


This will be also fixed in maven-new (ArtifactHandlers)
but I would propose a temporary hack in maven-old and to hard code more
artifact type
which should be added to class path.


see org.apache.maven.DependencyClasspathBuilder.

Michal

P.S.


A workaround for 1st problem for ejbs is:


ejb
actual file name 


AFAIK There is no workaround for 2nd problem,


> -Original Message-
> From: Vincent Massol [mailto:[EMAIL PROTECTED]
> Sent: Wednesday, June 18, 2003 6:01 PM
> To: 'Maven Developers List'
> Subject: Problems of EJB plugin and Dependencies download
>
>
> Hi,
>
> The EJB plugin ejb:install goal installs its artifacts in
> /ejbs/-.jar (note the "jar" extension").
>
> However, the maven dependency resolver looks for a file named:
> /ejbs/-.ejb (not the "ejb" extension)
>
> Thus it fails to find the artifact...
>
> Several solutions:
>
> 1/ All jar files (.ear, .jar, .war are considered of the "jar" type)
>
> 2/ The dependency resolver supports .jar extensions when using the "ejb"
> type. In other words there is mapping between "artifact type" and
> "artifact extension" instead of assuming extension = .
>
> Currently the EJB, WAR and EAR plugins put their artifacts in
> **/ejbs/**, **/wars/** and **/ears/**.
>
> What do we do?
>
> Thanks
> -Vincent
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
> --
> Newsowy portal INTERIA.PL >>> http://link.interia.pl/f1735
>
>
>



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Problems of EJB plugin and Dependencies download

2003-06-18 Thread Vincent Massol
Hi,

The EJB plugin ejb:install goal installs its artifacts in
/ejbs/-.jar (note the "jar" extension").

However, the maven dependency resolver looks for a file named:
/ejbs/-.ejb (not the "ejb" extension)

Thus it fails to find the artifact...

Several solutions:

1/ All jar files (.ear, .jar, .war are considered of the "jar" type)

2/ The dependency resolver supports .jar extensions when using the "ejb"
type. In other words there is mapping between "artifact type" and
"artifact extension" instead of assuming extension = .

Currently the EJB, WAR and EAR plugins put their artifacts in
**/ejbs/**, **/wars/** and **/ears/**.

What do we do?

Thanks
-Vincent


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]