Re: [CANCELED] [VOTE] Maven 3.2.4 Release

2014-12-13 Thread Hervé BOUTEMY
I can't reproduce the problem: see the logs in attachment

can you give me more details?


notice that from every changes we did on toolchains, the only expected visible 
change was on MNG-5718: custom toolchains need to be enhanced.
MNG-5719 wasn't supposed to have any impact on Tycho or any other project.
But perhaps you're using custom compoennt more tied to core than expected.

Regards,

Hervé

Le samedi 13 décembre 2014 00:03:38 Igor Fedorenko a écrit :
 Providing backwards compatibility shim seems to be quite
 straightforward, but there appears to be another problem. From what I
 can tell, current maven master breaks maven-toolchains-plugin 1.0, at
 least for some projects that work with maven 3.2.3.
 
 I've attached a trivial example that shows the problem with
 maven-toolchains-plugin plugin and will appreciate if somebody familiar
 toolchains had a look.
 
 
 --
 Regards,
 Igor
 
 On 2014-12-12, 20:26, Igor Fedorenko wrote:
  I'll prepare a fix later today or tomorrow morning (eastern time). Unless
  somebody else wants to do this, of course. 
  On December 12, 2014 7:27:14 PM EST, Jason van Zyl ja...@takari.io 
wrote:
  Tycho is a very important consumer of Maven and we can't break them.
  
  This is the second time that the removal of signatures has broken Tycho
  and I restored them previously.  I think we need to do the same here.
  
  On Dec 12, 2014, at 7:22 PM, Jason van Zyl ja...@takari.io wrote:
  I will cancel the release, we can't break Tycho.
  
  Are there no ITs for toolchains? How did they not break?
  
  On Dec 12, 2014, at 6:38 PM, Igor Fedorenko i...@ifedorenko.com
  
  wrote:
  Unfortunately, I have to take this back. The changes to toolchain
  broke Tycho and, short of using reflection, I don't see how
  to make Tycho work with maven 3.2.4 and earlier versions of Maven.
  
  For better or worse,
  org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
  Maven API since 2.x and I don't think we can just remove the class.
  
  I see two ways to fix this. Either we rename the classes back, which
  
  is
  
  probably the easiest. Or we introduce deprecated
  
  DefaultJavaToolChain
  
  that extends the new implementation.
  
  Here is my -1 for releasing 3.2.4 in its current state.
  
  --
  Regards,
  Igor
  
  On 2014-12-12, 18:01, Igor Fedorenko wrote:
  +1
  
  --
  Regards,
  Igor
  
  On 2014-12-12, 16:54, Jason van Zyl wrote:
  Hi,
  
  Time to release Maven 3.2.4!
  
  Here is a link to Jira with 20 issues resolved:
  https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500version
  =20574 
  Staging repo:
  https://repository.apache.org/content/repositories/maven-1102/
  
  The distributable binaries and sources for testing can be found
  
  here:
  
  https://repository.apache.org/content/repositories/maven-1102/org/apache/
  maven/apache-maven/3.2.4/ 
  Specifically the zip, tarball, and source archives can be found
  
  here:
  
  https://repository.apache.org/content/repositories/maven-1102/org/apache/
  maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
  
  
  https://repository.apache.org/content/repositories/maven-1102/org/apache/
  maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
  
  
  https://repository.apache.org/content/repositories/maven-1102/org/apache/
  maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
  
  
  https://repository.apache.org/content/repositories/maven-1102/org/apache/
  maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz 
  Source release checksum(s):
  
  apache-maven-3.2.4-src.zip sha1:
  db5fb9feda693f05fe7effaf096d6cd4dd5eff44
  
  Staging site:
  http://takari.io/maven-3.2.4/
  
  Vote open for 72 hours.
  
  [ ] +1
  [ ] +0
  [ ] -1
  
  Thanks,
  
  The Maven Team
  
  -
  
  To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
  For additional commands, e-mail: dev-h...@maven.apache.org
  
  -
  
  To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
  For additional commands, e-mail: dev-h...@maven.apache.org
  
  -
  
  To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
  For additional commands, e-mail: dev-h...@maven.apache.org
  
  Thanks,
  
  Jason
  
  --
  Jason van Zyl
  Founder,  Apache Maven
  http://twitter.com/jvanzyl
  http://twitter.com/takari_io
  -
  
  You are never dedicated to something you have complete confidence in.
  No one is fanatically shouting that the sun is going to rise
  
  tomorrow.
  
  They know it is going to rise tomorrow. When people are fanatically
  dedicated to political or religious faiths or any other kind of
  dogmas or goals, it's always because these dogmas or
  goals are in doubt.
  
 -- Robert Pirzig, Zen and the Art of 

Re: [CANCELED] [VOTE] Maven 3.2.4 Release

2014-12-13 Thread Igor Fedorenko

Are you able to run mvn validate on the attached project with staged
maven 3.2.4 or current master? The log you attached is from maven 3.2.3.
I've attached log from current master.

--
Regards,
Igor

On 2014-12-13, 3:32, Hervé BOUTEMY wrote:

I can't reproduce the problem: see the logs in attachment

can you give me more details?


notice that from every changes we did on toolchains, the only expected visible
change was on MNG-5718: custom toolchains need to be enhanced.
MNG-5719 wasn't supposed to have any impact on Tycho or any other project.
But perhaps you're using custom compoennt more tied to core than expected.

Regards,

Hervé

Le samedi 13 décembre 2014 00:03:38 Igor Fedorenko a écrit :

Providing backwards compatibility shim seems to be quite
straightforward, but there appears to be another problem. From what I
can tell, current maven master breaks maven-toolchains-plugin 1.0, at
least for some projects that work with maven 3.2.3.

I've attached a trivial example that shows the problem with
maven-toolchains-plugin plugin and will appreciate if somebody familiar
toolchains had a look.


--
Regards,
Igor

On 2014-12-12, 20:26, Igor Fedorenko wrote:

I'll prepare a fix later today or tomorrow morning (eastern time). Unless
somebody else wants to do this, of course.
On December 12, 2014 7:27:14 PM EST, Jason van Zyl ja...@takari.io

wrote:

Tycho is a very important consumer of Maven and we can't break them.

This is the second time that the removal of signatures has broken Tycho
and I restored them previously.  I think we need to do the same here.

On Dec 12, 2014, at 7:22 PM, Jason van Zyl ja...@takari.io wrote:

I will cancel the release, we can't break Tycho.

Are there no ITs for toolchains? How did they not break?

On Dec 12, 2014, at 6:38 PM, Igor Fedorenko i...@ifedorenko.com


wrote:

Unfortunately, I have to take this back. The changes to toolchain
broke Tycho and, short of using reflection, I don't see how
to make Tycho work with maven 3.2.4 and earlier versions of Maven.

For better or worse,
org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
Maven API since 2.x and I don't think we can just remove the class.

I see two ways to fix this. Either we rename the classes back, which


is


probably the easiest. Or we introduce deprecated


DefaultJavaToolChain


that extends the new implementation.

Here is my -1 for releasing 3.2.4 in its current state.

--
Regards,
Igor

On 2014-12-12, 18:01, Igor Fedorenko wrote:

+1

--
Regards,
Igor

On 2014-12-12, 16:54, Jason van Zyl wrote:

Hi,

Time to release Maven 3.2.4!



Here is a link to Jira with 20 issues resolved:

https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500version
=20574

Staging repo:
https://repository.apache.org/content/repositories/maven-1102/

The distributable binaries and sources for testing can be found


here:

https://repository.apache.org/content/repositories/maven-1102/org/apache/
maven/apache-maven/3.2.4/

Specifically the zip, tarball, and source archives can be found


here:

https://repository.apache.org/content/repositories/maven-1102/org/apache/
maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip


https://repository.apache.org/content/repositories/maven-1102/org/apache/
maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz


https://repository.apache.org/content/repositories/maven-1102/org/apache/
maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip


https://repository.apache.org/content/repositories/maven-1102/org/apache/
maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz

Source release checksum(s):



apache-maven-3.2.4-src.zip sha1:

db5fb9feda693f05fe7effaf096d6cd4dd5eff44


Staging site:
http://takari.io/maven-3.2.4/

Vote open for 72 hours.

[ ] +1
[ ] +0
[ ] -1

Thanks,

The Maven Team


-


To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-


To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-


To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


Thanks,

Jason

--
Jason van Zyl
Founder,  Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/takari_io
-

You are never dedicated to something you have complete confidence in.
No one is fanatically shouting that the sun is going to rise


tomorrow.


They know it is going to rise tomorrow. When people are fanatically
dedicated to political or religious faiths or any other kind of
dogmas or goals, it's always because these dogmas or
goals are in doubt.

-- Robert Pirzig, Zen and the Art of Motorcycle 

Re: [CANCELED] [VOTE] Maven 3.2.4 Release

2014-12-13 Thread Hervé BOUTEMY
uh, stupid me, I answered too early in the morning ;)

The problem is in pom.xml: the config is wrong
configuration
  toolchains
vendorfake/vendor
  /toolchains
/configuration
the result can be seen in the INFO message
[INFO] Type:vendor

With previous version, this (surprisingly) could work
But with MNG-5716 fixed, this does not work any more: there is no vendor 
toolchain, but you're looking for a jdk toolchain with vendor requirement

the configuration has to be:
configuration
  toolchains
jdk
  vendorfake/vendor
/jdk
  /toolchains
/configuration

Regards,

Hervé

Le samedi 13 décembre 2014 07:22:03 Igor Fedorenko a écrit :
 Are you able to run mvn validate on the attached project with staged
 maven 3.2.4 or current master? The log you attached is from maven 3.2.3.
 I've attached log from current master.
 
 --
 Regards,
 Igor
 
 On 2014-12-13, 3:32, Hervé BOUTEMY wrote:
  I can't reproduce the problem: see the logs in attachment
  
  can you give me more details?
  
  
  notice that from every changes we did on toolchains, the only expected
  visible change was on MNG-5718: custom toolchains need to be enhanced.
  MNG-5719 wasn't supposed to have any impact on Tycho or any other project.
  But perhaps you're using custom compoennt more tied to core than expected.
  
  Regards,
  
  Hervé
  
  Le samedi 13 décembre 2014 00:03:38 Igor Fedorenko a écrit :
  Providing backwards compatibility shim seems to be quite
  straightforward, but there appears to be another problem. From what I
  can tell, current maven master breaks maven-toolchains-plugin 1.0, at
  least for some projects that work with maven 3.2.3.
  
  I've attached a trivial example that shows the problem with
  maven-toolchains-plugin plugin and will appreciate if somebody familiar
  toolchains had a look.
  
  
  --
  Regards,
  Igor
  
  On 2014-12-12, 20:26, Igor Fedorenko wrote:
  I'll prepare a fix later today or tomorrow morning (eastern time).
  Unless
  somebody else wants to do this, of course.
  On December 12, 2014 7:27:14 PM EST, Jason van Zyl ja...@takari.io
  
  wrote:
  Tycho is a very important consumer of Maven and we can't break them.
  
  This is the second time that the removal of signatures has broken Tycho
  and I restored them previously.  I think we need to do the same here.
  
  On Dec 12, 2014, at 7:22 PM, Jason van Zyl ja...@takari.io wrote:
  I will cancel the release, we can't break Tycho.
  
  Are there no ITs for toolchains? How did they not break?
  
  On Dec 12, 2014, at 6:38 PM, Igor Fedorenko i...@ifedorenko.com
  
  wrote:
  Unfortunately, I have to take this back. The changes to toolchain
  broke Tycho and, short of using reflection, I don't see how
  to make Tycho work with maven 3.2.4 and earlier versions of Maven.
  
  For better or worse,
  org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
  Maven API since 2.x and I don't think we can just remove the class.
  
  I see two ways to fix this. Either we rename the classes back, which
  
  is
  
  probably the easiest. Or we introduce deprecated
  
  DefaultJavaToolChain
  
  that extends the new implementation.
  
  Here is my -1 for releasing 3.2.4 in its current state.
  
  --
  Regards,
  Igor
  
  On 2014-12-12, 18:01, Igor Fedorenko wrote:
  +1
  
  --
  Regards,
  Igor
  
  On 2014-12-12, 16:54, Jason van Zyl wrote:
  Hi,
  
  Time to release Maven 3.2.4!
  
  Here is a link to Jira with 20 issues resolved:
  https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500versi
  on
  =20574
  
  Staging repo:
  https://repository.apache.org/content/repositories/maven-1102/
  
  The distributable binaries and sources for testing can be found
  
  here:
  
  https://repository.apache.org/content/repositories/maven-1102/org/apach
  e/
  maven/apache-maven/3.2.4/
  
  Specifically the zip, tarball, and source archives can be found
  
  here:
  
  https://repository.apache.org/content/repositories/maven-1102/org/apach
  e/
  maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
  
  
  https://repository.apache.org/content/repositories/maven-1102/org/apach
  e/
  maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
  
  
  https://repository.apache.org/content/repositories/maven-1102/org/apach
  e/
  maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
  
  
  https://repository.apache.org/content/repositories/maven-1102/org/apach
  e/
  maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
  
  Source release checksum(s):
  
  apache-maven-3.2.4-src.zip sha1:
  db5fb9feda693f05fe7effaf096d6cd4dd5eff44
  
  Staging site:
  http://takari.io/maven-3.2.4/
  
  Vote open for 72 hours.
  
  [ ] +1
  [ ] +0
  [ ] -1
  
  Thanks,
  
  The Maven Team
  
  -
  
  To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
  For additional commands, e-mail: 

Re: [CANCELED] [VOTE] Maven 3.2.4 Release

2014-12-13 Thread Igor Fedorenko

I just wanted to point out there was a change in behaviour between 3.2.3
and 3.2.4. If you this was expected/desired, I have no objections.

--
Regards,
Igor

On 2014-12-13, 8:33, Hervé BOUTEMY wrote:

uh, stupid me, I answered too early in the morning ;)

The problem is in pom.xml: the config is wrong
 configuration
   toolchains
 vendorfake/vendor
   /toolchains
 /configuration
the result can be seen in the INFO message
[INFO] Type:vendor

With previous version, this (surprisingly) could work
But with MNG-5716 fixed, this does not work any more: there is no vendor
toolchain, but you're looking for a jdk toolchain with vendor requirement

the configuration has to be:
 configuration
   toolchains
 jdk
   vendorfake/vendor
 /jdk
   /toolchains
 /configuration

Regards,

Hervé

Le samedi 13 décembre 2014 07:22:03 Igor Fedorenko a écrit :

Are you able to run mvn validate on the attached project with staged
maven 3.2.4 or current master? The log you attached is from maven 3.2.3.
I've attached log from current master.

--
Regards,
Igor

On 2014-12-13, 3:32, Hervé BOUTEMY wrote:

I can't reproduce the problem: see the logs in attachment

can you give me more details?


notice that from every changes we did on toolchains, the only expected
visible change was on MNG-5718: custom toolchains need to be enhanced.
MNG-5719 wasn't supposed to have any impact on Tycho or any other project.
But perhaps you're using custom compoennt more tied to core than expected.

Regards,

Hervé

Le samedi 13 décembre 2014 00:03:38 Igor Fedorenko a écrit :

Providing backwards compatibility shim seems to be quite
straightforward, but there appears to be another problem. From what I
can tell, current maven master breaks maven-toolchains-plugin 1.0, at
least for some projects that work with maven 3.2.3.

I've attached a trivial example that shows the problem with
maven-toolchains-plugin plugin and will appreciate if somebody familiar
toolchains had a look.


--
Regards,
Igor

On 2014-12-12, 20:26, Igor Fedorenko wrote:

I'll prepare a fix later today or tomorrow morning (eastern time).
Unless
somebody else wants to do this, of course.
On December 12, 2014 7:27:14 PM EST, Jason van Zyl ja...@takari.io


wrote:

Tycho is a very important consumer of Maven and we can't break them.

This is the second time that the removal of signatures has broken Tycho
and I restored them previously.  I think we need to do the same here.

On Dec 12, 2014, at 7:22 PM, Jason van Zyl ja...@takari.io wrote:

I will cancel the release, we can't break Tycho.

Are there no ITs for toolchains? How did they not break?

On Dec 12, 2014, at 6:38 PM, Igor Fedorenko i...@ifedorenko.com


wrote:

Unfortunately, I have to take this back. The changes to toolchain
broke Tycho and, short of using reflection, I don't see how
to make Tycho work with maven 3.2.4 and earlier versions of Maven.

For better or worse,
org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
Maven API since 2.x and I don't think we can just remove the class.

I see two ways to fix this. Either we rename the classes back, which


is


probably the easiest. Or we introduce deprecated


DefaultJavaToolChain


that extends the new implementation.

Here is my -1 for releasing 3.2.4 in its current state.

--
Regards,
Igor

On 2014-12-12, 18:01, Igor Fedorenko wrote:

+1

--
Regards,
Igor

On 2014-12-12, 16:54, Jason van Zyl wrote:

Hi,

Time to release Maven 3.2.4!



Here is a link to Jira with 20 issues resolved:

https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500versi
on
=20574


Staging repo:
https://repository.apache.org/content/repositories/maven-1102/

The distributable binaries and sources for testing can be found


here:

https://repository.apache.org/content/repositories/maven-1102/org/apach
e/
maven/apache-maven/3.2.4/


Specifically the zip, tarball, and source archives can be found


here:

https://repository.apache.org/content/repositories/maven-1102/org/apach
e/
maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip


https://repository.apache.org/content/repositories/maven-1102/org/apach
e/
maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz


https://repository.apache.org/content/repositories/maven-1102/org/apach
e/
maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip


https://repository.apache.org/content/repositories/maven-1102/org/apach
e/
maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz


Source release checksum(s):



apache-maven-3.2.4-src.zip sha1:

db5fb9feda693f05fe7effaf096d6cd4dd5eff44


Staging site:
http://takari.io/maven-3.2.4/

Vote open for 72 hours.

[ ] +1
[ ] +0
[ ] -1

Thanks,

The Maven Team


-


To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [CANCELED] [VOTE] Maven 3.2.4 Release

2014-12-12 Thread Igor Fedorenko
I'll prepare a fix later today or tomorrow morning (eastern time). Unless 
somebody else wants to do this, of course.

On December 12, 2014 7:27:14 PM EST, Jason van Zyl ja...@takari.io wrote:
Tycho is a very important consumer of Maven and we can't break them.

This is the second time that the removal of signatures has broken Tycho
and I restored them previously.  I think we need to do the same here.

On Dec 12, 2014, at 7:22 PM, Jason van Zyl ja...@takari.io wrote:

 I will cancel the release, we can't break Tycho.
 
 Are there no ITs for toolchains? How did they not break?
 
 On Dec 12, 2014, at 6:38 PM, Igor Fedorenko i...@ifedorenko.com
wrote:
 
 Unfortunately, I have to take this back. The changes to toolchain
 broke Tycho and, short of using reflection, I don't see how
 to make Tycho work with maven 3.2.4 and earlier versions of Maven.
 
 For better or worse,
 org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
 Maven API since 2.x and I don't think we can just remove the class.
 
 I see two ways to fix this. Either we rename the classes back, which
is
 probably the easiest. Or we introduce deprecated
DefaultJavaToolChain
 that extends the new implementation.
 
 Here is my -1 for releasing 3.2.4 in its current state.
 
 --
 Regards,
 Igor
 
 On 2014-12-12, 18:01, Igor Fedorenko wrote:
 +1
 
 --
 Regards,
 Igor
 
 On 2014-12-12, 16:54, Jason van Zyl wrote:
 Hi,
 
 Time to release Maven 3.2.4!
 
 Here is a link to Jira with 20 issues resolved:

https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500version=20574
 
 
 Staging repo:
 https://repository.apache.org/content/repositories/maven-1102/
 
 The distributable binaries and sources for testing can be found
here:

https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/
 
 
 Specifically the zip, tarball, and source archives can be found
here:

https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
 

https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
 

https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
 

https://repository.apache.org/content/repositories/maven-1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
 
 
 Source release checksum(s):
 apache-maven-3.2.4-src.zip sha1:
db5fb9feda693f05fe7effaf096d6cd4dd5eff44
 
 Staging site:
 http://takari.io/maven-3.2.4/
 
 Vote open for 72 hours.
 
 [ ] +1
 [ ] +0
 [ ] -1
 
 Thanks,
 
 The Maven Team

-
 To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
 For additional commands, e-mail: dev-h...@maven.apache.org
 
 

-
 To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
 For additional commands, e-mail: dev-h...@maven.apache.org
 
 

-
 To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
 For additional commands, e-mail: dev-h...@maven.apache.org
 
 
 Thanks,
 
 Jason
 
 --
 Jason van Zyl
 Founder,  Apache Maven
 http://twitter.com/jvanzyl
 http://twitter.com/takari_io
 -
 
 You are never dedicated to something you have complete confidence in.
 No one is fanatically shouting that the sun is going to rise
tomorrow.
 They know it is going to rise tomorrow. When people are fanatically
 dedicated to political or religious faiths or any other kind of 
 dogmas or goals, it's always because these dogmas or
 goals are in doubt.
 
   -- Robert Pirzig, Zen and the Art of Motorcycle Maintenance
 
 
 
 
 
 
 
 
 

Thanks,

Jason

--
Jason van Zyl
Founder,  Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/takari_io
-

What matters is not ideas, but the people who have them. Good people
can fix bad ideas, but good ideas can't save bad people. 

 -- Paul Graham

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [CANCELED] [VOTE] Maven 3.2.4 Release

2014-12-12 Thread Hervé BOUTEMY
I did the work on this: I'll have a look

Sorry for the breaks: if tycho is a good regression test and can be automated, 
we should add it to our CI server to detect such problems earlier

Regards,

Hervé

Le samedi 13 décembre 2014 00:03:38 Igor Fedorenko a écrit :
 Providing backwards compatibility shim seems to be quite
 straightforward, but there appears to be another problem. From what I
 can tell, current maven master breaks maven-toolchains-plugin 1.0, at
 least for some projects that work with maven 3.2.3.
 
 I've attached a trivial example that shows the problem with
 maven-toolchains-plugin plugin and will appreciate if somebody familiar
 toolchains had a look.
 
 
 --
 Regards,
 Igor
 
 On 2014-12-12, 20:26, Igor Fedorenko wrote:
  I'll prepare a fix later today or tomorrow morning (eastern time). Unless
  somebody else wants to do this, of course. 
  On December 12, 2014 7:27:14 PM EST, Jason van Zyl ja...@takari.io 
wrote:
  Tycho is a very important consumer of Maven and we can't break them.
  
  This is the second time that the removal of signatures has broken Tycho
  and I restored them previously.  I think we need to do the same here.
  
  On Dec 12, 2014, at 7:22 PM, Jason van Zyl ja...@takari.io wrote:
  I will cancel the release, we can't break Tycho.
  
  Are there no ITs for toolchains? How did they not break?
  
  On Dec 12, 2014, at 6:38 PM, Igor Fedorenko i...@ifedorenko.com
  
  wrote:
  Unfortunately, I have to take this back. The changes to toolchain
  broke Tycho and, short of using reflection, I don't see how
  to make Tycho work with maven 3.2.4 and earlier versions of Maven.
  
  For better or worse,
  org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
  Maven API since 2.x and I don't think we can just remove the class.
  
  I see two ways to fix this. Either we rename the classes back, which
  
  is
  
  probably the easiest. Or we introduce deprecated
  
  DefaultJavaToolChain
  
  that extends the new implementation.
  
  Here is my -1 for releasing 3.2.4 in its current state.
  
  --
  Regards,
  Igor
  
  On 2014-12-12, 18:01, Igor Fedorenko wrote:
  +1
  
  --
  Regards,
  Igor
  
  On 2014-12-12, 16:54, Jason van Zyl wrote:
  Hi,
  
  Time to release Maven 3.2.4!
  
  Here is a link to Jira with 20 issues resolved:
  https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500version
  =20574 
  Staging repo:
  https://repository.apache.org/content/repositories/maven-1102/
  
  The distributable binaries and sources for testing can be found
  
  here:
  
  https://repository.apache.org/content/repositories/maven-1102/org/apache/
  maven/apache-maven/3.2.4/ 
  Specifically the zip, tarball, and source archives can be found
  
  here:
  
  https://repository.apache.org/content/repositories/maven-1102/org/apache/
  maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
  
  
  https://repository.apache.org/content/repositories/maven-1102/org/apache/
  maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
  
  
  https://repository.apache.org/content/repositories/maven-1102/org/apache/
  maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
  
  
  https://repository.apache.org/content/repositories/maven-1102/org/apache/
  maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz 
  Source release checksum(s):
  
  apache-maven-3.2.4-src.zip sha1:
  db5fb9feda693f05fe7effaf096d6cd4dd5eff44
  
  Staging site:
  http://takari.io/maven-3.2.4/
  
  Vote open for 72 hours.
  
  [ ] +1
  [ ] +0
  [ ] -1
  
  Thanks,
  
  The Maven Team
  
  -
  
  To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
  For additional commands, e-mail: dev-h...@maven.apache.org
  
  -
  
  To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
  For additional commands, e-mail: dev-h...@maven.apache.org
  
  -
  
  To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
  For additional commands, e-mail: dev-h...@maven.apache.org
  
  Thanks,
  
  Jason
  
  --
  Jason van Zyl
  Founder,  Apache Maven
  http://twitter.com/jvanzyl
  http://twitter.com/takari_io
  -
  
  You are never dedicated to something you have complete confidence in.
  No one is fanatically shouting that the sun is going to rise
  
  tomorrow.
  
  They know it is going to rise tomorrow. When people are fanatically
  dedicated to political or religious faiths or any other kind of
  dogmas or goals, it's always because these dogmas or
  goals are in doubt.
  
 -- Robert Pirzig, Zen and the Art of Motorcycle Maintenance
  
  Thanks,
  
  Jason
  
  --
  Jason van Zyl
  Founder,  Apache Maven
  http://twitter.com/jvanzyl