Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

[Hervé Boutemy]

+1

Reproducible Build ok: reference build done with JDK 11 on *nix

see 
https://github.com/jvm-repo-rebuild/reproducible-apache/blob/master/wip/maven-shade-plugin-3.5.2.buildspec

anybody should be able to rebuild locally with
  ./rebuild.sh wip/maven-shade-plugin-3.5.2.buildspec

Regards,

Hervé

Le samedi 17 février 2024, 19:00:47 CET Hervé Boutemy a écrit :
> Hi,
> 
> We solved 6 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317921&ve
> rsion=12352505&styleName=Text
> 
> Staging repo:
> https://repository.apache.org/content/repositories/maven-2065/
> https://repository.apache.org/content/repositories/maven-2065/org/apache/mav
> en/plugins/maven-shade-plugin/3.5.2/maven-shade-plugin-3.5.2-source-release.
> zip
> 
> Source release checksum(s):
> maven-shade-plugin-3.5.2-source-release.zip sha512:
> 23fcd21e6b915114efa133b1c4e46fa0b3d77874ff9d974e4bdb24940ea0ed9b7ffaf7f3d1e
> 8a8549837cfe1de7ff2fc8ae7fc68bfc0477ea7a4b8b53e42f6f7%
> 
> Staging site:
> https://maven.apache.org/plugins-archives/maven-shade-plugin-LATEST/
> 
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
> 
> Vote open for at least 72 hours.
> 
> [ ] +1
> [ ] +0
> [ ] -1
> 
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

[Romain Manni-Bucau]

+1, project ok, downstream projects ok, tested on mvn 3.9.2 & java 11

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le dim. 18 févr. 2024 à 09:38, Hervé Boutemy  a
écrit :

> +1
>
> Reproducible Build ok: reference build done with JDK 11 on *nix
>
> see
> https://github.com/jvm-repo-rebuild/reproducible-apache/blob/master/wip/maven-shade-plugin-3.5.2.buildspec
>
> anybody should be able to rebuild locally with
>   ./rebuild.sh wip/maven-shade-plugin-3.5.2.buildspec
>
> Regards,
>
> Hervé
>
> Le samedi 17 février 2024, 19:00:47 CET Hervé Boutemy a écrit :
> > Hi,
> >
> > We solved 6 issues:
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317921&ve
> > rsion=12352505&styleName=Text
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-2065/
> >
> https://repository.apache.org/content/repositories/maven-2065/org/apache/mav
> >
> en/plugins/maven-shade-plugin/3.5.2/maven-shade-plugin-3.5.2-source-release.
> > zip
> >
> > Source release checksum(s):
> > maven-shade-plugin-3.5.2-source-release.zip sha512:
> >
> 23fcd21e6b915114efa133b1c4e46fa0b3d77874ff9d974e4bdb24940ea0ed9b7ffaf7f3d1e
> > 8a8549837cfe1de7ff2fc8ae7fc68bfc0477ea7a4b8b53e42f6f7%
> >
> > Staging site:
> > https://maven.apache.org/plugins-archives/maven-shade-plugin-LATEST/
> >
> > Guide to testing staged releases:
> > https://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for at least 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> >
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
>
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

[zhongming hua]

+1
* building is ok
* test successfully
* release note is ok

Romain Manni-Bucau  于2024年2月18日周日 16:48写道：
>
> +1, project ok, downstream projects ok, tested on mvn 3.9.2 & java 11
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github  |
> LinkedIn  | Book
> 
>
>
> Le dim. 18 févr. 2024 à 09:38, Hervé Boutemy  a
> écrit :
>
> > +1
> >
> > Reproducible Build ok: reference build done with JDK 11 on *nix
> >
> > see
> > https://github.com/jvm-repo-rebuild/reproducible-apache/blob/master/wip/maven-shade-plugin-3.5.2.buildspec
> >
> > anybody should be able to rebuild locally with
> >   ./rebuild.sh wip/maven-shade-plugin-3.5.2.buildspec
> >
> > Regards,
> >
> > Hervé
> >
> > Le samedi 17 février 2024, 19:00:47 CET Hervé Boutemy a écrit :
> > > Hi,
> > >
> > > We solved 6 issues:
> > >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317921&ve
> > > rsion=12352505&styleName=Text
> > >
> > > Staging repo:
> > > https://repository.apache.org/content/repositories/maven-2065/
> > >
> > https://repository.apache.org/content/repositories/maven-2065/org/apache/mav
> > >
> > en/plugins/maven-shade-plugin/3.5.2/maven-shade-plugin-3.5.2-source-release.
> > > zip
> > >
> > > Source release checksum(s):
> > > maven-shade-plugin-3.5.2-source-release.zip sha512:
> > >
> > 23fcd21e6b915114efa133b1c4e46fa0b3d77874ff9d974e4bdb24940ea0ed9b7ffaf7f3d1e
> > > 8a8549837cfe1de7ff2fc8ae7fc68bfc0477ea7a4b8b53e42f6f7%
> > >
> > > Staging site:
> > > https://maven.apache.org/plugins-archives/maven-shade-plugin-LATEST/
> > >
> > > Guide to testing staged releases:
> > > https://maven.apache.org/guides/development/guide-testing-releases.html
> > >
> > > Vote open for at least 72 hours.
> > >
> > > [ ] +1
> > > [ ] +0
> > > [ ] -1
> > >
> > >
> > >
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > For additional commands, e-mail: dev-h...@maven.apache.org
> >
> >
> >
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> >
> >

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

[Elliotte Rusty Harold]

-1

https://github.com/apache/maven-shade-plugin/pull/193 from an external
contributor is open and unreviewed, although it seems to meet the
criteria for merging if it's correct. It's helpful to triage open PRs
and issues before cutting a release.

On Sat, Feb 17, 2024 at 1:01 PM Hervé Boutemy  wrote:
>
> Hi,
>
> We solved 6 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317921&version=12352505&styleName=Text
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-2065/
> https://repository.apache.org/content/repositories/maven-2065/org/apache/maven/plugins/maven-shade-plugin/3.5.2/maven-shade-plugin-3.5.2-source-release.zip
>
> Source release checksum(s):
> maven-shade-plugin-3.5.2-source-release.zip sha512: 
> 23fcd21e6b915114efa133b1c4e46fa0b3d77874ff9d974e4bdb24940ea0ed9b7ffaf7f3d1e8a8549837cfe1de7ff2fc8ae7fc68bfc0477ea7a4b8b53e42f6f7%
>
> Staging site:
> https://maven.apache.org/plugins-archives/maven-shade-plugin-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>


-- 
Elliotte Rusty Harold
elh...@ibiblio.org

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

[Romain Manni-Bucau]

Hi Eliotte,

Is the -1 only motivated by the fact there is a PR opened?

If so please consider two things:
*  it is always the case for most releases (maven, asf, living projects ;))
so not sure when it became a hard criteria but if so we should probably
think to be more open if we want to release a day
* If you take time to review the PR you mention you will also see it just
revert a fix and that the final code should be more complex if it lands in
shade plugin a day - there are always workarounds there - so don't think we
can make it in the week so can await another round and way more time to
make it right (long story sort shade has an old bug where it mixes the same
config for different kind of rewritten sources, while it often works and
stays simple, it also makes it insanely hard to be right since you don't
know what you rewrite - a variable, a package, a class name, ...)

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le dim. 18 févr. 2024 à 14:30, Elliotte Rusty Harold  a
écrit :

> -1
>
> https://github.com/apache/maven-shade-plugin/pull/193 from an external
> contributor is open and unreviewed, although it seems to meet the
> criteria for merging if it's correct. It's helpful to triage open PRs
> and issues before cutting a release.
>
> On Sat, Feb 17, 2024 at 1:01 PM Hervé Boutemy 
> wrote:
> >
> > Hi,
> >
> > We solved 6 issues:
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317921&version=12352505&styleName=Text
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-2065/
> >
> https://repository.apache.org/content/repositories/maven-2065/org/apache/maven/plugins/maven-shade-plugin/3.5.2/maven-shade-plugin-3.5.2-source-release.zip
> >
> > Source release checksum(s):
> > maven-shade-plugin-3.5.2-source-release.zip sha512:
> 23fcd21e6b915114efa133b1c4e46fa0b3d77874ff9d974e4bdb24940ea0ed9b7ffaf7f3d1e8a8549837cfe1de7ff2fc8ae7fc68bfc0477ea7a4b8b53e42f6f7%
> >
> > Staging site:
> > https://maven.apache.org/plugins-archives/maven-shade-plugin-LATEST/
> >
> > Guide to testing staged releases:
> > https://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for at least 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> >
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> >
>
>
> --
> Elliotte Rusty Harold
> elh...@ibiblio.org
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

[Sylwester Lachiewicz]

+1

sob., 17 lut 2024, 19:01 użytkownik Hervé Boutemy 
napisał:

> Hi,
>
> We solved 6 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317921&version=12352505&styleName=Text
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-2065/
>
> https://repository.apache.org/content/repositories/maven-2065/org/apache/maven/plugins/maven-shade-plugin/3.5.2/maven-shade-plugin-3.5.2-source-release.zip
>
> Source release checksum(s):
> maven-shade-plugin-3.5.2-source-release.zip sha512:
> 23fcd21e6b915114efa133b1c4e46fa0b3d77874ff9d974e4bdb24940ea0ed9b7ffaf7f3d1e8a8549837cfe1de7ff2fc8ae7fc68bfc0477ea7a4b8b53e42f6f7%
>
> Staging site:
> https://maven.apache.org/plugins-archives/maven-shade-plugin-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

[Elliotte Rusty Harold]

On Sun, Feb 18, 2024 at 8:43 AM Romain Manni-Bucau
 wrote:
>
> Hi Eliotte,
>
> Is the -1 only motivated by the fact there is a PR opened?

That there is an unaddressed PR that looks worthy of review and has
been open for months without a reply. 13 others are open. One of them
is not ready for review. I haven't looked at the other 12 since, IMHO,
one unreviewed PR is sufficient reason to delay a cut.

> If so please consider two things:
> *  it is always the case for most releases (maven, asf, living projects ;))
> so not sure when it became a hard criteria but if so we should probably
> think to be more open if we want to release a day

It isn't necessary to finish and merge all PRs before a release, but a
review is not much to ask when someone has volunteered effort to fix
something. Rarely, there's an emergency push for a critical bug. Short
of that, it doesn't take all that long to scan the Github queue and
see if there's anything useful that got missed. In practice though I
often find even simple dependabot PRs unmerged after a release is cut.
I would like to get in the habit of tidying up the queue prior to a
release cut.

> * If you take time to review the PR you mention you will also see it just
> revert a fix and that the final code should be more complex if it lands in
> shade plugin a day - there are always workarounds there - so don't think we
> can make it in the week so can await another round and way more time to
> make it right (long story sort shade has an old bug where it mixes the same
> config for different kind of rewritten sources, while it often works and
> stays simple, it also makes it insanely hard to be right since you don't
> know what you rewrite - a variable, a package, a class name, ...)
>

That's all fine, but please say this on the PR so the new contributor
can address these points. It's not good for PRs to sit in limbo for
years. Commenting on PRs also helps to avoid someone else who doesn't
have the context you do (e.g. me) from coming along and simply merging
the PR because I don't happen to notice the problems you do.

-- 
Elliotte Rusty Harold
elh...@ibiblio.org

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

[Hervé Boutemy]

FYI I reviewed PRs and merged what I was confident with
I can't say if this one can be merged: I don't know the feature sufficiently

I understand the good intent of the feedback, even if I find -1 a little bit 
strong: I did what I could, believe in my good intent too doing that release

Regards,

Hervé

Le dimanche 18 février 2024, 15:14:37 CET Elliotte Rusty Harold a écrit :
> On Sun, Feb 18, 2024 at 8:43 AM Romain Manni-Bucau
> 
>  wrote:
> > Hi Eliotte,
> > 
> > Is the -1 only motivated by the fact there is a PR opened?
> 
> That there is an unaddressed PR that looks worthy of review and has
> been open for months without a reply. 13 others are open. One of them
> is not ready for review. I haven't looked at the other 12 since, IMHO,
> one unreviewed PR is sufficient reason to delay a cut.
> 
> > If so please consider two things:
> > *  it is always the case for most releases (maven, asf, living projects
> > ;))
> > so not sure when it became a hard criteria but if so we should probably
> > think to be more open if we want to release a day
> 
> It isn't necessary to finish and merge all PRs before a release, but a
> review is not much to ask when someone has volunteered effort to fix
> something. Rarely, there's an emergency push for a critical bug. Short
> of that, it doesn't take all that long to scan the Github queue and
> see if there's anything useful that got missed. In practice though I
> often find even simple dependabot PRs unmerged after a release is cut.
> I would like to get in the habit of tidying up the queue prior to a
> release cut.
> 
> > * If you take time to review the PR you mention you will also see it just
> > revert a fix and that the final code should be more complex if it lands in
> > shade plugin a day - there are always workarounds there - so don't think
> > we
> > can make it in the week so can await another round and way more time to
> > make it right (long story sort shade has an old bug where it mixes the
> > same
> > config for different kind of rewritten sources, while it often works and
> > stays simple, it also makes it insanely hard to be right since you don't
> > know what you rewrite - a variable, a package, a class name, ...)
> 
> That's all fine, but please say this on the PR so the new contributor
> can address these points. It's not good for PRs to sit in limbo for
> years. Commenting on PRs also helps to avoid someone else who doesn't
> have the context you do (e.g. me) from coming along and simply merging
> the PR because I don't happen to notice the problems you do.





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

[Guillaume Nodet]

+1

And fwiw, I fully support what Hervé said.  A release is a best effort
from the one who decides to start it and if Hervé was not confident in
merging the other PRs, that's fine with me.

Guillaume

Le dim. 18 févr. 2024 à 17:12, Hervé Boutemy  a écrit :
>
> FYI I reviewed PRs and merged what I was confident with
> I can't say if this one can be merged: I don't know the feature sufficiently
>
> I understand the good intent of the feedback, even if I find -1 a little bit
> strong: I did what I could, believe in my good intent too doing that release
>
> Regards,
>
> Hervé
>
> Le dimanche 18 février 2024, 15:14:37 CET Elliotte Rusty Harold a écrit :
> > On Sun, Feb 18, 2024 at 8:43 AM Romain Manni-Bucau
> >
> >  wrote:
> > > Hi Eliotte,
> > >
> > > Is the -1 only motivated by the fact there is a PR opened?
> >
> > That there is an unaddressed PR that looks worthy of review and has
> > been open for months without a reply. 13 others are open. One of them
> > is not ready for review. I haven't looked at the other 12 since, IMHO,
> > one unreviewed PR is sufficient reason to delay a cut.
> >
> > > If so please consider two things:
> > > *  it is always the case for most releases (maven, asf, living projects
> > > ;))
> > > so not sure when it became a hard criteria but if so we should probably
> > > think to be more open if we want to release a day
> >
> > It isn't necessary to finish and merge all PRs before a release, but a
> > review is not much to ask when someone has volunteered effort to fix
> > something. Rarely, there's an emergency push for a critical bug. Short
> > of that, it doesn't take all that long to scan the Github queue and
> > see if there's anything useful that got missed. In practice though I
> > often find even simple dependabot PRs unmerged after a release is cut.
> > I would like to get in the habit of tidying up the queue prior to a
> > release cut.
> >
> > > * If you take time to review the PR you mention you will also see it just
> > > revert a fix and that the final code should be more complex if it lands in
> > > shade plugin a day - there are always workarounds there - so don't think
> > > we
> > > can make it in the week so can await another round and way more time to
> > > make it right (long story sort shade has an old bug where it mixes the
> > > same
> > > config for different kind of rewritten sources, while it often works and
> > > stays simple, it also makes it insanely hard to be right since you don't
> > > know what you rewrite - a variable, a package, a class name, ...)
> >
> > That's all fine, but please say this on the PR so the new contributor
> > can address these points. It's not good for PRs to sit in limbo for
> > years. Commenting on PRs also helps to avoid someone else who doesn't
> > have the context you do (e.g. me) from coming along and simply merging
> > the PR because I don't happen to notice the problems you do.
>
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>


-- 

Guillaume Nodet

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

[Slawomir Jaranowski]

+1

Every next release even with a few fixes is step forward.
Every time we can review / merge more PR and start the next release.



sob., 17 lut 2024 o 19:00 Hervé Boutemy  napisał(a):

> Hi,
>
> We solved 6 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317921&version=12352505&styleName=Text
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-2065/
>
> https://repository.apache.org/content/repositories/maven-2065/org/apache/maven/plugins/maven-shade-plugin/3.5.2/maven-shade-plugin-3.5.2-source-release.zip
>
> Source release checksum(s):
> maven-shade-plugin-3.5.2-source-release.zip sha512:
> 23fcd21e6b915114efa133b1c4e46fa0b3d77874ff9d974e4bdb24940ea0ed9b7ffaf7f3d1e8a8549837cfe1de7ff2fc8ae7fc68bfc0477ea7a4b8b53e42f6f7%
>
> Staging site:
> https://maven.apache.org/plugins-archives/maven-shade-plugin-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

-- 
Sławomir Jaranowski

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

[Tamás Cservenák]

+1

With Herve fully here.

BUT
I agree somewhat with Eliotte as well:
We need to get rid of our habit of neglecting PRs.
At least _some_ feedback on PR would be welcome, as leaving PRs hanging
without ANY response is the worst way of treating contributors, and we do
lack them.

T

On Sun, Feb 18, 2024 at 5:12 PM Hervé Boutemy  wrote:

> FYI I reviewed PRs and merged what I was confident with
> I can't say if this one can be merged: I don't know the feature
> sufficiently
>
> I understand the good intent of the feedback, even if I find -1 a little
> bit
> strong: I did what I could, believe in my good intent too doing that
> release
>
> Regards,
>
> Hervé
>
> Le dimanche 18 février 2024, 15:14:37 CET Elliotte Rusty Harold a écrit :
> > On Sun, Feb 18, 2024 at 8:43 AM Romain Manni-Bucau
> >
> >  wrote:
> > > Hi Eliotte,
> > >
> > > Is the -1 only motivated by the fact there is a PR opened?
> >
> > That there is an unaddressed PR that looks worthy of review and has
> > been open for months without a reply. 13 others are open. One of them
> > is not ready for review. I haven't looked at the other 12 since, IMHO,
> > one unreviewed PR is sufficient reason to delay a cut.
> >
> > > If so please consider two things:
> > > *  it is always the case for most releases (maven, asf, living projects
> > > ;))
> > > so not sure when it became a hard criteria but if so we should probably
> > > think to be more open if we want to release a day
> >
> > It isn't necessary to finish and merge all PRs before a release, but a
> > review is not much to ask when someone has volunteered effort to fix
> > something. Rarely, there's an emergency push for a critical bug. Short
> > of that, it doesn't take all that long to scan the Github queue and
> > see if there's anything useful that got missed. In practice though I
> > often find even simple dependabot PRs unmerged after a release is cut.
> > I would like to get in the habit of tidying up the queue prior to a
> > release cut.
> >
> > > * If you take time to review the PR you mention you will also see it
> just
> > > revert a fix and that the final code should be more complex if it
> lands in
> > > shade plugin a day - there are always workarounds there - so don't
> think
> > > we
> > > can make it in the week so can await another round and way more time to
> > > make it right (long story sort shade has an old bug where it mixes the
> > > same
> > > config for different kind of rewritten sources, while it often works
> and
> > > stays simple, it also makes it insanely hard to be right since you
> don't
> > > know what you rewrite - a variable, a package, a class name, ...)
> >
> > That's all fine, but please say this on the PR so the new contributor
> > can address these points. It's not good for PRs to sit in limbo for
> > years. Commenting on PRs also helps to avoid someone else who doesn't
> > have the context you do (e.g. me) from coming along and simply merging
> > the PR because I don't happen to notice the problems you do.
>
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

[Benjamin Marwell]

+1 for the release as it is

+100 with the way Tamás put it.

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

[Karl Heinz Marbaise]

Hi,

+1

form my side.

Kind regards
Karl Heinz Marbaise
On 17.02.24 19:00, Hervé Boutemy wrote:

Hi,

We solved 6 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317921&version=12352505&styleName=Text

Staging repo:
https://repository.apache.org/content/repositories/maven-2065/
https://repository.apache.org/content/repositories/maven-2065/org/apache/maven/plugins/maven-shade-plugin/3.5.2/maven-shade-plugin-3.5.2-source-release.zip

Source release checksum(s):
maven-shade-plugin-3.5.2-source-release.zip sha512: 
23fcd21e6b915114efa133b1c4e46fa0b3d77874ff9d974e4bdb24940ea0ed9b7ffaf7f3d1e8a8549837cfe1de7ff2fc8ae7fc68bfc0477ea7a4b8b53e42f6f7%

Staging site:
https://maven.apache.org/plugins-archives/maven-shade-plugin-LATEST/

Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for at least 72 hours.

[ ] +1
[ ] +0
[ ] -1




-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

[Olivier Lamy]

+1

On Sun, 18 Feb 2024 at 04:00, Hervé Boutemy  wrote:
>
> Hi,
>
> We solved 6 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317921&version=12352505&styleName=Text
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-2065/
> https://repository.apache.org/content/repositories/maven-2065/org/apache/maven/plugins/maven-shade-plugin/3.5.2/maven-shade-plugin-3.5.2-source-release.zip
>
> Source release checksum(s):
> maven-shade-plugin-3.5.2-source-release.zip sha512: 
> 23fcd21e6b915114efa133b1c4e46fa0b3d77874ff9d974e4bdb24940ea0ed9b7ffaf7f3d1e8a8549837cfe1de7ff2fc8ae7fc68bfc0477ea7a4b8b53e42f6f7%
>
> Staging site:
> https://maven.apache.org/plugins-archives/maven-shade-plugin-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org