Re: apply MNG-2293 to maven-2.0.x?
And remember also to apply later changes to that files that were not ported to the branch as they didn't exist there. On 6/21/06, Brett Porter [EMAIL PROTECTED] wrote: On 20/06/2006 10:27 PM, jerome lacoste wrote: On 6/10/06, Brett Porter [EMAIL PROTECTED] wrote: +1, but considering it an exception to the rule, not a change to the rule. I'd rather we were doing .x releases every 6 months instead. +1: 2 -1: 0 Is that sufficient? Kenney makes 3, but that's irrelevant. One +1 is enough to do it, one -1 is enough to pull it back out (though in both cases it is healthy to discuss it first if you are unsure :) If so, who's responsible to apply this change onto the branch ? I'll leave that to Kenney as the original committer. Jerome - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Brett Porter [EMAIL PROTECTED] Apache Maven - http://maven.apache.org/ Better Builds with Maven - http://library.mergere.com/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- I could give you my word as a Spaniard. No good. I've known too many Spaniards. -- The Princess Bride - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: apply MNG-2293 to maven-2.0.x?
On 6/10/06, Brett Porter [EMAIL PROTECTED] wrote: +1, but considering it an exception to the rule, not a change to the rule. I'd rather we were doing .x releases every 6 months instead. +1: 2 -1: 0 Is that sufficient? If so, who's responsible to apply this change onto the branch ? Jerome - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: apply MNG-2293 to maven-2.0.x?
On 20/06/2006 10:27 PM, jerome lacoste wrote: On 6/10/06, Brett Porter [EMAIL PROTECTED] wrote: +1, but considering it an exception to the rule, not a change to the rule. I'd rather we were doing .x releases every 6 months instead. +1: 2 -1: 0 Is that sufficient? Kenney makes 3, but that's irrelevant. One +1 is enough to do it, one -1 is enough to pull it back out (though in both cases it is healthy to discuss it first if you are unsure :) If so, who's responsible to apply this change onto the branch ? I'll leave that to Kenney as the original committer. Jerome - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Brett Porter [EMAIL PROTECTED] Apache Maven - http://maven.apache.org/ Better Builds with Maven - http://library.mergere.com/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: apply MNG-2293 to maven-2.0.x?
On 6/9/06, Kenney Westerhof [EMAIL PROTECTED] wrote: Hi there, This issue is about adding an 'implementation' parameter to the @parameter annotation for mojo fields, so you can specify a default implementation in case the field's type is an interface. Since it's a new feature, I'm asking whether this should be applied to the 2.0.x branch too? I would love this to be in 2.0.x (except if you can convince that 2.1 is out before 2.0.5 :) I need this for a webstart functionality I plan for 1.0 (I have the patch waiting in my local tree). I can implement this new feature in a different way but that would break the format of the config file, which I am trying to avoid... That would piss off the 2+ users of the plugin :) I would understand if it's vetoed given the nature of the change. Cheers, Jerome Lacoste - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: apply MNG-2293 to maven-2.0.x?
it's ok for me if all tests are ok. With it, mojo will can evoluate without waiting maven 2.1 Emmanuel Kenney Westerhof a écrit : Hi there, This issue is about adding an 'implementation' parameter to the @parameter annotation for mojo fields, so you can specify a default implementation in case the field's type is an interface. Since it's a new feature, I'm asking whether this should be applied to the 2.0.x branch too? I've discussed this with Carlos and he feels that we shouldn't apply to 2.0.x since this is a new feature. But if it should, I want to do this ASAP so the overhead of updating the patch after other commits on the branch could consume a lot of time.. I've applied the patch to the 2.0.x branch locally and all it tests pass. There's currently no workaround for this in 2.0.x - it requires maven-plugin-descriptor and maven-core 2.1-SNAPSHOT. WDYT? -- Kenney - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: apply MNG-2293 to maven-2.0.x?
+1, but considering it an exception to the rule, not a change to the rule. I'd rather we were doing .x releases every 6 months instead. - Brett Emmanuel Venisse wrote: it's ok for me if all tests are ok. With it, mojo will can evoluate without waiting maven 2.1 Emmanuel Kenney Westerhof a écrit : Hi there, This issue is about adding an 'implementation' parameter to the @parameter annotation for mojo fields, so you can specify a default implementation in case the field's type is an interface. Since it's a new feature, I'm asking whether this should be applied to the 2.0.x branch too? I've discussed this with Carlos and he feels that we shouldn't apply to 2.0.x since this is a new feature. But if it should, I want to do this ASAP so the overhead of updating the patch after other commits on the branch could consume a lot of time.. I've applied the patch to the 2.0.x branch locally and all it tests pass. There's currently no workaround for this in 2.0.x - it requires maven-plugin-descriptor and maven-core 2.1-SNAPSHOT. WDYT? -- Kenney - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Brett Porter [EMAIL PROTECTED] Apache Maven - http://maven.apache.org/ Better Builds with Maven - http://library.mergere.com/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
