Review Request 25618: MESOS-1792: add os::shell with pluggable IO descriptors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25618/ --- Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Vinod Kone. Bugs: MESOS-1792 https://issues.apache.org/jira/browse/MESOS-1792 Repository: mesos-git Description --- Adds an overload of os::shell that allows to run a command with stdin and/or stdout substituted by file descriptors passed as parameters. This will allow to pipe a stream of data in and out of a process e.g. directly from download to extraction, as proposed by Bernd Mathiske in MESOS-1667. A unit test has been added. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp 6728ad8 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 84ef49c Diff: https://reviews.apache.org/r/25618/diff/ Testing --- cd 3rdparty/libprocess/ make check Thanks, Kamil Domanski
Re: Review Request 25035: Fix for MESOS-1688
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25035/#review53280 --- Patch looks great! Reviews applied: [25035] All tests passed. - Mesos ReviewBot On Sept. 13, 2014, 7:10 p.m., Martin Weindel wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25035/ --- (Updated Sept. 13, 2014, 7:10 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1688 https://issues.apache.org/jira/browse/MESOS-1688 Repository: mesos-git Description --- As already explained in JIRA MESOS-1688, there are schedulers allocating memory only for the executor and not for tasks. For tasks only CPU resources are allocated in this case. Such a scheduler does not get offered any idle CPUs if the slave has nearly used up all memory. This can easily lead to a dead lock (in the application, not in Mesos). Simple example: 1. Scheduler allocates all memory of a slave for an executor 2. Scheduler launches a task for this executor (allocating 1 CPU) 3. Task finishes: 1 CPU , 0 MB memory allocatable. 4. No offers are made, as no memory is left. Scheduler will wait for offers forever. Dead lock in the application. To fix this problem, offers must be made if CPU resources are allocatable without considering allocatable memory Diffs - CHANGELOG a822cc4 src/common/resources.cpp edf36b1 src/master/constants.cpp faa1503 src/master/hierarchical_allocator_process.hpp 34f8cd6 src/master/master.cpp 18464ba src/tests/allocator_tests.cpp 774528a Diff: https://reviews.apache.org/r/25035/diff/ Testing --- Deployed patched Mesos 0.19.1 on a small cluster with 3 slaves and tested running multiple parallel Spark jobs in fine-grained mode to saturate allocatable memory. The jobs run fine now. This load always caused a dead lock in all Spark jobs within one minute with the unpatched Mesos. Thanks, Martin Weindel
Jenkins build is back to normal : mesos-reviewbot #1540
See https://builds.apache.org/job/mesos-reviewbot/1540/
Review Request 25622: Update the Mesos Style Guide with C++11 and naming notes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25622/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, Dominic Hamon, and Till Toenshoff. Bugs: MESOS-1793 https://issues.apache.org/jira/browse/MESOS-1793 Repository: mesos-git Description --- Explicitly prohibit the use of namespace aliases. The discussion about using namespace aliases took place in [the other review](https://reviews.apache.org/r/25434/#comment91754). The majority agreed not to introduce them in code. Add a note about allowed C++11 features. This issue was discussed [here](https://mail-archives.apache.org/mod_mbox/mesos-dev/201408.mbox/%3CCA+A2mTvk9RpUY0mFzdQnJTg8sA0nW-51fAwpuPrRjyGp+QV=a...@mail.gmail.com%3E) and has to be officially documented. Diffs - docs/mesos-c++-style-guide.md 4381d24 Diff: https://reviews.apache.org/r/25622/diff/ Testing --- Documentation change, no `make check` needed. Thanks, Alexander Rukletsov
Re: Review Request 25618: MESOS-1792: add os::shell with pluggable IO descriptors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25618/ --- (Updated Sept. 14, 2014, 4:05 p.m.) Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Vinod Kone. Changes --- Added return value check for pipe2 Added #include unistd.h Bugs: MESOS-1792 https://issues.apache.org/jira/browse/MESOS-1792 Repository: mesos-git Description --- Adds an overload of os::shell that allows to run a command with stdin and/or stdout substituted by file descriptors passed as parameters. This will allow to pipe a stream of data in and out of a process e.g. directly from download to extraction, as proposed by Bernd Mathiske in MESOS-1667. A unit test has been added. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp 6728ad8 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 84ef49c Diff: https://reviews.apache.org/r/25618/diff/ Testing --- cd 3rdparty/libprocess/ make check Thanks, Kamil Domanski
Re: Review Request 25618: MESOS-1792: add os::shell with pluggable IO descriptors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25618/#review53287 --- Patch looks great! Reviews applied: [25618] All tests passed. - Mesos ReviewBot On Sept. 14, 2014, 2:05 p.m., Kamil Domanski wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25618/ --- (Updated Sept. 14, 2014, 2:05 p.m.) Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Vinod Kone. Bugs: MESOS-1792 https://issues.apache.org/jira/browse/MESOS-1792 Repository: mesos-git Description --- Adds an overload of os::shell that allows to run a command with stdin and/or stdout substituted by file descriptors passed as parameters. This will allow to pipe a stream of data in and out of a process e.g. directly from download to extraction, as proposed by Bernd Mathiske in MESOS-1667. A unit test has been added. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp 6728ad8 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 84ef49c Diff: https://reviews.apache.org/r/25618/diff/ Testing --- cd 3rdparty/libprocess/ make check Thanks, Kamil Domanski
Review Request 25623: MESOS-1794: allow CURL download into any FD
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25623/
---
Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Vinod
Kone.
Bugs: MESOS-1794
https://issues.apache.org/jira/browse/MESOS-1794
Repository: mesos-git
Description
---
This divides {{Tryint net::download(const std::string url, const
std::string path)}} into three overloads:
1. Tryint net::download(const std::string url, FILE* file) downloads a file
and sends it to FILE stream
2. Tryint net::download(const std::string url, int fdout) opens a file
stream based on a file descriptor and calls 1)
3. Tryint net::download(const std::string url, const std::string path)
opens a file at _path_ and passes the descriptor to 2), effectively working as
before this change
This will allow to download into any file descriptor, such as a pipe, e.g.
directly to extraction, as proposed by Bernd Mathiske in MESOS-1667.
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 7138bc2
Diff: https://reviews.apache.org/r/25623/diff/
Testing
---
`cd 3rdparty/libprocess/ make check` for compilation test only
https://gist.github.com/kdomanski/f1d39266f6abc0f14f58 for operation test
Thanks,
Kamil Domanski
Re: Review Request 25623: MESOS-1794: allow CURL download into any FD
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25623/#review53291
---
Bad patch!
Reviews applied: [25623]
Failed command: ./support/mesos-style.py
Error:
Checking 504 files using filter
--filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:102: Redundant blank
line at the start of a code block should be deleted. [whitespace/blank_line]
[2]
Total errors found: 1
- Mesos ReviewBot
On Sept. 14, 2014, 5:47 p.m., Kamil Domanski wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25623/
---
(Updated Sept. 14, 2014, 5:47 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Vinod
Kone.
Bugs: MESOS-1794
https://issues.apache.org/jira/browse/MESOS-1794
Repository: mesos-git
Description
---
This divides {{Tryint net::download(const std::string url, const
std::string path)}} into three overloads:
1. Tryint net::download(const std::string url, FILE* file) downloads a
file and sends it to FILE stream
2. Tryint net::download(const std::string url, int fdout) opens a file
stream based on a file descriptor and calls 1)
3. Tryint net::download(const std::string url, const std::string path)
opens a file at _path_ and passes the descriptor to 2), effectively working
as before this change
This will allow to download into any file descriptor, such as a pipe, e.g.
directly to extraction, as proposed by Bernd Mathiske in MESOS-1667.
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 7138bc2
Diff: https://reviews.apache.org/r/25623/diff/
Testing
---
`cd 3rdparty/libprocess/ make check` for compilation test only
https://gist.github.com/kdomanski/f1d39266f6abc0f14f58 for operation test
Thanks,
Kamil Domanski
Re: Review Request 25623: MESOS-1794: allow CURL download into any FD
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25623/
---
(Updated Sept. 14, 2014, 8:25 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Vinod
Kone.
Changes
---
fixed style
Bugs: MESOS-1794
https://issues.apache.org/jira/browse/MESOS-1794
Repository: mesos-git
Description
---
This divides {{Tryint net::download(const std::string url, const
std::string path)}} into three overloads:
1. Tryint net::download(const std::string url, FILE* file) downloads a file
and sends it to FILE stream
2. Tryint net::download(const std::string url, int fdout) opens a file
stream based on a file descriptor and calls 1)
3. Tryint net::download(const std::string url, const std::string path)
opens a file at _path_ and passes the descriptor to 2), effectively working as
before this change
This will allow to download into any file descriptor, such as a pipe, e.g.
directly to extraction, as proposed by Bernd Mathiske in MESOS-1667.
Diffs (updated)
-
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 7138bc2
Diff: https://reviews.apache.org/r/25623/diff/
Testing
---
`cd 3rdparty/libprocess/ make check` for compilation test only
https://gist.github.com/kdomanski/f1d39266f6abc0f14f58 for operation test
Thanks,
Kamil Domanski
Build failed in Jenkins: mesos-reviewbot #1547
See https://builds.apache.org/job/mesos-reviewbot/1547/
--
[...truncated 5543 lines...]
rm -f slave/*.o
rm -f slave/containerizer/.dirstamp
rm -f slave/containerizer/isolators/cgroups/.deps/.dirstamp
rm -f slave/*.lo
rm -f slave/containerizer/isolators/cgroups/.dirstamp
rm -f slave/containerizer/*.o
rm -f slave/containerizer/isolators/network/.deps/.dirstamp
rm -f slave/containerizer/isolators/network/.dirstamp
rm -f slave/containerizer/mesos/.deps/.dirstamp
rm -f slave/containerizer/*.lo
rm -f slave/containerizer/mesos/.dirstamp
rm -f slave/containerizer/isolators/cgroups/*.o
rm -f state/.deps/.dirstamp
rm -f state/.dirstamp
rm -f slave/containerizer/isolators/cgroups/*.lo
rm -f tests/.deps/.dirstamp
rm -f slave/containerizer/isolators/network/*.o
rm -f tests/.dirstamp
rm -f slave/containerizer/isolators/network/*.lo
rm -f tests/common/.deps/.dirstamp
rm -f tests/common/.dirstamp
rm -f slave/containerizer/mesos/*.o
rm -f usage/.deps/.dirstamp
rm -f usage/.dirstamp
rm -f slave/containerizer/mesos/*.lo
rm -f zookeeper/.deps/.dirstamp
rm -f state/*.o
rm -f zookeeper/.dirstamp
rm -f state/*.lo
rm -f tests/*.o
rm -rf authorizer/.libs authorizer/_libs
rm -rf common/.libs common/_libs
rm -rf containerizer/.libs containerizer/_libs
rm -rf docker/.libs docker/_libs
rm -rf exec/.libs exec/_libs
rm -f tests/common/*.o
rm -rf files/.libs files/_libs
rm -f usage/*.o
rm -rf java/jni/.libs java/jni/_libs
rm -f usage/*.lo
rm -f zookeeper/*.o
rm -rf jvm/.libs jvm/_libs
rm -f zookeeper/*.lo
rm -rf jvm/org/apache/.libs jvm/org/apache/_libs
rm -rf linux/.libs linux/_libs
rm -rf linux/routing/.libs linux/routing/_libs
rm -rf linux/routing/filter/.libs linux/routing/filter/_libs
rm -rf linux/routing/link/.libs linux/routing/link/_libs
rm -rf linux/routing/queueing/.libs linux/routing/queueing/_libs
rm -rf local/.libs local/_libs
rm -rf log/.libs log/_libs
rm -rf log/tool/.libs log/tool/_libs
rm -rf logging/.libs logging/_libs
rm -rf master/.libs master/_libs
rm -rf messages/.libs messages/_libs
rm -rf sasl/.libs sasl/_libs
rm -rf sched/.libs sched/_libs
rm -rf scheduler/.libs scheduler/_libs
rm -rf slave/.libs slave/_libs
rm -rf slave/containerizer/.libs slave/containerizer/_libs
rm -rf slave/containerizer/isolators/cgroups/.libs
slave/containerizer/isolators/cgroups/_libs
rm -rf slave/containerizer/isolators/network/.libs
slave/containerizer/isolators/network/_libs
rm -rf slave/containerizer/mesos/.libs slave/containerizer/mesos/_libs
rm -rf state/.libs state/_libs
rm -rf usage/.libs usage/_libs
rm -rf zookeeper/.libs zookeeper/_libs
rm -rf ./.deps authorizer/.deps cli/.deps common/.deps containerizer/.deps
docker/.deps examples/.deps exec/.deps files/.deps health-check/.deps
java/jni/.deps jvm/.deps jvm/org/apache/.deps launcher/.deps linux/.deps
linux/routing/.deps linux/routing/filter/.deps linux/routing/link/.deps
linux/routing/queueing/.deps local/.deps log/.deps log/tool/.deps logging/.deps
master/.deps messages/.deps sasl/.deps sched/.deps scheduler/.deps slave/.deps
slave/containerizer/.deps slave/containerizer/isolators/cgroups/.deps
slave/containerizer/isolators/network/.deps slave/containerizer/mesos/.deps
state/.deps tests/.deps tests/common/.deps usage/.deps zookeeper/.deps
rm -f Makefile
make[2]: Leaving directory
`https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/src'
Making distclean in ec2
make[2]: Entering directory
`https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/ec2'
rm -rf .libs _libs
rm -f *.lo
test -z || rm -f
test . = ../../ec2 || test -z || rm -f
rm -f Makefile
make[2]: Leaving directory
`https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/ec2'
rm -f config.status config.cache config.log configure.lineno
config.status.lineno
rm -f Makefile
make[1]: Leaving directory
`https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build'
if test -d mesos-0.21.0; then find mesos-0.21.0 -type d ! -perm -200 -exec
chmod u+w {} ';' rm -rf mesos-0.21.0 || { sleep 5 rm -rf
mesos-0.21.0; }; else :; fi
==
mesos-0.21.0 archives ready for distribution:
mesos-0.21.0.tar.gz
==
real92m7.624s
user142m59.471s
sys 8m25.377s
+ chmod -R +w 3rdparty CHANGELOG Doxyfile LICENSE Makefile Makefile.am
Makefile.in NOTICE README.md aclocal.m4 ar-lib autom4te.cache bin bootstrap
compile config.guess config.log config.lt config.status config.sub configure
configure.ac depcomp docs ec2 frameworks include install-sh libtool ltmain.sh
m4 mesos-0.21.0.tar.gz mesos.pc mesos.pc.in missing mpi src support
+ git clean -fdx
Removing .libs/
Removing 3rdparty/Makefile
Removing 3rdparty/Makefile.in
Removing 3rdparty/libprocess/.deps/
Removing 3rdparty/libprocess/3rdparty/.deps/
Removing 3rdparty/libprocess/3rdparty/Makefile
Removing 3rdparty/libprocess/3rdparty/Makefile.in
Removing
Build failed in Jenkins: mesos-reviewbot #1548
See https://builds.apache.org/job/mesos-reviewbot/1548/
--
[...truncated 5543 lines...]
rm -f slave/containerizer/isolators/network/.dirstamp
rm -f sched/*.o
rm -f slave/containerizer/mesos/.deps/.dirstamp
rm -f sched/*.lo
rm -f slave/containerizer/mesos/.dirstamp
rm -f scheduler/*.o
rm -f state/.deps/.dirstamp
rm -f scheduler/*.lo
rm -f state/.dirstamp
rm -f slave/*.o
rm -f tests/.deps/.dirstamp
rm -f tests/.dirstamp
rm -f tests/common/.deps/.dirstamp
rm -f slave/*.lo
rm -f tests/common/.dirstamp
rm -f slave/containerizer/*.o
rm -f usage/.deps/.dirstamp
rm -f usage/.dirstamp
rm -f slave/containerizer/*.lo
rm -f zookeeper/.deps/.dirstamp
rm -f slave/containerizer/isolators/cgroups/*.o
rm -f zookeeper/.dirstamp
rm -f slave/containerizer/isolators/cgroups/*.lo
rm -f slave/containerizer/isolators/network/*.o
rm -f slave/containerizer/isolators/network/*.lo
rm -f slave/containerizer/mesos/*.o
rm -f slave/containerizer/mesos/*.lo
rm -f state/*.o
rm -f state/*.lo
rm -f tests/*.o
rm -f tests/common/*.o
rm -f usage/*.o
rm -f usage/*.lo
rm -f zookeeper/*.o
rm -f zookeeper/*.lo
rm -rf authorizer/.libs authorizer/_libs
rm -rf common/.libs common/_libs
rm -rf containerizer/.libs containerizer/_libs
rm -rf docker/.libs docker/_libs
rm -rf exec/.libs exec/_libs
rm -rf files/.libs files/_libs
rm -rf java/jni/.libs java/jni/_libs
rm -rf jvm/.libs jvm/_libs
rm -rf jvm/org/apache/.libs jvm/org/apache/_libs
rm -rf linux/.libs linux/_libs
rm -rf linux/routing/.libs linux/routing/_libs
rm -rf linux/routing/filter/.libs linux/routing/filter/_libs
rm -rf linux/routing/link/.libs linux/routing/link/_libs
rm -rf linux/routing/queueing/.libs linux/routing/queueing/_libs
rm -rf local/.libs local/_libs
rm -rf log/.libs log/_libs
rm -rf log/tool/.libs log/tool/_libs
rm -rf logging/.libs logging/_libs
rm -rf master/.libs master/_libs
rm -rf messages/.libs messages/_libs
rm -rf sasl/.libs sasl/_libs
rm -rf sched/.libs sched/_libs
rm -rf scheduler/.libs scheduler/_libs
rm -rf slave/.libs slave/_libs
rm -rf slave/containerizer/.libs slave/containerizer/_libs
rm -rf slave/containerizer/isolators/cgroups/.libs
slave/containerizer/isolators/cgroups/_libs
rm -rf slave/containerizer/isolators/network/.libs
slave/containerizer/isolators/network/_libs
rm -rf slave/containerizer/mesos/.libs slave/containerizer/mesos/_libs
rm -rf state/.libs state/_libs
rm -rf usage/.libs usage/_libs
rm -rf zookeeper/.libs zookeeper/_libs
rm -rf ./.deps authorizer/.deps cli/.deps common/.deps containerizer/.deps
docker/.deps examples/.deps exec/.deps files/.deps health-check/.deps
java/jni/.deps jvm/.deps jvm/org/apache/.deps launcher/.deps linux/.deps
linux/routing/.deps linux/routing/filter/.deps linux/routing/link/.deps
linux/routing/queueing/.deps local/.deps log/.deps log/tool/.deps logging/.deps
master/.deps messages/.deps sasl/.deps sched/.deps scheduler/.deps slave/.deps
slave/containerizer/.deps slave/containerizer/isolators/cgroups/.deps
slave/containerizer/isolators/network/.deps slave/containerizer/mesos/.deps
state/.deps tests/.deps tests/common/.deps usage/.deps zookeeper/.deps
rm -f Makefile
make[2]: Leaving directory
`https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/src'
Making distclean in ec2
make[2]: Entering directory
`https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/ec2'
rm -rf .libs _libs
rm -f *.lo
test -z || rm -f
test . = ../../ec2 || test -z || rm -f
rm -f Makefile
make[2]: Leaving directory
`https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/ec2'
rm -f config.status config.cache config.log configure.lineno
config.status.lineno
rm -f Makefile
make[1]: Leaving directory
`https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build'
if test -d mesos-0.21.0; then find mesos-0.21.0 -type d ! -perm -200 -exec
chmod u+w {} ';' rm -rf mesos-0.21.0 || { sleep 5 rm -rf
mesos-0.21.0; }; else :; fi
==
mesos-0.21.0 archives ready for distribution:
mesos-0.21.0.tar.gz
==
real107m31.932s
user146m18.414s
sys 8m43.954s
+ chmod -R +w 3rdparty CHANGELOG Doxyfile LICENSE Makefile Makefile.am
Makefile.in NOTICE README.md aclocal.m4 ar-lib autom4te.cache bin bootstrap
compile config.guess config.log config.lt config.status config.sub configure
configure.ac depcomp docs ec2 frameworks include install-sh libtool ltmain.sh
m4 mesos-0.21.0.tar.gz mesos.pc mesos.pc.in missing mpi src support
+ git clean -fdx
Removing .libs/
Removing 3rdparty/Makefile
Removing 3rdparty/Makefile.in
Removing 3rdparty/libprocess/.deps/
Removing 3rdparty/libprocess/3rdparty/.deps/
Removing 3rdparty/libprocess/3rdparty/Makefile
Removing 3rdparty/libprocess/3rdparty/Makefile.in
Removing 3rdparty/libprocess/3rdparty/gmock_sources.cc
Removing 3rdparty/libprocess/3rdparty/stout/Makefile
Removing 3rdparty/libprocess/3rdparty/stout/Makefile.in
Removing
Contributor role in Jira
Vinod, I'm working with Adam Bordelon to manage 0.20.1 release. Can you grant me Contributor access in jira to manage versions and changelogs? Thank you, -- Regards, Bhuvan Arumugam www.livecipher.com
Re: Review Request 25237: Avoid Docker pull on each run
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25237/#review53297 --- Timothy Chen: do you have an ETA for a revised patch? This would help to plan 0.20.1 release. - Bhuvan Arumugam On Sept. 1, 2014, 7:16 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25237/ --- (Updated Sept. 1, 2014, 7:16 p.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos-git Description --- Avoid Docker pull on each run. Currently each Docker run will run a docker pull which calls the docker registry each time. To avoid this this patch adds a docker inspect image and skip calling pull if it already exists. Diffs - src/slave/containerizer/docker.cpp 0febbac5df4126f6c8d9a06dd0ba1668d041b34a Diff: https://reviews.apache.org/r/25237/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 25237: Avoid Docker pull on each run
Hi Bhuvan, I already have a new patch here: https://reviews.apache.org/r/25523/ Thanks, Tim Sent from my iPhone On Sep 14, 2014, at 5:33 PM, Bhuvan Arumugam bhu...@apache.org wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25237/ Timothy Chen: do you have an ETA for a revised patch? This would help to plan 0.20.1 release. - Bhuvan Arumugam On September 1st, 2014, 7:16 p.m. UTC, Timothy Chen wrote: Review request for mesos, Benjamin Hindman and Jie Yu. By Timothy Chen. Updated Sept. 1, 2014, 7:16 p.m. Repository: mesos-git Description Avoid Docker pull on each run. Currently each Docker run will run a docker pull which calls the docker registry each time. To avoid this this patch adds a docker inspect image and skip calling pull if it already exists. Testing make check Diffs src/slave/containerizer/docker.cpp (0febbac5df4126f6c8d9a06dd0ba1668d041b34a) View Diff
Re: Contributor role in Jira
Done. On Sun, Sep 14, 2014 at 5:24 PM, Bhuvan Arumugam bhu...@apache.org wrote: Vinod, I'm working with Adam Bordelon to manage 0.20.1 release. Can you grant me Contributor access in jira to manage versions and changelogs? Thank you, -- Regards, Bhuvan Arumugam www.livecipher.com
Re: Review Request 25270: Enable bridge network in Mesos
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/#review53298 --- src/tests/docker_containerizer_tests.cpp https://reviews.apache.org/r/25270/#comment92903 Timothy Chen: do you intend to use the image mesosphere/test-executor? - Bhuvan Arumugam On Sept. 11, 2014, 5:48 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/ --- (Updated Sept. 11, 2014, 5:48 p.m.) Review request for mesos, Benjamin Hindman, Jie Yu, and Timothy St. Clair. Bugs: MESOS-1621 https://issues.apache.org/jira/browse/MESOS-1621 Repository: mesos-git Description --- Review: https://reviews.apache.org/r/25270 Diffs - include/mesos/mesos.proto dea51f94d130c131421c43e7fd774ceb8941f501 src/docker/docker.cpp af51ac9058382aede61b09e06e312ad2ce6de03e src/slave/slave.cpp 1b3dc7370a2441e4159aa5ee552b64ca5e511e96 src/tests/docker_containerizer_tests.cpp 8654f9c787bd207f6a7b821651e0c083bea9dc8a src/tests/docker_tests.cpp 826a8c1ef1b3089d416e5775fa2cf4e5cb0c26d1 Diff: https://reviews.apache.org/r/25270/diff/ Testing --- make check Thanks, Timothy Chen
Jenkins build is back to normal : mesos-reviewbot #1549
See https://builds.apache.org/job/mesos-reviewbot/1549/
Re: Review Request 25623: MESOS-1794: allow CURL download into any FD
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25623/#review53300
---
Patch looks great!
Reviews applied: [25623]
All tests passed.
- Mesos ReviewBot
On Sept. 14, 2014, 6:25 p.m., Kamil Domanski wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25623/
---
(Updated Sept. 14, 2014, 6:25 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Vinod
Kone.
Bugs: MESOS-1794
https://issues.apache.org/jira/browse/MESOS-1794
Repository: mesos-git
Description
---
This divides {{Tryint net::download(const std::string url, const
std::string path)}} into three overloads:
1. Tryint net::download(const std::string url, FILE* file) downloads a
file and sends it to FILE stream
2. Tryint net::download(const std::string url, int fdout) opens a file
stream based on a file descriptor and calls 1)
3. Tryint net::download(const std::string url, const std::string path)
opens a file at _path_ and passes the descriptor to 2), effectively working
as before this change
This will allow to download into any file descriptor, such as a pipe, e.g.
directly to extraction, as proposed by Bernd Mathiske in MESOS-1667.
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 7138bc2
Diff: https://reviews.apache.org/r/25623/diff/
Testing
---
`cd 3rdparty/libprocess/ make check` for compilation test only
https://gist.github.com/kdomanski/f1d39266f6abc0f14f58 for operation test
Thanks,
Kamil Domanski
Re: Review Request 25622: Update the Mesos Style Guide with C++11 and naming notes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25622/#review53303 --- You might want to wait for [MESOS-1752](https://issues.apache.org/jira/browse/MESOS-1752) and [MESOS-1753](https://issues.apache.org/jira/browse/MESOS-1753). - Kamil Domanski On Sept. 14, 2014, 4:03 p.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25622/ --- (Updated Sept. 14, 2014, 4:03 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, Dominic Hamon, and Till Toenshoff. Bugs: MESOS-1793 https://issues.apache.org/jira/browse/MESOS-1793 Repository: mesos-git Description --- Explicitly prohibit the use of namespace aliases. The discussion about using namespace aliases took place in [the other review](https://reviews.apache.org/r/25434/#comment91754). The majority agreed not to introduce them in code. Add a note about allowed C++11 features. This issue was discussed [here](https://mail-archives.apache.org/mod_mbox/mesos-dev/201408.mbox/%3CCA+A2mTvk9RpUY0mFzdQnJTg8sA0nW-51fAwpuPrRjyGp+QV=a...@mail.gmail.com%3E) and has to be officially documented. Diffs - docs/mesos-c++-style-guide.md 4381d24 Diff: https://reviews.apache.org/r/25622/diff/ Testing --- Documentation change, no `make check` needed. Thanks, Alexander Rukletsov
Re: Review Request 25270: Enable bridge network in Mesos
On Sept. 15, 2014, 12:44 a.m., Bhuvan Arumugam wrote: src/tests/docker_containerizer_tests.cpp, line 243 https://reviews.apache.org/r/25270/diff/5/?file=685937#file685937line243 Timothy Chen: do you intend to use the image mesosphere/test-executor? No I actually intend to use the new image, I don't have access to update that image so I created a new one. The test-executor is a native go implementation of the api, and was lacking what libprocess was doing which is to publish PID with publish host ip, and it used to only subscribe as 0.0.0.0 which won't work with bridge network. - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/#review53298 --- On Sept. 11, 2014, 5:48 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/ --- (Updated Sept. 11, 2014, 5:48 p.m.) Review request for mesos, Benjamin Hindman, Jie Yu, and Timothy St. Clair. Bugs: MESOS-1621 https://issues.apache.org/jira/browse/MESOS-1621 Repository: mesos-git Description --- Review: https://reviews.apache.org/r/25270 Diffs - include/mesos/mesos.proto dea51f94d130c131421c43e7fd774ceb8941f501 src/docker/docker.cpp af51ac9058382aede61b09e06e312ad2ce6de03e src/slave/slave.cpp 1b3dc7370a2441e4159aa5ee552b64ca5e511e96 src/tests/docker_containerizer_tests.cpp 8654f9c787bd207f6a7b821651e0c083bea9dc8a src/tests/docker_tests.cpp 826a8c1ef1b3089d416e5775fa2cf4e5cb0c26d1 Diff: https://reviews.apache.org/r/25270/diff/ Testing --- make check Thanks, Timothy Chen
Build failed in Jenkins: mesos-reviewbot #1552
See https://builds.apache.org/job/mesos-reviewbot/1552/ -- [...truncated 3770 lines...] libtool: link: g++ -pthread -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -o .libs/mesos-slave slave/mesos_slave-main.o ./.libs/libmesos.so -lsasl2 /usr/lib/x86_64-linux-gnu/libcurl.so -lz -lrt -pthread -Wl,-rpath -Wl,https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_inst/lib libtool: link: g++ -pthread -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -o .libs/mesos-master master/mesos_master-main.o ./.libs/libmesos.so -lsasl2 /usr/lib/x86_64-linux-gnu/libcurl.so -lz -lrt -pthread -Wl,-rpath -Wl,https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_inst/lib creating build/bdist.linux-x86_64 creating build/bdist.linux-x86_64/egg creating build/bdist.linux-x86_64/egg/mesos copying build/lib.linux-x86_64-2.7/mesos/__init__.py - build/bdist.linux-x86_64/egg/mesos creating build/bdist.linux-x86_64/egg/mesos/native copying build/lib.linux-x86_64-2.7/mesos/native/__init__.py - build/bdist.linux-x86_64/egg/mesos/native copying build/lib.linux-x86_64-2.7/mesos/native/_mesos.so - build/bdist.linux-x86_64/egg/mesos/native byte-compiling build/bdist.linux-x86_64/egg/mesos/__init__.py to __init__.pyc byte-compiling build/bdist.linux-x86_64/egg/mesos/native/__init__.py to __init__.pyc creating stub loader for mesos/native/_mesos.so byte-compiling build/bdist.linux-x86_64/egg/mesos/native/_mesos.py to _mesos.pyc creating build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.native.egg-info/PKG-INFO - build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.native.egg-info/SOURCES.txt - build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.native.egg-info/dependency_links.txt - build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.native.egg-info/namespace_packages.txt - build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.native.egg-info/requires.txt - build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.native.egg-info/top_level.txt - build/bdist.linux-x86_64/egg/EGG-INFO writing build/bdist.linux-x86_64/egg/EGG-INFO/native_libs.txt zip_safe flag not set; analyzing archive contents... mesos.__init__: module references __path__ creating dist creating 'dist/mesos.native-0.21.0-py2.7-linux-x86_64.egg' and adding 'build/bdist.linux-x86_64/egg' to it removing 'build/bdist.linux-x86_64/egg' (and everything under it) make[3]: Leaving directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/src' make[2]: Leaving directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/src' Making all in ec2 make[2]: Entering directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/ec2' make[2]: Nothing to be done for `all'. make[2]: Leaving directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/ec2' make[1]: Leaving directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build' make[1]: Entering directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build' Making dvi in . make[2]: Entering directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build' make[2]: Nothing to be done for `dvi-am'. make[2]: Leaving directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build' Making dvi in 3rdparty make[2]: Entering directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty' Making dvi in libprocess make[3]: Entering directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty/libprocess' Making dvi in 3rdparty make[4]: Entering directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty/libprocess/3rdparty' Making dvi in stout make[5]: Entering directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty/libprocess/3rdparty/stout' Making dvi in . make[6]: Entering directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty/libprocess/3rdparty/stout' make[6]: Nothing to be done for `dvi-am'. make[6]: Leaving directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty/libprocess/3rdparty/stout' Making dvi in include make[6]: Entering directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty/libprocess/3rdparty/stout/include' make[6]: Nothing to be done for `dvi'. make[6]: Leaving directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty/libprocess/3rdparty/stout/include' make[5]: Leaving directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty/libprocess/3rdparty/stout' make[5]: Entering directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty/libprocess/3rdparty' make[5]: Nothing to be done for `dvi-am'. make[5]: Leaving directory
