Re: Review Request 33296: Added a flag which controls libprocess firewall initialzation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33296/#review81160 --- Patch looks great! Reviews applied: [33295, 33296] All tests passed. - Mesos ReviewBot On April 22, 2015, 2:36 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33296/ --- (Updated April 22, 2015, 2:36 p.m.) Review request for mesos, Adam B, Benjamin Hindman, and Till Toenshoff. Bugs: MESOS-2620 https://issues.apache.org/jira/browse/MESOS-2620 Repository: mesos Description --- See summary. Diffs - include/mesos/mesos.proto 3a8e8bf303e0576c212951f6028af77e54d93537 include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45 src/common/parse.hpp 547b32041f39f0ff0c38179b66a32b2239134abc src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90 src/master/main.cpp 88bb39d57ea7d654bea11a3db0cf0903b4b22d99 src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032 src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932 src/slave/main.cpp c62d3ab9825bf952071e8e312d383a0cb46547d2 Diff: https://reviews.apache.org/r/33296/diff/ Testing --- make check and manual tests. Thanks, Alexander Rojas
Re: Review Request 29889: Recover Docker containers when mesos slave is in a container
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29889/#review81180 --- Bad patch! Reviews applied: [29327, 29328] Failed command: ./support/apply-review.sh -n -r 29328 Error: 2015-04-22 17:37:07 URL:https://reviews.apache.org/r/29328/diff/raw/ [2149/2149] - 29328.patch [1] error: patch failed: src/slave/flags.hpp:311 error: src/slave/flags.hpp: patch does not apply Failed to apply patch - Mesos ReviewBot On April 22, 2015, 5:33 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29889/ --- (Updated April 22, 2015, 5:33 p.m.) Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff. Repository: mesos Description --- This is a one mega patch and contains many reviews that's already on rb. This review is not meant to be merged, only provided for easier review. Diffs - Dockerfile 35abf25 docs/configuration.md 54c4e31 docs/docker-containerizer.md a5438b7 src/Makefile.am 93c7c8a src/docker/docker.hpp 3ebbc1f src/docker/docker.cpp 3a485a2 src/docker/executor.cpp PRE-CREATION src/slave/containerizer/docker.hpp 0d5289c src/slave/containerizer/docker.cpp f9fb078 src/slave/flags.hpp d3b1ce1 src/slave/flags.cpp d0932b0 src/tests/docker_containerizer_tests.cpp b119a17 Diff: https://reviews.apache.org/r/29889/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 33109: Allow setting environment variables in mesos-execute
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33109/#review81195
---
Patch looks great!
Reviews applied: [33109]
All tests passed.
- Mesos ReviewBot
On April 22, 2015, 5:38 p.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33109/
---
(Updated April 22, 2015, 5:38 p.m.)
Review request for mesos and Adam B.
Bugs: MESOS-2023
https://issues.apache.org/jira/browse/MESOS-2023
Repository: mesos
Description
---
Allow setting environment variables in mesos-execute
Diffs
-
include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45
src/cli/execute.cpp 84f70dccbc2c5dd43f68105d967f4488c82f582b
src/common/parse.hpp 547b32041f39f0ff0c38179b66a32b2239134abc
Diff: https://reviews.apache.org/r/33109/diff/
Testing
---
### Test without env
```
$ ./src/mesos-execute --master=127.0.0.1:5050 --name=test --command='echo $a'
```
The log from mesos, we could see the output is empty
```
Registered executor on localhostI0423 01:27:37.180140 14061 slave.cpp:1540]
Sending queued task 'test' to executor 'test' of framework
20150423-012731-16777343-5050-14024-
Starting task test
Forked command at 14133
sh -c 'echo $a'
I0423 01:27:37.183823 14064 slave.cpp:2507] Handling status update
TASK_RUNNING (UUID: be8664ab-a4ca-409e-87e4-de3756506c4a) for task test of
framework 20150423-012731-16777343-5050-14024- from
executor(1)@127.0.0.1:33700
```
### Test with env from command
```
$ ./src/mesos-execute --master=127.0.0.1:5050 --name=test --command='echo
$a' --env={\a\: \stdin\}
```
The log from mesos, we could see the output is stdin
```
Registered executor on localhost
Starting task test
sh -c 'echo $a'
Forked command at 14783
stdin
I0423 01:30:41.750128 14063 slave.cpp:2507] Handling status update
TASK_RUNNING (UUID: e8b6cf52-9635-4393-94de-b16869e50c91) for task test of
framework 20150423-012731-16777343-5050-14024-0001 from
executor(1)@127.0.0.1:40051
```
### Test with env from file
```
$ cat /tmp/env
{a: file}
```
```
$ ./src/mesos-execute --master=127.0.0.1:5050 --name=test --command='echo
$a' --env=file:///tmp/env
```
The log from mesos, we could see the output is file
```
Registered executor on localhost
Starting task testsh -c 'echo $a'
Forked command at 15258
file
I0423 01:32:49.817705 14065 slave.cpp:2507] Handling status update
TASK_RUNNING (UUID: 9e8945d0-4921-41e8-a8e2-d64ec36eea16) for task test of
framework 20150423-012731-16777343-5050-14024-0002 from
executor(1)@127.0.0.1:56334
```
Thanks,
haosdent huang
Re: Review Request 33276: Fix capture by reference of temporaries in Libprocess.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33276/#review81202 --- Patch looks great! Reviews applied: [33271, 33274, 33276] All tests passed. - Mesos ReviewBot On April 22, 2015, 6:11 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33276/ --- (Updated April 22, 2015, 6:11 p.m.) Review request for mesos, Bernd Mathiske, Cody Maloney, Joerg Schad, Michael Park, and Till Toenshoff. Bugs: MESOS-2631 https://issues.apache.org/jira/browse/MESOS-2631 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/include/process/gmock.hpp a99eb8ae8fedef2b7d9e227afb3c101f82f753db 3rdparty/libprocess/src/http.cpp eed42ad2725d56ef8c000c1bdedcdc6063ad28c9 3rdparty/libprocess/src/process.cpp 97ac09fd10b767bc46387abc3657d005a00830c8 3rdparty/libprocess/src/tests/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618 3rdparty/libprocess/src/tests/reap_tests.cpp a18d54c43fba44d084e722abdc67d32e5d4504e4 Diff: https://reviews.apache.org/r/33276/diff/ Testing --- make check Thanks, Joris Van Remoortere
Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review81131
---
Patch looks great!
Reviews applied: [32198, 32163, 30612]
All tests passed.
- Mesos ReviewBot
On April 22, 2015, 6:21 a.m., Alexander Rojas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/
---
(Updated April 22, 2015, 6:21 a.m.)
Review request for mesos, Ben Mahler, Marco Massenzio, Niklas Nielsen, and
Till Toenshoff.
Bugs: MESOS-2157
https://issues.apache.org/jira/browse/MESOS-2157
Repository: mesos
Description
---
Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
Adds tests for the endpoints.
Works with [29883](https://reviews.apache.org/r/29883).
Builds on the abandoned patch 14286.
Diffs
-
src/master/http.cpp 00c22c43bd1f6cef7963b2ffa9c095c6cbd01cd3
src/master/master.hpp c10e7c08c191acef9d31d98018a47a2a952a4dfc
src/master/master.cpp b1093bb867eb8624740f3d094cef2c23405a18b6
src/tests/master_tests.cpp 32b1e9bb58d8046e5363fafe2ab8f662b6c9a666
Diff: https://reviews.apache.org/r/30612/diff/
Testing
---
make check
Thanks,
Alexander Rojas
Re: Review Request 33358: Moved implementation of StatusUpdateStream to a compilation unit.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33358/#review81137 --- Patch looks great! Reviews applied: [33358] All tests passed. - Mesos ReviewBot On April 22, 2015, 9:09 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33358/ --- (Updated April 22, 2015, 9:09 a.m.) Review request for mesos, Alexander Rukletsov, Joerg Schad, and Till Toenshoff. Bugs: MESOS-2609 https://issues.apache.org/jira/browse/MESOS-2609 Repository: mesos Description --- Moves the implementation of StatusUpdateStream to a compilation unit. Also cleans up headers. Diffs - src/slave/status_update_manager.hpp b4d91b22b515195fdb69c89af9c2864e469e7e54 src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4 Diff: https://reviews.apache.org/r/33358/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 33376: MESOS-2633 Moved struct Framework methods to their own implementation class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33376/#review81049 --- Patch looks great! Reviews applied: [33376] All tests passed. - Mesos ReviewBot On April 21, 2015, 7:06 p.m., Marco Massenzio wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33376/ --- (Updated April 21, 2015, 7:06 p.m.) Review request for mesos and Joris Van Remoortere. Bugs: MESOS-2633 https://issues.apache.org/jira/browse/MESOS-2633 Repository: mesos Description --- Created new file framework.cpp containing all the methods' implementations for the `Framework` class (declared in master/master.hpp) Declared `operator ==` for Task in type_utils.hpp (it was implemented before, but not declared in the header file); Refactored all the LOG(WARNING) to a single utility method. Diffs - .gitignore-template 1a8e2a8677a29f06ba6386d56537a0013d38821c include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45 src/Makefile.am d15a37365bcdd5c3906160b46b389635b38b1673 src/master/framework.cpp PRE-CREATION src/master/master.hpp c10e7c08c191acef9d31d98018a47a2a952a4dfc Diff: https://reviews.apache.org/r/33376/diff/ Testing --- All tests (make check) pass. Thanks, Marco Massenzio
Re: Review Request 33358: Moved implementation of StatusUpdateStream to a compilation unit.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33358/#review80971 --- Patch looks great! Reviews applied: [33358] All tests passed. - Mesos ReviewBot On April 21, 2015, 12:38 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33358/ --- (Updated April 21, 2015, 12:38 p.m.) Review request for mesos, Alexander Rukletsov, Joerg Schad, and Till Toenshoff. Bugs: MESOS-2609 https://issues.apache.org/jira/browse/MESOS-2609 Repository: mesos Description --- Moves the implementation of StatusUpdateStream to a compilation unit. Also cleans up headers. Diffs - src/slave/status_update_manager.hpp b4d91b22b515195fdb69c89af9c2864e469e7e54 src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4 Diff: https://reviews.apache.org/r/33358/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 33296: Added a flag which controls libprocess firewall initialzation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33296/#review80959 --- Patch looks great! Reviews applied: [33295, 33296] All tests passed. - Mesos ReviewBot On April 21, 2015, 12:02 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33296/ --- (Updated April 21, 2015, 12:02 p.m.) Review request for mesos, Adam B, Benjamin Hindman, and Till Toenshoff. Bugs: MESOS-2620 https://issues.apache.org/jira/browse/MESOS-2620 Repository: mesos Description --- See summary. Diffs - include/mesos/mesos.proto 3a8e8bf303e0576c212951f6028af77e54d93537 include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45 src/common/parse.hpp 547b32041f39f0ff0c38179b66a32b2239134abc src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90 src/master/main.cpp 7cce3a0bb808a1cb7bac9acab31eb1c67a15ea9f src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032 src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932 src/slave/main.cpp c62d3ab9825bf952071e8e312d383a0cb46547d2 Diff: https://reviews.apache.org/r/33296/diff/ Testing --- make check and manual tests. Thanks, Alexander Rojas
Re: Review Request 33415: Changed launchers and isolators to adapt to the new orphan cleanup semantics.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33415/#review81079 --- Bad patch! Reviews applied: [33412, 33413, 33414] Failed command: ./support/apply-review.sh -n -r 33414 Error: 2015-04-21 22:30:40 URL:https://reviews.apache.org/r/33414/diff/raw/ [8143/8143] - 33414.patch [1] error: patch failed: src/slave/containerizer/mesos/containerizer.cpp:1026 error: src/slave/containerizer/mesos/containerizer.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On April 21, 2015, 9:48 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33415/ --- (Updated April 21, 2015, 9:48 p.m.) Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. Bugs: MESOS-2367 https://issues.apache.org/jira/browse/MESOS-2367 Repository: mesos Description --- Changed launchers and isolators to adapt to the new orphan cleanup semantics. See my description in https://reviews.apache.org/r/33413/. Diffs - src/slave/containerizer/isolators/cgroups/cpushare.cpp 41b2597098a81baffae19fa91d6c9a86cf60d429 src/slave/containerizer/isolators/cgroups/mem.cpp a7a83ef9ad4726aa139a92fc7f5917ed687d33f5 src/slave/containerizer/isolators/cgroups/perf_event.cpp 4dfccc51035b234c31a9f73ca67b3bf0fd28441b src/slave/containerizer/isolators/namespaces/pid.cpp eb35ae6e34fa46dd38c9a96e69d38a229b3678d3 src/slave/containerizer/isolators/network/port_mapping.cpp ccdc44f465f204f674b859c429ba1a6ada51cd88 src/slave/containerizer/linux_launcher.hpp 60082c7eb8b77330911ac4fa38cc9ba795fc4051 src/slave/containerizer/linux_launcher.cpp b176ac126657ed8291dd817ceb61c04a68ff1d42 src/slave/containerizer/mesos/containerizer.hpp ae61a0fcd19f2ba808624312401f020121baf5d4 src/tests/port_mapping_tests.cpp 36219e737c75a5942dfc206c10997d5bcaf619fe Diff: https://reviews.apache.org/r/33415/diff/ Testing --- sudo make check The new code is exercised by the exiting test: PortMappingMesosTest.ROOT_CleanUpOrphanTest Thanks, Jie Yu
Re: Review Request 33372: Added decorator documentation and described the semantic change in Mesos 0.23.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33372/#review81063 --- Patch looks great! Reviews applied: [30961, 30962, 31016, 31028, 32948, 31017, 33372] All tests passed. - Mesos ReviewBot On April 21, 2015, 8:13 p.m., Niklas Nielsen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33372/ --- (Updated April 21, 2015, 8:13 p.m.) Review request for mesos and Adam B. Bugs: MESOS-2622 https://issues.apache.org/jira/browse/MESOS-2622 Repository: mesos Description --- See summary. Diffs - docs/modules.md a8b471541cdfa584eeb89fbe96643f93c712cfd4 Diff: https://reviews.apache.org/r/33372/diff/ Testing --- Thanks, Niklas Nielsen
Re: Review Request 33241: docs: Add documentation on observability metrics.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/#review81087 --- Patch looks great! Reviews applied: [33241] All tests passed. - Mesos ReviewBot On April 21, 2015, 10:09 p.m., Ricardo Cervera-Navarro wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/ --- (Updated April 21, 2015, 10:09 p.m.) Review request for mesos. Bugs: MESOS-2621 https://issues.apache.org/jira/browse/MESOS-2621 Repository: mesos Description --- docs: Add documentation on observability metrics. Diffs - docs/home.md 6ab61f85aa7d62e0f19267b886dffb4e0aa826ea docs/metrics.md PRE-CREATION Diff: https://reviews.apache.org/r/33241/diff/ Testing --- - Previewed in markdown editor. - Replaced page content using the Element Inspector in Chrome to ensure that the tables look good. Thanks, Ricardo Cervera-Navarro
Re: Review Request 33372: Added decorator documentation and described the semantic change in Mesos 0.23.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33372/#review80830 --- Patch looks great! Reviews applied: [30961, 30962, 31016, 31028, 32948, 31017, 33372] All tests passed. - Mesos ReviewBot On April 20, 2015, 9:27 p.m., Niklas Nielsen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33372/ --- (Updated April 20, 2015, 9:27 p.m.) Review request for mesos and Adam B. Bugs: MESOS-2622 https://issues.apache.org/jira/browse/MESOS-2622 Repository: mesos Description --- See summary. Diffs - docs/modules.md a8b471541cdfa584eeb89fbe96643f93c712cfd4 Diff: https://reviews.apache.org/r/33372/diff/ Testing --- Thanks, Niklas Nielsen
Re: Review Request 33257: Fixed recover tasks only by the intiated containerizer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33257/#review80845 --- Patch looks great! Reviews applied: [33257] All tests passed. - Mesos ReviewBot On April 20, 2015, 9:18 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33257/ --- (Updated April 20, 2015, 9:18 p.m.) Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ian Downes, Jie Yu, and Till Toenshoff. Bugs: MESOS-2601 https://issues.apache.org/jira/browse/MESOS-2601 Repository: mesos Description --- Fixed recover tasks only by the intiated containerizer. Currently both mesos and docker containerizer recovers tasks that wasn't started by themselves. The proposed fix is to record the intended containerizer in the checkpointed executorInfo, and reuse that information on recover to know if the containerizer should recover or not. We are free to modify the executorInfo since it's not being used to relaunch any task. The external containerizer doesn't need to change since it is only recovering containers that are returned by the containers script. Diffs - src/slave/containerizer/docker.hpp 0d5289c626bdf22420759485f2146abfb6bdaffc src/slave/containerizer/docker.cpp f9fb07806e3b7d7d2afc1be3b8756eac23b32dcd src/slave/containerizer/mesos/containerizer.cpp e4136095fca55637864f495098189ab3ad8d8fe7 src/slave/slave.cpp 8ec80ed26f338690e0a1e712065750ab77a724cd src/tests/containerizer_tests.cpp 5991aa628083dac7c5e8bf7ba297f4f9edeec05f src/tests/docker_containerizer_tests.cpp b119a174de79c2f98a0c575e6be2f59649f509ef Diff: https://reviews.apache.org/r/33257/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 33376: MESOS-2633 Moved struct Framework methods to their own implementation class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33376/#review80860 --- Patch looks great! Reviews applied: [33376] All tests passed. - Mesos ReviewBot On April 20, 2015, 10:38 p.m., Marco Massenzio wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33376/ --- (Updated April 20, 2015, 10:38 p.m.) Review request for mesos and Joris Van Remoortere. Bugs: MESOS-2633 https://issues.apache.org/jira/browse/MESOS-2633 Repository: mesos Description --- Created new file framework.cpp containing all the methods' implementations for the `Framework` class (declared in master/master.hpp) Declared `operator ==` for Task in type_utils.hpp (it was implemented before, but not declared in the header file); Refactored all the LOG(WARNING) to a single utility method. Diffs - .gitignore-template 1a8e2a8677a29f06ba6386d56537a0013d38821c include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45 src/Makefile.am d15a37365bcdd5c3906160b46b389635b38b1673 src/master/framework.cpp PRE-CREATION src/master/master.hpp c10e7c08c191acef9d31d98018a47a2a952a4dfc Diff: https://reviews.apache.org/r/33376/diff/ Testing --- All tests (make check) pass. Thanks, Marco Massenzio
Re: Review Request 32509: Documented the scheduler Event/Call protobufs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32509/#review80815 --- Patch looks great! Reviews applied: [32500, 32501, 32502, 32504, 32505, 32843, 32506, 32844, 32845, 32509] All tests passed. - Mesos ReviewBot On April 20, 2015, 8:05 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32509/ --- (Updated April 20, 2015, 8:05 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-1127 https://issues.apache.org/jira/browse/MESOS-1127 Repository: mesos Description --- See summary. Diffs - include/mesos/scheduler/scheduler.proto 783a63ad1cc0edd86605d638046fb959cb6e97e8 Diff: https://reviews.apache.org/r/32509/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/#review80700 --- Patch looks great! Reviews applied: [30032] All tests passed. - Mesos ReviewBot On April 20, 2015, 11:58 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/ --- (Updated April 20, 2015, 11:58 a.m.) Review request for mesos, Benjamin Hindman, Bernd Mathiske, Joerg Schad, Michael Park, and Till Toenshoff. Bugs: mesos-708 https://issues.apache.org/jira/browse/mesos-708 Repository: mesos Description --- When serving a static file, libprocess returns the header `Last-Modified` which is used by browsers to control Cache. When a http request arrives containing the header `If-Modified-Since`, a response `304 Not Modified` is returned if the date in the request and the modification time (as returned by doing `stat` in the file) coincide. Unit tests added. Diffs - 3rdparty/libprocess/include/process/http.hpp 07825b2b7195fe7fe752e8fda65b7f0a8b8b1f38 3rdparty/libprocess/src/process.cpp 97ac09fd10b767bc46387abc3657d005a00830c8 3rdparty/libprocess/src/tests/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618 Diff: https://reviews.apache.org/r/30032/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 32693: Change Http Request log level to VLOG(1)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32693/#review80670 --- Patch looks great! Reviews applied: [32693] All tests passed. - Mesos ReviewBot On April 20, 2015, 7 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32693/ --- (Updated April 20, 2015, 7 a.m.) Review request for mesos and Adam B. Bugs: MESOS-2498 https://issues.apache.org/jira/browse/MESOS-2498 Repository: mesos Description --- Change Http Request log level to VLOG(1) Diffs - src/master/http.cpp 00c22c43bd1f6cef7963b2ffa9c095c6cbd01cd3 src/slave/http.cpp 914e7e5d0d6f5f628ba3c02e0dc23629d0a23512 Diff: https://reviews.apache.org/r/32693/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 31268: Wired up test allocator to allocator tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31268/#review80721 --- Patch looks great! Reviews applied: [31775, 31776, 33356, 31266, 31267, 31262, 31263, 31265, 31268] All tests passed. - Mesos ReviewBot On April 20, 2015, 1:51 p.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31268/ --- (Updated April 20, 2015, 1:51 p.m.) Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen. Bugs: MESOS-2160 https://issues.apache.org/jira/browse/MESOS-2160 Repository: mesos Description --- Same typed tests are used for built-in and modularized allocators. Diffs - src/tests/master_allocator_tests.cpp 03a1bb8c92b44bc1ad1b5f5cff8d1fb971df2302 Diff: https://reviews.apache.org/r/31268/diff/ Testing --- make check (Mac OS 10.9.5, CentOS 7.0) Thanks, Alexander Rukletsov
Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review80743
---
Patch looks great!
Reviews applied: [32198, 32163, 30612]
All tests passed.
- Mesos ReviewBot
On April 20, 2015, 4:27 p.m., Alexander Rojas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/
---
(Updated April 20, 2015, 4:27 p.m.)
Review request for mesos, Ben Mahler, Marco Massenzio, Niklas Nielsen, and
Till Toenshoff.
Bugs: MESOS-2157
https://issues.apache.org/jira/browse/MESOS-2157
Repository: mesos
Description
---
Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
Adds tests for the endpoints.
Works with [29883](https://reviews.apache.org/r/29883).
Builds on the abandoned patch 14286.
Diffs
-
src/master/http.cpp 00c22c43bd1f6cef7963b2ffa9c095c6cbd01cd3
src/master/master.hpp c10e7c08c191acef9d31d98018a47a2a952a4dfc
src/master/master.cpp e30b951eda2b3b0d5b2a80716f0b32c6bbe041bc
src/tests/master_tests.cpp 32b1e9bb58d8046e5363fafe2ab8f662b6c9a666
Diff: https://reviews.apache.org/r/30612/diff/
Testing
---
make check
Thanks,
Alexander Rojas
Re: Review Request 33329: Removed unnecessary freeaddrinfo in getIP if getaddrinfo returns error.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33329/#review80800 --- Patch looks great! Reviews applied: [33329] All tests passed. - Mesos ReviewBot On April 20, 2015, 7:16 p.m., Chi Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33329/ --- (Updated April 20, 2015, 7:16 p.m.) Review request for mesos, Ben Mahler, Evelina Dumitrescu, and Jie Yu. Bugs: mesos-2636 https://issues.apache.org/jira/browse/mesos-2636 Repository: mesos Description --- Removed unnecessary freeaddrinfo in getIP if getaddrinfo returns error. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 3622165af064a1f0a9d461af0e1d0d88a352d4a8 Diff: https://reviews.apache.org/r/33329/diff/ Testing --- Thanks, Chi Zhang
Re: Review Request 31667: Piped hashmapSlaveID, Resources from allocator through to sorter.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31667/#review80429 --- Patch looks great! Reviews applied: [31183, 31664, 31665, 31666, 31667] All tests passed. - Mesos ReviewBot On April 17, 2015, 4:57 a.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31667/ --- (Updated April 17, 2015, 4:57 a.m.) Review request for mesos, Alexander Rukletsov and Ben Mahler. Bugs: MESOS-2373 https://issues.apache.org/jira/browse/MESOS-2373 Repository: mesos Description --- `Sorter` changes: - Augmented `add`, `remove`, `allocated`, `unallocated`, `update` with `SlaveID`. - `allocation` returns `hashmapSlaveID, Resources`. `DRFSorter` changes: - `allocations` is updated from `hashmapstd::string, Resources` to `hashmapstd::string, hashmapSlaveID, Resources`. - `resources` is updated from `Resources` to `hashmapSlaveID, Resources`. Diffs - src/master/allocator/mesos/hierarchical.hpp 9f9a631ee52a3ab194e678f9be139e8dabc7f3db src/master/allocator/sorter/drf/sorter.hpp 4366710d6530b784aa5094813328d0e338239ba0 src/master/allocator/sorter/drf/sorter.cpp 2f69f384b95ff20d3ee429a4570a8cffa74d8e8b src/master/allocator/sorter/sorter.hpp e2efb27b11dbea42dd73f81e5db0d6d2b0a6034b src/tests/sorter_tests.cpp 42442353afe7bd3d1a5b43992f8ae191ac19bdcd Diff: https://reviews.apache.org/r/31667/diff/ Testing --- make check Thanks, Michael Park
Re: Review Request 27113: Libprocess benchmark cleanup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27113/#review80495 --- Patch looks great! Reviews applied: [33315, 27113] All tests passed. - Mesos ReviewBot On April 17, 2015, 5:28 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27113/ --- (Updated April 17, 2015, 5:28 p.m.) Review request for mesos, Ben Mahler, Cody Maloney, Joerg Schad, and Michael Park. Bugs: MESOS-1980 https://issues.apache.org/jira/browse/MESOS-1980 Repository: mesos Description --- Clean up Libprocess for readability / extensibility. Diffs - 3rdparty/libprocess/src/tests/benchmarks.cpp a927e4ecd8c8955cd9f85e716173a73a9a21c6cd Diff: https://reviews.apache.org/r/27113/diff/ Testing --- make check Thanks, Joris Van Remoortere
Re: Review Request 33318: Fix docker containerizer usage and test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33318/#review80506 --- Patch looks great! Reviews applied: [33318] All tests passed. - Mesos ReviewBot On April 17, 2015, 6:21 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33318/ --- (Updated April 17, 2015, 6:21 p.m.) Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff. Repository: mesos Description --- Fix docker containerizer usage and test. The docker usage test is failing with the most recent change in including executor resources in docker containerizer. Diffs - src/slave/containerizer/docker.hpp 6893684e6d199a5d69fc8bba8e60c4acaae9c3c9 src/tests/docker_containerizer_tests.cpp c772d4c836de18b0e87636cb42200356d24ec73d Diff: https://reviews.apache.org/r/33318/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 33257: Fixed recover tasks only by the intiated containerizer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33257/#review80512 --- Patch looks great! Reviews applied: [33257] All tests passed. - Mesos ReviewBot On April 17, 2015, 7:07 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33257/ --- (Updated April 17, 2015, 7:07 p.m.) Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ian Downes, Jie Yu, and Till Toenshoff. Bugs: MESOS-2601 https://issues.apache.org/jira/browse/MESOS-2601 Repository: mesos Description --- Fixed recover tasks only by the intiated containerizer. Currently both mesos and docker containerizer recovers tasks that wasn't started by themselves. The proposed fix is to record the intended containerizer in the checkpointed executorInfo, and reuse that information on recover to know if the containerizer should recover or not. We are free to modify the executorInfo since it's not being used to relaunch any task. The external containerizer doesn't need to change since it is only recovering containers that are returned by the containers script. Diffs - src/slave/containerizer/docker.hpp 6893684e6d199a5d69fc8bba8e60c4acaae9c3c9 src/slave/containerizer/docker.cpp f9fb07806e3b7d7d2afc1be3b8756eac23b32dcd src/slave/containerizer/mesos/containerizer.cpp e4136095fca55637864f495098189ab3ad8d8fe7 src/slave/slave.cpp a0595f93ce4720f5b9926326d01210460ccb0667 src/tests/containerizer_tests.cpp 5991aa628083dac7c5e8bf7ba297f4f9edeec05f src/tests/docker_containerizer_tests.cpp c772d4c836de18b0e87636cb42200356d24ec73d Diff: https://reviews.apache.org/r/33257/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 33330: Fixed C++ style guide formatting.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/0/#review80574 --- Patch looks great! Reviews applied: [0] All tests passed. - Mesos ReviewBot On April 18, 2015, 1:32 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/0/ --- (Updated April 18, 2015, 1:32 a.m.) Review request for mesos. Repository: mesos-incubating Description --- Enables syntax highlighting in markdown viewers. Diffs - docs/mesos-c++-style-guide.md de1b93e Diff: https://reviews.apache.org/r/0/diff/ Testing --- N/A Thanks, Till Toenshoff
Re: Review Request 33331: Added file headers section to the C++ style guide.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review80578 --- Patch looks great! Reviews applied: [0, 1] All tests passed. - Mesos ReviewBot On April 18, 2015, 1:34 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/ --- (Updated April 18, 2015, 1:34 a.m.) Review request for mesos. Repository: mesos-incubating Description --- see summary. Diffs - docs/mesos-c++-style-guide.md de1b93e Diff: https://reviews.apache.org/r/1/diff/ Testing --- N/A Thanks, Till Toenshoff
Re: Review Request 33329: Removed unnecessary freeaddrinfo in getIP if getaddrinfo returns error.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33329/#review80571 --- Patch looks great! Reviews applied: [33329] All tests passed. - Mesos ReviewBot On April 18, 2015, 12:35 a.m., Chi Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33329/ --- (Updated April 18, 2015, 12:35 a.m.) Review request for mesos, Ben Mahler, Evelina Dumitrescu, and Jie Yu. Bugs: mesos-2636 https://issues.apache.org/jira/browse/mesos-2636 Repository: mesos Description --- Removed unnecessary freeaddrinfo in getIP if getaddrinfo returns error. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 3622165af064a1f0a9d461af0e1d0d88a352d4a8 Diff: https://reviews.apache.org/r/33329/diff/ Testing --- Thanks, Chi Zhang
Re: Review Request 33263: Extended SlaveTest.ShutdownUnregisteredExecutor test with a reason check.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33263/#review80335 --- Patch looks great! Reviews applied: [33263] All tests passed. - Mesos ReviewBot On April 16, 2015, 2:31 p.m., Andrey Dyatlov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33263/ --- (Updated April 16, 2015, 2:31 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till Toenshoff. Bugs: MESOS-2625 https://issues.apache.org/jira/browse/MESOS-2625 Repository: mesos Description --- Extended SlaveTest.ShutdownUnregisteredExecutor test with a reason check. Check that the reason is REASON_COMMAND_EXECUTOR_FAILED. According to the Slave::sendExecutorTerminatedStatusUpdate member function, this reason is expected instead of more general REASON_EXECUTOR_TERMINATED because the command executer is used in this test. Diffs - src/tests/slave_tests.cpp b826000e0a4221690f956ea51f49ad4c99d5e188 Diff: https://reviews.apache.org/r/33263/diff/ Testing --- make check Thanks, Andrey Dyatlov
Re: Review Request 33266: Check patch command in configure.ac
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33266/#review80356 --- Patch looks great! Reviews applied: [33266] All tests passed. - Mesos ReviewBot On April 16, 2015, 5:30 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33266/ --- (Updated April 16, 2015, 5:30 p.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-2624 https://issues.apache.org/jira/browse/MESOS-2624 Repository: mesos Description --- Check patch command in configure.ac Diffs - configure.ac 7f9e52916b9d78f2bbff9d6ed9871444a0fda629 Diff: https://reviews.apache.org/r/33266/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 31268: Wired up test allocator to allocator tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31268/#review80184 --- Bad patch! Reviews applied: [31775] Failed command: ./support/apply-review.sh -n -r 31775 Error: 2015-04-15 14:40:31 URL:https://reviews.apache.org/r/31775/diff/raw/ [5716/5716] - 31775.patch [1] error: patch failed: src/master/allocator/allocator.hpp:24 error: src/master/allocator/allocator.hpp: patch does not apply Failed to apply patch - Mesos ReviewBot On April 15, 2015, 2:22 p.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31268/ --- (Updated April 15, 2015, 2:22 p.m.) Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen. Bugs: MESOS-2160 https://issues.apache.org/jira/browse/MESOS-2160 Repository: mesos Description --- Same typed tests are used for built-in and modularized allocators. Diffs - src/tests/master_allocator_tests.cpp 03a1bb8c92b44bc1ad1b5f5cff8d1fb971df2302 Diff: https://reviews.apache.org/r/31268/diff/ Testing --- make check (Mac OS 10.9.5, CentOS 7.0) Thanks, Alexander Rukletsov
Re: Review Request 33241: docs: Add documentation on observability metrics.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/#review80274 --- Patch looks great! Reviews applied: [33241] All tests passed. - Mesos ReviewBot On April 15, 2015, 9:49 p.m., Ricardo Cervera-Navarro wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/ --- (Updated April 15, 2015, 9:49 p.m.) Review request for mesos. Bugs: MESOS-2621 https://issues.apache.org/jira/browse/MESOS-2621 Repository: mesos Description --- docs: Add documentation on observability metrics. Diffs - docs/home.md 6ab61f85aa7d62e0f19267b886dffb4e0aa826ea docs/metrics.md PRE-CREATION Diff: https://reviews.apache.org/r/33241/diff/ Testing --- - Previewed in markdown editor. - Replaced page content using the Element Inspector in Chrome to ensure that the tables look good. Thanks, Ricardo Cervera-Navarro
Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33249/#review80289 --- Patch looks great! Reviews applied: [33249] All tests passed. - Mesos ReviewBot On April 16, 2015, 12:32 a.m., Jay Buffington wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33249/ --- (Updated April 16, 2015, 12:32 a.m.) Review request for mesos, Ben Mahler, Timothy Chen, and Vinod Kone. Repository: mesos Description --- When mesos is unable to launch the containerizer the scheduler should get a TASK_FAILED with a status message that includes the error the containerizer encounted when trying to launch. Introduces a new TaskStatus: REASON_CONTAINERIZER_LAUNCH_FAILED Fixes MESOS-2020 Diffs - include/mesos/mesos.proto 3a8e8bf303e0576c212951f6028af77e54d93537 src/slave/slave.cpp a0595f93ce4720f5b9926326d01210460ccb0667 src/tests/containerizer.cpp 26b87ac6b16dfeaf84888e80296ef540697bd775 src/tests/slave_tests.cpp b826000e0a4221690f956ea51f49ad4c99d5e188 Diff: https://reviews.apache.org/r/33249/diff/ Testing --- I added test case to slave_test.cpp. I also tried this with Aurora, supplied a bogus docker image url and saw the docker pull failure stderr message in Aurora's web UI. Thanks, Jay Buffington
Re: Review Request 33241: docs: Add documentation on observability metrics.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/#review80268 --- Bad patch! Reviews applied: [33241] Failed command: ./support/apply-review.sh -n -r 33241 Error: 2015-04-15 21:10:27 URL:https://reviews.apache.org/r/33241/diff/raw/ [23211/23211] - 33241.patch [1] 33241.patch:1061: new blank line at EOF. + warning: 1 line adds whitespace errors. Successfully applied: docs: Add documentation on observability metrics. docs: Add documentation on observability metrics. Review: https://reviews.apache.org/r/33241 docs/metrics.md:1043: new blank line at EOF. Failed to commit patch - Mesos ReviewBot On April 15, 2015, 8:47 p.m., Ricardo Cervera-Navarro wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/ --- (Updated April 15, 2015, 8:47 p.m.) Review request for mesos. Bugs: MESOS-2621 https://issues.apache.org/jira/browse/MESOS-2621 Repository: mesos Description --- docs: Add documentation on observability metrics. Diffs - docs/home.md 6ab61f85aa7d62e0f19267b886dffb4e0aa826ea docs/metrics.md PRE-CREATION Diff: https://reviews.apache.org/r/33241/diff/ Testing --- - Previewed in markdown editor. - Replaced page content using the Element Inspector in Chrome to ensure that the tables look good. Thanks, Ricardo Cervera-Navarro
Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review80053 --- Patch looks great! Reviews applied: [33174] All tests passed. - Mesos ReviewBot On April 14, 2015, 4:44 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/ --- (Updated April 14, 2015, 4:44 p.m.) Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-2617 https://issues.apache.org/jira/browse/MESOS-2617 Repository: mesos Description --- Fix for docker containerizer not configuring CFS quotas correctly. It would be nice to refactor all this isolation code in a way that can be shared between all containerizers, as this is basically just copied from the CgroupsCpushareIsolator, but that's a much bigger undertaking. Diffs - src/slave/containerizer/docker.cpp 5f4b4ce49a9523e4743e5c79da4050e6f9e29ed7 Diff: https://reviews.apache.org/r/33174/diff/ Testing --- Thanks, Steve Niemitz
Re: Review Request 30263: Added test for CRAM-MD5 support of SASL within configuration phase.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30263/#review80151 --- Patch looks great! Reviews applied: [30263] All tests passed. - Mesos ReviewBot On April 15, 2015, 2:50 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30263/ --- (Updated April 15, 2015, 2:50 a.m.) Review request for mesos, Alexander Rojas and Cody Maloney. Bugs: MESOS-2165 https://issues.apache.org/jira/browse/MESOS-2165 Repository: mesos Description --- see summary Diffs - configure.ac 868c041 Diff: https://reviews.apache.org/r/30263/diff/ Testing --- make distcheck (with and without CRAM-MD5 installed, Linux OSX) Thanks, Till Toenshoff
Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review80126 --- Patch looks great! Reviews applied: [33174] All tests passed. - Mesos ReviewBot On April 14, 2015, 8:32 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/ --- (Updated April 14, 2015, 8:32 p.m.) Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. Bugs: MESOS-2617 https://issues.apache.org/jira/browse/MESOS-2617 Repository: mesos Description --- Fix for docker containerizer not configuring CFS quotas correctly. It would be nice to refactor all this isolation code in a way that can be shared between all containerizers, as this is basically just copied from the CgroupsCpushareIsolator, but that's a much bigger undertaking. Diffs - src/slave/containerizer/docker.cpp 5f4b4ce49a9523e4743e5c79da4050e6f9e29ed7 Diff: https://reviews.apache.org/r/33174/diff/ Testing --- Thanks, Steve Niemitz
Re: Review Request 27113: Libprocess benchmark cleanup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27113/#review80103 --- Patch looks great! Reviews applied: [25448, 27113] All tests passed. - Mesos ReviewBot On April 14, 2015, 7:46 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27113/ --- (Updated April 14, 2015, 7:46 p.m.) Review request for mesos, Ben Mahler, Cody Maloney, Joerg Schad, and Michael Park. Bugs: MESOS-1980 https://issues.apache.org/jira/browse/MESOS-1980 Repository: mesos Description --- Clean up Libprocess for readability / extensibility. Diffs - 3rdparty/libprocess/src/tests/benchmarks.cpp a927e4ecd8c8955cd9f85e716173a73a9a21c6cd Diff: https://reviews.apache.org/r/27113/diff/ Testing --- make check Thanks, Joris Van Remoortere
Re: Review Request 32749: Add -Wno-unused-local-typedef for clang 3.6
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32749/#review79946 --- Patch looks great! Reviews applied: [32747, 32748, 32749] All tests passed. - Mesos ReviewBot On April 13, 2015, 9:01 p.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32749/ --- (Updated April 13, 2015, 9:01 p.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-2550 https://issues.apache.org/jira/browse/MESOS-2550 Repository: mesos Description --- Add -Wno-unused-local-typedef for clang 3.6 Diffs - configure.ac 868c0413a2e2307ae8ab2211f56874595759b139 Diff: https://reviews.apache.org/r/32749/diff/ Testing --- For series: ../configure --disable-java --disable-python CC=clang CXX=clang++ `make check` passed on ArchLinux with clang version 3.6 as host compiler. CXXFLAGS contains the typedef. Didn't build without patches. `make check` on ArchLinux with GCC 4.9 ../configure `make distcheck` on CentOS 7 (GCC 4.8) ../configure `make distcheck` with OS X (Clang 3.5). Verified no '-Wno-unused-local-typedef'. Thanks, Cody Maloney
Re: Review Request 33155: Added commented-out tests for slave removal metrics.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33155/#review79981 --- Patch looks great! Reviews applied: [33152, 33153, 33154, 33155] All tests passed. - Mesos ReviewBot On April 14, 2015, 1:46 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33155/ --- (Updated April 14, 2015, 1:46 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2485 https://issues.apache.org/jira/browse/MESOS-2485 Repository: mesos Description --- I updated the existing tests to validate the metrics. However, it blocks the tests due to the slave metrics never getting satisfied. Added a TODO. Diffs - src/tests/master_tests.cpp 32b1e9bb58d8046e5363fafe2ab8f662b6c9a666 src/tests/partition_tests.cpp 1018e479a77a6b533f2dd392fedbdccb80e3ac1f src/tests/slave_tests.cpp b826000e0a4221690f956ea51f49ad4c99d5e188 Diff: https://reviews.apache.org/r/33155/diff/ Testing --- make check Thanks, Ben Mahler
Re: Review Request 33159: Pump updateFramework through Allocator from Master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33159/#review79982 --- Patch looks great! Reviews applied: [32961, 33159] All tests passed. - Mesos ReviewBot On April 14, 2015, 2:57 a.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33159/ --- (Updated April 14, 2015, 2:57 a.m.) Review request for mesos, Benjamin Hindman and Niklas Nielsen. Bugs: MESOS-2615 and MESOS-703 https://issues.apache.org/jira/browse/MESOS-2615 https://issues.apache.org/jira/browse/MESOS-703 Repository: mesos Description --- Follow up of 32961 where we add the 'updateFramework' function to the allocator. Diffs - src/master/allocator/allocator.hpp 91f80501aa9bc733fd53f9cb1ac0f15949a74964 src/master/allocator/mesos/allocator.hpp fb898f1175b61b442204e6e38c69ccc2838a646f src/master/allocator/mesos/hierarchical.hpp 9f9a631ee52a3ab194e678f9be139e8dabc7f3db src/master/master.cpp 44b0a0147f5354824d86332a67b30018634c9a36 src/tests/mesos.hpp 42e42ac425a448fcc5e93db1cef1112cbf5e67c4 Diff: https://reviews.apache.org/r/33159/diff/ Testing --- make check Thanks, Joris Van Remoortere
Re: Review Request 32975: MESOS-1790 Adds chown option to CommandInfo.URI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32975/#review79900 --- Patch looks great! Reviews applied: [32975] All tests passed. - Mesos ReviewBot On April 13, 2015, 4:55 p.m., Jim Klucar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32975/ --- (Updated April 13, 2015, 4:55 p.m.) Review request for mesos. Bugs: MESOS-1790 https://issues.apache.org/jira/browse/MESOS-1790 Repository: mesos Description --- Added chown to CommandInfo.URI protocol buffer as an optional boolean that defaults to true, the current chown behavior. The fetcher was updated to skip the os::chown operation if the chown boolean is set to false. No documentation was updated. Diffs - include/mesos/mesos.proto 3c592d5ab3092ecbeddfaff95e0c1addc3ac58f8 src/common/type_utils.cpp e92f6f36de0955784619029a016667b46bbe221b src/launcher/fetcher.cpp 796526f59c25898ef6db2b828b0e2bb7b172ba25 src/tests/fetcher_tests.cpp 4549e6a631e2c17cec3766efaa556593eeac9a1e Diff: https://reviews.apache.org/r/32975/diff/ Testing --- Unit testing this functionality is difficult because it would require that the user running the test to have permission to chown a file to someone other than themselves. I didn't want to add that as a requirement to build. I added the new field to the existing test cases just to see that they populate. Thanks, Jim Klucar
Re: Review Request 29889: Recover Docker containers when mesos slave is in a container
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29889/#review79840 --- Bad patch! Reviews applied: [29327, 29328] Failed command: ./support/apply-review.sh -n -r 29328 Error: 2015-04-13 06:44:31 URL:https://reviews.apache.org/r/29328/diff/raw/ [2149/2149] - 29328.patch [1] error: patch failed: src/slave/flags.hpp:311 error: src/slave/flags.hpp: patch does not apply Failed to apply patch - Mesos ReviewBot On April 13, 2015, 6:36 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29889/ --- (Updated April 13, 2015, 6:36 a.m.) Review request for mesos and Benjamin Hindman. Repository: mesos Description --- This is a one mega patch and contains many reviews that's already on rb. This review is not meant to be merged, only provided for easier review. Diffs - Dockerfile 35abf25 docs/configuration.md 54c4e31 docs/docker-containerizer.md a5438b7 src/docker/docker.hpp 3ebbc1f src/docker/docker.cpp 3a485a2 src/docker/executor.cpp PRE-CREATION src/slave/containerizer/docker.hpp 6893684 src/slave/containerizer/docker.cpp f9fb078 src/tests/docker_containerizer_tests.cpp c772d4c Diff: https://reviews.apache.org/r/29889/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 33111: Should install apr-util-devel in CentOS 6.5
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33111/#review79823 --- Patch looks great! Reviews applied: [33111] All tests passed. - Mesos ReviewBot On April 12, 2015, 9:33 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33111/ --- (Updated April 12, 2015, 9:33 a.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-2611 https://issues.apache.org/jira/browse/MESOS-2611 Repository: mesos Description --- Should install apr-util-devel in CentOS 6.5 Diffs - docs/getting-started.md b1d08e68bfce8097468e244f219bd178b6a33f57 Diff: https://reviews.apache.org/r/33111/diff/ Testing --- apr-utils-devel should be apr-util-devel Thanks, haosdent huang
Re: Review Request 33040: Expose qdisc statistics from libnl
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33040/#review79745 --- Bad patch! Reviews applied: [33040] Failed command: ./support/apply-review.sh -n -r 33040 Error: 2015-04-10 19:53:12 URL:https://reviews.apache.org/r/33040/diff/raw/ [20574/20574] - 33040.patch [1] error: patch failed: src/Makefile.am:459 error: src/Makefile.am: patch does not apply error: patch failed: src/linux/routing/queueing/fq_codel.hpp:43 error: src/linux/routing/queueing/fq_codel.hpp: patch does not apply error: patch failed: src/linux/routing/queueing/fq_codel.cpp:125 error: src/linux/routing/queueing/fq_codel.cpp: patch does not apply error: patch failed: src/linux/routing/queueing/ingress.hpp:38 error: src/linux/routing/queueing/ingress.hpp: patch does not apply error: patch failed: src/linux/routing/queueing/ingress.cpp:110 error: src/linux/routing/queueing/ingress.cpp: patch does not apply error: patch failed: src/linux/routing/queueing/internal.hpp:231 error: src/linux/routing/queueing/internal.hpp: patch does not apply error: src/linux/routing/queueing/statistics.hpp: does not exist in index error: src/linux/routing/queueing/statistics.cpp: does not exist in index error: patch failed: src/tests/routing_tests.cpp:16 error: src/tests/routing_tests.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On April 10, 2015, 7:47 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33040/ --- (Updated April 10, 2015, 7:47 p.m.) Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. Bugs: mesos-2332 https://issues.apache.org/jira/browse/mesos-2332 Repository: mesos Description --- Expose qdisc statistics from libnl Diffs - configure.ac 868c0413a2e2307ae8ab2211f56874595759b139 src/Makefile.am 9c01f5d6c692f835100e7cade928748cc4763cc8 src/linux/routing/queueing/fq_codel.hpp 4f67ab7d64afea96a07dfcf36769a9c667749a00 src/linux/routing/queueing/fq_codel.cpp 02ad8df7814c0e549a9ca9aef39777684e6abdcb src/linux/routing/queueing/ingress.hpp b323a7f6daed828327d6d9e9740df81582e0ba2b src/linux/routing/queueing/ingress.cpp 47c73376097d70819defdee31a6d1e446df6b8ba src/linux/routing/queueing/internal.hpp 7c6c4d3d960b9a4bf44dcf482212317522353d69 src/linux/routing/queueing/statistics.hpp PRE-CREATION src/linux/routing/queueing/statistics.cpp PRE-CREATION src/tests/routing_tests.cpp 7cc3b57a3b71544874557d2b1cf88a241b7062ba Diff: https://reviews.apache.org/r/33040/diff/ Testing --- make check Thanks, Paul Brett
Re: Review Request 33045: Added Jenkins build script to build Mesos inside Docker container.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33045/#review79759 --- Patch looks great! Reviews applied: [33045] All tests passed. - Mesos ReviewBot On April 10, 2015, 9:31 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33045/ --- (Updated April 10, 2015, 9:31 p.m.) Review request for mesos, Ben Mahler and Cody Maloney. Bugs: MESOS-2233 https://issues.apache.org/jira/browse/MESOS-2233 Repository: mesos Description --- My goal is to replace the miscelleneous Jenkins jobs on ASF with a single multi-configuration job whose configuration lies in the repo. This will make the CI management much simpler. Diffs - support/jenkins_build.sh PRE-CREATION Diff: https://reviews.apache.org/r/33045/diff/ Testing --- Tested with a custom job on ASF Jenkins. https://builds.apache.org/job/vinod-docker-multi/ NOTE: Disabled clang on CentOS because of known issue (https://issues.apache.org/jira/browse/MESOS-1385). Thanks, Vinod Kone
Re: Review Request 33040: Expose qdisc statistics from libnl
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33040/#review79783 --- Patch looks great! Reviews applied: [33040] All tests passed. - Mesos ReviewBot On April 10, 2015, 11:17 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33040/ --- (Updated April 10, 2015, 11:17 p.m.) Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. Bugs: mesos-2332 https://issues.apache.org/jira/browse/mesos-2332 Repository: mesos Description --- Expose qdisc statistics from libnl Diffs - configure.ac 868c041 src/linux/routing/queueing/fq_codel.hpp 4f67ab7 src/linux/routing/queueing/fq_codel.cpp 02ad8df src/linux/routing/queueing/ingress.hpp b323a7f src/linux/routing/queueing/ingress.cpp 47c7337 src/linux/routing/queueing/internal.hpp 7c6c4d3 src/tests/routing_tests.cpp 7cc3b57 Diff: https://reviews.apache.org/r/33040/diff/ Testing --- make check Thanks, Paul Brett
Re: Review Request 33045: Added Jenkins build script to build Mesos inside Docker container.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33045/#review79789 --- Patch looks great! Reviews applied: [33045] All tests passed. - Mesos ReviewBot On April 11, 2015, 12:20 a.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33045/ --- (Updated April 11, 2015, 12:20 a.m.) Review request for mesos, Ben Mahler and Cody Maloney. Bugs: MESOS-2233 https://issues.apache.org/jira/browse/MESOS-2233 Repository: mesos Description --- My goal is to replace the miscelleneous Jenkins jobs on ASF with a single multi-configuration job whose configuration lies in the repo. This will make the CI management much simpler. Diffs - support/jenkins_build.sh PRE-CREATION Diff: https://reviews.apache.org/r/33045/diff/ Testing --- Tested with a custom job on ASF Jenkins. https://builds.apache.org/job/vinod-docker-multi/ NOTE: Disabled clang on CentOS because of known issue (https://issues.apache.org/jira/browse/MESOS-1385). Thanks, Vinod Kone
Re: Review Request 32967: Cleaned upstyle and comments in modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32967/#review79571 --- Patch looks great! Reviews applied: [32967] All tests passed. - Mesos ReviewBot On April 9, 2015, 6:40 p.m., Aditi Dixit wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32967/ --- (Updated April 9, 2015, 6:40 p.m.) Review request for mesos, Alexander Rukletsov, Kapil Arya, and Till Toenshoff. Bugs: MESOS-2565 https://issues.apache.org/jira/browse/MESOS-2565 Repository: mesos Description --- Fixed minor style issues in modules and the misleading comments. Diffs - include/mesos/module.hpp 594212605127522a1b5f0d1335d6c208b499289b include/mesos/module/authenticatee.hpp 94de988d524d6390a9f59edbc61f1f7cae514efd include/mesos/module/authenticator.hpp 6a83f17b76ab0bf7af8acd3ddb8044f1bdfa78c0 include/mesos/module/hook.hpp a474e2bd118a5451c0574e33e2cbe9d7d7e95fce include/mesos/module/isolator.hpp 452ad318b9d5445860fa49bcdb933925d750f900 src/examples/test_anonymous_module.cpp 859f4e19e0d50794172af4cff708edf171e6d02f src/examples/test_hook_module.cpp 47409cd4d02e238d1d182571d92019114662cd41 src/examples/test_isolator_module.cpp 2c303f5ff2f17d56a840a5e0108281873c17ce6a src/examples/test_module.hpp 041570ef3af338bc51c3b3218c460cc8b3f4e4de Diff: https://reviews.apache.org/r/32967/diff/ Testing --- make check Thanks, Aditi Dixit
Re: Review Request 32558: Improve compile time of mesos by splitting flags
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32558/#review79558 --- Patch looks great! Reviews applied: [32558] All tests passed. - Mesos ReviewBot On April 9, 2015, 6:27 p.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32558/ --- (Updated April 9, 2015, 6:27 p.m.) Review request for mesos, Joris Van Remoortere and Michael Park. Bugs: MESOS-292 https://issues.apache.org/jira/browse/MESOS-292 Repository: mesos Description --- Split the mesos master, slave flags into header + source file to improve compile time significantly. Should be no functional changes. Largely copy-paste, with a little reworking to remove unnecessary headers from the .hpp, and order headers a little more reliably (as well as remove duplicate includes) in the .cpp. # Impact of these changes `time make check -j8` Before: make check 2732.93s user 103.89s system 514% cpu 9:11.63 total After: make check 2421.18s user 96.60s system 506% cpu 8:16.67 total 4 core machine, 8 hypter threads enabled. SSD, 16 GB RAM, Intel i7-4790K. The numbers aren't incredibly stable (Other software running, overclocking enabled, etc). They are a good general measure though of speedup. I do a `make check` rather than just `make` because that is what devs do in a day-to-day flow, and if runtime is significantly impacted, it will show up. Test steps: ``` # Warm cache ../configure --disable-python --disable-java make check # Timed build rm -rf * ../configure --disable-python --disable-java time make check ``` Note: Similar, likely greater improvements in compile time would happen if stout were made to not be header only. Specifically stout/os.hpp. Diffs - src/Makefile.am 9c01f5d6c692f835100e7cade928748cc4763cc8 src/logging/flags.hpp 4facb33201cee5a82451a13ca05607c875574752 src/logging/flags.cpp PRE-CREATION src/master/allocator/allocator.hpp b67b8fddbd7a3fffc6fe24d5e77cd1db8cb6f69b src/master/flags.hpp 85ce3285731c11b464aca6eaaa0a9165c73afebd src/master/flags.cpp PRE-CREATION src/slave/flags.hpp 3da71afad38ae41adefab979dbed2ae0b10a98ef src/slave/flags.cpp PRE-CREATION Diff: https://reviews.apache.org/r/32558/diff/ Testing --- make check on ArchLinux with GCC 4.9.2 make distcheck CentOS 7 Thanks, Cody Maloney
Re: Review Request 32975: MESOS-1790 Adds chown option to CommandInfo.URI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32975/#review79530 --- Patch looks great! Reviews applied: [32975] All tests passed. - Mesos ReviewBot On April 9, 2015, 4:40 p.m., Jim Klucar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32975/ --- (Updated April 9, 2015, 4:40 p.m.) Review request for mesos. Bugs: MESOS-1790 https://issues.apache.org/jira/browse/MESOS-1790 Repository: mesos Description --- Added chown to CommandInfo.URI protocol buffer as an optional boolean that defaults to true, the current chown behavior. The fetcher was updated to skip the os::chown operation if the chown boolean is set to false. No documentation was updated. Diffs - include/mesos/mesos.proto 3c592d5ab3092ecbeddfaff95e0c1addc3ac58f8 src/common/type_utils.cpp e92f6f36de0955784619029a016667b46bbe221b src/launcher/fetcher.cpp 796526f59c25898ef6db2b828b0e2bb7b172ba25 src/tests/fetcher_tests.cpp 4549e6a631e2c17cec3766efaa556593eeac9a1e Diff: https://reviews.apache.org/r/32975/diff/ Testing --- Unit testing this functionality is difficult because it would require that the user running the test to have permission to chown a file to someone other than themselves. I didn't want to add that as a requirement to build. I added the new field to the existing test cases just to see that they populate. Thanks, Jim Klucar
Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31444/#review79361
---
Patch looks great!
Reviews applied: [32978, 32891, 31444]
All tests passed.
- Mesos ReviewBot
On April 8, 2015, 3:24 p.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31444/
---
(Updated April 8, 2015, 3:24 p.m.)
Review request for mesos, Chi Zhang, Dominic Hamon, Jay Buffington, Jie Yu,
and James Peach.
Bugs: MESOS-2350
https://issues.apache.org/jira/browse/MESOS-2350
Repository: mesos
Description
---
Optionally take a path that the launch helper should chroot to before
exec'ing the executor. It is assumed that the work directory is mounted to
the appropriate location under the chroot. In particular, the path to the
executor must be relative to the chroot.
Configuration that should be private to the chroot is done during the launch,
e.g. mounting proc and statically configuring basic devices. It is assumed
that other configuration, e.g., preparing the image, mounting in volumes or
persistent resources, is done by the caller.
Mounts can be made to the chroot (e.g., updating the volumes or persistent
resources) and they will propagate in to the container but mounts made inside
the container will not propagate out to the host.
It currently assumes that at least {{chroot}}/tmp is writeable and that mount
points {{chroot}}/{tmp,dev,proc,sys} exist in the chroot.
This is specific to Linux.
Diffs
-
src/Makefile.am 9c01f5d6c692f835100e7cade928748cc4763cc8
src/linux/fs.cpp 1c9cf3f2ffead37148e4f6a81cefdbb97f679b09
src/slave/containerizer/mesos/launch.hpp
7c8b535746b5ce9add00afef86fdb6faefb5620e
src/slave/containerizer/mesos/launch.cpp
2f2d60e2011f60ec711d3b29fd2c157e30c83c34
src/tests/launch_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/31444/diff/
Testing
---
Manual testing only so far. This is harder to automate because we need a
self-contained chroot to execute something in... Suggestions welcome.
Thanks,
Ian Downes
Re: Review Request 32975: MESOS-1790 Adds chown option to CommandInfo.URI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32975/#review79352 --- Patch looks great! Reviews applied: [32975] All tests passed. - Mesos ReviewBot On April 8, 2015, 2:20 p.m., Jim Klucar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32975/ --- (Updated April 8, 2015, 2:20 p.m.) Review request for mesos. Bugs: MESOS-1790 https://issues.apache.org/jira/browse/MESOS-1790 Repository: mesos Description --- Added chown to CommandInfo.URI protocol buffer as an optional boolean that defaults to true, the current chown behavior. The fetcher was updated to skip the os::chown operation if the chown boolean is set to false. No documentation was updated. Diffs - include/mesos/mesos.proto 3c592d5ab3092ecbeddfaff95e0c1addc3ac58f8 src/launcher/fetcher.cpp 796526f59c25898ef6db2b828b0e2bb7b172ba25 src/tests/fetcher_tests.cpp 4549e6a631e2c17cec3766efaa556593eeac9a1e Diff: https://reviews.apache.org/r/32975/diff/ Testing --- Unit testing this functionality is difficult because it would require that the user running the test to have permission to chown a file to someone other than themselves. I didn't want to add that as a requirement to build. I added the new field to the existing test cases just to see that they populate. Thanks, Jim Klucar
Re: Review Request 32967: [MESOS-2565] Cleaned upstyle and comments in modules
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32967/#review79339 --- Patch looks great! Reviews applied: [32967] All tests passed. - Mesos ReviewBot On April 8, 2015, 1:25 p.m., Aditi Dixit wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32967/ --- (Updated April 8, 2015, 1:25 p.m.) Review request for mesos, Alexander Rukletsov and Kapil Arya. Bugs: MESOS-2565 https://issues.apache.org/jira/browse/MESOS-2565 Repository: mesos Description --- [MESOS-2565] Cleaned upstyle and comments in modules Diffs - include/mesos/module/authenticatee.hpp 94de988d524d6390a9f59edbc61f1f7cae514efd include/mesos/module/authenticator.hpp 6a83f17b76ab0bf7af8acd3ddb8044f1bdfa78c0 include/mesos/module/hook.hpp a474e2bd118a5451c0574e33e2cbe9d7d7e95fce include/mesos/module/isolator.hpp 452ad318b9d5445860fa49bcdb933925d750f900 src/examples/test_anonymous_module.cpp 859f4e19e0d50794172af4cff708edf171e6d02f src/examples/test_hook_module.cpp 47409cd4d02e238d1d182571d92019114662cd41 src/examples/test_isolator_module.cpp 2c303f5ff2f17d56a840a5e0108281873c17ce6a src/examples/test_module.hpp 041570ef3af338bc51c3b3218c460cc8b3f4e4de Diff: https://reviews.apache.org/r/32967/diff/ Testing --- make check Thanks, Aditi Dixit
Re: Review Request 32984: Added an example framework for testing persistent volumes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32984/#review79413 --- Patch looks great! Reviews applied: [32983, 32984] All tests passed. - Mesos ReviewBot On April 8, 2015, 7:08 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32984/ --- (Updated April 8, 2015, 7:08 p.m.) Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-2404 https://issues.apache.org/jira/browse/MESOS-2404 Repository: mesos Description --- Added an example framework for testing persistent volumes. Diffs - src/Makefile.am 9c01f5d6c692f835100e7cade928748cc4763cc8 src/examples/persistent_volume_framework.cpp PRE-CREATION src/tests/examples_tests.cpp 5222b6d5e66736495b743367b5731bb9094410fd src/tests/persistent_volume_framework_test.sh PRE-CREATION Diff: https://reviews.apache.org/r/32984/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 32398: Persist the reservation state on the slave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32398/#review79417 --- Bad patch! Reviews applied: [32139, 32140, 32149, 32150, 29748, 32333] Failed command: ./support/apply-review.sh -n -r 32333 Error: 2015-04-08 19:54:50 URL:https://reviews.apache.org/r/32333/diff/raw/ [16704/16704] - 32333.patch [1] error: patch failed: src/tests/reservation_tests.cpp:286 error: src/tests/reservation_tests.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On April 8, 2015, 6:38 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32398/ --- (Updated April 8, 2015, 6:38 p.m.) Review request for mesos and Alexander Rukletsov. Bugs: MESOS-2491 https://issues.apache.org/jira/browse/MESOS-2491 Repository: mesos Description --- * Added `isDynamicReservation(resource)` which returns true if the resource is either a dynamic role reservation or a framework reservation. * Added the `isDynamicReservation` condition onto `needCheckpointing`. * Updated the `applyCheckpointedResources` to consider dynamic reservations. * Added tests. Diffs - include/mesos/resources.hpp 56affd45e1e71e96ff5778b43271f81b9b9a9e4d src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059 src/common/resources_utils.cpp fe04d57227fa193d6d11d2f76529c46aea74c6a1 src/tests/reservation_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/32398/diff/ Testing --- make check Thanks, Michael Park
Re: Review Request 32999: Added a document for engineering principles and practices.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32999/#review79463 --- Patch looks great! Reviews applied: [32995, 32996, 32997, 32998, 32999] All tests passed. - Mesos ReviewBot On April 9, 2015, 12:30 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32999/ --- (Updated April 9, 2015, 12:30 a.m.) Review request for mesos, Adam B, Benjamin Hindman, Jie Yu, Niklas Nielsen, and Vinod Kone. Repository: mesos Description --- Added a document for engineering principles and practices. Diffs - docs/engineering-principles-and-practices.md PRE-CREATION docs/home.md 6ab61f85aa7d62e0f19267b886dffb4e0aa826ea Diff: https://reviews.apache.org/r/32999/diff/ Testing --- N/A Thanks, Ben Mahler
Re: Review Request 32982: Added reservation user guide.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/#review79436 --- Patch looks great! Reviews applied: [32982] All tests passed. - Mesos ReviewBot On April 8, 2015, 6:41 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/ --- (Updated April 8, 2015, 6:41 p.m.) Review request for mesos, Alexander Rukletsov and Timothy Chen. Bugs: MESOS-2205 https://issues.apache.org/jira/browse/MESOS-2205 Repository: mesos Description --- See summary. Diffs - docs/reservation.md PRE-CREATION Diff: https://reviews.apache.org/r/32982/diff/ Testing --- Documentation. Thanks, Michael Park
Re: Review Request 31268: Wired up test allocator to allocator tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31268/#review79175 --- Patch looks great! Reviews applied: [31775, 31776, 31266, 31267, 31262, 31263, 31265, 31268] All tests passed. - Mesos ReviewBot On April 7, 2015, 12:49 p.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31268/ --- (Updated April 7, 2015, 12:49 p.m.) Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen. Bugs: MESOS-2160 https://issues.apache.org/jira/browse/MESOS-2160 Repository: mesos Description --- Same typed tests are used for built-in and modularized allocators. Diffs - src/tests/master_allocator_tests.cpp 03a1bb8c92b44bc1ad1b5f5cff8d1fb971df2302 Diff: https://reviews.apache.org/r/31268/diff/ Testing --- make check (Mac OS 10.9.5, CentOS 7.0) Thanks, Alexander Rukletsov
Re: Review Request 32700: Removed FrameworkID from FrameworkState.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32700/#review79215 --- Patch looks great! Reviews applied: [32583, 32584, 32585, 32586, 32587, 32700] All tests passed. - Mesos ReviewBot On April 7, 2015, 5 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32700/ --- (Updated April 7, 2015, 5 p.m.) Review request for mesos, Adam B and Niklas Nielsen. Bugs: MESOS-2559 https://issues.apache.org/jira/browse/MESOS-2559 Repository: mesos Description --- FrameworkState already has FrameworkInfo which will have a valid FrameworkID. NOTE: This patch is only to be merged _ONLY_ after all the dependent patches have shipped, i.e. after 0.23.0 (tracked here: https://issues.apache.org/jira/browse/MESOS-2561) has released. Diffs - src/slave/containerizer/docker.cpp e83b912c707a3f2687b09a647a9ed248a940ea97 src/slave/containerizer/external_containerizer.cpp 1bbd61cb096771b7e4a1350079f79a20102e78f9 src/slave/containerizer/mesos/containerizer.cpp fbd1c0a0e5f4f227adb022f0baaa6d2c7e3ad748 src/slave/slave.cpp c7e65a6c095963feaa9d5fdbb519c68f8f761d16 src/slave/state.hpp 31dfdd5a4b644f466756a712deded1b025a73c02 src/slave/state.cpp 35ce70b6702473a3100991372f3ba36bcad391c0 src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4 Diff: https://reviews.apache.org/r/32700/diff/ Testing --- make check. TODO: Test for upgrade path. Thanks, Kapil Arya
Re: Review Request 32911: Fixed sandbox ownership bug for executors without URIs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32911/#review79231 --- Patch looks great! Reviews applied: [32911] All tests passed. - Mesos ReviewBot On April 7, 2015, 6:10 p.m., Niklas Nielsen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32911/ --- (Updated April 7, 2015, 6:10 p.m.) Review request for mesos, Benjamin Hindman and Ian Downes. Bugs: MESOS-2592 https://issues.apache.org/jira/browse/MESOS-2592 Repository: mesos Description --- During recent refactorings, executor directory ownership was delegated to the fetcher. However, the fetcher is not invoked if no URIs are present in the executor or task command. This left some of these tasks broken as the directory ownership defaulted to the mesos-slave's (root). Diffs - src/slave/containerizer/external_containerizer.cpp 1bbd61c src/slave/paths.hpp 1618439 src/slave/paths.cpp 01ea856 src/slave/slave.cpp 521624c Diff: https://reviews.apache.org/r/32911/diff/ Testing --- Functional tests with mesos-execute and make check. Have created JIRA's for introduction of more permission/user tests. Thanks, Niklas Nielsen
Re: Review Request 32939: Bumped the log level for dropped messages.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32939/#review79265 --- Patch looks great! Reviews applied: [32939] All tests passed. - Mesos ReviewBot On April 7, 2015, 9:48 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32939/ --- (Updated April 7, 2015, 9:48 p.m.) Review request for mesos, Ben Mahler and Cody Maloney. Repository: mesos Description --- Currently these log messages are fired whenever we have delayed messages to a process that is exited (e.g., log appends). I've also seen this a bunch in our tests. Bumping this to VLOG(2) to keep fidelity of VLOG(1) high. Diffs - 3rdparty/libprocess/src/process.cpp cf4e36489be2c6aa01e838c1c71383f248deab5b Diff: https://reviews.apache.org/r/32939/diff/ Testing --- Thanks, Vinod Kone
Re: Review Request 32956: Simplified MemUsage test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32956/#review79297 --- Patch looks great! Reviews applied: [32956] All tests passed. - Mesos ReviewBot On April 8, 2015, 2:30 a.m., Chi Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32956/ --- (Updated April 8, 2015, 2:30 a.m.) Review request for mesos, Ian Downes and Jie Yu. Bugs: mesos-2573 https://issues.apache.org/jira/browse/mesos-2573 Repository: mesos Description --- Simplified MemUsage test. Diffs - src/tests/isolator_tests.cpp 535e9afd942a2be507f69bf8bd9bb32f41a85a3a Diff: https://reviews.apache.org/r/32956/diff/ Testing --- Thanks, Chi Zhang
Re: Review Request 32955: Simplified ROOT_CGROUPS_Listen test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32955/#review79294 --- Patch looks great! Reviews applied: [32955] All tests passed. - Mesos ReviewBot On April 8, 2015, 2:29 a.m., Chi Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32955/ --- (Updated April 8, 2015, 2:29 a.m.) Review request for mesos, Ian Downes and Jie Yu. Bugs: mesos-2573 https://issues.apache.org/jira/browse/mesos-2573 Repository: mesos Description --- Simplified ROOT_CGROUPS_Listen test. Diffs - src/tests/cgroups_tests.cpp e18aed1feca182da89a117f81bed0897a00fb0ef Diff: https://reviews.apache.org/r/32955/diff/ Testing --- Thanks, Chi Zhang
Re: Review Request 32954: Added a 'slave_shutdowns_completed' metric.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32954/#review79295 --- Patch looks great! Reviews applied: [32954] All tests passed. - Mesos ReviewBot On April 8, 2015, 2:29 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32954/ --- (Updated April 8, 2015, 2:29 a.m.) Review request for mesos and Vinod Kone. Repository: mesos Description --- This allows us to determine the number of pending slave shutdowns, as the scheduled shutdowns must either be canceled or completed. Diffs - src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b src/master/metrics.hpp 52a83289cfe7e6b6fd8d5bff0774ebe5ce51d0ed src/master/metrics.cpp 14486bf7130250f561c9fb7a43c95f3fc1e76a4b Diff: https://reviews.apache.org/r/32954/diff/ Testing --- make check Thanks, Ben Mahler
Re: Review Request 32859: Add Camel-case libprocess variable and method names sample.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32859/#review78934 --- Patch looks great! Reviews applied: [32859] All tests passed. - Mesos ReviewBot On April 6, 2015, 4:36 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32859/ --- (Updated April 6, 2015, 4:36 p.m.) Review request for mesos and Niklas Nielsen. Bugs: MESOS-2576 https://issues.apache.org/jira/browse/MESOS-2576 Repository: mesos Description --- Add Camel-case libprocess variable and method names sample. Diffs - 3rdparty/libprocess/src/libev.hpp e4a403d9e769c13182f26034e0dd1c4db92b04cb 3rdparty/libprocess/src/libev.cpp 610dfb896ed8f9c00f9cf8fc8dbfc7d434f7d1e5 3rdparty/libprocess/src/libev_poll.cpp 324e4dd950989f3717ca73fe48520ca3e518518f 3rdparty/libprocess/src/process.cpp cf4e36489be2c6aa01e838c1c71383f248deab5b Diff: https://reviews.apache.org/r/32859/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 32895: Environment variables are case sensitive
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32895/#review78974 --- Patch looks great! Reviews applied: [32895] All tests passed. - Mesos ReviewBot On April 6, 2015, 6:45 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32895/ --- (Updated April 6, 2015, 6:45 p.m.) Review request for mesos and Ian Downes. Bugs: mesos-1801 https://issues.apache.org/jira/browse/mesos-1801 Repository: mesos Description --- Environment variables are case sensitive Diffs - src/deploy/mesos-master-env.sh.template 7fe7e536de351c9c8673d9bb8b16b59926e00c2c src/deploy/mesos-slave-env.sh.template 31567d6a47e19385aed56edfc7e67457c8cdde3e Diff: https://reviews.apache.org/r/32895/diff/ Testing --- Thanks, Paul Brett
Re: Review Request 32898: Eliminate use of 'echo -n'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32898/#review79053 --- Patch looks great! Reviews applied: [32898] All tests passed. - Mesos ReviewBot On April 6, 2015, 7:27 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32898/ --- (Updated April 6, 2015, 7:27 p.m.) Review request for mesos and Ian Downes. Bugs: mesos-1424 https://issues.apache.org/jira/browse/mesos-1424 Repository: mesos Description --- Eliminate use of 'echo -n' Diffs - ec2/deploy.amazon64-old/root/mesos-ec2/hypertable/Capfile 8b50912745977cb71232ba1dfa77f8bb0d60191e ec2/deploy.amazon64-old/root/mesos-ec2/setup 8d4f4b07c4b6bdf92c66db109930b1c285e7c783 ec2/deploy.amazon64/root/mesos-ec2/hypertable/Capfile 8b50912745977cb71232ba1dfa77f8bb0d60191e ec2/deploy.amazon64/root/mesos-ec2/setup b6b736091d4d5be431c8da29cdb98360a1df2d29 ec2/deploy.centos64/root/mesos-ec2/hypertable/Capfile f85584af5580ecfe5ee5ce3f03fb78408b466ccd ec2/deploy.centos64/root/mesos-ec2/setup f380f7a1c29034b795d4ed5197e52effabb5a175 ec2/deploy.lucid64/root/mesos-ec2/setup 0a74757433521cfe4b37b0e13221375558dce118 src/tests/port_mapping_tests.cpp 55a5e69ed818fd0856179026e3deb889236fea77 support/timed_tests.sh 5e01af9411d1d736b12a6996c3ecb0f18468faca Diff: https://reviews.apache.org/r/32898/diff/ Testing --- make check (on linux host only) Thanks, Paul Brett
Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31444/#review78965
---
Patch looks great!
Reviews applied: [32891, 31444]
All tests passed.
- Mesos ReviewBot
On April 6, 2015, 6:02 p.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31444/
---
(Updated April 6, 2015, 6:02 p.m.)
Review request for mesos, Chi Zhang, Dominic Hamon, Jay Buffington, Jie Yu,
and James Peach.
Bugs: MESOS-2350
https://issues.apache.org/jira/browse/MESOS-2350
Repository: mesos
Description
---
Optionally take a path that the launch helper should chroot to before
exec'ing the executor. It is assumed that the work directory is mounted to
the appropriate location under the chroot. In particular, the path to the
executor must be relative to the chroot.
Configuration that should be private to the chroot is done during the launch,
e.g. mounting proc and statically configuring basic devices. It is assumed
that other configuration, e.g., preparing the image, mounting in volumes or
persistent resources, is done by the caller.
Mounts can be made to the chroot (e.g., updating the volumes or persistent
resources) and they will propagate in to the container but mounts made inside
the container will not propagate out to the host.
It currently assumes that at least {{chroot}}/tmp is writeable and that mount
points {{chroot}}/{tmp,dev,proc,sys} exist in the chroot.
This is specific to Linux.
Diffs
-
src/slave/containerizer/mesos/launch.hpp
7c8b535746b5ce9add00afef86fdb6faefb5620e
src/slave/containerizer/mesos/launch.cpp
2f2d60e2011f60ec711d3b29fd2c157e30c83c34
Diff: https://reviews.apache.org/r/31444/diff/
Testing
---
Manual testing only so far. This is harder to automate because we need a
self-contained chroot to execute something in... Suggestions welcome.
Thanks,
Ian Downes
Re: Review Request 32903: Eliminate the use of 'echo -n' in EC2 scripts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32903/#review79077 --- Patch looks great! Reviews applied: [32903] All tests passed. - Mesos ReviewBot On April 6, 2015, 10:09 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32903/ --- (Updated April 6, 2015, 10:09 p.m.) Review request for mesos and Ian Downes. Bugs: mesos-1424 https://issues.apache.org/jira/browse/mesos-1424 Repository: mesos Description --- Eliminate the use of 'echo -n' in EC2 scripts Diffs - ec2/deploy.amazon64-old/root/mesos-ec2/hypertable/Capfile 8b50912745977cb71232ba1dfa77f8bb0d60191e ec2/deploy.amazon64-old/root/mesos-ec2/setup 8d4f4b07c4b6bdf92c66db109930b1c285e7c783 ec2/deploy.amazon64/root/mesos-ec2/hypertable/Capfile 8b50912745977cb71232ba1dfa77f8bb0d60191e ec2/deploy.amazon64/root/mesos-ec2/setup b6b736091d4d5be431c8da29cdb98360a1df2d29 ec2/deploy.centos64/root/mesos-ec2/hypertable/Capfile f85584af5580ecfe5ee5ce3f03fb78408b466ccd ec2/deploy.centos64/root/mesos-ec2/setup f380f7a1c29034b795d4ed5197e52effabb5a175 ec2/deploy.lucid64/root/mesos-ec2/setup 0a74757433521cfe4b37b0e13221375558dce118 Diff: https://reviews.apache.org/r/32903/diff/ Testing --- None Thanks, Paul Brett
Re: Review Request 32898: Eliminate use of 'echo -n'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32898/#review79072 --- Patch looks great! Reviews applied: [32898] All tests passed. - Mesos ReviewBot On April 6, 2015, 10:05 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32898/ --- (Updated April 6, 2015, 10:05 p.m.) Review request for mesos and Ian Downes. Bugs: mesos-1424 https://issues.apache.org/jira/browse/mesos-1424 Repository: mesos Description --- Eliminate use of 'echo -n' Diffs - src/tests/port_mapping_tests.cpp 55a5e69 support/timed_tests.sh 5e01af9 Diff: https://reviews.apache.org/r/32898/diff/ Testing --- make check (on linux host only) Thanks, Paul Brett
Re: Review Request 32906: Add safety check for staged but uncommitted changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32906/#review79087 --- Patch looks great! Reviews applied: [32906] All tests passed. - Mesos ReviewBot On April 6, 2015, 11:03 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32906/ --- (Updated April 6, 2015, 11:03 p.m.) Review request for mesos and Ian Downes. Bugs: mesos-598 https://issues.apache.org/jira/browse/mesos-598 Repository: mesos Description --- Add safety check for staged but uncommitted changes Diffs - support/post-reviews.py 2b6c479cf2bda1a93a1f9b10eb0de709aa49dcbe Diff: https://reviews.apache.org/r/32906/diff/ Testing --- vim support/post-reviews.py # edited source $ ./support/post-reviews.py Please commit or stash any changes before using post-reviews! $ git add support/post-reviews.py $ ./support/post-reviews.py Please commit staged changes before using post-reviews! $ git commit . [mesos-598 1867d05] Add safety check for staged but uncommitted changes 1 file changed, 8 insertions(+), 1 deletion(-) $ ./support/post-reviews.py Running 'rbt post' across all of ... Thanks, Paul Brett
Re: Review Request 32911: Fixed sandbox ownership bug for executors without URIs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32911/#review79104 --- Patch looks great! Reviews applied: [32911] All tests passed. - Mesos ReviewBot On April 7, 2015, 12:40 a.m., Niklas Nielsen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32911/ --- (Updated April 7, 2015, 12:40 a.m.) Review request for mesos, Benjamin Hindman and Ian Downes. Bugs: MESOS-2592 https://issues.apache.org/jira/browse/MESOS-2592 Repository: mesos Description --- During recent refactorings, executor directory ownership was delegated to the fetcher. However, the fetcher is not invoked if no URIs are present in the executor or task command. This left some of these tasks broken as the directory ownership defaulted to the mesos-slave's (root). Diffs - src/slave/containerizer/external_containerizer.cpp 1bbd61cb096771b7e4a1350079f79a20102e78f9 src/slave/paths.hpp 1618439d728ded347ec75317ce8dd998acd7ee94 src/slave/paths.cpp 01ea856aa2e628d4aee5fd31f7e49d147f740e8f src/slave/slave.cpp 521624c335b9110e12ee1ff21c3918e5af6a2bde Diff: https://reviews.apache.org/r/32911/diff/ Testing --- Functional tests with mesos-execute and make check. Have created JIRA's for introduction of more permission/user tests. Thanks, Niklas Nielsen
Re: Review Request 32859: Add Camel-case libprocess variable and method names sample.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32859/#review78886 --- Patch looks great! Reviews applied: [32859] All tests passed. - Mesos ReviewBot On April 4, 2015, 7:48 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32859/ --- (Updated April 4, 2015, 7:48 a.m.) Review request for mesos and Niklas Nielsen. Bugs: MESOS-2576 https://issues.apache.org/jira/browse/MESOS-2576 Repository: mesos Description --- Add Camel-case libprocess variable and method names sample. Diffs - 3rdparty/libprocess/src/decoder.hpp 56adde07b650984de367fb861d7a496fa37884cb Diff: https://reviews.apache.org/r/32859/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 32654: Clean up HostIPNetwork since every use performs the same extract stringify operation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32654/#review78816 --- Bad patch! Reviews applied: [32654] Failed command: ./support/apply-review.sh -n -r 32654 Error: 2015-04-03 18:45:36 URL:https://reviews.apache.org/r/32654/diff/raw/ [1134/1134] - 32654.patch [1] error: patch failed: src/tests/port_mapping_tests.cpp:148 error: src/tests/port_mapping_tests.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On April 3, 2015, 6:29 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32654/ --- (Updated April 3, 2015, 6:29 p.m.) Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. Bugs: mesos-2332 https://issues.apache.org/jira/browse/mesos-2332 Repository: mesos Description --- Clean up HostIPNetwork since every use performs the same extract stringify operation Diffs - src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131 Diff: https://reviews.apache.org/r/32654/diff/ Testing --- make check Thanks, Paul Brett
Re: Review Request 32805: Terminated the perf subprocess once the parent exits.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32805/#review78809 --- Patch looks great! Reviews applied: [32820, 32805] All tests passed. - Mesos ReviewBot On April 3, 2015, 5:11 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32805/ --- (Updated April 3, 2015, 5:11 p.m.) Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. Bugs: MESOS-2462 https://issues.apache.org/jira/browse/MESOS-2462 Repository: mesos Description --- Terminated the perf subprocess once the parent exits. The idea is to have a nanny process which installs a SIGTERM handler which will kill the process group (of course, we need to put the nanny and perf process to the same process group). We set the death signal of the nanny process to be SIGTERM. In that way, when slave exits, the nanny process will receive a SIGTERM, which will then kill all processes in the process group. Diffs - src/linux/perf.cpp cad6c80e2a9608ff02fc2b8976efba52713dd5a8 Diff: https://reviews.apache.org/r/32805/diff/ Testing --- sudo make check I also manually verified it by terminating the slave while perf is in progress. The perf is killed immediately. Thanks, Jie Yu
Re: Review Request 32654: Clean up HostIPNetwork since every use performs the same extract stringify operation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32654/#review78825 --- Patch looks great! Reviews applied: [32654] All tests passed. - Mesos ReviewBot On April 3, 2015, 7:19 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32654/ --- (Updated April 3, 2015, 7:19 p.m.) Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. Bugs: mesos-2332 https://issues.apache.org/jira/browse/mesos-2332 Repository: mesos Description --- Clean up HostIPNetwork since every use performs the same extract stringify operation Diffs - src/tests/port_mapping_tests.cpp 58709b5a0ac58f13985dcc4b71250ec41487ff18 Diff: https://reviews.apache.org/r/32654/diff/ Testing --- make check Thanks, Paul Brett
Re: Review Request 32832: Added CHANGELOG for 0.22.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32832/#review78835 --- Patch looks great! Reviews applied: [32832] All tests passed. - Mesos ReviewBot On April 3, 2015, 8:43 p.m., Niklas Nielsen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32832/ --- (Updated April 3, 2015, 8:43 p.m.) Review request for mesos, Ben Mahler and Timothy Chen. Repository: mesos Description --- Added changelog section for Mesos 0.22.1 Diffs - CHANGELOG efcadfa0f896a50f21f34b84bdcaa61046d8cd4b Diff: https://reviews.apache.org/r/32832/diff/ Testing --- Thanks, Niklas Nielsen
Re: Review Request 32834: Modifiy gdb scripts error message to check gdb is installed.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32834/#review78846 --- Patch looks great! Reviews applied: [32834] All tests passed. - Mesos ReviewBot On April 3, 2015, 10:01 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32834/ --- (Updated April 3, 2015, 10:01 p.m.) Review request for mesos, Adam B, Cody Maloney, and Niklas Nielsen. Repository: mesos Description --- Ran into a problem where gdb isn't installed and I see a error message saying generated libtool doesn't support gdb. Changed the error message to ask user to make sure gdb is also installed. Diffs - bin/gdb-mesos-local.sh.in 72cfb68b4ff2ac796aa381cf6c49f6a4b83eb28b bin/gdb-mesos-master.sh.in f00af078bb9b8a6c3689d1ddd0db6efe38614d87 bin/gdb-mesos-slave.sh.in e01325c59ed62eb2e0d6bdf24808fc3f0cd206ab bin/gdb-mesos-tests.sh.in 626fefe7d953bf226e6d5fb84c87a6f3d66f4da9 Diff: https://reviews.apache.org/r/32834/diff/ Testing --- make Thanks, Timothy Chen
Re: Review Request 32845: Renamed UNREGISTER call to UNSUBSCRIBE.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32845/#review78869 --- Patch looks great! Reviews applied: [32500, 32501, 32502, 32504, 32505, 32843, 32506, 32844, 32845] All tests passed. - Mesos ReviewBot On April 3, 2015, 11:50 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32845/ --- (Updated April 3, 2015, 11:50 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-1127 https://issues.apache.org/jira/browse/MESOS-1127 Repository: mesos Description --- Renamed UNREGISTER call to UNSUBSCRIBE for consistency. Diffs - include/mesos/scheduler/scheduler.proto 783a63ad1cc0edd86605d638046fb959cb6e97e8 src/examples/low_level_scheduler_libprocess.cpp 63d34eefb60d13fe2b82905c1cec9b762340e997 src/examples/low_level_scheduler_pthread.cpp 6d1f938660c02db75bfcbf7c8de0d941cff1920d src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 Diff: https://reviews.apache.org/r/32845/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32850/#review78876 --- Patch looks great! Reviews applied: [32850] All tests passed. - Mesos ReviewBot On April 4, 2015, 3:22 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32850/ --- (Updated April 4, 2015, 3:22 a.m.) Review request for mesos, Joris Van Remoortere and switched to 'mcypark'. Bugs: MESOS-2584 https://issues.apache.org/jira/browse/MESOS-2584 Repository: mesos-incubating Description --- Removing the process from the header is much cleaner and also fixes the linked clang 3.4.2 JIRA. Apart from that moving, no code is changed. NOTE: This patch is mostly a proof of concept for validation and further research. There are more tests breaking as described in the JIRA and those might need some care as well, depending on our clang 3.4 support strategy. Diffs - src/Makefile.am 9c01f5d src/authentication/cram_md5/authenticatee.hpp 55fac68 src/authentication/cram_md5/authenticatee.cpp PRE-CREATION Diff: https://reviews.apache.org/r/32850/diff/ Testing --- make check Thanks, Till Toenshoff
Re: Review Request 32509: Documented the scheduler Event/Call protobufs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32509/#review78874 --- Patch looks great! Reviews applied: [32500, 32501, 32502, 32504, 32505, 32843, 32506, 32844, 32845, 32509] All tests passed. - Mesos ReviewBot On April 3, 2015, 11:55 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32509/ --- (Updated April 3, 2015, 11:55 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-1127 https://issues.apache.org/jira/browse/MESOS-1127 Repository: mesos Description --- See summary. Diffs - include/mesos/scheduler/scheduler.proto 783a63ad1cc0edd86605d638046fb959cb6e97e8 Diff: https://reviews.apache.org/r/32509/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 32832: Added CHANGELOG for 0.22.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32832/#review78854 --- Patch looks great! Reviews applied: [32832] All tests passed. - Mesos ReviewBot On April 3, 2015, 10:58 p.m., Niklas Nielsen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32832/ --- (Updated April 3, 2015, 10:58 p.m.) Review request for mesos, Ben Mahler and Timothy Chen. Repository: mesos Description --- Added changelog section for Mesos 0.22.1 Diffs - CHANGELOG efcadfa0f896a50f21f34b84bdcaa61046d8cd4b Diff: https://reviews.apache.org/r/32832/diff/ Testing --- Thanks, Niklas Nielsen
Re: Review Request 32744: PortMapping: change to not host namespace symlink handles in /var/run/netns.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32744/#review78707 --- Patch looks great! Reviews applied: [32744] All tests passed. - Mesos ReviewBot On April 2, 2015, 7:06 p.m., Chi Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32744/ --- (Updated April 2, 2015, 7:06 p.m.) Review request for mesos, Jie Yu and Cong Wang. Bugs: mesos-2574 https://issues.apache.org/jira/browse/mesos-2574 Repository: mesos Description --- MESOS-2574 Diffs - src/slave/containerizer/isolators/network/port_mapping.hpp 33837b4662959a003c8f38d1e786c6615287a4ff src/slave/containerizer/isolators/network/port_mapping.cpp e691d463515084518c94cdec3fbdf37be4a72977 src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131 Diff: https://reviews.apache.org/r/32744/diff/ Testing --- Thanks, Chi Zhang
Re: Review Request 32654: Clean up HostIPNetwork since every use performs the same extract stringify operation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32654/#review78719 --- Patch looks great! Reviews applied: [32654] All tests passed. - Mesos ReviewBot On April 2, 2015, 7:06 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32654/ --- (Updated April 2, 2015, 7:06 p.m.) Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. Bugs: mesos-2332 https://issues.apache.org/jira/browse/mesos-2332 Repository: mesos Description --- Clean up HostIPNetwork since every use performs the same extract stringify operation Diffs - src/tests/port_mapping_tests.cpp f4124c3 Diff: https://reviews.apache.org/r/32654/diff/ Testing --- make check Thanks, Paul Brett
Re: Review Request 32798: Add test to verify executor clean up in docker containerizer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32798/#review78749 --- Patch looks great! Reviews applied: [32796, 32797, 32798] All tests passed. - Mesos ReviewBot On April 2, 2015, 11:38 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32798/ --- (Updated April 2, 2015, 11:38 p.m.) Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff. Bugs: MESOS-2583 https://issues.apache.org/jira/browse/MESOS-2583 Repository: mesos Description --- Add test to verify executor clean up in docker containerizer. Diffs - src/tests/docker_containerizer_tests.cpp fdd706a892ee1c8d55a406b3f956d99c076c623b Diff: https://reviews.apache.org/r/32798/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 32805: Terminated the perf subprocess once the parent exits.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32805/#review78757 --- Bad patch! Reviews applied: [32805] Failed command: ./support/apply-review.sh -n -r 32805 Error: 2015-04-03 02:04:58 URL:https://reviews.apache.org/r/32805/diff/raw/ [2268/2268] - 32805.patch [1] error: patch failed: src/linux/perf.cpp:29 error: src/linux/perf.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On April 3, 2015, 1:42 a.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32805/ --- (Updated April 3, 2015, 1:42 a.m.) Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. Bugs: MESOS-2462 https://issues.apache.org/jira/browse/MESOS-2462 Repository: mesos Description --- Terminated the perf subprocess once the parent exits. The idea is to have a nanny process which installs a SIGTERM handler which will kill the process group (of course, we need to put the nanny and perf process to the same process group). We set the death signal of the nanny process to be SIGTERM. In that way, when slave exits, the nanny process will receive a SIGTERM, which will then kill all processes in the process group. Diffs - src/linux/perf.cpp cad6c80e2a9608ff02fc2b8976efba52713dd5a8 Diff: https://reviews.apache.org/r/32805/diff/ Testing --- sudo make check I also manually verified it by terminating the slave while perf is in progress. The perf is killed immediately. Thanks, Jie Yu
Re: Review Request 32750: MESOS-2585: Use full width for mesos div.container
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32750/#review78741 --- Patch looks great! Reviews applied: [32750] All tests passed. - Mesos ReviewBot On April 2, 2015, 10:26 p.m., Alson Kemp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32750/ --- (Updated April 2, 2015, 10:26 p.m.) Review request for mesos. Bugs: MESOS-2585 https://issues.apache.org/jira/browse/MESOS-2585 Repository: mesos Description --- MESOS-2585: Use full width for mesos div.container Diffs - src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10 src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1 Diff: https://reviews.apache.org/r/32750/diff/ Testing --- Visual verification. Thanks, Alson Kemp
Re: Review Request 31676: Added documentation about the use of the LIBPROCESS_DISABLED_ENDPOINTS environment variable.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31676/#review78502 --- Patch looks great! Reviews applied: [31228, 31676] All tests passed. - Mesos ReviewBot On April 1, 2015, 9:47 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31676/ --- (Updated April 1, 2015, 9:47 a.m.) Review request for mesos, Joerg Schad, Niklas Nielsen, and Till Toenshoff. Bugs: mesos-2333 https://issues.apache.org/jira/browse/mesos-2333 Repository: mesos Description --- Adds documentation on how to disable endpoints using `LIBPROCESS_DISABLED_ENDPOINTS`. Diffs - docs/configuration.md 54c4e31ed6dfed3c23d492c19a301ce119a0519b Diff: https://reviews.apache.org/r/31676/diff/ Testing --- Thanks, Alexander Rojas
Re: Review Request 31268: Wired up test allocator to allocator tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31268/#review78525 --- Patch looks great! Reviews applied: [31775, 31776, 31266, 31267, 31262, 31263, 31265, 31268] All tests passed. - Mesos ReviewBot On April 1, 2015, 2:29 p.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31268/ --- (Updated April 1, 2015, 2:29 p.m.) Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen. Bugs: MESOS-2160 https://issues.apache.org/jira/browse/MESOS-2160 Repository: mesos Description --- Same typed tests are used for built-in and modularized allocators. Diffs - src/tests/master_allocator_tests.cpp 03a1bb8c92b44bc1ad1b5f5cff8d1fb971df2302 Diff: https://reviews.apache.org/r/31268/diff/ Testing --- make check (Mac OS 10.9.5, CentOS 7.0) Thanks, Alexander Rukletsov
Re: Review Request 32657: Refactor wrappers for JSON encoded stats in preparation for greater reuse
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32657/#review78532 --- Bad patch! Reviews applied: [32654] Failed command: ./support/apply-review.sh -n -r 32654 Error: 2015-04-01 15:54:52 URL:https://reviews.apache.org/r/32654/diff/raw/ [6185/6185] - 32654.patch [1] error: patch failed: src/tests/port_mapping_tests.cpp:400 error: src/tests/port_mapping_tests.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On April 1, 2015, 3:39 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32657/ --- (Updated April 1, 2015, 3:39 p.m.) Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. Bugs: mesos-2332 https://issues.apache.org/jira/browse/mesos-2332 Repository: mesos Description --- Refactor wrappers for JSON encoded stats in preparation for greater reuse Diffs - src/slave/containerizer/isolators/network/port_mapping.hpp 33837b4662959a003c8f38d1e786c6615287a4ff src/slave/containerizer/isolators/network/port_mapping.cpp e691d463515084518c94cdec3fbdf37be4a72977 src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131 Diff: https://reviews.apache.org/r/32657/diff/ Testing --- make check Thanks, Paul Brett
Re: Review Request 32664: Add port mapping isolator statistics tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32664/#review78534 --- Bad patch! Reviews applied: [32658, 32659] Failed command: ./support/apply-review.sh -n -r 32659 Error: 2015-04-01 16:14:41 URL:https://reviews.apache.org/r/32659/diff/raw/ [1497/1497] - 32659.patch [1] error: patch failed: src/tests/port_mapping_tests.cpp:100 error: src/tests/port_mapping_tests.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On April 1, 2015, 3:45 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32664/ --- (Updated April 1, 2015, 3:45 p.m.) Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. Bugs: mesos-2332 https://issues.apache.org/jira/browse/mesos-2332 Repository: mesos Description --- Add port mapping isolator statistics tests Diffs - src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131 Diff: https://reviews.apache.org/r/32664/diff/ Testing --- make check Thanks, Paul Brett
Re: Review Request 32744: PortMapping: change to not host namespace symlink handles in /var/run/netns.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32744/#review78631 --- Patch looks great! Reviews applied: [32744] All tests passed. - Mesos ReviewBot On April 1, 2015, 10:36 p.m., Chi Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32744/ --- (Updated April 1, 2015, 10:36 p.m.) Review request for mesos, Jie Yu and Cong Wang. Bugs: mesos-2574 https://issues.apache.org/jira/browse/mesos-2574 Repository: mesos Description --- MESOS-2574 Diffs - src/slave/containerizer/isolators/network/port_mapping.hpp 33837b4662959a003c8f38d1e786c6615287a4ff src/slave/containerizer/isolators/network/port_mapping.cpp e691d463515084518c94cdec3fbdf37be4a72977 src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131 Diff: https://reviews.apache.org/r/32744/diff/ Testing --- Thanks, Chi Zhang
Re: Review Request 32750: MESOS-2585: Use full width for mesos div.container
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32750/#review78625 --- Patch looks great! Reviews applied: [32750] All tests passed. - Mesos ReviewBot On April 1, 2015, 10:22 p.m., Alson Kemp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32750/ --- (Updated April 1, 2015, 10:22 p.m.) Review request for mesos. Bugs: MESOS-2585 https://issues.apache.org/jira/browse/MESOS-2585 Repository: mesos Description --- MESOS-2585: Use full width for mesos div.container Diffs - src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10 Diff: https://reviews.apache.org/r/32750/diff/ Testing --- Visual verification. Thanks, Alson Kemp
Re: Review Request 32742: Added command logging for processes running in slave's cgroup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32742/#review78635 --- Patch looks great! Reviews applied: [32742] All tests passed. - Mesos ReviewBot On April 1, 2015, 10:39 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32742/ --- (Updated April 1, 2015, 10:39 p.m.) Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. Bugs: MESOS-2461 https://issues.apache.org/jira/browse/MESOS-2461 Repository: mesos Description --- Added command logging for processes running in slave's cgroup. Diffs - src/slave/slave.cpp 0f70ebafb0f5b16c560decc66e22a43a52732d09 Diff: https://reviews.apache.org/r/32742/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 32654: Clean up HostIPNetwork since every use performs the same extract stringify operation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32654/#review78639 --- Patch looks great! Reviews applied: [32654] All tests passed. - Mesos ReviewBot On April 1, 2015, 11:07 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32654/ --- (Updated April 1, 2015, 11:07 p.m.) Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. Bugs: mesos-2332 https://issues.apache.org/jira/browse/mesos-2332 Repository: mesos Description --- Clean up HostIPNetwork since every use performs the same extract stringify operation Diffs - src/tests/port_mapping_tests.cpp f4124c3 Diff: https://reviews.apache.org/r/32654/diff/ Testing --- make check Thanks, Paul Brett
Re: Review Request 32653: Replace busy loop on ready file with a more relaxed loop
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32653/#review78637 --- Patch looks great! Reviews applied: [32653] All tests passed. - Mesos ReviewBot On April 1, 2015, 11 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32653/ --- (Updated April 1, 2015, 11 p.m.) Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. Bugs: mesos-2332 https://issues.apache.org/jira/browse/mesos-2332 Repository: mesos Description --- Replace busy loop on ready file with a more relaxed loop Diffs - src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131 Diff: https://reviews.apache.org/r/32653/diff/ Testing --- make check Thanks, Paul Brett
Re: Review Request 32750: MESOS-2585: Use full width for mesos div.container
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32750/#review78648 --- Patch looks great! Reviews applied: [32750] All tests passed. - Mesos ReviewBot On April 2, 2015, 12:05 a.m., Alson Kemp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32750/ --- (Updated April 2, 2015, 12:05 a.m.) Review request for mesos. Bugs: MESOS-2585 https://issues.apache.org/jira/browse/MESOS-2585 Repository: mesos Description --- MESOS-2585: Use full width for mesos div.container Diffs - src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10 Diff: https://reviews.apache.org/r/32750/diff/ Testing --- Visual verification. Thanks, Alson Kemp
Re: Review Request 31915: MemIsolator: Improved some statistics naming. (MESOS-2104)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31915/#review78626 --- Patch looks great! Reviews applied: [31914, 31915] All tests passed. - Mesos ReviewBot On April 1, 2015, 10:28 p.m., Chi Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31915/ --- (Updated April 1, 2015, 10:28 p.m.) Review request for mesos, Ian Downes and Paul Brett. Bugs: mesos-2104 https://issues.apache.org/jira/browse/mesos-2104 Repository: mesos Description --- MemIsolator: Improved some statistics naming. (MESOS-2104) Diffs - include/mesos/mesos.proto 3a8e8bf303e0576c212951f6028af77e54d93537 src/slave/containerizer/isolators/cgroups/mem.cpp a7a83ef9ad4726aa139a92fc7f5917ed687d33f5 Diff: https://reviews.apache.org/r/31915/diff/ Testing --- Thanks, Chi Zhang
Re: Review Request 32757: [5/5] Added a memory statistics test for writeback.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32757/#review78642 --- Patch looks great! Reviews applied: [31012, 32754, 32755, 32756, 32757] All tests passed. - Mesos ReviewBot On April 1, 2015, 11:18 p.m., Chi Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32757/ --- (Updated April 1, 2015, 11:18 p.m.) Review request for mesos, Ian Downes and Jie Yu. Bugs: mesos-2572 https://issues.apache.org/jira/browse/mesos-2572 Repository: mesos Description --- Added a memory statistics test for writeback. Diffs - src/tests/cgroups_tests.cpp e18aed1feca182da89a117f81bed0897a00fb0ef src/tests/memory_test_helper.hpp 11712d7f378d9426f160d53b0387c698a28a4207 src/tests/memory_test_helper.cpp cdf769b32036c746ec4aa90841ea45c9a4159b51 Diff: https://reviews.apache.org/r/32757/diff/ Testing --- Thanks, Chi Zhang
