----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32850/#review78876 -----------------------------------------------------------
Patch looks great! Reviews applied: [32850] All tests passed. - Mesos ReviewBot On April 4, 2015, 3:22 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32850/ > ----------------------------------------------------------- > > (Updated April 4, 2015, 3:22 a.m.) > > > Review request for mesos, Joris Van Remoortere and switched to 'mcypark'. > > > Bugs: MESOS-2584 > https://issues.apache.org/jira/browse/MESOS-2584 > > > Repository: mesos-incubating > > > Description > ------- > > Removing the process from the header is much cleaner and also fixes the > linked clang 3.4.2 JIRA. Apart from that moving, no code is changed. > > NOTE: This patch is mostly a proof of concept for validation and further > research. There are more tests breaking as described in the JIRA and those > might need some care as well, depending on our clang 3.4 support strategy. > > > Diffs > ----- > > src/Makefile.am 9c01f5d > src/authentication/cram_md5/authenticatee.hpp 55fac68 > src/authentication/cram_md5/authenticatee.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/32850/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
