Re: Review Request 25373: Added a test for sending pending tasks during re-registration.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25373/#review52672
---


Patch looks great!

Reviews applied: [25371, 25372, 25373]

All tests passed.

- Mesos ReviewBot


On Sept. 9, 2014, 12:43 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25373/
> ---
> 
> (Updated Sept. 9, 2014, 12:43 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1715
> https://issues.apache.org/jira/browse/MESOS-1715
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> This test drops the _runTask dispatch to ensure a task remains pending during 
> re-registration.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> b0e74b94db8a68cd676569d42b2ccd120f12b9d3 
> 
> Diff: https://reviews.apache.org/r/25373/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 25373: Added a test for sending pending tasks during re-registration.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25373/#review52669
---

Ship it!


Ship It!

- Vinod Kone


On Sept. 9, 2014, 12:43 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25373/
> ---
> 
> (Updated Sept. 9, 2014, 12:43 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1715
> https://issues.apache.org/jira/browse/MESOS-1715
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> This test drops the _runTask dispatch to ensure a task remains pending during 
> re-registration.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> b0e74b94db8a68cd676569d42b2ccd120f12b9d3 
> 
> Diff: https://reviews.apache.org/r/25373/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 25373: Added a test for sending pending tasks during re-registration.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25373/
---

(Updated Sept. 9, 2014, 12:43 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Cleaned up the test per Vinod's review.


Bugs: MESOS-1715
https://issues.apache.org/jira/browse/MESOS-1715


Repository: mesos-git


Description (updated)
---

This test drops the _runTask dispatch to ensure a task remains pending during 
re-registration.


Diffs (updated)
-

  src/tests/fault_tolerance_tests.cpp b0e74b94db8a68cd676569d42b2ccd120f12b9d3 

Diff: https://reviews.apache.org/r/25373/diff/


Testing
---

make check


Thanks,

Ben Mahler

Re: Review Request 25373: Added a test for sending pending tasks during re-registration.

[Ben Mahler]

> On Sept. 8, 2014, 6:02 p.m., Vinod Kone wrote:
> > src/tests/fault_tolerance_tests.cpp, line 2322
> > 
> >
> > Instead of having a mock gc executor and launching 2 tasks and pausing 
> > the gc's unschedule, can we just do:
> > 
> > launch one task.
> > 
> > drop _runTask() dispatch.
> > 
> > force re-registration.
> > 
> > is that not enough?

Much better, thanks!


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25373/#review52611
---


On Sept. 9, 2014, 12:43 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25373/
> ---
> 
> (Updated Sept. 9, 2014, 12:43 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1715
> https://issues.apache.org/jira/browse/MESOS-1715
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> This test drops the _runTask dispatch to ensure a task remains pending during 
> re-registration.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> b0e74b94db8a68cd676569d42b2ccd120f12b9d3 
> 
> Diff: https://reviews.apache.org/r/25373/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 25373: Added a test for sending pending tasks during re-registration.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25373/#review52611
---



src/tests/fault_tolerance_tests.cpp


s/executor ,/executor,/



src/tests/fault_tolerance_tests.cpp


s/the the/the/



src/tests/fault_tolerance_tests.cpp


What is the guarantee here that the 2nd task is pending on the slave at 
this point?



src/tests/fault_tolerance_tests.cpp


Instead of having a mock gc executor and launching 2 tasks and pausing the 
gc's unschedule, can we just do:

launch one task.

drop _runTask() dispatch.

force re-registration.

is that not enough?


- Vinod Kone


On Sept. 5, 2014, 3:10 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25373/
> ---
> 
> (Updated Sept. 5, 2014, 3:10 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1715
> https://issues.apache.org/jira/browse/MESOS-1715
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> This uses a MockGarbageCollector and a detector to force the slave to 
> re-register with a pending task.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> b0e74b94db8a68cd676569d42b2ccd120f12b9d3 
> 
> Diff: https://reviews.apache.org/r/25373/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 25373: Added a test for sending pending tasks during re-registration.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25373/#review52452
---


Patch looks great!

Reviews applied: [25371, 25372, 25373]

All tests passed.

- Mesos ReviewBot


On Sept. 5, 2014, 3:10 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25373/
> ---
> 
> (Updated Sept. 5, 2014, 3:10 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1715
> https://issues.apache.org/jira/browse/MESOS-1715
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> This uses a MockGarbageCollector and a detector to force the slave to 
> re-register with a pending task.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> b0e74b94db8a68cd676569d42b2ccd120f12b9d3 
> 
> Diff: https://reviews.apache.org/r/25373/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>