Re: Review Request 25756: post-reviews.py: added --no-color to git log.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25756/ --- (Updated Sept. 18, 2014, 3:02 p.m.) Review request for mesos. Repository: mesos-git Description (updated) --- Force git log to never emit colored output (for setups with colored output enabled by default). For example, the command git --no-pager log --pretty=oneline --reverse master..HEAD should generate output similiar to the following: ``` fa7e46cfc228e9f80e08d7c28a978d561fbba5a7 post-reviews.py: added --no-color to git log. - For setups that have colored output for git log. ``` However, in a setup where git emits colored output, the raw output would look like the following: ``` ^[[33mfa7e46cfc228e9f80e08d7c28a978d561fbba5a7^[[m post-reviews.py: added --no-color to git log. - For setups that have colored output for git log. ``` The parser in post-review.py then picks '`^[[33mfa7e46cfc228e9f80e08d7c28a978d561fbba5a7^[[m`' as the sha and crashes. The '--no-color' flag forces git to never emit colored output. Diffs - support/post-reviews.py ee27bb8119b4992d5533d09de260b4668b9d6b3e Diff: https://reviews.apache.org/r/25756/diff/ Testing --- Created this review request using the updated script. Thanks, Kapil Arya
Re: Review Request 25756: post-reviews.py: added --no-color to git log.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25756/#review53755 --- Ship it! Ship It! - Timothy Chen On Sept. 17, 2014, 10:26 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25756/ --- (Updated Sept. 17, 2014, 10:26 p.m.) Review request for mesos. Repository: mesos-git Description --- - For setups that have colored output for git log. Diffs - support/post-reviews.py ee27bb8119b4992d5533d09de260b4668b9d6b3e Diff: https://reviews.apache.org/r/25756/diff/ Testing --- Created this review request using the updated script. Thanks, Kapil Arya
Re: Review Request 25756: post-reviews.py: added --no-color to git log.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25756/#review53765 --- Can you add a little more description as to what this is fixing? It's hard to tell. - Ben Mahler On Sept. 17, 2014, 10:26 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25756/ --- (Updated Sept. 17, 2014, 10:26 p.m.) Review request for mesos. Repository: mesos-git Description --- - For setups that have colored output for git log. Diffs - support/post-reviews.py ee27bb8119b4992d5533d09de260b4668b9d6b3e Diff: https://reviews.apache.org/r/25756/diff/ Testing --- Created this review request using the updated script. Thanks, Kapil Arya
Re: Review Request 25756: post-reviews.py: added --no-color to git log.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25756/#review53772 --- Patch looks great! Reviews applied: [25756] All tests passed. - Mesos ReviewBot On Sept. 17, 2014, 10:26 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25756/ --- (Updated Sept. 17, 2014, 10:26 p.m.) Review request for mesos. Repository: mesos-git Description --- - For setups that have colored output for git log. Diffs - support/post-reviews.py ee27bb8119b4992d5533d09de260b4668b9d6b3e Diff: https://reviews.apache.org/r/25756/diff/ Testing --- Created this review request using the updated script. Thanks, Kapil Arya
Re: Review Request 25756: post-reviews.py: added --no-color to git log.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25756/ --- (Updated Sept. 17, 2014, 7:35 p.m.) Review request for mesos. Changes --- Updated problem description Repository: mesos-git Description (updated) --- For setups that have colored output for git log. For example, the command git --no-pager log --pretty=oneline --reverse master..HEAD should generate output similiar to the following: ``` fa7e46cfc228e9f80e08d7c28a978d561fbba5a7 post-reviews.py: added --no-color to git log. - For setups that have colored output for git log. ``` However, in a setup where git emits colored output, the raw output would look like the following: ``` ^[[33mfa7e46cfc228e9f80e08d7c28a978d561fbba5a7^[[m post-reviews.py: added --no-color to git log. - For setups that have colored output for git log. ``` The parser in post-review.py then picks '`^[[33mfa7e46cfc228e9f80e08d7c28a978d561fbba5a7^[[m`' as the sha and crashes. The fix is to add '--no-color' to force git to never emit colored ouput. Diffs - support/post-reviews.py ee27bb8119b4992d5533d09de260b4668b9d6b3e Diff: https://reviews.apache.org/r/25756/diff/ Testing --- Created this review request using the updated script. Thanks, Kapil Arya
