Review Request 25567: Hold on to unacknowledged terminal tasks in the Master.

2014-09-11 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25567/
---

Review request for mesos, Niklas Nielsen and Vinod Kone.


Bugs: MESOS-1410
https://issues.apache.org/jira/browse/MESOS-1410


Repository: mesos-git


Description
---

This is the MESOS-1410 which fixes MESOS-1389.

The idea here is that the master needs to hold on to those tasks that are 
terminal, but have yet to be acknowledged by the scheduler. Otherwise, 
reconciliation requests could lead to TASK_LOST updates **before** a framework 
receives a terminal TASK_FINISHED/TASK_FAILED/etc update for the task.

Now the master needs to:
(1) Remove tasks when an acknowledgement arrives.
(2) Recover resources when the task becomes terminal.
(3) Omit resources for terminal tasks in the http statistics.


Diffs
-

  src/master/master.hpp b4926001178ebb00b34b0b7e03f491d4a800afc2 
  src/master/master.cpp d5db24ef3c2d2501aa5852b62d50a425bc0ad925 

Diff: https://reviews.apache.org/r/25567/diff/


Testing
---

make check

Added new tests in https://reviews.apache.org/r/25568/


Thanks,

Ben Mahler

Re: Review Request 25567: Hold on to unacknowledged terminal tasks in the Master.

2014-09-15 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25567/#review53450
---

Ship it!



src/master/master.hpp


s/updateTaskState/updateTask/ since you are not just updating the state?



src/master/master.hpp


s/a/the/


- Vinod Kone


On Sept. 12, 2014, 2:01 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25567/
> ---
> 
> (Updated Sept. 12, 2014, 2:01 a.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-1410
> https://issues.apache.org/jira/browse/MESOS-1410
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> This is the MESOS-1410 which fixes MESOS-1389.
> 
> The idea here is that the master needs to hold on to those tasks that are 
> terminal, but have yet to be acknowledged by the scheduler. Otherwise, 
> reconciliation requests could lead to TASK_LOST updates **before** a 
> framework receives a terminal TASK_FINISHED/TASK_FAILED/etc update for the 
> task.
> 
> Now the master needs to:
> (1) Remove tasks when an acknowledgement arrives.
> (2) Recover resources when the task becomes terminal.
> (3) Omit resources for terminal tasks in the http statistics.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp b4926001178ebb00b34b0b7e03f491d4a800afc2 
>   src/master/master.cpp d5db24ef3c2d2501aa5852b62d50a425bc0ad925 
> 
> Diff: https://reviews.apache.org/r/25567/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Added new tests in https://reviews.apache.org/r/25568/
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 25567: Hold on to unacknowledged terminal tasks in the Master.

2014-09-18 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25567/
---

(Updated Sept. 18, 2014, 9:30 p.m.)


Review request for mesos, Niklas Nielsen and Vinod Kone.


Changes
---

Trivial changes from Vinod's review.


Bugs: MESOS-1410
https://issues.apache.org/jira/browse/MESOS-1410


Repository: mesos-git


Description
---

This is the MESOS-1410 which fixes MESOS-1389.

The idea here is that the master needs to hold on to those tasks that are 
terminal, but have yet to be acknowledged by the scheduler. Otherwise, 
reconciliation requests could lead to TASK_LOST updates **before** a framework 
receives a terminal TASK_FINISHED/TASK_FAILED/etc update for the task.

Now the master needs to:
(1) Remove tasks when an acknowledgement arrives.
(2) Recover resources when the task becomes terminal.
(3) Omit resources for terminal tasks in the http statistics.


Diffs (updated)
-

  src/master/master.hpp 80d753509be21614325b9492a078350d6cb6641c 
  src/master/master.cpp 52a7409f7132f89f4a64e589fa096dd07f527fd9 

Diff: https://reviews.apache.org/r/25567/diff/


Testing
---

make check

Added new tests in https://reviews.apache.org/r/25568/


Thanks,

Ben Mahler

Re: Review Request 25567: Hold on to unacknowledged terminal tasks in the Master.

2014-09-18 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25567/#review53904
---

Ship it!


Ship It!

- Vinod Kone


On Sept. 18, 2014, 9:30 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25567/
> ---
> 
> (Updated Sept. 18, 2014, 9:30 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-1410
> https://issues.apache.org/jira/browse/MESOS-1410
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> This is the MESOS-1410 which fixes MESOS-1389.
> 
> The idea here is that the master needs to hold on to those tasks that are 
> terminal, but have yet to be acknowledged by the scheduler. Otherwise, 
> reconciliation requests could lead to TASK_LOST updates **before** a 
> framework receives a terminal TASK_FINISHED/TASK_FAILED/etc update for the 
> task.
> 
> Now the master needs to:
> (1) Remove tasks when an acknowledgement arrives.
> (2) Recover resources when the task becomes terminal.
> (3) Omit resources for terminal tasks in the http statistics.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 80d753509be21614325b9492a078350d6cb6641c 
>   src/master/master.cpp 52a7409f7132f89f4a64e589fa096dd07f527fd9 
> 
> Diff: https://reviews.apache.org/r/25567/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Added new tests in https://reviews.apache.org/r/25568/
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>