Re: Review Request 26071: Sample isolator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 22, 2014, 4:04 a.m.) Review request for mesos, Bernd Mathiske, Ian Downes, and Niklas Nielsen. Changes --- Rebased diff. Bugs: MESOS-1384 https://issues.apache.org/jira/browse/MESOS-1384 Repository: mesos-git Description --- Created CPU and Memory isolation modules based on Posix CPU/Memory Isolators. These modules are also hooked up to the relevant Isolator tests using the typed test mechanism. It also paves the way for future integration with custom modules specified on the command line. Diffs (updated) - src/Makefile.am c44a9ad47d6e1262949b9049f4ae25b049440d99 src/examples/test_isolator_module.cpp PRE-CREATION src/module/isolator.hpp PRE-CREATION src/module/manager.cpp 105e5afd5b49e907380389f6020a7f6d5e732b3f src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 src/tests/main.cpp 90a7ddcb5695d4c9a7760e18285548d99e7bcfa8 src/tests/module.hpp PRE-CREATION src/tests/module.cpp PRE-CREATION src/tests/module_tests.cpp e92d8717427e259b1fa26b3f17719fd616a748c7 Diff: https://reviews.apache.org/r/26071/diff/ Testing --- make check with an Isolator module test. Thanks, Kapil Arya
Re: Review Request 26071: Sample isolator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 22, 2014, 1:51 p.m.) Review request for mesos, Bernd Mathiske, Ian Downes, and Niklas Nielsen. Changes --- Addressed Nik's comments. Bugs: MESOS-1384 https://issues.apache.org/jira/browse/MESOS-1384 Repository: mesos-git Description --- Created CPU and Memory isolation modules based on Posix CPU/Memory Isolators. These modules are also hooked up to the relevant Isolator tests using the typed test mechanism. It also paves the way for future integration with custom modules specified on the command line. Diffs (updated) - src/Makefile.am c44a9ad47d6e1262949b9049f4ae25b049440d99 src/examples/test_isolator_module.cpp PRE-CREATION src/module/isolator.hpp PRE-CREATION src/module/manager.cpp 105e5afd5b49e907380389f6020a7f6d5e732b3f src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 src/tests/main.cpp 90a7ddcb5695d4c9a7760e18285548d99e7bcfa8 src/tests/module.hpp PRE-CREATION src/tests/module.cpp PRE-CREATION src/tests/module_tests.cpp e92d8717427e259b1fa26b3f17719fd616a748c7 Diff: https://reviews.apache.org/r/26071/diff/ Testing --- make check with an Isolator module test. Thanks, Kapil Arya
Re: Review Request 26071: Sample isolator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/#review57648 --- LGTM - one last question below. BenH - any last comments? src/tests/module.cpp https://reviews.apache.org/r/26071/#comment98451 Did you want to change this to a flat static? - Niklas Nielsen On Oct. 20, 2014, 5:56 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 20, 2014, 5:56 p.m.) Review request for mesos, Bernd Mathiske, Ian Downes, and Niklas Nielsen. Bugs: MESOS-1384 https://issues.apache.org/jira/browse/MESOS-1384 Repository: mesos-git Description --- Created CPU and Memory isolation modules based on Posix CPU/Memory Isolators. These modules are also hooked up to the relevant Isolator tests using the typed test mechanism. It also paves the way for future integration with custom modules specified on the command line. Diffs - src/Makefile.am c44a9ad47d6e1262949b9049f4ae25b049440d99 src/examples/test_isolator_module.cpp PRE-CREATION src/module/isolator.hpp PRE-CREATION src/module/manager.hpp 56e2af334866d2736a8d43f45daf2dbf5189ce2d src/module/manager.cpp 2727fe06a66fda77d984f862bd5b0eaa3cd23726 src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 src/tests/main.cpp 90a7ddcb5695d4c9a7760e18285548d99e7bcfa8 src/tests/module.hpp PRE-CREATION src/tests/module.cpp PRE-CREATION src/tests/module_tests.cpp 54e1e8d26719069d01bfabd918f7c37ddbf3c7c4 Diff: https://reviews.apache.org/r/26071/diff/ Testing --- make check with an Isolator module test. Thanks, Kapil Arya
Re: Review Request 26071: Sample isolator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 21, 2014, 5:35 p.m.) Review request for mesos, Bernd Mathiske, Ian Downes, and Niklas Nielsen. Changes --- Addressed Nik's comments. Bugs: MESOS-1384 https://issues.apache.org/jira/browse/MESOS-1384 Repository: mesos-git Description --- Created CPU and Memory isolation modules based on Posix CPU/Memory Isolators. These modules are also hooked up to the relevant Isolator tests using the typed test mechanism. It also paves the way for future integration with custom modules specified on the command line. Diffs (updated) - src/Makefile.am c44a9ad47d6e1262949b9049f4ae25b049440d99 src/examples/test_isolator_module.cpp PRE-CREATION src/module/isolator.hpp PRE-CREATION src/module/manager.cpp 2727fe06a66fda77d984f862bd5b0eaa3cd23726 src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 src/tests/main.cpp 90a7ddcb5695d4c9a7760e18285548d99e7bcfa8 src/tests/module.hpp PRE-CREATION src/tests/module.cpp PRE-CREATION src/tests/module_tests.cpp 54e1e8d26719069d01bfabd918f7c37ddbf3c7c4 Diff: https://reviews.apache.org/r/26071/diff/ Testing --- make check with an Isolator module test. Thanks, Kapil Arya
Re: Review Request 26071: Sample isolator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 20, 2014, 8:56 p.m.) Review request for mesos, Bernd Mathiske, Ian Downes, and Niklas Nielsen. Bugs: MESOS-1384 https://issues.apache.org/jira/browse/MESOS-1384 Repository: mesos-git Description --- Created CPU and Memory isolation modules based on Posix CPU/Memory Isolators. These modules are also hooked up to the relevant Isolator tests using the typed test mechanism. It also paves the way for future integration with custom modules specified on the command line. Diffs (updated) - src/Makefile.am c44a9ad47d6e1262949b9049f4ae25b049440d99 src/examples/test_isolator_module.cpp PRE-CREATION src/module/isolator.hpp PRE-CREATION src/module/manager.hpp 56e2af334866d2736a8d43f45daf2dbf5189ce2d src/module/manager.cpp 2727fe06a66fda77d984f862bd5b0eaa3cd23726 src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 src/tests/main.cpp 90a7ddcb5695d4c9a7760e18285548d99e7bcfa8 src/tests/module.hpp PRE-CREATION src/tests/module.cpp PRE-CREATION src/tests/module_tests.cpp 54e1e8d26719069d01bfabd918f7c37ddbf3c7c4 Diff: https://reviews.apache.org/r/26071/diff/ Testing --- make check with an Isolator module test. Thanks, Kapil Arya
Re: Review Request 26071: Sample isolator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/#review57506 --- Ship it! Ship It! - Niklas Nielsen On Oct. 20, 2014, 5:56 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 20, 2014, 5:56 p.m.) Review request for mesos, Bernd Mathiske, Ian Downes, and Niklas Nielsen. Bugs: MESOS-1384 https://issues.apache.org/jira/browse/MESOS-1384 Repository: mesos-git Description --- Created CPU and Memory isolation modules based on Posix CPU/Memory Isolators. These modules are also hooked up to the relevant Isolator tests using the typed test mechanism. It also paves the way for future integration with custom modules specified on the command line. Diffs - src/Makefile.am c44a9ad47d6e1262949b9049f4ae25b049440d99 src/examples/test_isolator_module.cpp PRE-CREATION src/module/isolator.hpp PRE-CREATION src/module/manager.hpp 56e2af334866d2736a8d43f45daf2dbf5189ce2d src/module/manager.cpp 2727fe06a66fda77d984f862bd5b0eaa3cd23726 src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 src/tests/main.cpp 90a7ddcb5695d4c9a7760e18285548d99e7bcfa8 src/tests/module.hpp PRE-CREATION src/tests/module.cpp PRE-CREATION src/tests/module_tests.cpp 54e1e8d26719069d01bfabd918f7c37ddbf3c7c4 Diff: https://reviews.apache.org/r/26071/diff/ Testing --- make check with an Isolator module test. Thanks, Kapil Arya
Re: Review Request 26071: Sample isolator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 20, 2014, 1:42 a.m.) Review request for mesos, Bernd Mathiske, Ian Downes, and Niklas Nielsen. Changes --- Rebased diff. Bugs: MESOS-1384 https://issues.apache.org/jira/browse/MESOS-1384 Repository: mesos-git Description --- Created CPU and Memory isolation modules based on Posix CPU/Memory Isolators. These modules are also hooked up to the relevant Isolator tests using the typed test mechanism. It also paves the way for future integration with custom modules specified on the command line. Diffs (updated) - src/Makefile.am c44a9ad47d6e1262949b9049f4ae25b049440d99 src/examples/test_isolator_module.cpp PRE-CREATION src/module/isolator.hpp PRE-CREATION src/module/manager.hpp 56e2af334866d2736a8d43f45daf2dbf5189ce2d src/module/manager.cpp 2727fe06a66fda77d984f862bd5b0eaa3cd23726 src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 src/tests/main.cpp 90a7ddcb5695d4c9a7760e18285548d99e7bcfa8 src/tests/module.hpp PRE-CREATION src/tests/module.cpp PRE-CREATION src/tests/module_tests.cpp 54e1e8d26719069d01bfabd918f7c37ddbf3c7c4 Diff: https://reviews.apache.org/r/26071/diff/ Testing --- make check with an Isolator module test. Thanks, Kapil Arya
Re: Review Request 26071: Sample isolator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 18, 2014, 3:10 p.m.) Review request for mesos, Bernd Mathiske, Ian Downes, and Niklas Nielsen. Changes --- Addressed Nik's comments. Bugs: MESOS-1384 https://issues.apache.org/jira/browse/MESOS-1384 Repository: mesos-git Description --- Created CPU and Memory isolation modules based on Posix CPU/Memory Isolators. These modules are also hooked up to the relevant Isolator tests using the typed test mechanism. It also paves the way for future integration with custom modules specified on the command line. Diffs (updated) - src/Makefile.am c44a9ad47d6e1262949b9049f4ae25b049440d99 src/examples/test_isolator_module.cpp PRE-CREATION src/module/isolator.hpp PRE-CREATION src/module/manager.hpp 56e2af334866d2736a8d43f45daf2dbf5189ce2d src/module/manager.cpp 2727fe06a66fda77d984f862bd5b0eaa3cd23726 src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 src/tests/main.cpp 90a7ddcb5695d4c9a7760e18285548d99e7bcfa8 src/tests/module.hpp PRE-CREATION src/tests/module.cpp PRE-CREATION src/tests/module_tests.cpp 54e1e8d26719069d01bfabd918f7c37ddbf3c7c4 Diff: https://reviews.apache.org/r/26071/diff/ Testing --- make check with an Isolator module test. Thanks, Kapil Arya
Re: Review Request 26071: Sample isolator module.
On Oct. 16, 2014, 6:24 p.m., Niklas Nielsen wrote: src/tests/isolator_tests.cpp, lines 129-130 https://reviews.apache.org/r/26071/diff/6/?file=723152#file723152line129 Don't know if we have any specific wrapping rules wrt very long templates. This looks off to me - but let's look into that. I have left it as is for now. Let's figure out a better way. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/#review57013 --- On Oct. 18, 2014, 3:10 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 18, 2014, 3:10 p.m.) Review request for mesos, Bernd Mathiske, Ian Downes, and Niklas Nielsen. Bugs: MESOS-1384 https://issues.apache.org/jira/browse/MESOS-1384 Repository: mesos-git Description --- Created CPU and Memory isolation modules based on Posix CPU/Memory Isolators. These modules are also hooked up to the relevant Isolator tests using the typed test mechanism. It also paves the way for future integration with custom modules specified on the command line. Diffs - src/Makefile.am c44a9ad47d6e1262949b9049f4ae25b049440d99 src/examples/test_isolator_module.cpp PRE-CREATION src/module/isolator.hpp PRE-CREATION src/module/manager.hpp 56e2af334866d2736a8d43f45daf2dbf5189ce2d src/module/manager.cpp 2727fe06a66fda77d984f862bd5b0eaa3cd23726 src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 src/tests/main.cpp 90a7ddcb5695d4c9a7760e18285548d99e7bcfa8 src/tests/module.hpp PRE-CREATION src/tests/module.cpp PRE-CREATION src/tests/module_tests.cpp 54e1e8d26719069d01bfabd918f7c37ddbf3c7c4 Diff: https://reviews.apache.org/r/26071/diff/ Testing --- make check with an Isolator module test. Thanks, Kapil Arya
Re: Review Request 26071: Sample isolator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 16, 2014, 3:19 p.m.) Review request for mesos, Bernd Mathiske, Ian Downes, and Niklas Nielsen. Changes --- Addressed Nik's comments. Bugs: MESOS-1384 https://issues.apache.org/jira/browse/MESOS-1384 Repository: mesos-git Description --- Created CPU and Memory isolation modules based on Posix CPU/Memory Isolators. These modules are also hooked up to the relevant Isolator tests using the typed test mechanism. It also paves the way for future integration with custom modules specified on the command line. Diffs (updated) - src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4 src/examples/test_isolator_module.cpp PRE-CREATION src/module/isolator.hpp PRE-CREATION src/module/manager.hpp 797728a8c8e88dd1a13142a355cbe0b1491fb7a2 src/module/manager.cpp 8cc79956a8d3d7cb27016889ec59d138a0b58e45 src/slave/containerizer/isolator.hpp e52e8b15c740c62ef64b49897d3d6ae5179d4719 src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 src/tests/main.cpp 90a7ddcb5695d4c9a7760e18285548d99e7bcfa8 src/tests/module.hpp PRE-CREATION src/tests/module.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26071/diff/ Testing --- make check with an Isolator module test. Thanks, Kapil Arya
Re: Review Request 26071: Sample isolator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 16, 2014, 3:20 p.m.) Review request for mesos, Bernd Mathiske, Ian Downes, and Niklas Nielsen. Changes --- Updated dependency Bugs: MESOS-1384 https://issues.apache.org/jira/browse/MESOS-1384 Repository: mesos-git Description --- Created CPU and Memory isolation modules based on Posix CPU/Memory Isolators. These modules are also hooked up to the relevant Isolator tests using the typed test mechanism. It also paves the way for future integration with custom modules specified on the command line. Diffs - src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4 src/examples/test_isolator_module.cpp PRE-CREATION src/module/isolator.hpp PRE-CREATION src/module/manager.hpp 797728a8c8e88dd1a13142a355cbe0b1491fb7a2 src/module/manager.cpp 8cc79956a8d3d7cb27016889ec59d138a0b58e45 src/slave/containerizer/isolator.hpp e52e8b15c740c62ef64b49897d3d6ae5179d4719 src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 src/tests/main.cpp 90a7ddcb5695d4c9a7760e18285548d99e7bcfa8 src/tests/module.hpp PRE-CREATION src/tests/module.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26071/diff/ Testing --- make check with an Isolator module test. Thanks, Kapil Arya
Re: Review Request 26071: Sample isolator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/#review57013 --- src/Makefile.am https://reviews.apache.org/r/26071/#comment97452 'Library containing test CPU and memory isolator modules'? src/examples/test_isolator_module.cpp https://reviews.apache.org/r/26071/#comment97481 Let's use modu...@mesos.apache.org (it is working) instead - We don't want to generate modules traffic on the regular dev list. src/examples/test_isolator_module.cpp https://reviews.apache.org/r/26071/#comment97480 Why 'Test' and not Test? src/slave/containerizer/isolator.hpp https://reviews.apache.org/r/26071/#comment97474 Reinsert newline please src/tests/isolator_tests.cpp https://reviews.apache.org/r/26071/#comment97473 Don't know if we have any specific wrapping rules wrt very long templates. This looks off to me - but let's look into that. src/tests/isolator_tests.cpp https://reviews.apache.org/r/26071/#comment97472 same here src/tests/main.cpp https://reviews.apache.org/r/26071/#comment97477 Mind expanding on, that the two modules lists are merged or that they compliment each other? src/tests/module.hpp https://reviews.apache.org/r/26071/#comment97467 Mind adding a comment on why you neem this enum? src/tests/module.hpp https://reviews.apache.org/r/26071/#comment97468 You could add a comment here too explaining how it is used with type_param'ed tests src/tests/module.cpp https://reviews.apache.org/r/26071/#comment97479 Don't you need an include for hashmap (rather than relying on it being included in one of the headers?) Same for path::join src/tests/module.cpp https://reviews.apache.org/r/26071/#comment97459 Mind adding a comment on how future test isolators have to be added? :-) src/tests/module.cpp https://reviews.apache.org/r/26071/#comment97464 I have a hard time understanding how this comment ties into the functionality of initModules() Can you expand/clarify? Or does it belong to moduleNames() instead? src/tests/module.cpp https://reviews.apache.org/r/26071/#comment97460 Please expand 'm' to a full word src/tests/module.cpp https://reviews.apache.org/r/26071/#comment97462 Can you expand a bit on what went wrong? The error message is a bit too general / doesn't add much context. src/tests/module.cpp https://reviews.apache.org/r/26071/#comment97478 Mind distinguish type and kind? Now, you fact called it an ID :-) src/tests/module.cpp https://reviews.apache.org/r/26071/#comment97465 Can you include the module id value in the error message? Makes it a bit easier to debug. - Niklas Nielsen On Oct. 16, 2014, 12:20 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 16, 2014, 12:20 p.m.) Review request for mesos, Bernd Mathiske, Ian Downes, and Niklas Nielsen. Bugs: MESOS-1384 https://issues.apache.org/jira/browse/MESOS-1384 Repository: mesos-git Description --- Created CPU and Memory isolation modules based on Posix CPU/Memory Isolators. These modules are also hooked up to the relevant Isolator tests using the typed test mechanism. It also paves the way for future integration with custom modules specified on the command line. Diffs - src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4 src/examples/test_isolator_module.cpp PRE-CREATION src/module/isolator.hpp PRE-CREATION src/module/manager.hpp 797728a8c8e88dd1a13142a355cbe0b1491fb7a2 src/module/manager.cpp 8cc79956a8d3d7cb27016889ec59d138a0b58e45 src/slave/containerizer/isolator.hpp e52e8b15c740c62ef64b49897d3d6ae5179d4719 src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 src/tests/main.cpp 90a7ddcb5695d4c9a7760e18285548d99e7bcfa8 src/tests/module.hpp PRE-CREATION src/tests/module.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26071/diff/ Testing --- make check with an Isolator module test. Thanks, Kapil Arya
Re: Review Request 26071: Sample isolator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 15, 2014, 11:50 a.m.) Review request for mesos, Bernd Mathiske, Ian Downes, and Niklas Nielsen. Changes --- Updated Isolator tests to run with example Isolator modules as well. Bugs: MESOS-1384 https://issues.apache.org/jira/browse/MESOS-1384 Repository: mesos-git Description (updated) --- Created CPU and Memory isolation modules based on Posix CPU/Memory Isolators. These modules are also hooked up to the relevant Isolator tests using the typed test mechanism. It also paves the way for future integration with custom modules specified on the command line. Diffs (updated) - src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4 src/examples/test_isolator_module.cpp PRE-CREATION src/module/manager.cpp 8cc79956a8d3d7cb27016889ec59d138a0b58e45 src/slave/containerizer/isolator.hpp e52e8b15c740c62ef64b49897d3d6ae5179d4719 src/slave/containerizer/isolators/posix.hpp f120aafef96343d84f93c5636484509dc972a0a8 src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 src/tests/module.hpp PRE-CREATION src/tests/module.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26071/diff/ Testing --- make check with an Isolator module test. Thanks, Kapil Arya
Re: Review Request 26071: Sample isolator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 15, 2014, 11:50 a.m.) Review request for mesos, Bernd Mathiske, Ian Downes, and Niklas Nielsen. Bugs: MESOS-1384 https://issues.apache.org/jira/browse/MESOS-1384 Repository: mesos-git Description --- Created CPU and Memory isolation modules based on Posix CPU/Memory Isolators. These modules are also hooked up to the relevant Isolator tests using the typed test mechanism. It also paves the way for future integration with custom modules specified on the command line. Diffs - src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4 src/examples/test_isolator_module.cpp PRE-CREATION src/module/manager.cpp 8cc79956a8d3d7cb27016889ec59d138a0b58e45 src/slave/containerizer/isolator.hpp e52e8b15c740c62ef64b49897d3d6ae5179d4719 src/slave/containerizer/isolators/posix.hpp f120aafef96343d84f93c5636484509dc972a0a8 src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 src/tests/module.hpp PRE-CREATION src/tests/module.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26071/diff/ Testing --- make check with an Isolator module test. Thanks, Kapil Arya
Re: Review Request 26071: Sample isolator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 15, 2014, 12:52 p.m.) Review request for mesos, Bernd Mathiske, Ian Downes, and Niklas Nielsen. Changes --- Makefile.am update for distcheck. Bugs: MESOS-1384 https://issues.apache.org/jira/browse/MESOS-1384 Repository: mesos-git Description --- Created CPU and Memory isolation modules based on Posix CPU/Memory Isolators. These modules are also hooked up to the relevant Isolator tests using the typed test mechanism. It also paves the way for future integration with custom modules specified on the command line. Diffs (updated) - src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4 src/examples/test_isolator_module.cpp PRE-CREATION src/module/manager.cpp 8cc79956a8d3d7cb27016889ec59d138a0b58e45 src/slave/containerizer/isolator.hpp e52e8b15c740c62ef64b49897d3d6ae5179d4719 src/slave/containerizer/isolators/posix.hpp f120aafef96343d84f93c5636484509dc972a0a8 src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 src/tests/module.hpp PRE-CREATION src/tests/module.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26071/diff/ Testing --- make check with an Isolator module test. Thanks, Kapil Arya
Re: Review Request 26071: Sample isolator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/#review56740 --- Patch looks great! Reviews applied: [26071] All tests passed. - Mesos ReviewBot On Oct. 15, 2014, 4:52 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 15, 2014, 4:52 p.m.) Review request for mesos, Bernd Mathiske, Ian Downes, and Niklas Nielsen. Bugs: MESOS-1384 https://issues.apache.org/jira/browse/MESOS-1384 Repository: mesos-git Description --- Created CPU and Memory isolation modules based on Posix CPU/Memory Isolators. These modules are also hooked up to the relevant Isolator tests using the typed test mechanism. It also paves the way for future integration with custom modules specified on the command line. Diffs - src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4 src/examples/test_isolator_module.cpp PRE-CREATION src/module/manager.cpp 8cc79956a8d3d7cb27016889ec59d138a0b58e45 src/slave/containerizer/isolator.hpp e52e8b15c740c62ef64b49897d3d6ae5179d4719 src/slave/containerizer/isolators/posix.hpp f120aafef96343d84f93c5636484509dc972a0a8 src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 src/tests/module.hpp PRE-CREATION src/tests/module.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26071/diff/ Testing --- make check with an Isolator module test. Thanks, Kapil Arya
Re: Review Request 26071: Sample isolator module.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26071/#review56742
---
src/examples/test_isolator_module.cpp
https://reviews.apache.org/r/26071/#comment97136
You wired up the modules - you can put in your own info (and serve the
purpose of tracking down the right author of broken modules ;-)
Here and below
src/examples/test_isolator_module.cpp
https://reviews.apache.org/r/26071/#comment97135
'Test' CPU Isolator module?
src/examples/test_isolator_module.cpp
https://reviews.apache.org/r/26071/#comment97137
Is this just to exercise the compatible logic? It always returns true.
Please comment if that is the purpose.
src/slave/containerizer/isolator.hpp
https://reviews.apache.org/r/26071/#comment97124
Can we move this to src/modules instead?
src/slave/containerizer/isolators/posix.hpp
https://reviews.apache.org/r/26071/#comment97131
Why this change? Here and below.
src/tests/module.hpp
https://reviews.apache.org/r/26071/#comment97125
Can you make the name and use of this module type more explicit? I had to
think twice, why this wasn't captured by the regular module 'kind'
src/tests/module.hpp
https://reviews.apache.org/r/26071/#comment97127
Can ModuleHelper and TestModule be merged?
src/tests/module.hpp
https://reviews.apache.org/r/26071/#comment97133
How about moving the statics into accessors instead? Here and below
src/tests/module.hpp
https://reviews.apache.org/r/26071/#comment97126
TestModule is a bit vague term for what it does (and a bit confusing mixed
with out previous notions of test/example module). I can't come up with a
better one on the spot, but let's think about it :-)
src/tests/module.cpp
https://reviews.apache.org/r/26071/#comment97130
So the idea is that moduleNames gets populated (later on) by flags? For
example ./mesos-tests --modules={} --module_tests={name: cpu_isolator,
value: org_apache_modules_FooBarIsolator} ?
Or is it only for internal mapping?
How about using strings to map instead of the enum? You would have to keep
a second map from the enum to the string eventually?
src/tests/module.cpp
https://reviews.apache.org/r/26071/#comment97122
How about using the libraryExtension constant as with the previous module
patch?
- Niklas Nielsen
On Oct. 15, 2014, 9:52 a.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26071/
---
(Updated Oct. 15, 2014, 9:52 a.m.)
Review request for mesos, Bernd Mathiske, Ian Downes, and Niklas Nielsen.
Bugs: MESOS-1384
https://issues.apache.org/jira/browse/MESOS-1384
Repository: mesos-git
Description
---
Created CPU and Memory isolation modules based on Posix CPU/Memory Isolators.
These modules are also hooked up to the relevant Isolator tests using the
typed test mechanism. It also paves the way for future integration with
custom modules specified on the command line.
Diffs
-
src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4
src/examples/test_isolator_module.cpp PRE-CREATION
src/module/manager.cpp 8cc79956a8d3d7cb27016889ec59d138a0b58e45
src/slave/containerizer/isolator.hpp
e52e8b15c740c62ef64b49897d3d6ae5179d4719
src/slave/containerizer/isolators/posix.hpp
f120aafef96343d84f93c5636484509dc972a0a8
src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610
src/tests/module.hpp PRE-CREATION
src/tests/module.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/26071/diff/
Testing
---
make check with an Isolator module test.
Thanks,
Kapil Arya
Re: Review Request 26071: Sample isolator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 15, 2014, 9:38 p.m.) Review request for mesos, Bernd Mathiske, Ian Downes, and Niklas Nielsen. Changes --- Addressed most of Nik's comments. Bugs: MESOS-1384 https://issues.apache.org/jira/browse/MESOS-1384 Repository: mesos-git Description --- Created CPU and Memory isolation modules based on Posix CPU/Memory Isolators. These modules are also hooked up to the relevant Isolator tests using the typed test mechanism. It also paves the way for future integration with custom modules specified on the command line. Diffs (updated) - src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4 src/examples/test_isolator_module.cpp PRE-CREATION src/module/manager.cpp 8cc79956a8d3d7cb27016889ec59d138a0b58e45 src/slave/containerizer/isolator.hpp e52e8b15c740c62ef64b49897d3d6ae5179d4719 src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 src/tests/main.cpp 90a7ddcb5695d4c9a7760e18285548d99e7bcfa8 src/tests/module.hpp PRE-CREATION src/tests/module.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26071/diff/ Testing --- make check with an Isolator module test. Thanks, Kapil Arya
Re: Review Request 26071: Sample isolator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/#review54652 --- Patch looks great! Reviews applied: [25848, 26071] All tests passed. - Mesos ReviewBot On Sept. 26, 2014, 5:47 a.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Sept. 26, 2014, 5:47 a.m.) Review request for mesos, Bernd Mathiske and Niklas Nielsen. Bugs: MESOS-1384 https://issues.apache.org/jira/browse/MESOS-1384 Repository: mesos-git Description --- Sample isolator module copied from cgroups/cpu. Diffs - src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b src/examples/test_isolator_module.cpp PRE-CREATION src/examples/test_module.hpp PRE-CREATION src/tests/module_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26071/diff/ Testing --- make check with an Isolator module test. Thanks, Kapil Arya
Re: Review Request 26071: Sample isolator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Sept. 26, 2014, 11:32 a.m.) Review request for mesos, Bernd Mathiske, Ian Downes, and Niklas Nielsen. Changes --- adding ian downes for his take. Bugs: MESOS-1384 https://issues.apache.org/jira/browse/MESOS-1384 Repository: mesos-git Description --- Sample isolator module copied from cgroups/cpu. Diffs - src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b src/examples/test_isolator_module.cpp PRE-CREATION src/examples/test_module.hpp PRE-CREATION src/tests/module_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26071/diff/ Testing --- make check with an Isolator module test. Thanks, Kapil Arya
Re: Review Request 26071: Sample isolator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Sept. 26, 2014, 5:57 p.m.) Review request for mesos, Bernd Mathiske, Ian Downes, and Niklas Nielsen. Changes --- Moved TestIsolatorProcess and TestCpuIsolatorProcesses classes to test_isolator_module.cpp. Bugs: MESOS-1384 https://issues.apache.org/jira/browse/MESOS-1384 Repository: mesos-git Description --- Sample isolator module copied from cgroups/cpu. Diffs (updated) - src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b src/examples/test_isolator_module.cpp PRE-CREATION src/tests/module_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26071/diff/ Testing --- make check with an Isolator module test. Thanks, Kapil Arya
Review Request 26071: Sample isolator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- Review request for mesos, Bernd Mathiske and Niklas Nielsen. Bugs: MESOS-1384 https://issues.apache.org/jira/browse/MESOS-1384 Repository: mesos-git Description --- Sample isolator module copied from cgroups/cpu. Diffs - src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b src/examples/test_isolator_module.cpp PRE-CREATION src/examples/test_module.hpp PRE-CREATION src/tests/module_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26071/diff/ Testing --- make check with an Isolator module test. Thanks, Kapil Arya
