Re: Review Request 26275: MESOS-444: Remove --checkpoint flag
On Jan. 20, 2015, 11:05 a.m., Niklas Nielsen wrote: Is this good to go? If so - let's get it in :) I can commit if you don't have time Committed. - Adam --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/#review68757 --- On Jan. 16, 2015, 4:15 p.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/ --- (Updated Jan. 16, 2015, 4:15 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-444 https://issues.apache.org/jira/browse/MESOS-444 Repository: mesos Description --- Checkpointing has been enabled by default in the slave since 0.14, remove the flag now because all slaves should checkpoint. Removing checkpoint from slaves throughout the codebase will occur in a series of following commits. Diffs - src/slave/flags.hpp a4498e6573758642ed8ba28d6a1d228b91c4f2d4 Diff: https://reviews.apache.org/r/26275/diff/ Testing --- make check on ubuntu 14.04 with gcc. Thanks, Cody Maloney
Re: Review Request 26275: MESOS-444: Remove --checkpoint flag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/#review68757 --- Is this good to go? If so - let's get it in :) I can commit if you don't have time - Niklas Nielsen On Jan. 16, 2015, 4:15 p.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/ --- (Updated Jan. 16, 2015, 4:15 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-444 https://issues.apache.org/jira/browse/MESOS-444 Repository: mesos-git Description --- Checkpointing has been enabled by default in the slave since 0.14, remove the flag now because all slaves should checkpoint. Removing checkpoint from slaves throughout the codebase will occur in a series of following commits. Diffs - src/slave/flags.hpp a4498e6573758642ed8ba28d6a1d228b91c4f2d4 Diff: https://reviews.apache.org/r/26275/diff/ Testing --- make check on ubuntu 14.04 with gcc. Thanks, Cody Maloney
Re: Review Request 26275: MESOS-444: Remove --checkpoint flag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/ --- (Updated Jan. 17, 2015, 12:15 a.m.) Review request for mesos and Vinod Kone. Changes --- Rebased patch on master, added missing period at end of comment. Bugs: MESOS-444 https://issues.apache.org/jira/browse/MESOS-444 Repository: mesos-git Description --- Checkpointing has been enabled by default in the slave since 0.14, remove the flag now because all slaves should checkpoint. Removing checkpoint from slaves throughout the codebase will occur in a series of following commits. Diffs (updated) - src/slave/flags.hpp a4498e6573758642ed8ba28d6a1d228b91c4f2d4 Diff: https://reviews.apache.org/r/26275/diff/ Testing --- make check on ubuntu 14.04 with gcc. Thanks, Cody Maloney
Re: Review Request 26275: MESOS-444: Remove --checkpoint flag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/#review68536 --- Patch looks great! Reviews applied: [26275] All tests passed. - Mesos ReviewBot On Jan. 17, 2015, 12:15 a.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/ --- (Updated Jan. 17, 2015, 12:15 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-444 https://issues.apache.org/jira/browse/MESOS-444 Repository: mesos-git Description --- Checkpointing has been enabled by default in the slave since 0.14, remove the flag now because all slaves should checkpoint. Removing checkpoint from slaves throughout the codebase will occur in a series of following commits. Diffs - src/slave/flags.hpp a4498e6573758642ed8ba28d6a1d228b91c4f2d4 Diff: https://reviews.apache.org/r/26275/diff/ Testing --- make check on ubuntu 14.04 with gcc. Thanks, Cody Maloney
Re: Review Request 26275: MESOS-444: Remove --checkpoint flag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/ --- (Updated Jan. 15, 2015, 11:03 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-444 https://issues.apache.org/jira/browse/MESOS-444 Repository: mesos-git Description --- Checkpointing has been enabled by default in the slave since 0.14, remove the flag now because all slaves should checkpoint. Removing checkpoint from slaves throughout the codebase will occur in a series of following commits. Diffs - src/slave/flags.hpp 16f0cc2 Diff: https://reviews.apache.org/r/26275/diff/ Testing --- make check on ubuntu 14.04 with gcc. Thanks, Cody Maloney
Re: Review Request 26275: MESOS-444: Remove --checkpoint flag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/#review68346 --- Cody, thanks for your patience. Since 0.21.0 has been released with a deprecation warning, we can commit this now. Mind rebasing it? - Vinod Kone On Jan. 15, 2015, 11:03 p.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/ --- (Updated Jan. 15, 2015, 11:03 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-444 https://issues.apache.org/jira/browse/MESOS-444 Repository: mesos-git Description --- Checkpointing has been enabled by default in the slave since 0.14, remove the flag now because all slaves should checkpoint. Removing checkpoint from slaves throughout the codebase will occur in a series of following commits. Diffs - src/slave/flags.hpp 16f0cc2 Diff: https://reviews.apache.org/r/26275/diff/ Testing --- make check on ubuntu 14.04 with gcc. Thanks, Cody Maloney
Re: Review Request 26275: MESOS-444: Remove --checkpoint flag
On Oct. 8, 2014, 5:26 p.m., Vinod Kone wrote: Sorry for the delay in committing this. Since we didn't do a proper deprecation, I'm waiting for some of Twitter's clusters to get updated (i.e., removing --checkpoint from slave config files) before landing this on trunk. Let me know if there is an urgency in landing this patch and we'll figure out how to fast track it or do a proper deprecation. IIUC, given that this flag has defaulted to the correct value for a while there shouldn't need to be a delay to commit this patch. If a particular organization's deployment breaks because it's still explicitly specifying this flag it'll find out very quickly at start time right? We can just add a note to UPDATING that users should remove the flag before upgrading to 0.21.0 from 0.20.0. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/#review55918 --- On Oct. 6, 2014, 11:50 a.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/ --- (Updated Oct. 6, 2014, 11:50 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-444 https://issues.apache.org/jira/browse/MESOS-444 Repository: mesos-git Description --- Checkpointing has been enabled by default in the slave since 0.14, remove the flag now because all slaves should checkpoint. Removing checkpoint from slaves throughout the codebase will occur in a series of following commits. Diffs - src/slave/flags.hpp 16f0cc2 Diff: https://reviews.apache.org/r/26275/diff/ Testing --- make check on ubuntu 14.04 with gcc. Thanks, Cody Maloney
Re: Review Request 26275: MESOS-444: Remove --checkpoint flag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/#review55543 --- Ship it! minor fixes and we will get this committed. src/slave/flags.hpp https://reviews.apache.org/r/26275/#comment95911 Indent by 2 spaces not 4. src/slave/flags.hpp https://reviews.apache.org/r/26275/#comment95912 I don't it's that clear what No add... means. Just say See MESOS-444 for more details. on line #338. - Vinod Kone On Oct. 2, 2014, 7:25 p.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/ --- (Updated Oct. 2, 2014, 7:25 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-444 https://issues.apache.org/jira/browse/MESOS-444 Repository: mesos-git Description --- Checkpointing has been enabled by default in the slave since 0.14, remove the flag now because all slaves should checkpoint. Removing checkpoint from slaves throughout the codebase will occur in a series of following commits. Diffs - src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d Diff: https://reviews.apache.org/r/26275/diff/ Testing --- make check on ubuntu 14.04 with gcc. Thanks, Cody Maloney
Re: Review Request 26275: MESOS-444: Remove --checkpoint flag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/#review55584 --- Patch looks great! Reviews applied: [26275] All tests passed. - Mesos ReviewBot On Oct. 6, 2014, 6:50 p.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/ --- (Updated Oct. 6, 2014, 6:50 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-444 https://issues.apache.org/jira/browse/MESOS-444 Repository: mesos-git Description --- Checkpointing has been enabled by default in the slave since 0.14, remove the flag now because all slaves should checkpoint. Removing checkpoint from slaves throughout the codebase will occur in a series of following commits. Diffs - src/slave/flags.hpp 16f0cc2 Diff: https://reviews.apache.org/r/26275/diff/ Testing --- make check on ubuntu 14.04 with gcc. Thanks, Cody Maloney
Review Request 26275: MESOS-444: Remove --checkpoint flag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-444 https://issues.apache.org/jira/browse/MESOS-444 Repository: mesos-git Description --- Checkpointing has been enabled by default in the slave since 0.14, remove the flag now because all slaves should checkpoint. Removing checkpoint from slaves throughout the codebase will occur in a series of following commits. Diffs - src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d Diff: https://reviews.apache.org/r/26275/diff/ Testing --- make check on ubuntu 14.04 with gcc. Thanks, Cody Maloney
Re: Review Request 26275: MESOS-444: Remove --checkpoint flag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/#review55232 --- src/slave/flags.hpp https://reviews.apache.org/r/26275/#comment95627 we put the initializer list on the next line. src/slave/flags.hpp https://reviews.apache.org/r/26275/#comment95629 Can you send an email to the dev list indicating this change? If people object to this change landing in 0.21.0 without deprecation warning, we might have to kill it in 0.22.0 with a warning in 0.21.0. src/slave/flags.hpp https://reviews.apache.org/r/26275/#comment95628 Can you add a comment here mentioning why the field is here though there is no corresponding add? - Vinod Kone On Oct. 2, 2014, 6:44 p.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/ --- (Updated Oct. 2, 2014, 6:44 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-444 https://issues.apache.org/jira/browse/MESOS-444 Repository: mesos-git Description --- Checkpointing has been enabled by default in the slave since 0.14, remove the flag now because all slaves should checkpoint. Removing checkpoint from slaves throughout the codebase will occur in a series of following commits. Diffs - src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d Diff: https://reviews.apache.org/r/26275/diff/ Testing --- make check on ubuntu 14.04 with gcc. Thanks, Cody Maloney
Re: Review Request 26275: MESOS-444: Remove --checkpoint flag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/#review55233 --- src/slave/flags.hpp https://reviews.apache.org/r/26275/#comment95631 please add a comment to MESOS-444 capturing this TODO, and include a reference to that issue in this comment. src/slave/flags.hpp https://reviews.apache.org/r/26275/#comment95630 consider making this const to indicate it is no longer mutable through flags. - Dominic Hamon On Oct. 2, 2014, 12:25 p.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/ --- (Updated Oct. 2, 2014, 12:25 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-444 https://issues.apache.org/jira/browse/MESOS-444 Repository: mesos-git Description --- Checkpointing has been enabled by default in the slave since 0.14, remove the flag now because all slaves should checkpoint. Removing checkpoint from slaves throughout the codebase will occur in a series of following commits. Diffs - src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d Diff: https://reviews.apache.org/r/26275/diff/ Testing --- make check on ubuntu 14.04 with gcc. Thanks, Cody Maloney
Re: Review Request 26275: MESOS-444: Remove --checkpoint flag
On Oct. 2, 2014, 7:28 p.m., Dominic Hamon wrote: src/slave/flags.hpp, line 348 https://reviews.apache.org/r/26275/diff/2/?file=711514#file711514line348 consider making this const to indicate it is no longer mutable through flags. There is manual setting of this in a number of the unit tests, so it can't be const here yet. In the next patch which I've been working on I remove this variable entirely from flags (Leaving the checkpoint variable in the SlaveInfo struct). - Cody --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/#review55233 --- On Oct. 2, 2014, 7:25 p.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/ --- (Updated Oct. 2, 2014, 7:25 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-444 https://issues.apache.org/jira/browse/MESOS-444 Repository: mesos-git Description --- Checkpointing has been enabled by default in the slave since 0.14, remove the flag now because all slaves should checkpoint. Removing checkpoint from slaves throughout the codebase will occur in a series of following commits. Diffs - src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d Diff: https://reviews.apache.org/r/26275/diff/ Testing --- make check on ubuntu 14.04 with gcc. Thanks, Cody Maloney
Re: Review Request 26275: MESOS-444: Remove --checkpoint flag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/#review55263 --- Patch looks great! Reviews applied: [26275] All tests passed. - Mesos ReviewBot On Oct. 2, 2014, 7:25 p.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/ --- (Updated Oct. 2, 2014, 7:25 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-444 https://issues.apache.org/jira/browse/MESOS-444 Repository: mesos-git Description --- Checkpointing has been enabled by default in the slave since 0.14, remove the flag now because all slaves should checkpoint. Removing checkpoint from slaves throughout the codebase will occur in a series of following commits. Diffs - src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d Diff: https://reviews.apache.org/r/26275/diff/ Testing --- make check on ubuntu 14.04 with gcc. Thanks, Cody Maloney
