Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-25 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/#review77721
---

Ship it!


Ship It!

- Till Toenshoff


On March 9, 2015, 11:09 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31538/
> ---
> 
> (Updated March 9, 2015, 11:09 a.m.)
> 
> 
> Review request for mesos, Isabel Jimenez, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: mesos-2291
> https://issues.apache.org/jira/browse/mesos-2291
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Copies validations made to the messages exchanged between the slave and the 
> `MesosExecutorDriver` and performed in the executor driver to the slave. This 
> is requiered since the new HTTP API will deprecate the executor driver.
> 
> 
> Diffs
> -
> 
>   src/exec/exec.cpp d678f0682d803b0b080c3a6c296067ac9ab5dbf8 
>   src/slave/slave.cpp 364d911b086dfe1f15f76aa3888f99146aa8d876 
> 
> Diff: https://reviews.apache.org/r/31538/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-24 Thread Isabel Jimenez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/#review77644
---


LGTM!

- Isabel Jimenez


On March 9, 2015, 11:09 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31538/
> ---
> 
> (Updated March 9, 2015, 11:09 a.m.)
> 
> 
> Review request for mesos, Isabel Jimenez, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: mesos-2291
> https://issues.apache.org/jira/browse/mesos-2291
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Copies validations made to the messages exchanged between the slave and the 
> `MesosExecutorDriver` and performed in the executor driver to the slave. This 
> is requiered since the new HTTP API will deprecate the executor driver.
> 
> 
> Diffs
> -
> 
>   src/exec/exec.cpp d678f0682d803b0b080c3a6c296067ac9ab5dbf8 
>   src/slave/slave.cpp 364d911b086dfe1f15f76aa3888f99146aa8d876 
> 
> Diff: https://reviews.apache.org/r/31538/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-24 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/#review77632
---

Ship it!


Ship It!

- Alexander Rukletsov


On March 9, 2015, 11:09 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31538/
> ---
> 
> (Updated March 9, 2015, 11:09 a.m.)
> 
> 
> Review request for mesos, Isabel Jimenez, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: mesos-2291
> https://issues.apache.org/jira/browse/mesos-2291
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Copies validations made to the messages exchanged between the slave and the 
> `MesosExecutorDriver` and performed in the executor driver to the slave. This 
> is requiered since the new HTTP API will deprecate the executor driver.
> 
> 
> Diffs
> -
> 
>   src/exec/exec.cpp d678f0682d803b0b080c3a6c296067ac9ab5dbf8 
>   src/slave/slave.cpp 364d911b086dfe1f15f76aa3888f99146aa8d876 
> 
> Diff: https://reviews.apache.org/r/31538/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-09 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/#review75690
---


Patch looks great!

Reviews applied: [31538]

All tests passed.

- Mesos ReviewBot


On March 9, 2015, 11:09 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31538/
> ---
> 
> (Updated March 9, 2015, 11:09 a.m.)
> 
> 
> Review request for mesos, Isabel Jimenez, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: mesos-2291
> https://issues.apache.org/jira/browse/mesos-2291
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Copies validations made to the messages exchanged between the slave and the 
> `MesosExecutorDriver` and performed in the executor driver to the slave. This 
> is requiered since the new HTTP API will deprecate the executor driver.
> 
> 
> Diffs
> -
> 
>   src/exec/exec.cpp d678f0682d803b0b080c3a6c296067ac9ab5dbf8 
>   src/slave/slave.cpp 364d911b086dfe1f15f76aa3888f99146aa8d876 
> 
> Diff: https://reviews.apache.org/r/31538/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-09 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/
---

(Updated March 9, 2015, 12:09 p.m.)


Review request for mesos, Isabel Jimenez, Till Toenshoff, and Vinod Kone.


Changes
---

Updating comments in order to reflect the elimination of the validations on the 
`ExecutorDriver`.


Bugs: mesos-2291
https://issues.apache.org/jira/browse/mesos-2291


Repository: mesos


Description
---

Copies validations made to the messages exchanged between the slave and the 
`MesosExecutorDriver` and performed in the executor driver to the slave. This 
is requiered since the new HTTP API will deprecate the executor driver.


Diffs (updated)
-

  src/exec/exec.cpp d678f0682d803b0b080c3a6c296067ac9ab5dbf8 
  src/slave/slave.cpp 364d911b086dfe1f15f76aa3888f99146aa8d876 

Diff: https://reviews.apache.org/r/31538/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-06 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/#review75582
---

Ship it!



src/slave/slave.cpp


This no longer applies, so how about

// Failing this validation on the executor driver
// used to cause the driver to abort. Now that the 
// validation is done by the slave, it should
// shutdown the executor to be consistent.
// TODO(arojas): Once the HTTP API is the default, return a
// 400 Bad Request response, indicating the reason in the body.



src/slave/slave.cpp


```

LOG(ERROR) << "Received TASK_STAGING from executor << executor->id
   << " of framework " << update.framework_id()
   << " which is not allowed; Shutting down the executor";

shutdownExecutor(framework, executor);

```


- Vinod Kone


On March 6, 2015, 10:42 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31538/
> ---
> 
> (Updated March 6, 2015, 10:42 a.m.)
> 
> 
> Review request for mesos, Isabel Jimenez, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: mesos-2291
> https://issues.apache.org/jira/browse/mesos-2291
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Copies validations made to the messages exchanged between the slave and the 
> `MesosExecutorDriver` and performed in the executor driver to the slave. This 
> is requiered since the new HTTP API will deprecate the executor driver.
> 
> 
> Diffs
> -
> 
>   src/exec/exec.cpp d678f0682d803b0b080c3a6c296067ac9ab5dbf8 
>   src/slave/slave.cpp 2d52ea0c440fd530174b0e44a59c8ae68fa2616c 
> 
> Diff: https://reviews.apache.org/r/31538/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-06 Thread Isabel Jimenez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/#review75556
---


LGTM!

- Isabel Jimenez


On March 6, 2015, 10:42 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31538/
> ---
> 
> (Updated March 6, 2015, 10:42 a.m.)
> 
> 
> Review request for mesos, Isabel Jimenez, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: mesos-2291
> https://issues.apache.org/jira/browse/mesos-2291
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Copies validations made to the messages exchanged between the slave and the 
> `MesosExecutorDriver` and performed in the executor driver to the slave. This 
> is requiered since the new HTTP API will deprecate the executor driver.
> 
> 
> Diffs
> -
> 
>   src/exec/exec.cpp d678f0682d803b0b080c3a6c296067ac9ab5dbf8 
>   src/slave/slave.cpp 2d52ea0c440fd530174b0e44a59c8ae68fa2616c 
> 
> Diff: https://reviews.apache.org/r/31538/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-06 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/#review75485
---


Patch looks great!

Reviews applied: [31538]

All tests passed.

- Mesos ReviewBot


On March 6, 2015, 10:42 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31538/
> ---
> 
> (Updated March 6, 2015, 10:42 a.m.)
> 
> 
> Review request for mesos, Isabel Jimenez, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: mesos-2291
> https://issues.apache.org/jira/browse/mesos-2291
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Copies validations made to the messages exchanged between the slave and the 
> `MesosExecutorDriver` and performed in the executor driver to the slave. This 
> is requiered since the new HTTP API will deprecate the executor driver.
> 
> 
> Diffs
> -
> 
>   src/exec/exec.cpp d678f0682d803b0b080c3a6c296067ac9ab5dbf8 
>   src/slave/slave.cpp 2d52ea0c440fd530174b0e44a59c8ae68fa2616c 
> 
> Diff: https://reviews.apache.org/r/31538/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-06 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/
---

(Updated March 6, 2015, 11:42 a.m.)


Review request for mesos, Isabel Jimenez, Till Toenshoff, and Vinod Kone.


Changes
---

1. Added the framework and executor id in the log so debugging is made easier.
2. Shuts down the executor.
3. Removes validation from the `ExecutorDriver`.
4. Adds and indication to the comments, requesting to send a message explaining 
why the driver is being shutdown.


Bugs: mesos-2291
https://issues.apache.org/jira/browse/mesos-2291


Repository: mesos


Description
---

Copies validations made to the messages exchanged between the slave and the 
`MesosExecutorDriver` and performed in the executor driver to the slave. This 
is requiered since the new HTTP API will deprecate the executor driver.


Diffs (updated)
-

  src/exec/exec.cpp d678f0682d803b0b080c3a6c296067ac9ab5dbf8 
  src/slave/slave.cpp 2d52ea0c440fd530174b0e44a59c8ae68fa2616c 

Diff: https://reviews.apache.org/r/31538/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-05 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/#review75353
---



src/slave/slave.cpp


Add the executor id in the log and framework id.

Add a comment to send an error message to the executor when it can be done.

Shutdown the executor.

Remove the validation in the executor driver.


- Alexander Rojas


On March 5, 2015, 11:02 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31538/
> ---
> 
> (Updated March 5, 2015, 11:02 a.m.)
> 
> 
> Review request for mesos, Isabel Jimenez, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: mesos-2291
> https://issues.apache.org/jira/browse/mesos-2291
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Copies validations made to the messages exchanged between the slave and the 
> `MesosExecutorDriver` and performed in the executor driver to the slave. This 
> is requiered since the new HTTP API will deprecate the executor driver.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 2d52ea0c440fd530174b0e44a59c8ae68fa2616c 
> 
> Diff: https://reviews.apache.org/r/31538/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-05 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/#review75317
---


Patch looks great!

Reviews applied: [31538]

All tests passed.

- Mesos ReviewBot


On March 5, 2015, 10:02 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31538/
> ---
> 
> (Updated March 5, 2015, 10:02 a.m.)
> 
> 
> Review request for mesos, Isabel Jimenez, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: mesos-2291
> https://issues.apache.org/jira/browse/mesos-2291
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Copies validations made to the messages exchanged between the slave and the 
> `MesosExecutorDriver` and performed in the executor driver to the slave. This 
> is requiered since the new HTTP API will deprecate the executor driver.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 2d52ea0c440fd530174b0e44a59c8ae68fa2616c 
> 
> Diff: https://reviews.apache.org/r/31538/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-05 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/
---

(Updated March 5, 2015, 11:02 a.m.)


Review request for mesos, Isabel Jimenez, Till Toenshoff, and Vinod Kone.


Changes
---

Added TODO reflecting the behaviour of the check once the HTTP API is in place.
Log string style fixes.


Bugs: mesos-2291
https://issues.apache.org/jira/browse/mesos-2291


Repository: mesos


Description
---

Copies validations made to the messages exchanged between the slave and the 
`MesosExecutorDriver` and performed in the executor driver to the slave. This 
is requiered since the new HTTP API will deprecate the executor driver.


Diffs (updated)
-

  src/slave/slave.cpp 2d52ea0c440fd530174b0e44a59c8ae68fa2616c 

Diff: https://reviews.apache.org/r/31538/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-04 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/#review75269
---


Patch looks great!

Reviews applied: [31538]

All tests passed.

- Mesos ReviewBot


On March 4, 2015, 10:08 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31538/
> ---
> 
> (Updated March 4, 2015, 10:08 a.m.)
> 
> 
> Review request for mesos, Isabel Jimenez, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: mesos-2291
> https://issues.apache.org/jira/browse/mesos-2291
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Copies validations made to the messages exchanged between the slave and the 
> `MesosExecutorDriver` and performed in the executor driver to the slave. This 
> is requiered since the new HTTP API will deprecate the executor driver.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp a06d68032f26ccb3f786b6ea7c3a6c3c52449bd2 
> 
> Diff: https://reviews.apache.org/r/31538/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-04 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/#review75214
---

Ship it!



src/slave/slave.cpp


s/updates./update. Destroying the container/

We don't use periods at the end of log lines.


- Vinod Kone


On March 4, 2015, 10:08 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31538/
> ---
> 
> (Updated March 4, 2015, 10:08 a.m.)
> 
> 
> Review request for mesos, Isabel Jimenez, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: mesos-2291
> https://issues.apache.org/jira/browse/mesos-2291
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Copies validations made to the messages exchanged between the slave and the 
> `MesosExecutorDriver` and performed in the executor driver to the slave. This 
> is requiered since the new HTTP API will deprecate the executor driver.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp a06d68032f26ccb3f786b6ea7c3a6c3c52449bd2 
> 
> Diff: https://reviews.apache.org/r/31538/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-04 Thread Isabel Jimenez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/#review75209
---



src/slave/slave.cpp


Could you add a TODO on how the error will be handled for the HTTP API?


- Isabel Jimenez


On March 4, 2015, 10:08 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31538/
> ---
> 
> (Updated March 4, 2015, 10:08 a.m.)
> 
> 
> Review request for mesos, Isabel Jimenez, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: mesos-2291
> https://issues.apache.org/jira/browse/mesos-2291
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Copies validations made to the messages exchanged between the slave and the 
> `MesosExecutorDriver` and performed in the executor driver to the slave. This 
> is requiered since the new HTTP API will deprecate the executor driver.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp a06d68032f26ccb3f786b6ea7c3a6c3c52449bd2 
> 
> Diff: https://reviews.apache.org/r/31538/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-04 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/
---

(Updated March 4, 2015, 11:08 a.m.)


Review request for mesos, Isabel Jimenez and Till Toenshoff.


Changes
---

Uploads correct patch. Destroys container on validation failure.


Bugs: mesos-2291
https://issues.apache.org/jira/browse/mesos-2291


Repository: mesos


Description
---

Copies validations made to the messages exchanged between the slave and the 
`MesosExecutorDriver` and performed in the executor driver to the slave. This 
is requiered since the new HTTP API will deprecate the executor driver.


Diffs (updated)
-

  src/slave/slave.cpp a06d68032f26ccb3f786b6ea7c3a6c3c52449bd2 

Diff: https://reviews.apache.org/r/31538/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-03 Thread Isabel Jimenez 


> On March 3, 2015, 10:04 p.m., Isabel Jimenez wrote:
> > Ship It!

Sorry I missed the main issue, see Vinod's comment.


- Isabel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/#review75056
---


On March 3, 2015, 2:24 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31538/
> ---
> 
> (Updated March 3, 2015, 2:24 p.m.)
> 
> 
> Review request for mesos, Isabel Jimenez and Till Toenshoff.
> 
> 
> Bugs: mesos-2291
> https://issues.apache.org/jira/browse/mesos-2291
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Copies validations made to the messages exchanged between the slave and the 
> `MesosExecutorDriver` and performed in the executor driver to the slave. This 
> is requiered since the new HTTP API will deprecate the executor driver.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp a06d68032f26ccb3f786b6ea7c3a6c3c52449bd2 
> 
> Diff: https://reviews.apache.org/r/31538/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-03 Thread Isabel Jimenez 


> On March 3, 2015, 10:25 p.m., Vinod Kone wrote:
> > src/slave/slave.cpp, line 2519
> > 
> >
> > shouldn't this be "status.state() == TASK_STAGING" !?!?
> > 
> > I'm surprised this passed 'make check'!??
> > 
> > This validation in the driver aborted the driver/executor. Now this 
> > validation in the slave silently drops this message without informing the 
> > driver. How about destroying the container instead for now to keep parity? 
> > With HTTP API this will probably just result in a "400 Bad Request" 
> > response.

+1


- Isabel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/#review75062
---


On March 3, 2015, 2:24 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31538/
> ---
> 
> (Updated March 3, 2015, 2:24 p.m.)
> 
> 
> Review request for mesos, Isabel Jimenez and Till Toenshoff.
> 
> 
> Bugs: mesos-2291
> https://issues.apache.org/jira/browse/mesos-2291
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Copies validations made to the messages exchanged between the slave and the 
> `MesosExecutorDriver` and performed in the executor driver to the slave. This 
> is requiered since the new HTTP API will deprecate the executor driver.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp a06d68032f26ccb3f786b6ea7c3a6c3c52449bd2 
> 
> Diff: https://reviews.apache.org/r/31538/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-03 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/#review75062
---



src/slave/slave.cpp


shouldn't this be "status.state() == TASK_STAGING" !?!?

I'm surprised this passed 'make check'!??

This validation in the driver aborted the driver/executor. Now this 
validation in the slave silently drops this message without informing the 
driver. How about destroying the container instead for now to keep parity? With 
HTTP API this will probably just result in a "400 Bad Request" response.


- Vinod Kone


On March 3, 2015, 2:24 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31538/
> ---
> 
> (Updated March 3, 2015, 2:24 p.m.)
> 
> 
> Review request for mesos, Isabel Jimenez and Till Toenshoff.
> 
> 
> Bugs: mesos-2291
> https://issues.apache.org/jira/browse/mesos-2291
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Copies validations made to the messages exchanged between the slave and the 
> `MesosExecutorDriver` and performed in the executor driver to the slave. This 
> is requiered since the new HTTP API will deprecate the executor driver.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp a06d68032f26ccb3f786b6ea7c3a6c3c52449bd2 
> 
> Diff: https://reviews.apache.org/r/31538/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-03 Thread Isabel Jimenez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/#review75056
---

Ship it!


Ship It!

- Isabel Jimenez


On March 3, 2015, 2:24 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31538/
> ---
> 
> (Updated March 3, 2015, 2:24 p.m.)
> 
> 
> Review request for mesos, Isabel Jimenez and Till Toenshoff.
> 
> 
> Bugs: mesos-2291
> https://issues.apache.org/jira/browse/mesos-2291
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Copies validations made to the messages exchanged between the slave and the 
> `MesosExecutorDriver` and performed in the executor driver to the slave. This 
> is requiered since the new HTTP API will deprecate the executor driver.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp a06d68032f26ccb3f786b6ea7c3a6c3c52449bd2 
> 
> Diff: https://reviews.apache.org/r/31538/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-03 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/
---

(Updated March 3, 2015, 3:24 p.m.)


Review request for mesos, Isabel Jimenez and Till Toenshoff.


Changes
---

Fixed issues pointed by ijimenez.


Bugs: mesos-2291
https://issues.apache.org/jira/browse/mesos-2291


Repository: mesos


Description
---

Copies validations made to the messages exchanged between the slave and the 
`MesosExecutorDriver` and performed in the executor driver to the slave. This 
is requiered since the new HTTP API will deprecate the executor driver.


Diffs (updated)
-

  src/slave/slave.cpp a06d68032f26ccb3f786b6ea7c3a6c3c52449bd2 

Diff: https://reviews.apache.org/r/31538/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.

2015-03-02 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/
---

(Updated March 2, 2015, 1:59 p.m.)


Review request for mesos, Isabel Jimenez and Till Toenshoff.


Changes
---

Removing unecesary comments.


Bugs: mesos-2291
https://issues.apache.org/jira/browse/mesos-2291


Repository: mesos


Description
---

Copies validations made to the messages exchanged between the slave and the 
`MesosExecutorDriver` and performed in the executor driver to the slave. This 
is requiered since the new HTTP API will deprecate the executor driver.


Diffs (updated)
-

  src/slave/slave.cpp a06d68032f26ccb3f786b6ea7c3a6c3c52449bd2 

Diff: https://reviews.apache.org/r/31538/diff/


Testing
---

make check


Thanks,

Alexander Rojas