[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/902 +1 ---
[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/902 I merged with master, so I expect Travis to be happy now. Just need +1s and I'll get this in to allow for any follow-ons. ---
[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/902 I have another script I want to add for tracking master in feature branches after this as well ---
[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/902 I can almost always be bought off with a jira number ---
[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/902 > @ottobackwards: I think of there being two users for these scripts... That makes perfect sense to me. Can we tackle that in a follow-on? ---
[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/902 I'm definitely fine with leaving HTML encoding to a follow-on. ---
[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/902 I think of there being two users for these scripts. 1. Committers, that will benefit by having scripted commit actions 2. Reviewers who would benefit by having scripted PR downloads for build and review. These may not be committers. If we merge the scripts, we should maintain the reviewer only case ( no apache id or email etc ) ---
[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/902 I'm game to merge the `prepare-commit` and `checkout-pr` logic into one script; I'm even fine with pushing that to be a follow-on. Regarding the HTML-encoded JIRA description issue, I'm also fine with this being a follow-on. I will be submitting a PR to support both of the Metron repos in this script after it's merged, and can take a stab at the JIRA description issue if it's still a problem. ---
[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/902
Re: the single quoting issue.
Avoiding the XML blob and using the main rest endpoint seems to kick back
actual quotation marks. Now you have to read JSON instead of XML, but it might
be more convenient to do that.
```
{8:57}~ â curl
https://issues.apache.org/jira/rest/api/latest/issue/METRON-1298\?fields\=summary
{"expand":"renderedFields,names,schema,operations,editmeta,changelog,versionedRepresentations","id":"13116358","self":"https://issues.apache.org/jira/rest/api/latest/issue/13116358","key":"METRON-1298","fields":{"summary":"TimeRange
Picker doesn't work on Safari"}}%
```
I didn't dig into why things are different, I was mostly more trying to
learn more about the API choice in there, and happened to notice it.
Sidenote, that XML blob can have the specific fields you want appended to
avoid pulling back everything
```
https://issues.apache.org/jira/si/jira.issueviews:issue-xml/METRON-1298/METRON-1298.xml?field=summary
```
---
[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/902 > @JonZeolla: ... the curl command HTML encodes the JIRA description but I don't know of a clean bash-native way to decode it. Yes, I have noticed, especially with apostrophes. When that happens, I usually just manually override it as a work around. My goal was just to get the tool into Apache as-is (warts and all). We can try and fix annoyances like that on subsequent PRs (IMHO). I know you have some enhancements that you would like to make also. Looking forward to those. :) ---
[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/902 Also, I've never liked the name `prepare-commit`. If you guys can think of something better, please let me know. ---
[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/902 Travis had a hickup... Doing the "close/reopen" dance to trigger the CI build. ---
[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/902 The Apache ID isn't really necessary to use `prepare-commit`. What if I just changed the docs to note that it is not required? I could document how you could use the script to review a PR. I would like to try and fill the need that you've identified @ottobackwards, I just really want to keep the amount of code that we have to maintain and support as minimal as possible. ---
[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/902 Maybe we can have reviewer tools and put checkout-pr in it? For those without an apache id? ---
[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/902 I don't see the value in `checkout-pr` any longer. You can just use `prepare-commit` which gives you the exact view of what the code would look-like when its merged. ---
[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/902 I think checkout-pr is equally as valuable and should be included ---
[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool
Github user mattf-horton commented on the issue: https://github.com/apache/metron/pull/902 I have a mild preference for dev-utilities, since "support" has many meanings. ---
[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/902 Thanks @mattf-horton. Either of those suggestions works for me; 'dev-support' or 'dev-utilities'. I'll let others chime in with their preference and then update it accordingly. ---
[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool
Github user mattf-horton commented on the issue: https://github.com/apache/metron/pull/902 @nickwallen , excellent to get this into the main repo, and totally agree with the reorganization. My only suggestion is that the main directory, currently named "metron-dev-support", shouldn't have the word "metron" in it, because it isn't a package that gets built into the Metron product. "dev-support" or "dev-utilities" would be better. +1 whether you accept the suggestion or not. ---
