Re: [VOTE] MINA 2.0.0 take 2

2010-09-20 Thread Alan D. Cabrera 

On Sep 20, 2010, at 2:35 PM, Emmanuel Lecharny wrote:

> On 9/20/10 9:31 PM, Alan D. Cabrera wrote:
>> On Sep 20, 2010, at 11:38 AM, Emmanuel Lecharny wrote:
>> All I did was
>> 
>> mvn rat:check -fn
> 
> To get the full report, one should do mvn site and get the report from 
> target/site/rat-report.html, which I did.
> 
> Summary
> ---
> Notes: 0
> Binaries: 4
> Archives: 0
> Standards: 639
> 
> Apache Licensed: 613
> Generated Documents: 0
> 
> JavaDocs are generated and so license header is optional
> Generated files do not required license headers
> 
> 26 Unknown Licenses
> 
> 
> 
> There are some missing ASL header in the following files :
> 
> !? mina-core/src/main/java/org/apache/mina/proxy/utils/MD4.java
> !? 
> mina-core/src/test/java/org/apache/mina/core/service/AbstractIoServiceTest.java
> !? 
> mina-core/src/test/java/org/apache/mina/filter/logging/LoadTestMdcInjectionFilter.java
> !? mina-legal/src/main/resources/notices.xml
> 
> Should we abort the release once more for those 4 files, two of them having 
> been added whiel I was fighting with Maven, or can we wait for a 2.0.1 ?
> 
> Frankly, I would rather release a 2.0.1 immediately than going through the 
> 2.0.0 vote again.
> 
> wdyt ?

It's my understanding that those files are required to have an ASL header 
before a release can happen.


Regards,
Alan

Re: [VOTE] MINA 2.0.0 take 2

2010-09-20 Thread Ashish 
On Tue, Sep 21, 2010 at 3:05 AM, Emmanuel Lecharny  wrote:
>  On 9/20/10 9:31 PM, Alan D. Cabrera wrote:
>>
>> On Sep 20, 2010, at 11:38 AM, Emmanuel Lecharny wrote:
>> All I did was
>>
>> mvn rat:check -fn
>
> To get the full report, one should do mvn site and get the report from
> target/site/rat-report.html, which I did.
>
> Summary
> ---
> Notes: 0
> Binaries: 4
> Archives: 0
> Standards: 639
>
> Apache Licensed: 613
> Generated Documents: 0
>
> JavaDocs are generated and so license header is optional
> Generated files do not required license headers
>
> 26 Unknown Licenses
>
>
>
> There are some missing ASL header in the following files :
>
>  !? mina-core/src/main/java/org/apache/mina/proxy/utils/MD4.java
>  !?
> mina-core/src/test/java/org/apache/mina/core/service/AbstractIoServiceTest.java
>  !?
> mina-core/src/test/java/org/apache/mina/filter/logging/LoadTestMdcInjectionFilter.java
>  !? mina-legal/src/main/resources/notices.xml
>
> Should we abort the release once more for those 4 files, two of them having
> been added whiel I was fighting with Maven, or can we wait for a 2.0.1 ?
>
> Frankly, I would rather release a 2.0.1 immediately than going through the
> 2.0.0 vote again.
>
> wdyt ?

My -1 for vote again.

IMHO, we go for a release. Create a JIRA for this and address it in 2.0.1

People are waiting for a GA.

thanks
ashish

Re: [VOTE] MINA 2.0.0 take 2

2010-09-20 Thread Emmanuel Lecharny 

 On 9/20/10 9:31 PM, Alan D. Cabrera wrote:

On Sep 20, 2010, at 11:38 AM, Emmanuel Lecharny wrote:
All I did was

mvn rat:check -fn


To get the full report, one should do mvn site and get the report from 
target/site/rat-report.html, which I did.


Summary
---
Notes: 0
Binaries: 4
Archives: 0
Standards: 639

Apache Licensed: 613
Generated Documents: 0

JavaDocs are generated and so license header is optional
Generated files do not required license headers

26 Unknown Licenses



There are some missing ASL header in the following files :

 !? mina-core/src/main/java/org/apache/mina/proxy/utils/MD4.java
 !? 
mina-core/src/test/java/org/apache/mina/core/service/AbstractIoServiceTest.java
 !? 
mina-core/src/test/java/org/apache/mina/filter/logging/LoadTestMdcInjectionFilter.java
 !? mina-legal/src/main/resources/notices.xml

Should we abort the release once more for those 4 files, two of them having 
been added whiel I was fighting with Maven, or can we wait for a 2.0.1 ?

Frankly, I would rather release a 2.0.1 immediately than going through the 
2.0.0 vote again.

wdyt ?


--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com

Re: [VOTE] MINA 2.0.0 take 2

2010-09-20 Thread Alan D. Cabrera 

On Sep 20, 2010, at 11:38 AM, Emmanuel Lecharny wrote:

> On 9/20/10 8:18 PM, Alan D. Cabrera wrote:
>> Rat complains:
>> 
>> Too many unapproved licenses: 613
>> 
>> Should we be concerned?
> Rat must be drunk like a rat. We only have 561 java files, plus a few .xml 
> files.
> 
> Do you have a log ?

All I did was

mvn rat:check -fn


Regards,
Alan

Re: [VOTE] MINA 2.0.0 take 2

2010-09-20 Thread Emmanuel Lecharny 

 On 9/20/10 8:18 PM, Alan D. Cabrera wrote:

Rat complains:

Too many unapproved licenses: 613

Should we be concerned?
Rat must be drunk like a rat. We only have 561 java files, plus a few 
.xml files.


Do you have a log ?


--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com

Re: [VOTE] MINA 2.0.0 take 2

2010-09-20 Thread Alan D. Cabrera 
Rat complains:

Too many unapproved licenses: 613

Should we be concerned?


Regards,
Alan

On Sep 17, 2010, at 11:18 AM, Emmanuel Lecharny wrote:

> 
> Hi,
> 
> The last version of MINA (2.0.0) has been released !
> Here are the complete release notes from JIRA:
> 
> 
> 
>   Bug
> 
>   * [DIRMINA-539 ]
> - NioDatagramConnector doesn't takes the TrafficClass value set to
> his DatagramSessionConfig
>   * [DIRMINA-650 ]
> - Mina server does not recieve all data sent by client using
> SSLSocketFactory
>   * [DIRMINA-678 ]
> - NioProcessor 100% CPU usage on Linux (epoll selector bug)
>   * [DIRMINA-679 ]
> - NullPointerException in ProtocolCodecFilter.filterWrite
>   * [DIRMINA-684 ]
> - NullPointerException when opening socket to localhost
>   * [DIRMINA-711 ]
> - Adding some logs in the chain make the MDCFilter tests to fail
>   * [DIRMINA-720 ]
> - Hardware Flow Control Disables Serial Port on Windows Platform
>   * [DIRMINA-732 ]
> - Session Idle events never comes in sessions managed by
> NioDatagramAcceptor
>   * [DIRMINA-733 ]
> - The profile method in the ProfilerTimerFilter can caused more
> methods to be profiled than intended.
>   * [DIRMINA-742 ]
> - When session is closed, DefaultIoFilterChain is in deadlock.
>   * [DIRMINA-746 ]
> - DefaultSocketSessionConfig.setReceiveBufferSize(...) throws
> NullPointerException
>   * [DIRMINA-748 ]
> - CachedBufferAllocator does not free buffers when
> maxCachedBufferSize=0
>   * [DIRMINA-749 ]
> - Cannot have more than one CODEC in the chain
>   * [DIRMINA-753 ]
> - Some writes observed to stall until select times out
>   * [DIRMINA-755 ]
> - IoConnectot.dispose blocks forever
>   * [DIRMINA-760 ]
> - Client fails to detect disconnection
>   * [DIRMINA-762 ]
> - WARN org.apache.mina.core.service.IoProcessor - Create a new
> selector. Selected is 0, delta = 0
>   * [DIRMINA-763 ]
> - Errors with Datagram when running tests on linux
>   * [DIRMINA-764 ]
> - DDOS possible in only a few seconds...
>   * [DIRMINA-770 ]
> - Remove all the new NullPointerException()
>   * [DIRMINA-771 ]
> - Calling NioSocketSession.toString() causes java.lang.Error
>   * [DIRMINA-777 ]
> - IoSessionConfig.setUseReadOperation(true) doesn't seem to work
>   * [DIRMINA-778 ]
> - TextLineDecoder not thread safe?
>   * [DIRMINA-779 ]
> - SSLHandler can re-order data that it reads
>   * [DIRMINA-782 ]
> - Combination of SslFilter & FileRegionWriteFilter causes
> messageSent events to be lost
>   * [DIRMINA-784 ]
> - Error with MDCInjectionFilter on Windows
> 
> 
>   Improvement
> 
>   * [DIRMINA-593 ]
> - Javadoc & documentation for org/apache/mina/filter/reqres
>   * [DIRMINA-682 ]
> - We need a better documentation for the ExecutorFilter [was
> :Writing more than one message will block until the
> MessageReceived as been fully proceced]
>   * [DIRMINA-707 ]
> - Add sendfile support to APR transport
>   * [DIRMINA-751 ]
> - IoBuffer.normalizeCapacity improvement
>   * [DIRMINA-754 ]
> - Javadoc omission in IoFilterChain#fireMessageSent()
>   * [DIRMINA-761 ]
> - how to shutdown a mina application
>   * [DIRMINA-780 ]
> - Writing null objects to the Session should rais

[jira] Closed: (FTPSERVER-387) Disabling a user appears to have no effect

2010-09-20 Thread Niklas Gustavsson (JIRA) 

 [ 
https://issues.apache.org/jira/browse/FTPSERVER-387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Niklas Gustavsson closed FTPSERVER-387.
---

 Assignee: Niklas Gustavsson
Fix Version/s: 1.1.0
   Resolution: Fixed

Fixed in rev 998964, thanks for reporting!

> Disabling a user appears to have no effect
> --
>
> Key: FTPSERVER-387
> URL: https://issues.apache.org/jira/browse/FTPSERVER-387
> Project: FtpServer
>  Issue Type: Bug
>  Components: Server
>Affects Versions: 1.0.4
> Environment: WinXP
>Reporter: Chris Birchall
>Assignee: Niklas Gustavsson
> Fix For: 1.0.5, 1.1.0
>
>
> Using PropertiesUserManager, setting a user's "enableflag" to false does not 
> prevent the user from logging in, downloading files, etc.
> Here is the users.properties file:
> ===
> # Password is "admin"
> ftpserver.user.admin.userpassword=21232F297A57A5A743894A0E4A801FC3
> ftpserver.user.admin.homedirectory=./res/home
> ftpserver.user.admin.enableflag=true
> ftpserver.user.admin.writepermission=true
> ftpserver.user.admin.maxloginnumber=0
> ftpserver.user.admin.maxloginperip=0
> ftpserver.user.admin.idletime=0
> ftpserver.user.admin.uploadrate=0
> ftpserver.user.admin.downloadrate=0
> ftpserver.user.anonymous.userpassword=
> ftpserver.user.anonymous.homedirectory=./res/home
> ftpserver.user.anonymous.enableflag=true
> ftpserver.user.anonymous.writepermission=false
> ftpserver.user.anonymous.maxloginnumber=20
> ftpserver.user.anonymous.maxloginperip=2
> ftpserver.user.anonymous.idletime=300
> ftpserver.user.anonymous.uploadrate=4800
> ftpserver.user.anonymous.downloadrate=4800
> # Password is "admin"
> ftpserver.user.chris.userpassword=21232F297A57A5A743894A0E4A801FC3
> ftpserver.user.chris.homedirectory=./res/home
> ftpserver.user.chris.enableflag=false
> ftpserver.user.chris.writepermission=false
> ftpserver.user.chris.maxloginnumber=20
> ftpserver.user.chris.maxloginperip=2
> ftpserver.user.chris.idletime=300
> ftpserver.user.chris.uploadrate=4800
> ftpserver.user.chris.downloadrate=4800
> =
> User 'chris' can successfully login and download a file, even though he is 
> disabled.
> The DESCUSER command shows the user as disabled:
> ===
> コマンド: SITE DESCUSER chris
> 応答:   200-
> 応答:   userid  : chris
> 応答:   userpassword: 
> 応答:   homedirectory   : ./res/home
> 応答:   writepermission : false
> 応答:   enableflag  : false
> 応答:   idletime: 300
> 応答:   uploadrate  : 0
> 応答:   200 downloadrate: 0
> ===
> I did a quick check of the source, and the only place I could find a check of 
>  org.apache.ftpserver.ftplet.User#getEnabled() was in the SITE_DESCUSER 
> class. So it appears that at login time a user's enabled/disabled status is 
> never checked. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (FTPSERVER-387) Disabling a user appears to have no effect

2010-09-20 Thread Niklas Gustavsson (JIRA) 

 [ 
https://issues.apache.org/jira/browse/FTPSERVER-387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Niklas Gustavsson updated FTPSERVER-387:


Fix Version/s: 1.0.5

> Disabling a user appears to have no effect
> --
>
> Key: FTPSERVER-387
> URL: https://issues.apache.org/jira/browse/FTPSERVER-387
> Project: FtpServer
>  Issue Type: Bug
>  Components: Server
>Affects Versions: 1.0.4
> Environment: WinXP
>Reporter: Chris Birchall
> Fix For: 1.0.5
>
>
> Using PropertiesUserManager, setting a user's "enableflag" to false does not 
> prevent the user from logging in, downloading files, etc.
> Here is the users.properties file:
> ===
> # Password is "admin"
> ftpserver.user.admin.userpassword=21232F297A57A5A743894A0E4A801FC3
> ftpserver.user.admin.homedirectory=./res/home
> ftpserver.user.admin.enableflag=true
> ftpserver.user.admin.writepermission=true
> ftpserver.user.admin.maxloginnumber=0
> ftpserver.user.admin.maxloginperip=0
> ftpserver.user.admin.idletime=0
> ftpserver.user.admin.uploadrate=0
> ftpserver.user.admin.downloadrate=0
> ftpserver.user.anonymous.userpassword=
> ftpserver.user.anonymous.homedirectory=./res/home
> ftpserver.user.anonymous.enableflag=true
> ftpserver.user.anonymous.writepermission=false
> ftpserver.user.anonymous.maxloginnumber=20
> ftpserver.user.anonymous.maxloginperip=2
> ftpserver.user.anonymous.idletime=300
> ftpserver.user.anonymous.uploadrate=4800
> ftpserver.user.anonymous.downloadrate=4800
> # Password is "admin"
> ftpserver.user.chris.userpassword=21232F297A57A5A743894A0E4A801FC3
> ftpserver.user.chris.homedirectory=./res/home
> ftpserver.user.chris.enableflag=false
> ftpserver.user.chris.writepermission=false
> ftpserver.user.chris.maxloginnumber=20
> ftpserver.user.chris.maxloginperip=2
> ftpserver.user.chris.idletime=300
> ftpserver.user.chris.uploadrate=4800
> ftpserver.user.chris.downloadrate=4800
> =
> User 'chris' can successfully login and download a file, even though he is 
> disabled.
> The DESCUSER command shows the user as disabled:
> ===
> コマンド: SITE DESCUSER chris
> 応答:   200-
> 応答:   userid  : chris
> 応答:   userpassword: 
> 応答:   homedirectory   : ./res/home
> 応答:   writepermission : false
> 応答:   enableflag  : false
> 応答:   idletime: 300
> 応答:   uploadrate  : 0
> 応答:   200 downloadrate: 0
> ===
> I did a quick check of the source, and the only place I could find a check of 
>  org.apache.ftpserver.ftplet.User#getEnabled() was in the SITE_DESCUSER 
> class. So it appears that at login time a user's enabled/disabled status is 
> never checked. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: FtpServer 1.0.5 release planning

2010-09-20 Thread Niklas Gustavsson 
On Mon, Sep 20, 2010 at 1:52 PM, Sai Pullabhotla
 wrote:
> I think it is a major issue, and I recommend including it in the
> patch, if possible. FYI, I've been using this patch in production for
> quite some months now.

After sending my last email, I reviewed the patch again. I think we're
okay with including it.

/niklas

Re: FtpServer 1.0.5 release planning

2010-09-20 Thread Sai Pullabhotla 
I think it is a major issue, and I recommend including it in the
patch, if possible. FYI, I've been using this patch in production for
quite some months now.

On Mon, Sep 20, 2010 at 12:47 AM, Niklas Gustavsson
 wrote:
> On Mon, Sep 20, 2010 at 7:18 AM, Chandraprakash Bhagtani
>  wrote:
>> is FTPSERVER-362 included in this cut?
>
> No, not currently. As noted in the issue, I would prefer to keep that
> to 1.1.0 since it's a pretty significant change and also requires an
> update to the XML schema. If anyone feel strongly about getting this
> into 1.0.5, please speak up and let's review the patch further.
>
> /niklas
>

Re: [VOTE] MINA 2.0.0 take 2

2010-09-20 Thread Emmanuel Lecharny 



Good
job Emmanuel, thanks for struggling with this release and all that it
entailed.


+1 for fighting all mavens, Emmanuel! Thanks a lot!
Without Pierre-Arnaud Marcelot (my fellow Directory developer), the 
release wouldn't be on the table...



--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com

Fwd: Re: Possible synchronization issue

2010-09-20 Thread Emmanuel Lecharny 

 --> Users mailing list, not dev mailing list ! Emmanuel, wake up !

 On 9/20/10 8:59 AM, Guy Itzhaki wrote:

 Dear Emmanuel,
 Do you believe you will take a look on this issue today or still struggling 
the release?

I did and sent you a response. Or did I ? Damn, I can't find the mail
from my outbox... wtf ?

Ok, anyway, I'm missing the GetMessageResponse class, so I can't test
your code.

Can you send it to me ?

Thaks ?

--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com

Re: Possible synchronization issue

2010-09-20 Thread Emmanuel Lécharny 

 On 9/20/10 8:59 AM, Guy Itzhaki wrote:

Dear Emmanuel,
Do you believe you will take a look on this issue today or still struggling the 
release?
I did and sent you a response. Or did I ? Damn, I can't find the mail 
from my outbox... wtf ?


Ok, anyway, I'm missing the GetMessageResponse class, so I can't test 
your code.


Can you send it to me ?

Thaks ?

--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com

Re: [VOTE] MINA 2.0.0 take 2

2010-09-20 Thread Maarten Bosteels 
I did a quick smoke-test : created a maven quickstart with a simple client +
server using the maven repo 
https://repository.apache.org/content/repositories/orgapachemina-040
Seems fine. Thanks Emmanuel !

+1

One question though :  the distribution on [1] contains sources but no
binaries ?

Maarten

[1]
https://repository.apache.org/content/repositories/orgapachemina-040/org/apache/mina/mina-parent/2.0.0/



2010/9/19 Bernd Fondermann 

> On 19.09.10 15:26, Alex Karasulu wrote:
>
>> I don't have the ability to validate the release so I'll just +0 here.
>>
>
> +0 for the release from me, too.
>
>
>  Good
>> job Emmanuel, thanks for struggling with this release and all that it
>> entailed.
>>
>
> +1 for fighting all mavens, Emmanuel! Thanks a lot!
>
>  Bernd
>

Re: FtpServer 1.0.5 release planning

2010-09-20 Thread Chandraprakash Bhagtani 
Hi Niklas,

is FTPSERVER-362 included in this cut?

On Mon, Sep 20, 2010 at 12:27 AM, Niklas Gustavsson wrote:

> Hi
>
> I plan to cut a 1.0.5 release of FtpServer in a few days. We've fixed
> quite a few issues sine 1.0.4 and I think it's time to get it out,
> even if there still are open issues.
>
> So, if you have an issue you really want in 1.0.5 please let us know.
> And of course, helping out will increase the chances of us being able
> to get fixes in.
>
> /niklas
>



-- 
Thanks & Regards,
Chandra Prakash Bhagtani