Re: [VOTE] Release SSHD 0.6.0
On 9/2/11 6:58 PM, sebb wrote: The NOTICE file is wrong. It should start with: Apache MINA SSHD Copyright 2xxx-2011 The Apache Software Foundation This product includes software developed by The Apache Software Foundation (http://www.apache.org/). The rest of the NOTICE file is for *required* notices of software that is included in the release. It should not contain the license text; which should be in the LICENSE file Have a look at the httpd ones for an example. http://svn.apache.org/repos/asf/httpd/httpd/trunk/ These are blockers. Sorry, don't have time to check for AL headers at present. There is no missing AL. I ran mvn rat:check, all is ok. I agree with the LICENSE.txt file : slf4j is missing. The MINA NOTICE.txt contains all what is needed, it can be a good start for the sshd licences file. Regarding the staging repo, I must admit I don't understand why we have a org/apache/sshd/apache-sshd/0.6.0/ directory and a org/apache/sshd/sshd/0.6.0/ repository ? Otherwise, the apache-sshd/0.6.0/ apache-sshd-0.6.0-src.tar.gz https://repository.apache.org/content/repositories/orgapachemina-016/org/apache/sshd/apache-sshd/0.6.0/apache-sshd-0.6.0-src.tar.gz file does not reflect the current hierarchy we have on svn, as mentionned by Sebastien. The src subdirectory has been created, and I don't see the rational behind this creation. It's not a blocker for me, but I think this should be fixed. I'd like to see the NOTICE.txt file fixed before the release can be validated, and this is for me a -1. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com
Re: [VOTE] Release SSHD 0.6.0
Note that I don't have any problems with the way we do things in mina, but fwiw, the core mina library has exactly the same structure: * a binary / source distributions at http://www.apache.org/dist//mina/2.0.4/ this source distribution also contains the code in the src directory * another source distribution http://repo1.maven.org/maven2/org/apache/mina/mina-parent/2.0.4/ Also, that's true for ftpserver. Now, the rationale behind the using a src directory is when users download the binary + source distributions (which is different from building the binary distribution from source). If we take mina for example, we have the following folders when you unzip both distributions: * dist * docs * lib * src If we don't do that, the dist and lib folders would be lost amongst the various mina-xxx subfolders containing the source for the mina modules. Imho, it makes a lot of sense. On Mon, Sep 5, 2011 at 08:34, Emmanuel Lecharny elecha...@gmail.com wrote: On 9/2/11 6:58 PM, sebb wrote: The NOTICE file is wrong. It should start with: Apache MINA SSHD Copyright 2xxx-2011 The Apache Software Foundation This product includes software developed by The Apache Software Foundation (http://www.apache.org/). The rest of the NOTICE file is for *required* notices of software that is included in the release. It should not contain the license text; which should be in the LICENSE file Have a look at the httpd ones for an example. http://svn.apache.org/repos/asf/httpd/httpd/trunk/ These are blockers. Sorry, don't have time to check for AL headers at present. There is no missing AL. I ran mvn rat:check, all is ok. I agree with the LICENSE.txt file : slf4j is missing. The MINA NOTICE.txt contains all what is needed, it can be a good start for the sshd licences file. Regarding the staging repo, I must admit I don't understand why we have a org/apache/sshd/apache-sshd/0.6.0/ directory and a org/apache/sshd/sshd/0.6.0/ repository ? Otherwise, the apache-sshd/0.6.0/ apache-sshd-0.6.0-src.tar.gz https://repository.apache.org/content/repositories/orgapachemina-016/org/apache/sshd/apache-sshd/0.6.0/apache-sshd-0.6.0-src.tar.gz file does not reflect the current hierarchy we have on svn, as mentionned by Sebastien. The src subdirectory has been created, and I don't see the rational behind this creation. It's not a blocker for me, but I think this should be fixed. I'd like to see the NOTICE.txt file fixed before the release can be validated, and this is for me a -1. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com
Re: [VOTE] Release SSHD 0.6.0
Sorry, on the first sentence, I meant I don't have any problems with *changing* the way we do things On Mon, Sep 5, 2011 at 09:56, Guillaume Nodet gno...@gmail.com wrote: Note that I don't have any problems with the way we do things in mina, but fwiw, the core mina library has exactly the same structure: * a binary / source distributions at http://www.apache.org/dist//mina/2.0.4/ this source distribution also contains the code in the src directory * another source distribution http://repo1.maven.org/maven2/org/apache/mina/mina-parent/2.0.4/ Also, that's true for ftpserver. Now, the rationale behind the using a src directory is when users download the binary + source distributions (which is different from building the binary distribution from source). If we take mina for example, we have the following folders when you unzip both distributions: * dist * docs * lib * src If we don't do that, the dist and lib folders would be lost amongst the various mina-xxx subfolders containing the source for the mina modules. Imho, it makes a lot of sense. On Mon, Sep 5, 2011 at 08:34, Emmanuel Lecharny elecha...@gmail.com wrote: On 9/2/11 6:58 PM, sebb wrote: The NOTICE file is wrong. It should start with: Apache MINA SSHD Copyright 2xxx-2011 The Apache Software Foundation This product includes software developed by The Apache Software Foundation (http://www.apache.org/). The rest of the NOTICE file is for *required* notices of software that is included in the release. It should not contain the license text; which should be in the LICENSE file Have a look at the httpd ones for an example. http://svn.apache.org/repos/asf/httpd/httpd/trunk/ These are blockers. Sorry, don't have time to check for AL headers at present. There is no missing AL. I ran mvn rat:check, all is ok. I agree with the LICENSE.txt file : slf4j is missing. The MINA NOTICE.txt contains all what is needed, it can be a good start for the sshd licences file. Regarding the staging repo, I must admit I don't understand why we have a org/apache/sshd/apache-sshd/0.6.0/ directory and a org/apache/sshd/sshd/0.6.0/ repository ? Otherwise, the apache-sshd/0.6.0/ apache-sshd-0.6.0-src.tar.gz https://repository.apache.org/content/repositories/orgapachemina-016/org/apache/sshd/apache-sshd/0.6.0/apache-sshd-0.6.0-src.tar.gz file does not reflect the current hierarchy we have on svn, as mentionned by Sebastien. The src subdirectory has been created, and I don't see the rational behind this creation. It's not a blocker for me, but I think this should be fixed. I'd like to see the NOTICE.txt file fixed before the release can be validated, and this is for me a -1. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com
Re: [VOTE] Release SSHD 0.6.0
On 9/5/11 9:56 AM, Guillaume Nodet wrote: Note that I don't have any problems with the way we do things in mina, but fwiw, the core mina library has exactly the same structure: * a binary / source distributions at http://www.apache.org/dist//mina/2.0.4/ this source distribution also contains the code in the src directory * another source distribution http://repo1.maven.org/maven2/org/apache/mina/mina-parent/2.0.4/ Also, that's true for ftpserver. That's a different thing, IMHO. We gather all the sources in one single place because Maven can't generate this files on the top level project. But the content of this source file is exactly the same as what you will get if you do a svn co from the project's root. For SSHD, you have an extra src subdirectory in the generated targz file. Now, the rationale behind the using a src directory is when users download the binary + source distributions (which is different from building the binary distribution from source). This difference is already visible in the file's name. Why would you provide something different for such a case ? If we take mina for example, we have the following folders when you unzip both distributions: * dist * docs * lib * src If we don't do that, the dist and lib folders would be lost amongst the various mina-xxx subfolders containing the source for the mina modules. Imho, it makes a lot of sense. Hmmm, right. But I think that MINA is not doing the correct thing here. the dist directory should remain, but all the the other directories should be present. Look, right now, I do think the only major thing to fix in the SSHD 0.6.0 release is the NOTICE file. No need to start a new vote I guess, if you just fix it. The drectory layout could be discussed later on, it's not a SSHD pb, it's more a general problem in MINA. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com
Re: [VOTE] Release SSHD 0.6.0
On 5 September 2011 09:14, Emmanuel Lécharny elecha...@apache.org wrote: On 9/5/11 9:56 AM, Guillaume Nodet wrote: Note that I don't have any problems with the way we do things in mina, but fwiw, the core mina library has exactly the same structure: * a binary / source distributions at http://www.apache.org/dist//mina/2.0.4/ this source distribution also contains the code in the src directory * another source distribution http://repo1.maven.org/maven2/org/apache/mina/mina-parent/2.0.4/ Also, that's true for ftpserver. That's a different thing, IMHO. We gather all the sources in one single place because Maven can't generate this files on the top level project. But the content of this source file is exactly the same as what you will get if you do a svn co from the project's root. For SSHD, you have an extra src subdirectory in the generated targz file. Now, the rationale behind the using a src directory is when users download the binary + source distributions (which is different from building the binary distribution from source). This difference is already visible in the file's name. Why would you provide something different for such a case ? If we take mina for example, we have the following folders when you unzip both distributions: * dist * docs * lib * src If we don't do that, the dist and lib folders would be lost amongst the various mina-xxx subfolders containing the source for the mina modules. Imho, it makes a lot of sense. Hmmm, right. But I think that MINA is not doing the correct thing here. the dist directory should remain, but all the the other directories should be present. Look, right now, I do think the only major thing to fix in the SSHD 0.6.0 release is the NOTICE file. No need to start a new vote I guess, if you just fix it. There needs to be a new vote on the release, because the release contents will be different. The LICENSE file also needs changing. The drectory layout could be discussed later on, it's not a SSHD pb, it's more a general problem in MINA. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com
[CANCEL] [VOTE] Release SSHD 0.6.0
I'm cancelling this vote to fix the legal files. On Fri, Sep 2, 2011 at 11:19, Guillaume Nodet gno...@gmail.com wrote: A vote for this long overdue release of SSHD 0.6.0 which contains a bunch of improvements and bug fixes. A number of issues have been fixed: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849version=12315514 The staging repo is available at: https://repository.apache.org/content/repositories/orgapachemina-016/ Please review and vote: [ ] +1 Release SSHD 0.6.0 [ ] -1 Do not -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com
[VOTE] Release Mina SSHD 0.6.0 (2nd try)
2nd try for the release of SSHD 0.6.0. The legal files have been fixed and empty dirs removed, no other changes. A number of issues have been fixed: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849version=12315514 The staging repo is available at: https://repository.apache.org/content/repositories/orgapachemina-024/ Source and binary distributions are available at: https://repository.apache.org/content/repositories/orgapachemina-024/org/apache/sshd/apache-sshd/0.6.0/ The svn tag is: http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.6.0/ Please review and vote: [ ] +1 Release SSHD 0.6.0 [ ] -1 Do not -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com
Re: [VOTE] Release Mina SSHD 0.6.0 (2nd try)
On 5 September 2011 10:39, Guillaume Nodet gno...@gmail.com wrote: 2nd try for the release of SSHD 0.6.0. The legal files have been fixed and empty dirs removed, no other changes. A number of issues have been fixed: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849version=12315514 The staging repo is available at: https://repository.apache.org/content/repositories/orgapachemina-024/ Source and binary distributions are available at: https://repository.apache.org/content/repositories/orgapachemina-024/org/apache/sshd/apache-sshd/0.6.0/ The svn tag is: http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.6.0/ Since the tag was changed, it's necessary to document the revision number for future reference, i.e. Revision 1165238: /mina/sshd/tags/sshd-0.6.0 Please review and vote: [ ] +1 Release SSHD 0.6.0 [ ] -1 Do not -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com
Re: [VOTE] Release Mina SSHD 0.6.0 (2nd try)
Hi, I think the md5sums do not match md5sum apache-sshd-0.6.0-src.zip 1e50358e4aadb855e51f91d0bb95db00 *apache-sshd-0.6.0-src.zip md5sum apache-sshd-0.6.0-src.tar.gz 1bca2f231f455aa8864cd9a5c33125a6 *apache-sshd-0.6.0-src.tar.gz curl -k https://repository.apache.org/content/repositories/orgapachemina-024/org/apache/sshd/apache-sshd/0.6.0/apache-sshd-0.6.0-src.zip.asc.md5 b81cf2175154f183063ff9a11a35b0c1 curl -k https://repository.apache.org/content/repositories/orgapachemina-024/org/apache/sshd/apache-sshd/0.6.0/apache-sshd-0.6.0-src.tar.gz.asc.md5 33c046c17d6a403b71aaf18552c7b8fa WILL On Mon, Sep 5, 2011 at 7:04 AM, sebb seb...@gmail.com wrote: On 5 September 2011 10:39, Guillaume Nodet gno...@gmail.com wrote: 2nd try for the release of SSHD 0.6.0. The legal files have been fixed and empty dirs removed, no other changes. A number of issues have been fixed: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849version=12315514 The staging repo is available at: https://repository.apache.org/content/repositories/orgapachemina-024/ Source and binary distributions are available at: https://repository.apache.org/content/repositories/orgapachemina-024/org/apache/sshd/apache-sshd/0.6.0/ The svn tag is: http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.6.0/ Since the tag was changed, it's necessary to document the revision number for future reference, i.e. Revision 1165238: /mina/sshd/tags/sshd-0.6.0 Please review and vote: [ ] +1 Release SSHD 0.6.0 [ ] -1 Do not -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com
Re: [VOTE] Release Mina SSHD 0.6.0 (2nd try)
Doh, you're right. I wonder if I hit https://issues.sonatype.org/browse/NEXUS-4347 ... I've uploaded a new set of artifacts from the same tag at https://repository.apache.org/content/repositories/orgapachemina-028 It now seems to have correct md5. On Mon, Sep 5, 2011 at 15:37, Will Glass-Husain wglasshus...@gmail.com wrote: Hi, I think the md5sums do not match md5sum apache-sshd-0.6.0-src.zip 1e50358e4aadb855e51f91d0bb95db00 *apache-sshd-0.6.0-src.zip md5sum apache-sshd-0.6.0-src.tar.gz 1bca2f231f455aa8864cd9a5c33125a6 *apache-sshd-0.6.0-src.tar.gz curl -k https://repository.apache.org/content/repositories/orgapachemina-024/org/apache/sshd/apache-sshd/0.6.0/apache-sshd-0.6.0-src.zip.asc.md5 b81cf2175154f183063ff9a11a35b0c1 curl -k https://repository.apache.org/content/repositories/orgapachemina-024/org/apache/sshd/apache-sshd/0.6.0/apache-sshd-0.6.0-src.tar.gz.asc.md5 33c046c17d6a403b71aaf18552c7b8fa WILL On Mon, Sep 5, 2011 at 7:04 AM, sebb seb...@gmail.com wrote: On 5 September 2011 10:39, Guillaume Nodet gno...@gmail.com wrote: 2nd try for the release of SSHD 0.6.0. The legal files have been fixed and empty dirs removed, no other changes. A number of issues have been fixed: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849version=12315514 The staging repo is available at: https://repository.apache.org/content/repositories/orgapachemina-024/ Source and binary distributions are available at: https://repository.apache.org/content/repositories/orgapachemina-024/org/apache/sshd/apache-sshd/0.6.0/ The svn tag is: http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.6.0/ Since the tag was changed, it's necessary to document the revision number for future reference, i.e. Revision 1165238: /mina/sshd/tags/sshd-0.6.0 Please review and vote: [ ] +1 Release SSHD 0.6.0 [ ] -1 Do not -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com
Re: [VOTE] Release Mina SSHD 0.6.0 (2nd try)
On 5 September 2011 14:58, Guillaume Nodet gno...@gmail.com wrote: Doh, you're right. I wonder if I hit https://issues.sonatype.org/browse/NEXUS-4347 ... I've uploaded a new set of artifacts from the same tag at https://repository.apache.org/content/repositories/orgapachemina-028 It now seems to have correct md5. Perhaps the original -024 upload should be deleted now to avoid possible confusion when checking the release? On Mon, Sep 5, 2011 at 15:37, Will Glass-Husain wglasshus...@gmail.com wrote: Hi, I think the md5sums do not match md5sum apache-sshd-0.6.0-src.zip 1e50358e4aadb855e51f91d0bb95db00 *apache-sshd-0.6.0-src.zip md5sum apache-sshd-0.6.0-src.tar.gz 1bca2f231f455aa8864cd9a5c33125a6 *apache-sshd-0.6.0-src.tar.gz curl -k https://repository.apache.org/content/repositories/orgapachemina-024/org/apache/sshd/apache-sshd/0.6.0/apache-sshd-0.6.0-src.zip.asc.md5 b81cf2175154f183063ff9a11a35b0c1 curl -k https://repository.apache.org/content/repositories/orgapachemina-024/org/apache/sshd/apache-sshd/0.6.0/apache-sshd-0.6.0-src.tar.gz.asc.md5 33c046c17d6a403b71aaf18552c7b8fa WILL On Mon, Sep 5, 2011 at 7:04 AM, sebb seb...@gmail.com wrote: On 5 September 2011 10:39, Guillaume Nodet gno...@gmail.com wrote: 2nd try for the release of SSHD 0.6.0. The legal files have been fixed and empty dirs removed, no other changes. A number of issues have been fixed: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849version=12315514 The staging repo is available at: https://repository.apache.org/content/repositories/orgapachemina-024/ Source and binary distributions are available at: https://repository.apache.org/content/repositories/orgapachemina-024/org/apache/sshd/apache-sshd/0.6.0/ The svn tag is: http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.6.0/ Since the tag was changed, it's necessary to document the revision number for future reference, i.e. Revision 1165238: /mina/sshd/tags/sshd-0.6.0 Please review and vote: [ ] +1 Release SSHD 0.6.0 [ ] -1 Do not -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com
Re: [VOTE] Release Mina SSHD 0.6.0 (2nd try)
Done. On Mon, Sep 5, 2011 at 16:04, sebb seb...@gmail.com wrote: On 5 September 2011 14:58, Guillaume Nodet gno...@gmail.com wrote: Doh, you're right. I wonder if I hit https://issues.sonatype.org/browse/NEXUS-4347 ... I've uploaded a new set of artifacts from the same tag at https://repository.apache.org/content/repositories/orgapachemina-028 It now seems to have correct md5. Perhaps the original -024 upload should be deleted now to avoid possible confusion when checking the release? On Mon, Sep 5, 2011 at 15:37, Will Glass-Husain wglasshus...@gmail.com wrote: Hi, I think the md5sums do not match md5sum apache-sshd-0.6.0-src.zip 1e50358e4aadb855e51f91d0bb95db00 *apache-sshd-0.6.0-src.zip md5sum apache-sshd-0.6.0-src.tar.gz 1bca2f231f455aa8864cd9a5c33125a6 *apache-sshd-0.6.0-src.tar.gz curl -k https://repository.apache.org/content/repositories/orgapachemina-024/org/apache/sshd/apache-sshd/0.6.0/apache-sshd-0.6.0-src.zip.asc.md5 b81cf2175154f183063ff9a11a35b0c1 curl -k https://repository.apache.org/content/repositories/orgapachemina-024/org/apache/sshd/apache-sshd/0.6.0/apache-sshd-0.6.0-src.tar.gz.asc.md5 33c046c17d6a403b71aaf18552c7b8fa WILL On Mon, Sep 5, 2011 at 7:04 AM, sebb seb...@gmail.com wrote: On 5 September 2011 10:39, Guillaume Nodet gno...@gmail.com wrote: 2nd try for the release of SSHD 0.6.0. The legal files have been fixed and empty dirs removed, no other changes. A number of issues have been fixed: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849version=12315514 The staging repo is available at: https://repository.apache.org/content/repositories/orgapachemina-024/ Source and binary distributions are available at: https://repository.apache.org/content/repositories/orgapachemina-024/org/apache/sshd/apache-sshd/0.6.0/ The svn tag is: http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.6.0/ Since the tag was changed, it's necessary to document the revision number for future reference, i.e. Revision 1165238: /mina/sshd/tags/sshd-0.6.0 Please review and vote: [ ] +1 Release SSHD 0.6.0 [ ] -1 Do not -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com
[jira] [Created] (SSHD-143) Missing SVN EOL properties
Missing SVN EOL properties -- Key: SSHD-143 URL: https://issues.apache.org/jira/browse/SSHD-143 Project: MINA SSHD Issue Type: Bug Reporter: Sebb Missing or incorrect SVN eol-style properties - see patch to follow -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SSHD-143) Missing SVN EOL properties
[ https://issues.apache.org/jira/browse/SSHD-143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated SSHD-143: -- Attachment: sshd-0.6.0.sh Missing SVN EOL properties -- Key: SSHD-143 URL: https://issues.apache.org/jira/browse/SSHD-143 Project: MINA SSHD Issue Type: Bug Reporter: Sebb Attachments: sshd-0.6.0.sh Missing or incorrect SVN eol-style properties - see patch to follow -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [VOTE] Release Mina SSHD 0.6.0 (2nd try)
On 5 September 2011 10:39, Guillaume Nodet gno...@gmail.com wrote: 2nd try for the release of SSHD 0.6.0. The legal files have been fixed and empty dirs removed, no other changes. A number of issues have been fixed: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849version=12315514 The staging repo is available at: https://repository.apache.org/content/repositories/orgapachemina-024/ I checked https://repository.apache.org/content/repositories/orgapachemina-028/ Source and binary distributions are available at: https://repository.apache.org/content/repositories/orgapachemina-024/org/apache/sshd/apache-sshd/0.6.0/ I checked: https://repository.apache.org/content/repositories/orgapachemina-028/org/apache/sshd/apache-sshd/0.6.0/ It's very confusing to have two source archives. I suggest you delete sshd-0.6.0-source-release.zip from the release, i.e. delete https://repository.apache.org/content/repositories/orgapachemina-028/org/apache/sshd/sshd/ The binary archive content is a bit odd as well. Why include slf4j but not JCraft? They both have test scope, as far as I can tell. Also, why include bouncy castle and tomcat but not jcraft/jzlib (all optional)? Why not include net.sj.jpam, which is required by sshd-pam? The svn tag is: http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.6.0/ Lots of missing SVN eol-style settings. See https://issues.apache.org/jira/browse/SSHD-143 Not a blocker. No AL header in the file: sshd-core/src/main/java/org/apache/sshd/server/HandshakingUserAuth.java Please review and vote: [ ] +1 Release SSHD 0.6.0 [X] -1 Do not -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com
[CANCEL] [VOTE] Release Mina SSHD 0.6.0 (2nd try)
Cancelling this vote due to the missing AL header. On the optional dependecies, slf4j-api is actually mandatory. Also slf4j requires one implementation at runtime, so we include slf4j-simple (though we use slf4j-log4j in the tests). Bouncycastle and apr are included, because even if they are optional, they do provide some important features. For jpam, I don't think anyone is really using the pam module, so I'm not sure why we'd have to include the dependency. And if you ask why it is included, iirc it's because some people found odd that one artifact was not included in the binary distribution I think. On Mon, Sep 5, 2011 at 16:41, sebb seb...@gmail.com wrote: On 5 September 2011 10:39, Guillaume Nodet gno...@gmail.com wrote: 2nd try for the release of SSHD 0.6.0. The legal files have been fixed and empty dirs removed, no other changes. A number of issues have been fixed: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849version=12315514 The staging repo is available at: https://repository.apache.org/content/repositories/orgapachemina-024/ I checked https://repository.apache.org/content/repositories/orgapachemina-028/ Source and binary distributions are available at: https://repository.apache.org/content/repositories/orgapachemina-024/org/apache/sshd/apache-sshd/0.6.0/ I checked: https://repository.apache.org/content/repositories/orgapachemina-028/org/apache/sshd/apache-sshd/0.6.0/ It's very confusing to have two source archives. I suggest you delete sshd-0.6.0-source-release.zip from the release, i.e. delete https://repository.apache.org/content/repositories/orgapachemina-028/org/apache/sshd/sshd/ The binary archive content is a bit odd as well. Why include slf4j but not JCraft? They both have test scope, as far as I can tell. Also, why include bouncy castle and tomcat but not jcraft/jzlib (all optional)? Why not include net.sj.jpam, which is required by sshd-pam? The svn tag is: http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.6.0/ Lots of missing SVN eol-style settings. See https://issues.apache.org/jira/browse/SSHD-143 Not a blocker. No AL header in the file: sshd-core/src/main/java/org/apache/sshd/server/HandshakingUserAuth.java Please review and vote: [ ] +1 Release SSHD 0.6.0 [X] -1 Do not -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com
Re: [CANCEL] [VOTE] Release Mina SSHD 0.6.0 (2nd try)
On 5 September 2011 16:23, Guillaume Nodet gno...@gmail.com wrote: Cancelling this vote due to the missing AL header. On the optional dependecies, slf4j-api is actually mandatory. Also So is that a bug in the POM? slf4j requires one implementation at runtime, so we include slf4j-simple (though we use slf4j-log4j in the tests). Bouncycastle and apr are included, because even if they are optional, they do provide some important features. For jpam, I don't think anyone is really using the pam module, so I'm not sure why we'd have to include the dependency. And if you ask why it is included, iirc it's because some people found odd that one artifact was not included in the binary distribution I think. On Mon, Sep 5, 2011 at 16:41, sebb seb...@gmail.com wrote: On 5 September 2011 10:39, Guillaume Nodet gno...@gmail.com wrote: 2nd try for the release of SSHD 0.6.0. The legal files have been fixed and empty dirs removed, no other changes. A number of issues have been fixed: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849version=12315514 The staging repo is available at: https://repository.apache.org/content/repositories/orgapachemina-024/ I checked https://repository.apache.org/content/repositories/orgapachemina-028/ Source and binary distributions are available at: https://repository.apache.org/content/repositories/orgapachemina-024/org/apache/sshd/apache-sshd/0.6.0/ I checked: https://repository.apache.org/content/repositories/orgapachemina-028/org/apache/sshd/apache-sshd/0.6.0/ It's very confusing to have two source archives. I suggest you delete sshd-0.6.0-source-release.zip from the release, i.e. delete https://repository.apache.org/content/repositories/orgapachemina-028/org/apache/sshd/sshd/ The binary archive content is a bit odd as well. Why include slf4j but not JCraft? They both have test scope, as far as I can tell. Also, why include bouncy castle and tomcat but not jcraft/jzlib (all optional)? Why not include net.sj.jpam, which is required by sshd-pam? The svn tag is: http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.6.0/ Lots of missing SVN eol-style settings. See https://issues.apache.org/jira/browse/SSHD-143 Not a blocker. No AL header in the file: sshd-core/src/main/java/org/apache/sshd/server/HandshakingUserAuth.java Please review and vote: [ ] +1 Release SSHD 0.6.0 [X] -1 Do not -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com
Re: [CANCEL] [VOTE] Release Mina SSHD 0.6.0 (2nd try)
No, slf4j-api is mandatory as a a transitive dependency of mina-core while slf4j-log4j is flagged as test. On Mon, Sep 5, 2011 at 17:35, sebb seb...@gmail.com wrote: On 5 September 2011 16:23, Guillaume Nodet gno...@gmail.com wrote: Cancelling this vote due to the missing AL header. On the optional dependecies, slf4j-api is actually mandatory. Also So is that a bug in the POM? slf4j requires one implementation at runtime, so we include slf4j-simple (though we use slf4j-log4j in the tests). Bouncycastle and apr are included, because even if they are optional, they do provide some important features. For jpam, I don't think anyone is really using the pam module, so I'm not sure why we'd have to include the dependency. And if you ask why it is included, iirc it's because some people found odd that one artifact was not included in the binary distribution I think. On Mon, Sep 5, 2011 at 16:41, sebb seb...@gmail.com wrote: On 5 September 2011 10:39, Guillaume Nodet gno...@gmail.com wrote: 2nd try for the release of SSHD 0.6.0. The legal files have been fixed and empty dirs removed, no other changes. A number of issues have been fixed: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849version=12315514 The staging repo is available at: https://repository.apache.org/content/repositories/orgapachemina-024/ I checked https://repository.apache.org/content/repositories/orgapachemina-028/ Source and binary distributions are available at: https://repository.apache.org/content/repositories/orgapachemina-024/org/apache/sshd/apache-sshd/0.6.0/ I checked: https://repository.apache.org/content/repositories/orgapachemina-028/org/apache/sshd/apache-sshd/0.6.0/ It's very confusing to have two source archives. I suggest you delete sshd-0.6.0-source-release.zip from the release, i.e. delete https://repository.apache.org/content/repositories/orgapachemina-028/org/apache/sshd/sshd/ The binary archive content is a bit odd as well. Why include slf4j but not JCraft? They both have test scope, as far as I can tell. Also, why include bouncy castle and tomcat but not jcraft/jzlib (all optional)? Why not include net.sj.jpam, which is required by sshd-pam? The svn tag is: http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.6.0/ Lots of missing SVN eol-style settings. See https://issues.apache.org/jira/browse/SSHD-143 Not a blocker. No AL header in the file: sshd-core/src/main/java/org/apache/sshd/server/HandshakingUserAuth.java Please review and vote: [ ] +1 Release SSHD 0.6.0 [X] -1 Do not -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com
[VOTE] Release Mina SSHD 0.6.0 (3rd try)
3nd try for the release of SSHD 0.6.0. I've fixed the missing header and removed the duplicate source distribution from the staging repo. A number of issues have been fixed: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849version=12315514 The staging repo is available at: https://repository.apache.org/content/repositories/orgapachemina-030/ Source and binary distributions are available at: https://repository.apache.org/content/repositories/orgapachemina-030/org/apache/sshd/apache-sshd/0.6.0/ The svn tag is: http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.6.0/ at revision 1165357 http://svn.apache.org/viewvc?view=revisionrevision=1165357 Please review and vote: [ ] +1 Release SSHD 0.6.0 [ ] -1 Do not -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com
Re: [VOTE] Release Mina SSHD 0.6.0 (3rd try)
+1 Jeff On Sep 5, 2011, at 11:03 AM, Guillaume Nodet wrote: 3nd try for the release of SSHD 0.6.0. I've fixed the missing header and removed the duplicate source distribution from the staging repo. A number of issues have been fixed: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849version=12315514 The staging repo is available at: https://repository.apache.org/content/repositories/orgapachemina-030/ Source and binary distributions are available at: https://repository.apache.org/content/repositories/orgapachemina-030/org/apache/sshd/apache-sshd/0.6.0/ The svn tag is: http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.6.0/ at revision 1165357 http://svn.apache.org/viewvc?view=revisionrevision=1165357 Please review and vote: [ ] +1 Release SSHD 0.6.0 [ ] -1 Do not -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com
Re: [VOTE] Release Mina SSHD 0.6.0 (3rd try)
Hi Guillaume, -1 from me. When I run mvn clean package from the zipped source package, I get a failed test, specifically org.apache.sshd.SftpTest.testReadWriteWithOffset --- Test set: org.apache.sshd.SftpTest --- Tests run: 3, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 0.352 sec FAILURE! testReadWriteWithOffset(org.apache.sshd.SftpTest) Time elapsed: 0.124 sec FAILURE! java.lang.AssertionError: at org.junit.Assert.fail(Assert.java:74) at org.junit.Assert.assertTrue(Assert.java:37) at org.junit.Assert.assertTrue(Assert.java:46) at org.apache.sshd.SftpTest.testReadWriteWithOffset(SftpTest.java:158) Running on Win 7, Java 6, Maven 2.2.1 Other stuff I checked that worked - tars and zips matched - md5s matched. Happy to be part of this process-- don't mind rechecking again later. WILL P.S. On Mon, Sep 5, 2011 at 1:28 PM, Jeff Genender jgenen...@apache.org wrote: +1 Jeff On Sep 5, 2011, at 11:03 AM, Guillaume Nodet wrote: 3nd try for the release of SSHD 0.6.0. I've fixed the missing header and removed the duplicate source distribution from the staging repo. A number of issues have been fixed: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849version=12315514 The staging repo is available at: https://repository.apache.org/content/repositories/orgapachemina-030/ Source and binary distributions are available at: https://repository.apache.org/content/repositories/orgapachemina-030/org/apache/sshd/apache-sshd/0.6.0/ The svn tag is: http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.6.0/ at revision 1165357 http://svn.apache.org/viewvc?view=revisionrevision=1165357 Please review and vote: [ ] +1 Release SSHD 0.6.0 [ ] -1 Do not -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ Open Source SOA http://fusesource.com
