[jira] [Commented] (SSHD-1091) Java Module support

[Lyor Goldstein (Jira)]

[ 
https://issues.apache.org/jira/browse/SSHD-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235220#comment-17235220
 ] 

Lyor Goldstein commented on SSHD-1091:
--

I think we all agree that we need to look more closely at the packages and find 
a way to split them in a logical manner. I also agree that the names _common_ 
and _core_ should be changed (they are historical choices). Perhaps even split 
_common_ into other related sub-domains - e.g.,
 * generic utilities - I/O streams, threads, strings, maps, collections, 
property resolvers, validations, etc, not 100% related to SSH,
 * SSH files utilities - PEM(s), _authorized_keys_, _known_hosts_, 
_ssh_config_, PUTTY, PGP, etc,
 * SSH "support" classes - e.g. ciphers, MACs, KEXs, digests, etc.
 * SSH core - session, channel, factory manager, etc
 * client
 * server
 * etc.

And yes - we should decide on a naming that best reflects each module's core 
functionality.

On a related note - we might need to use some tests module that depends on all 
the rest for running all the tests that require both a client and a server 
(which obviously cannot reside in neither the client nor the server module). So 
basically we would get a dependency tree that looks something like this
{noformat}
+- generic
+- files
 +- SSH support
  +- core
  +- client
  \
   \
  tests
   /
  /
 + - server
{noformat}

> Java Module support
> ---
>
> Key: SSHD-1091
> URL: https://issues.apache.org/jira/browse/SSHD-1091
> Project: MINA SSHD
>  Issue Type: Improvement
>Affects Versions: 2.5.1
>Reporter: Gili
>Priority: Major
>  Labels: important
>
> Please use the mechanism found at 
> https://github.com/apache/maven-compiler-plugin/blob/master/src/it/multirelease-patterns/singleproject-runtime/pom.xml#L102-L108
>  to build multirelease JAR that will provide module-info.java for users of 
> Java 9 and newer.
> The current JAR triggers many problems for users of Java Modules and in fact 
> cannot be used at all in its current state due to 
> https://issues.apache.org/jira/browse/MCOMPILER-436
> This might be a bug in the Maven Compiler plugin but I suspect that 
> ultimately it will a problem with the library itself. For example, I noticed 
> that Apache Mina (which this library depends on) has split packages. Split 
> packages are incompatible with Java Modules.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

[jira] [Commented] (SSHD-1091) Java Module support

[Gili (Jira)]

[ 
https://issues.apache.org/jira/browse/SSHD-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234769#comment-17234769
 ] 

Gili commented on SSHD-1091:


[~gnodet] correct, that's what I meant. So, can you please explain what kind of 
things sshd-runtime would contain that sshd-common would not and why the two 
cannot go into the same module?

> Java Module support
> ---
>
> Key: SSHD-1091
> URL: https://issues.apache.org/jira/browse/SSHD-1091
> Project: MINA SSHD
>  Issue Type: Improvement
>Affects Versions: 2.5.1
>Reporter: Gili
>Priority: Major
>  Labels: important
>
> Please use the mechanism found at 
> https://github.com/apache/maven-compiler-plugin/blob/master/src/it/multirelease-patterns/singleproject-runtime/pom.xml#L102-L108
>  to build multirelease JAR that will provide module-info.java for users of 
> Java 9 and newer.
> The current JAR triggers many problems for users of Java Modules and in fact 
> cannot be used at all in its current state due to 
> https://issues.apache.org/jira/browse/MCOMPILER-436
> This might be a bug in the Maven Compiler plugin but I suspect that 
> ultimately it will a problem with the library itself. For example, I noticed 
> that Apache Mina (which this library depends on) has split packages. Split 
> packages are incompatible with Java Modules.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

[GitHub] [mina] kc7bfi commented on pull request #28: 2.1.x

[GitBox]

kc7bfi commented on pull request #28:
URL: https://github.com/apache/mina/pull/28#issuecomment-729714497


   Any idea when this pull request might be accepted into the mina code base?
   
   David R Robison
   Senior Systems Engineer
   [cid:image001.png@01D6BD8D.119EB360]
   
   From: Emmanuel Lécharny 
   Sent: Thursday, September 24, 2020 10:08 AM
   To: apache/mina 
   Cc: David Robison ; Author 

   Subject: Re: [apache/mina] 2.1.x (#28)
   
   
   Thanks, David !
   
   We are reviewing the patch. Most of the time, it's not doing anything unless 
you are using cached buffers. I assume this is teh case for you, then the 
buffer aren't getting cached if they aren't freed.
   
   —
   You are receiving this because you authored the thread.
   Reply to this email directly, view it on 
GitHub, or 
unsubscribe.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

[jira] [Commented] (SSHD-981) Implement no-flow-control SFTP extension

[Markus Spann (Jira)]

[ 
https://issues.apache.org/jira/browse/SSHD-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234457#comment-17234457
 ] 

Markus Spann commented on SSHD-981:
---

Guillaume and Lyor, thank you both! (y)

> Implement no-flow-control SFTP extension
> 
>
> Key: SSHD-981
> URL: https://issues.apache.org/jira/browse/SSHD-981
> Project: MINA SSHD
>  Issue Type: Improvement
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 2.7.0
>
>
> This extension has been specified by [https://tools.ietf.org/html/rfc8308]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org