[
https://issues.apache.org/jira/browse/SSHD-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235220#comment-17235220
]
Lyor Goldstein commented on SSHD-1091:
--------------------------------------
I think we all agree that we need to look more closely at the packages and find
a way to split them in a logical manner. I also agree that the names _common_
and _core_ should be changed (they are historical choices). Perhaps even split
_common_ into other related sub-domains - e.g.,
* generic utilities - I/O streams, threads, strings, maps, collections,
property resolvers, validations, etc, not 100% related to SSH,
* SSH files utilities - PEM(s), _authorized_keys_, _known_hosts_,
_ssh_config_, PUTTY, PGP, etc,
* SSH "support" classes - e.g. ciphers, MACs, KEXs, digests, etc.
* SSH core - session, channel, factory manager, etc
* client
* server
* etc.
And yes - we should decide on a naming that best reflects each module's core
functionality.
On a related note - we might need to use some tests module that depends on all
the rest for running all the tests that require both a client and a server
(which obviously cannot reside in neither the client nor the server module). So
basically we would get a dependency tree that looks something like this
{noformat}
+- generic
+- files
+- SSH support
+- core
+- client
\
\
tests
/
/
+ - server
{noformat}
> Java Module support
> -------------------
>
> Key: SSHD-1091
> URL: https://issues.apache.org/jira/browse/SSHD-1091
> Project: MINA SSHD
> Issue Type: Improvement
> Affects Versions: 2.5.1
> Reporter: Gili
> Priority: Major
> Labels: important
>
> Please use the mechanism found at
> https://github.com/apache/maven-compiler-plugin/blob/master/src/it/multirelease-patterns/singleproject-runtime/pom.xml#L102-L108
> to build multirelease JAR that will provide module-info.java for users of
> Java 9 and newer.
> The current JAR triggers many problems for users of Java Modules and in fact
> cannot be used at all in its current state due to
> https://issues.apache.org/jira/browse/MCOMPILER-436
> This might be a bug in the Maven Compiler plugin but I suspect that
> ultimately it will a problem with the library itself. For example, I noticed
> that Apache Mina (which this library depends on) has split packages. Split
> packages are incompatible with Java Modules.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
