Re: Moving 2.2.X to 4.0.X

[Jonathan Valliere]

Yes, I agree.

On Sat, Jan 22, 2022 at 3:24 PM Emmanuel Lécharny 
wrote:

> Hi Jonathan,
>
> yes I think this is the right move.
>
> The current 2.2.X shoulld move to a 4.0.X branch, to become an offical 4.0.
>
> I also think that there is no reason to move with faster major versions
> (à la Chrome or FF)
>
> In any case, we will keep the 2.0 and 2.1 branches alive for a bit of time.
>
> Also note that it may make sense to support Java 11+ only for 4.0.
>
> wdyt ?
>
> On 22/01/2022 17:05, Jonathan Valliere wrote:
> > Hello friends,
> >
> > After some discussion, the breaking changes in the current 2.2.X branch
> > necessitates moving to a new major version.  One would expect a move to
> > 3.0 however, a 3.0 branch and tags were created many years ago for an
> > abandoned effort to re-engineer the entirety of MINA.  The prospect of
> > this is not lost but for the time being that old work is now defunct.
> > Long story short, 2.2.X is moving to 4.0.X.
> >
> > Thank you for your patience.  Some new Quality of Life changes are
> > coming soon as well as an official 4.0 release.
> >
> > Cheers,
> > JV
>
> --
> *Emmanuel Lécharny - CTO* 205 Promenad
> e
> des Anglais – 06200 NICE
> T. +33 (0)4 89 97 36 50
> P. +33 (0)6 08 33 32 61
> emmanuel.lecha...@busit.com https://www.busit.com/
>

Re: Moving 2.2.X to 4.0.X

[Emmanuel Lécharny]

Hi Jonathan,

yes I think this is the right move.

The current 2.2.X shoulld move to a 4.0.X branch, to become an offical 4.0.

I also think that there is no reason to move with faster major versions 
(à la Chrome or FF)


In any case, we will keep the 2.0 and 2.1 branches alive for a bit of time.

Also note that it may make sense to support Java 11+ only for 4.0.

wdyt ?

On 22/01/2022 17:05, Jonathan Valliere wrote:

Hello friends,

After some discussion, the breaking changes in the current 2.2.X branch 
necessitates moving to a new major version.  One would expect a move to 
3.0 however, a 3.0 branch and tags were created many years ago for an 
abandoned effort to re-engineer the entirety of MINA.  The prospect of 
this is not lost but for the time being that old work is now defunct.  
Long story short, 2.2.X is moving to 4.0.X.


Thank you for your patience.  Some new Quality of Life changes are 
coming soon as well as an official 4.0 release.


Cheers,
JV


--
*Emmanuel Lécharny - CTO* 205 Promenade des Anglais – 06200 NICE
T. +33 (0)4 89 97 36 50
P. +33 (0)6 08 33 32 61
emmanuel.lecha...@busit.com https://www.busit.com/

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

Moving 2.2.X to 4.0.X

[Jonathan Valliere]

Hello friends,

After some discussion, the breaking changes in the current 2.2.X branch
necessitates moving to a new major version.  One would expect a move to 3.0
however, a 3.0 branch and tags were created many years ago for an abandoned
effort to re-engineer the entirety of MINA.  The prospect of this is not
lost but for the time being that old work is now defunct.  Long story
short, 2.2.X is moving to 4.0.X.

Thank you for your patience.  Some new Quality of Life changes are coming
soon as well as an official 4.0 release.

Cheers,
JV

[jira] [Commented] (DIRMINA-1157) Sporadic error when establishing a StartTLS or SSL connection

[Jonathan Valliere (Jira)]

[ 
https://issues.apache.org/jira/browse/DIRMINA-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480470#comment-17480470
 ] 

Jonathan Valliere commented on DIRMINA-1157:


I'm starting to think this should be just 3.0 but if we're going to break 
things might as well break some other things for some overall QOL improvements.

> Sporadic error when establishing a StartTLS or SSL connection
> -
>
> Key: DIRMINA-1157
> URL: https://issues.apache.org/jira/browse/DIRMINA-1157
> Project: MINA
>  Issue Type: Bug
>  Components: Core, SSL
>Affects Versions: 2.1.5
>Reporter: Steffen Liersch
>Priority: Blocker
>  Labels: security
> Attachments: SslHandler-compare.png, SslHandler-mod.java, 
> SslHandler.java
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> With the Mina components, a connection error occasionally occurs when 
> establishing a StartTLS or TLS connection. The cause is that payload data was 
> received immediately on the acknowledgement and is already in the receive 
> buffer.
> My colleagues have changed the checkStatus function of the SslHandler class 
> from apache-mina-2.1.5-src.zip so that the sporadic error demonstrably no 
> longer occurs. Please review the changes and include them in the codebase for 
> the next release.
> I have attached the original version of SslHandler.java, as well as the 
> modified version. Thank you for your support!



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

[jira] [Commented] (DIRMINA-1157) Sporadic error when establishing a StartTLS or SSL connection

[Jira]

[ 
https://issues.apache.org/jira/browse/DIRMINA-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480468#comment-17480468
 ] 

Emmanuel Lécharny commented on DIRMINA-1157:


Ok, I see.

I'm balanced. On the one hand, this break the SemVer logic:
* major: API change
* minor: Functionality addition
* patch

On the other hand, we already broke the semantic in 2.1 (with the addition of 
the SECURED event).

So let's keep the renaming, and explain it on the web site when the release is 
out. I'll fix the Spring test failure.


> Sporadic error when establishing a StartTLS or SSL connection
> -
>
> Key: DIRMINA-1157
> URL: https://issues.apache.org/jira/browse/DIRMINA-1157
> Project: MINA
>  Issue Type: Bug
>  Components: Core, SSL
>Affects Versions: 2.1.5
>Reporter: Steffen Liersch
>Priority: Blocker
>  Labels: security
> Attachments: SslHandler-compare.png, SslHandler-mod.java, 
> SslHandler.java
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> With the Mina components, a connection error occasionally occurs when 
> establishing a StartTLS or TLS connection. The cause is that payload data was 
> received immediately on the acknowledgement and is already in the receive 
> buffer.
> My colleagues have changed the checkStatus function of the SslHandler class 
> from apache-mina-2.1.5-src.zip so that the sporadic error demonstrably no 
> longer occurs. Please review the changes and include them in the codebase for 
> the next release.
> I have attached the original version of SslHandler.java, as well as the 
> modified version. Thank you for your support!



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

[jira] [Commented] (DIRMINA-1157) Sporadic error when establishing a StartTLS or SSL connection

[Jonathan Valliere (Jira)]

[ 
https://issues.apache.org/jira/browse/DIRMINA-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480438#comment-17480438
 ] 

Jonathan Valliere commented on DIRMINA-1157:


[~elecharny] I had changed it originally to match the acronym standard in the 
JDK e.g. SSLContext.  It also had the advantage of not letting someone in 
another project just bump up the MINA version number without testing because 
the majority of SSLFilter is different and is incompatible with previous 
versions.

> Sporadic error when establishing a StartTLS or SSL connection
> -
>
> Key: DIRMINA-1157
> URL: https://issues.apache.org/jira/browse/DIRMINA-1157
> Project: MINA
>  Issue Type: Bug
>  Components: Core, SSL
>Affects Versions: 2.1.5
>Reporter: Steffen Liersch
>Priority: Blocker
>  Labels: security
> Attachments: SslHandler-compare.png, SslHandler-mod.java, 
> SslHandler.java
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> With the Mina components, a connection error occasionally occurs when 
> establishing a StartTLS or TLS connection. The cause is that payload data was 
> received immediately on the acknowledgement and is already in the receive 
> buffer.
> My colleagues have changed the checkStatus function of the SslHandler class 
> from apache-mina-2.1.5-src.zip so that the sporadic error demonstrably no 
> longer occurs. Please review the changes and include them in the codebase for 
> the next release.
> I have attached the original version of SslHandler.java, as well as the 
> modified version. Thank you for your support!



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

[jira] [Commented] (DIRMINA-1157) Sporadic error when establishing a StartTLS or SSL connection

[Jira]

[ 
https://issues.apache.org/jira/browse/DIRMINA-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480436#comment-17480436
 ] 

Emmanuel Lécharny commented on DIRMINA-1157:


[~johnnyv] the classes were named SSLFilter etc, while in MINA 2.0/2.1 they 
were named SslFilter. It breaks some Spring based tests (and generates braking 
for those who use classes in their imports). Not such a big deal, it's just a 
rename.

I have to clean up my env, merging is not possible without great pain atm. I'll 
do that later today.

> Sporadic error when establishing a StartTLS or SSL connection
> -
>
> Key: DIRMINA-1157
> URL: https://issues.apache.org/jira/browse/DIRMINA-1157
> Project: MINA
>  Issue Type: Bug
>  Components: Core, SSL
>Affects Versions: 2.1.5
>Reporter: Steffen Liersch
>Priority: Blocker
>  Labels: security
> Attachments: SslHandler-compare.png, SslHandler-mod.java, 
> SslHandler.java
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> With the Mina components, a connection error occasionally occurs when 
> establishing a StartTLS or TLS connection. The cause is that payload data was 
> received immediately on the acknowledgement and is already in the receive 
> buffer.
> My colleagues have changed the checkStatus function of the SslHandler class 
> from apache-mina-2.1.5-src.zip so that the sporadic error demonstrably no 
> longer occurs. Please review the changes and include them in the codebase for 
> the next release.
> I have attached the original version of SslHandler.java, as well as the 
> modified version. Thank you for your support!



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

[jira] [Comment Edited] (DIRMINA-1157) Sporadic error when establishing a StartTLS or SSL connection

[Jonathan Valliere (Jira)]

[ 
https://issues.apache.org/jira/browse/DIRMINA-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480416#comment-17480416
 ] 

Jonathan Valliere edited comment on DIRMINA-1157 at 1/22/22, 1:02 PM:
--

[~elecharny] 

I don't understand the case sensitive thing, I had renamed all of the 
references already.  Are you trying to back-port this?  The way you rename 
things in case-insensitive is by adding a 2 at the end so like "SslSomething" 
becomes "SSLSomething2" then remove the 2 "SSLSomething"

MacOS is case insensitive which is why the renaming problems happen.  Linux is 
case sensitive which doesn't have the renaming problems (which is what I use 
for development)

 

My MINA workspace should have been set to spaces to match everything else.  My 
work work stuff is set to tabs and line breaks (it would have looked way 
different).  I will check it the next time I work on something.


was (Author: johnnyv):
[~elecharny] 

I don't understand the case sensitive thing, I had renamed all of the 
references already.  Are you trying to back-port this?  The way you rename 
things in case-sensitive is by adding a 2 at the end so like "SslSomething" 
becomes "SSLSomething2" then remove the 2 "SSLSomething"

My MINA workspace should have been set to spaces to match everything else.  My 
work work stuff is set to tabs and line breaks (it would have looked way 
different).  I will check it the next time I work on something.

> Sporadic error when establishing a StartTLS or SSL connection
> -
>
> Key: DIRMINA-1157
> URL: https://issues.apache.org/jira/browse/DIRMINA-1157
> Project: MINA
>  Issue Type: Bug
>  Components: Core, SSL
>Affects Versions: 2.1.5
>Reporter: Steffen Liersch
>Priority: Blocker
>  Labels: security
> Attachments: SslHandler-compare.png, SslHandler-mod.java, 
> SslHandler.java
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> With the Mina components, a connection error occasionally occurs when 
> establishing a StartTLS or TLS connection. The cause is that payload data was 
> received immediately on the acknowledgement and is already in the receive 
> buffer.
> My colleagues have changed the checkStatus function of the SslHandler class 
> from apache-mina-2.1.5-src.zip so that the sporadic error demonstrably no 
> longer occurs. Please review the changes and include them in the codebase for 
> the next release.
> I have attached the original version of SslHandler.java, as well as the 
> modified version. Thank you for your support!



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

[jira] [Comment Edited] (DIRMINA-1157) Sporadic error when establishing a StartTLS or SSL connection

[Jonathan Valliere (Jira)]

[ 
https://issues.apache.org/jira/browse/DIRMINA-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480416#comment-17480416
 ] 

Jonathan Valliere edited comment on DIRMINA-1157 at 1/22/22, 1:02 PM:
--

[~elecharny] 

I don't understand the case sensitive thing, I had renamed all of the 
references already.  Are you trying to back-port this?  The way you rename 
things in case-insensitive is by adding a 2 at the end so like "SslSomething" 
becomes "SSLSomething2" then remove the 2 "SSLSomething"

MacOS is case insensitive which is why the renaming problems happen.  Linux is 
case sensitive which doesn't have the renaming problems (which is what I use 
for development)

My MINA workspace should have been set to spaces to match everything else.  My 
work work stuff is set to tabs and line breaks (it would have looked way 
different).  I will check it the next time I work on something.


was (Author: johnnyv):
[~elecharny] 

I don't understand the case sensitive thing, I had renamed all of the 
references already.  Are you trying to back-port this?  The way you rename 
things in case-insensitive is by adding a 2 at the end so like "SslSomething" 
becomes "SSLSomething2" then remove the 2 "SSLSomething"

MacOS is case insensitive which is why the renaming problems happen.  Linux is 
case sensitive which doesn't have the renaming problems (which is what I use 
for development)

 

My MINA workspace should have been set to spaces to match everything else.  My 
work work stuff is set to tabs and line breaks (it would have looked way 
different).  I will check it the next time I work on something.

> Sporadic error when establishing a StartTLS or SSL connection
> -
>
> Key: DIRMINA-1157
> URL: https://issues.apache.org/jira/browse/DIRMINA-1157
> Project: MINA
>  Issue Type: Bug
>  Components: Core, SSL
>Affects Versions: 2.1.5
>Reporter: Steffen Liersch
>Priority: Blocker
>  Labels: security
> Attachments: SslHandler-compare.png, SslHandler-mod.java, 
> SslHandler.java
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> With the Mina components, a connection error occasionally occurs when 
> establishing a StartTLS or TLS connection. The cause is that payload data was 
> received immediately on the acknowledgement and is already in the receive 
> buffer.
> My colleagues have changed the checkStatus function of the SslHandler class 
> from apache-mina-2.1.5-src.zip so that the sporadic error demonstrably no 
> longer occurs. Please review the changes and include them in the codebase for 
> the next release.
> I have attached the original version of SslHandler.java, as well as the 
> modified version. Thank you for your support!



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

[jira] [Comment Edited] (DIRMINA-1157) Sporadic error when establishing a StartTLS or SSL connection

[Jonathan Valliere (Jira)]

[ 
https://issues.apache.org/jira/browse/DIRMINA-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480416#comment-17480416
 ] 

Jonathan Valliere edited comment on DIRMINA-1157 at 1/22/22, 12:55 PM:
---

[~elecharny] 

I don't understand the case sensitive thing, I had renamed all of the 
references already.  Are you trying to back-port this?  The way you rename 
things in case-sensitive is by adding a 2 at the end so like "SslSomething" 
becomes "SSLSomething2" then remove the 2 "SSLSomething"

My MINA workspace should have been set to spaces to match everything else.  My 
work work stuff is set to tabs and line breaks (it would have looked way 
different).  I will check it the next time I work on something.


was (Author: johnnyv):
[~elecharny] 

I don't understand the case sensitive thing, I had renamed all of the 
references already.  Are you trying to back-port this?  The way you rename 
things is by adding a 2 at the end so like "SslSomething" becomes 
"SSLSomething2" then remove the 2 "SSLSomething"

My MINA workspace should have been set to spaces to match everything else.  My 
work work stuff is set to tabs and line breaks (it would have looked way 
different).  I will check it the next time I work on something.

> Sporadic error when establishing a StartTLS or SSL connection
> -
>
> Key: DIRMINA-1157
> URL: https://issues.apache.org/jira/browse/DIRMINA-1157
> Project: MINA
>  Issue Type: Bug
>  Components: Core, SSL
>Affects Versions: 2.1.5
>Reporter: Steffen Liersch
>Priority: Blocker
>  Labels: security
> Attachments: SslHandler-compare.png, SslHandler-mod.java, 
> SslHandler.java
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> With the Mina components, a connection error occasionally occurs when 
> establishing a StartTLS or TLS connection. The cause is that payload data was 
> received immediately on the acknowledgement and is already in the receive 
> buffer.
> My colleagues have changed the checkStatus function of the SslHandler class 
> from apache-mina-2.1.5-src.zip so that the sporadic error demonstrably no 
> longer occurs. Please review the changes and include them in the codebase for 
> the next release.
> I have attached the original version of SslHandler.java, as well as the 
> modified version. Thank you for your support!



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

[jira] [Comment Edited] (DIRMINA-1157) Sporadic error when establishing a StartTLS or SSL connection

[Jonathan Valliere (Jira)]

[ 
https://issues.apache.org/jira/browse/DIRMINA-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480416#comment-17480416
 ] 

Jonathan Valliere edited comment on DIRMINA-1157 at 1/22/22, 12:54 PM:
---

[~elecharny] 

I don't understand the case sensitive thing, I had renamed all of the 
references already.  Are you trying to back-port this?  The way you rename 
things is by adding a 2 at the end so like "SslSomething" becomes 
"SSLSomething2" then remove the 2 "SSLSomething"

My MINA workspace should have been set to spaces to match everything else.  My 
work work stuff is set to tabs and line breaks (it would have looked way 
different).  I will check it the next time I work on something.


was (Author: johnnyv):
[~elecharny] 

I don't understand the case sensitive thing, I had renamed all of the 
references already.  Are you trying to back-port this?

My MINA workspace should have been set to spaces to match everything else.  My 
work work stuff is set to tabs and line breaks (it would have looked way 
different).  I will check it the next time I work on something.

> Sporadic error when establishing a StartTLS or SSL connection
> -
>
> Key: DIRMINA-1157
> URL: https://issues.apache.org/jira/browse/DIRMINA-1157
> Project: MINA
>  Issue Type: Bug
>  Components: Core, SSL
>Affects Versions: 2.1.5
>Reporter: Steffen Liersch
>Priority: Blocker
>  Labels: security
> Attachments: SslHandler-compare.png, SslHandler-mod.java, 
> SslHandler.java
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> With the Mina components, a connection error occasionally occurs when 
> establishing a StartTLS or TLS connection. The cause is that payload data was 
> received immediately on the acknowledgement and is already in the receive 
> buffer.
> My colleagues have changed the checkStatus function of the SslHandler class 
> from apache-mina-2.1.5-src.zip so that the sporadic error demonstrably no 
> longer occurs. Please review the changes and include them in the codebase for 
> the next release.
> I have attached the original version of SslHandler.java, as well as the 
> modified version. Thank you for your support!



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

[jira] [Commented] (DIRMINA-1157) Sporadic error when establishing a StartTLS or SSL connection

[Jonathan Valliere (Jira)]

[ 
https://issues.apache.org/jira/browse/DIRMINA-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480416#comment-17480416
 ] 

Jonathan Valliere commented on DIRMINA-1157:


[~elecharny] 

I don't understand the case sensitive thing, I had renamed all of the 
references already.  Are you trying to back-port this?

My MINA workspace should have been set to spaces to match everything else.  My 
work work stuff is set to tabs and line breaks (it would have looked way 
different).  I will check it the next time I work on something.

> Sporadic error when establishing a StartTLS or SSL connection
> -
>
> Key: DIRMINA-1157
> URL: https://issues.apache.org/jira/browse/DIRMINA-1157
> Project: MINA
>  Issue Type: Bug
>  Components: Core, SSL
>Affects Versions: 2.1.5
>Reporter: Steffen Liersch
>Priority: Blocker
>  Labels: security
> Attachments: SslHandler-compare.png, SslHandler-mod.java, 
> SslHandler.java
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> With the Mina components, a connection error occasionally occurs when 
> establishing a StartTLS or TLS connection. The cause is that payload data was 
> received immediately on the acknowledgement and is already in the receive 
> buffer.
> My colleagues have changed the checkStatus function of the SslHandler class 
> from apache-mina-2.1.5-src.zip so that the sporadic error demonstrably no 
> longer occurs. Please review the changes and include them in the codebase for 
> the next release.
> I have attached the original version of SslHandler.java, as well as the 
> modified version. Thank you for your support!



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org