Re: [VOTE] Release Mina SSHD 2.13.0
Can you please point to our KEYS file so I don't have to hunt it down every time ;-) Gary On 2024/06/12 15:53:23 Guillaume Nodet wrote: > I've staged a candidate release for an SSHD 2.13.0 release at: > Official staging repo: > https://dist.apache.org/repos/dist/dev/mina/sshd/2.13.0/ > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachemina-1093 > Git tag: > https://github.com/apache/mina-sshd/commits/sshd-2.13.0 > Changelog: > > https://github.com/apache/mina-sshd/blob/sshd-2.13.0/docs/changes/2.13.0.md > > Remember, if you want to try building with tests, *you need docker to be > running on your computer* ! > Please review and vote ! > > -- > > Guillaume Nodet > - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
Re: [VOTE] Release Mina SSHD 2.13.0
Can you please point to our KEYS file so I don't have to hunt it down every time ;-) Gary On 2024/06/12 15:53:23 Guillaume Nodet wrote: > I've staged a candidate release for an SSHD 2.13.0 release at: > Official staging repo: > https://dist.apache.org/repos/dist/dev/mina/sshd/2.13.0/ > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachemina-1093 > Git tag: > https://github.com/apache/mina-sshd/commits/sshd-2.13.0 > Changelog: > > https://github.com/apache/mina-sshd/blob/sshd-2.13.0/docs/changes/2.13.0.md > > Remember, if you want to try building with tests, *you need docker to be > running on your computer* ! > Please review and vote ! > > -- > > Guillaume Nodet > - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
Re: [VOTE] Release Mina SSHD 2.13.0
My +1: - checked the signature - checked the N&L files - built from source One side note: on my new M3 mac, the org.apache.sshd.common.cipher.ArcFourOpenSshTest test never finishes. I will relaunch the tests to be sure, but it works just fine on my old Intel mac. (Java 11 on both computers) Thanks Guillaume! On 12/06/2024 17:53, Guillaume Nodet wrote: I've staged a candidate release for an SSHD 2.13.0 release at: Official staging repo: https://dist.apache.org/repos/dist/dev/mina/sshd/2.13.0/ Maven staging repo: https://repository.apache.org/content/repositories/orgapachemina-1093 Git tag: https://github.com/apache/mina-sshd/commits/sshd-2.13.0 Changelog: https://github.com/apache/mina-sshd/blob/sshd-2.13.0/docs/changes/2.13.0.md Remember, if you want to try building with tests, *you need docker to be running on your computer* ! Please review and vote ! -- *Emmanuel Lécharny* P. +33 (0)6 08 33 32 61 elecha...@apache.org - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
Re: [VOTE] Release Mina SSHD 2.13.0
Found the KEYS file: https://archive.apache.org/dist/mina/KEYS Gary On 2024/06/13 16:12:58 "Gary D. Gregory" wrote: > Can you please point to our KEYS file so I don't have to hunt it down every > time ;-) > > Gary > > On 2024/06/12 15:53:23 Guillaume Nodet wrote: > > I've staged a candidate release for an SSHD 2.13.0 release at: > > Official staging repo: > > https://dist.apache.org/repos/dist/dev/mina/sshd/2.13.0/ > > Maven staging repo: > > https://repository.apache.org/content/repositories/orgapachemina-1093 > > Git tag: > > https://github.com/apache/mina-sshd/commits/sshd-2.13.0 > > Changelog: > > > > https://github.com/apache/mina-sshd/blob/sshd-2.13.0/docs/changes/2.13.0.md > > > > Remember, if you want to try building with tests, *you need docker to be > > running on your computer* ! > > Please review and vote ! > > > > -- > > > > Guillaume Nodet > > > > - > To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org > For additional commands, e-mail: dev-h...@mina.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
Re: [VOTE] Release Mina SSHD 2.13.0
On 13.06.24 19:55 , Gary D. Gregory wrote: +1 Tested src zip file, ASC OK (gpg --verify'), SHA512 eyeballed OK (but couldn't use 'shasum --check') OK: mvn clean verify Would you please remind at the next go around us to turn off VPNs? Also point to the KEYS file :-) The build took 33 minutes. Is that normal? My build output is here: https://gist.github.com/garydgregory/60333120889b6df198cef0583ea0a6e8 Yes, that's normal. With a VPN, on Windows and Java 17, running 'mvn clean verify', I get failures: [ERROR] Errors: [ERROR] org.apache.sshd.common.forward.PortForwardingTest.testLocalBindingOnDifferentInterfaces [ERROR] Run 1: PortForwardingTest.testLocalBindingOnDifferentInterfaces:819->testRemoteURL:850 » SocketTimeout Read timed out [ERROR] Run 2: PortForwardingTest.testLocalBindingOnDifferentInterfaces:819->testRemoteURL:850 » Socket Unexpected end of file from server [ERROR] Run 3: PortForwardingTest.testLocalBindingOnDifferentInterfaces:819->testRemoteURL:850 » Socket Unexpected end of file from server [INFO] [INFO] [ERROR] Tests run: 317, Failures: 0, Errors: 1, Skipped: 9 After turning off my VPN, the build was able to proceed past this, unless it was a random failure. Forgot about that one. I had noticed this a while ago, but I haven't been using a VPN for quite some time now, so I forgot again. This problem is not new. The test tries to set up a local port forwarding using the local machine's address on each interface, but that fails for the VPN interface. Don't know if that is a bug in the test, or whether a local port forwarding using the VPN IP for the local machine should work. Cheers, Thomas - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
Re: [VOTE] Release Mina SSHD 2.13.0
+1 Tested src zip file, ASC OK (gpg --verify'), SHA512 eyeballed OK (but couldn't use 'shasum --check') OK: mvn clean verify Would you please remind at the next go around us to turn off VPNs? Also point to the KEYS file :-) The build took 33 minutes. Is that normal? My build output is here: https://gist.github.com/garydgregory/60333120889b6df198cef0583ea0a6e8 With a VPN, on Windows and Java 17, running 'mvn clean verify', I get failures: [ERROR] Errors: [ERROR] org.apache.sshd.common.forward.PortForwardingTest.testLocalBindingOnDifferentInterfaces [ERROR] Run 1: PortForwardingTest.testLocalBindingOnDifferentInterfaces:819->testRemoteURL:850 » SocketTimeout Read timed out [ERROR] Run 2: PortForwardingTest.testLocalBindingOnDifferentInterfaces:819->testRemoteURL:850 » Socket Unexpected end of file from server [ERROR] Run 3: PortForwardingTest.testLocalBindingOnDifferentInterfaces:819->testRemoteURL:850 » Socket Unexpected end of file from server [INFO] [INFO] [ERROR] Tests run: 317, Failures: 0, Errors: 1, Skipped: 9 After turning off my VPN, the build was able to proceed past this, unless it was a random failure. Using: Apache Maven 3.9.7 (8b094c9513efc1b9ce2d952b3b9c8eaedaf8cbf0) Maven home: C:\java\apache-maven-3.9.7 Java version: 17.0.11, vendor: Eclipse Adoptium, runtime: C:\Program Files\Eclipse Adoptium\jdk-17.0.11.9-hotspot Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Gary On 2024/06/13 14:54:41 Emmanuel Lécharny wrote: > My +1: > - checked the signature > - checked the N&L files > - built from source > > One side note: on my new M3 mac, the > org.apache.sshd.common.cipher.ArcFourOpenSshTest test never finishes. > > I will relaunch the tests to be sure, but it works just fine on my old > Intel mac. > > (Java 11 on both computers) > > Thanks Guillaume! > > On 12/06/2024 17:53, Guillaume Nodet wrote: > > I've staged a candidate release for an SSHD 2.13.0 release at: > > Official staging repo: > >https://dist.apache.org/repos/dist/dev/mina/sshd/2.13.0/ > > Maven staging repo: > >https://repository.apache.org/content/repositories/orgapachemina-1093 > > Git tag: > >https://github.com/apache/mina-sshd/commits/sshd-2.13.0 > > Changelog: > > > > https://github.com/apache/mina-sshd/blob/sshd-2.13.0/docs/changes/2.13.0.md > > > > Remember, if you want to try building with tests, *you need docker to be > > running on your computer* ! > > Please review and vote ! > > > > -- > *Emmanuel Lécharny* P. +33 (0)6 08 33 32 61 > elecha...@apache.org > > - > To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org > For additional commands, e-mail: dev-h...@mina.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
Re: [VOTE] Release Mina SSHD 2.13.0
On 13.06.24 16:54 , Emmanuel Lécharny wrote: My +1: - checked the signature - checked the N&L files - built from source One side note: on my new M3 mac, the org.apache.sshd.common.cipher.ArcFourOpenSshTest test never finishes. I will relaunch the tests to be sure, but it works just fine on my old Intel mac. (Java 11 on both computers) I don't have an M3 mac so I cannot debug this test myself. The test uses a docker container based on an old CentOS image to get an old OpenSSH, then tests connections using the old outdated insecure and definitely deprecated arcfour ciphers in combination with all MACs. So there might be a problem with docker on M3 (unlikely as there is at least one other test that also uses the same CentOS image), or with the arcfour cipher on M3 or inside the container when run on an M3 host. We might consider removing the test, and just having a quick and simple unit test that verifies that the block size of the arcfour ciphers is 8. I had used that test to figure out what was going on in Github issue 493 [1] but including it in our test suite may have been overkill. [1] https://github.com/apache/mina-sshd/issues/493 - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
Re: [VOTE] Release Mina SSHD 2.13.0
On 12.06.24 17:53 , Guillaume Nodet wrote: I've staged a candidate release for an SSHD 2.13.0 release at: [...] Thanks, Guillaume! +1 Since other people have tested other things already, I only checked: * Class files have class version 52 (Java 8), as expected * JGit tests run fine when using this 2.13.0 release Cheers, Thomas - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
Re: [VOTE] Release Mina SSHD 2.13.0
+1 Jeff > On Jun 13, 2024, at 8:54 AM, Emmanuel Lécharny wrote: > > My +1: > - checked the signature > - checked the N&L files > - built from source > > One side note: on my new M3 mac, the > org.apache.sshd.common.cipher.ArcFourOpenSshTest test never finishes. > > I will relaunch the tests to be sure, but it works just fine on my old Intel > mac. > > (Java 11 on both computers) > > Thanks Guillaume! > > On 12/06/2024 17:53, Guillaume Nodet wrote: >> I've staged a candidate release for an SSHD 2.13.0 release at: >> Official staging repo: >> https://dist.apache.org/repos/dist/dev/mina/sshd/2.13.0/ >> Maven staging repo: >> https://repository.apache.org/content/repositories/orgapachemina-1093 >> Git tag: >> https://github.com/apache/mina-sshd/commits/sshd-2.13.0 >> Changelog: >> https://github.com/apache/mina-sshd/blob/sshd-2.13.0/docs/changes/2.13.0.md >> Remember, if you want to try building with tests, *you need docker to be >> running on your computer* ! >> Please review and vote ! > > -- > *Emmanuel Lécharny* P. +33 (0)6 08 33 32 61 > elecha...@apache.org > > - > To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org > For additional commands, e-mail: dev-h...@mina.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
Re: [VOTE] Release Mina SSHD 2.13.0
What this vote wrapped up? Gary On Thu, Jun 13, 2024 at 6:14 PM wrote: > > +1 > > Jeff > > > > On Jun 13, 2024, at 8:54 AM, Emmanuel Lécharny wrote: > > > > My +1: > > - checked the signature > > - checked the N&L files > > - built from source > > > > One side note: on my new M3 mac, the > > org.apache.sshd.common.cipher.ArcFourOpenSshTest test never finishes. > > > > I will relaunch the tests to be sure, but it works just fine on my old > > Intel mac. > > > > (Java 11 on both computers) > > > > Thanks Guillaume! > > > > On 12/06/2024 17:53, Guillaume Nodet wrote: > >> I've staged a candidate release for an SSHD 2.13.0 release at: > >> Official staging repo: > >> https://dist.apache.org/repos/dist/dev/mina/sshd/2.13.0/ > >> Maven staging repo: > >> https://repository.apache.org/content/repositories/orgapachemina-1093 > >> Git tag: > >> https://github.com/apache/mina-sshd/commits/sshd-2.13.0 > >> Changelog: > >> https://github.com/apache/mina-sshd/blob/sshd-2.13.0/docs/changes/2.13.0.md > >> Remember, if you want to try building with tests, *you need docker to be > >> running on your computer* ! > >> Please review and vote ! > > > > -- > > *Emmanuel Lécharny* P. +33 (0)6 08 33 32 61 > > elecha...@apache.org > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org > > For additional commands, e-mail: dev-h...@mina.apache.org > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org > For additional commands, e-mail: dev-h...@mina.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
Re: [VOTE] Release Mina SSHD 2.13.0
+1 I'll close the vote and upload the release now. Guillaume Le mer. 19 juin 2024 à 03:08, Gary Gregory a écrit : > What this vote wrapped up? > > Gary > > On Thu, Jun 13, 2024 at 6:14 PM wrote: > > > > +1 > > > > Jeff > > > > > > > On Jun 13, 2024, at 8:54 AM, Emmanuel Lécharny > wrote: > > > > > > My +1: > > > - checked the signature > > > - checked the N&L files > > > - built from source > > > > > > One side note: on my new M3 mac, the > org.apache.sshd.common.cipher.ArcFourOpenSshTest test never finishes. > > > > > > I will relaunch the tests to be sure, but it works just fine on my old > Intel mac. > > > > > > (Java 11 on both computers) > > > > > > Thanks Guillaume! > > > > > > On 12/06/2024 17:53, Guillaume Nodet wrote: > > >> I've staged a candidate release for an SSHD 2.13.0 release at: > > >> Official staging repo: > > >> https://dist.apache.org/repos/dist/dev/mina/sshd/2.13.0/ > > >> Maven staging repo: > > >> > https://repository.apache.org/content/repositories/orgapachemina-1093 > > >> Git tag: > > >> https://github.com/apache/mina-sshd/commits/sshd-2.13.0 > > >> Changelog: > > >> > https://github.com/apache/mina-sshd/blob/sshd-2.13.0/docs/changes/2.13.0.md > > >> Remember, if you want to try building with tests, *you need docker to > be > > >> running on your computer* ! > > >> Please review and vote ! > > > > > > -- > > > *Emmanuel Lécharny* P. +33 (0)6 08 33 32 61 > > > elecha...@apache.org > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org > > > For additional commands, e-mail: dev-h...@mina.apache.org > > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org > > For additional commands, e-mail: dev-h...@mina.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org > For additional commands, e-mail: dev-h...@mina.apache.org > > -- Guillaume Nodet
