Re: [Vysper] Adding ID field in InfoRequest
Niklas Gustavsson wrote: > On Fri, Aug 21, 2009 at 12:56 PM, Bernd Fondermann > wrote: >>> :-) Now implemented. For what it is worth, the use case is >>> http://xmpp.org/extensions/xep-0045.html#disco-occupant >> Thanks. What do you think does the reference to the "Implementation >> Guidelines" refer to? #9? If yes, then the this forwarding should >> generally not be possible, as far as I understand it. > > I have no idea. I've read through the section multiple times without > understanding what it refers to. Right now, we forward everything. > However, I plan to make use of a ServerFeatures-like interface to be > able to disable this (and some other optional features). :-) I'd attribute it to the "speaking with the 'ChatBot'" feature. +1 for a features class and +1 for disabling this forwarding per default. Bernd
Re: [Vysper] Adding ID field in InfoRequest
On Fri, Aug 21, 2009 at 12:56 PM, Bernd Fondermann wrote: >> :-) Now implemented. For what it is worth, the use case is >> http://xmpp.org/extensions/xep-0045.html#disco-occupant > > Thanks. What do you think does the reference to the "Implementation > Guidelines" refer to? #9? If yes, then the this forwarding should > generally not be possible, as far as I understand it. I have no idea. I've read through the section multiple times without understanding what it refers to. Right now, we forward everything. However, I plan to make use of a ServerFeatures-like interface to be able to disable this (and some other optional features). /niklas
Re: [Vysper] Adding ID field in InfoRequest
Niklas Gustavsson wrote: > On Thu, Aug 20, 2009 at 10:08 PM, Bernd Fondermann > wrote: >>> Would anyone object against adding the ID from the original request as >>> a field and getter in InfoRequest? >> Sorry, got it now... +1. > > :-) Now implemented. For what it is worth, the use case is > http://xmpp.org/extensions/xep-0045.html#disco-occupant Thanks. What do you think does the reference to the "Implementation Guidelines" refer to? #9? If yes, then the this forwarding should generally not be possible, as far as I understand it. WDYT? Bernd
Re: [Vysper] Adding ID field in InfoRequest
On Thu, Aug 20, 2009 at 10:08 PM, Bernd Fondermann wrote: >> Would anyone object against adding the ID from the original request as >> a field and getter in InfoRequest? > > Sorry, got it now... +1. :-) Now implemented. For what it is worth, the use case is http://xmpp.org/extensions/xep-0045.html#disco-occupant /niklas
Re: [Vysper] Adding ID field in InfoRequest
Niklas Gustavsson wrote: > Hi > > In MUC, there is a use case in which the MUC service should forward a > disco request to a room occupant. For this, I'm rebuilding the IQ > stanza from the Inforequest. However, the ID from the original stanza > is missing, making it impossible to add this to the forwarded stanza. > > Would anyone object against adding the ID from the original request as > a field and getter in InfoRequest? Sorry, got it now... +1. Bernd
Re: [Vysper] Adding ID field in InfoRequest
Niklas Gustavsson wrote: > Hi > > In MUC, there is a use case in which the MUC service should forward a > disco request to a room occupant. For this, I'm rebuilding the IQ > stanza from the Inforequest. However, the ID from the original stanza > is missing, making it impossible to add this to the forwarded stanza. > > Would anyone object against adding the ID from the original request as > a field and getter in InfoRequest? I'm confused. IQ stanzas must have an ID, where does it go missing? Can you elaborate a little bit? AFAIK, when the server replies to an IQ stanza, it is already re-using (this is an XMPP requirement) the ID. And what section of the MUC XEP are you referring to? Note that IQStanza inherits getID() from XMPPCoreStanza. If you only have a Stanza instance, use XMPPCoreStanza.getWrapper() on it. Bernd
