Re: MINA SonarQube analysis
So many warnings… 😨 On Tue, Mar 6, 2018 at 11:58 AM, Emmanuel Lécharny wrote: > Hi guys, > > I just ran Sonarqube analysis on the current 2.0.17 branch, and there > are a few things we might want to fix. > > Please have a look at > https://sonarcloud.io/project/issues?id=org.apache.mina% > 3Amina-parent%3A2&resolved=false > > Thanks ! > -- > Emmanuel Lecharny > > Symas.com > directory.apache.org > >
Re: MINA SonarQube analysis
Le 06/03/2018 à 18:20, Jonathan Valliere a écrit : > So many warnings… 😨 Yes... There are a few puzzling ones, like the synchronized( buf ) where buf is a parameter... I think we should focus on blockers and critical level issues atm. -- Emmanuel Lecharny Symas.com directory.apache.org
Re: MINA SonarQube analysis
Looks interesting is there a guide as to how to register a project (I was thinking about SSHD...) >> Hi guys, >> I have registred MINA on the SonarQube server we have at Apache. The result can be seen here : >> https://builds.apache.org/analysis/component_measures/?id=MINA >> It gets generated every time a build is launched, ie, when a commit is pushed. >> Emmanuel Lecharny
Re: MINA SonarQube analysis
Hi Lyor, Le 18/03/2018 à 19:26, Lyor Goldstein a écrit : > Looks interesting is there a guide as to how to register a project (I was > thinking about SSHD...) I have created the config for SSHD. The result can be found here: https://builds.apache.org/analysis/overview?id=MINA_SSHD Now, the build fails (rat pb) which is a bit werid because it passes on my computer... [INFO] Rat check: Summary over all files. Unapproved: 2, unknown: 2, generated: 0, approved: 2 licenses. [CHECKSTYLE] No report found for mojo check [PMD] No report found for mojo check [INFO] [INFO] [INFO] Skipping Apache Mina SSHD [INFO] This project has been banned from the build due to previous failures. [INFO] [INFO] [INFO] Reactor Summary: [INFO] [INFO] Apache Mina SSHD ... FAILURE [ 14.173 s] [INFO] Apache Mina SSHD :: Core ... SKIPPED [INFO] Apache Mina SSHD :: Mina ... SKIPPED [INFO] Apache Mina SSHD :: LDAP ... SKIPPED [INFO] Apache Mina SSHD :: Git SKIPPED [INFO] Apache Mina SSHD :: Contributions .. SKIPPED [INFO] Apache Mina SSHD :: Spring integration SFTP adapter SKIPPED [INFO] Apache Mina SSHD :: Assembly ... SKIPPED [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 28.824 s [INFO] Finished at: 2018-03-19T09:20:00Z [INFO] Final Memory: 41M/402M [INFO] [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (check-apache-license-header) on project sshd: Too many files with unapproved license: 2 See RAT report in: /home/jenkins/jenkins-slave/workspace/MINA-SSHD jdk8 linux SONAR/target/rat.txt -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException (see https://builds.apache.org/job/MINA-SSHD%20jdk8%20linux%20SONAR/2/console) -- Emmanuel Lecharny Symas.com directory.apache.org
Re: MINA SonarQube analysis
Thanks a lot Emmanuel... As far as the build failure it is strange indeed as it passes on both my Windows and Linux machines. However, since it states: [INFO] Rat check: Summary over all files. Unapproved: 2 it means that the offending files are listed in the target/rat.txt file (or somewhere simuilar) - is there a way to see which files these are ? Then I can fix them (e.g., exclude them from the plugin's configuration) again - thanks a lot... Lyor >> Hi Lyor, >> Le 18/03/2018 à 19:26, Lyor Goldstein a écrit : Looks interesting is there a guide as to how to register a project (I was thinking about SSHD...) >> I have created the config for SSHD. >> The result can be found here: https://builds.apache.org/analysis/overview?id=MINA_SSHD >> Now, the build fails (rat pb) which is a bit werid because it passes on my computer...
Re: MINA SonarQube analysis
Le 19/03/2018 à 18:20, Lyor Goldstein a écrit : > Thanks a lot Emmanuel... > > As far as the build failure it is strange indeed as it passes on both my > Windows and Linux machines. However, since it states: > > [INFO] Rat check: Summary over all files. Unapproved: 2 > > it means that the offending files are listed in the target/rat.txt file (or > somewhere simuilar) - is there a way to see which files these are ? Then I > can fix them (e.g., exclude them from the plugin's configuration) The problem is that on my computer, when I run mvn apache-rat:check, I get no error. And if I run mvn rat:check, it's worse, because it does not ignore the .git files. I have no idea why it fails, and how to fix it. Ideally speaking, we should have a look at the target/rat.txt file on the instance the Sonar check was ran. I'll see with Infra if it's an option. -- Emmanuel Lecharny Symas.com directory.apache.org
