[jira] [Commented] (MYFACES-4610) Fix for issuing element key:value combination breaks Tobago

2023-06-27 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737968#comment-17737968
 ] 

Werner Punz commented on MYFACES-4610:
--

Pull request merged for main (Myfaces 4.0), other branches will follow the 
upcoming days

> Fix for issuing element key:value combination breaks Tobago
> ---
>
> Key: MYFACES-4610
> URL: https://issues.apache.org/jira/browse/MYFACES-4610
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 3.0.2, 2.3-next-M8, 4.0.2
>Reporter: Werner Punz
>Assignee: Werner Punz
>Priority: Major
>
> This is a follow up issue caused by the fix for 
> https://issues.apache.org/jira/browse/MYFACES-4606
> raised by the Tobago guys.
> The fix broke one of their testcases!
> [https://github.com/henningn/myfaces-tobago.git]
> 4 checkboxes on the page, example does not work anymore because
>  * git checkout jsfjs_next_gen402 
>  * mvn clean install
>  * cd tobago-example/tobago-example-demo 
>  * mvn clean -Pdev -Pjetty jetty:run
>  * open 
> [http://localhost:8080/content/030-select/50-selectManyCheckbox/Multi_Checkbox.xhtml]
> The request adds the issuing element with a null value!
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [myfaces] werpu merged pull request #592: https://issues.apache.org/jira/browse/MYFACES-4610

2023-06-27 Thread via GitHub


werpu merged PR #592:
URL: https://github.com/apache/myfaces/pull/592


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MYFACES-4605) Cross form rending via ajax, form is missing ViewState

2023-06-27 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737814#comment-17737814
 ] 

Werner Punz commented on MYFACES-4605:
--

Have issued a fix for the id :0 problem for myfaces 4.0 which will be merged 
today. Will issue a fix for the 2.x  and 3.x branches later this week!

 

> Cross form rending via ajax, form is missing ViewState
> --
>
> Key: MYFACES-4605
> URL: https://issues.apache.org/jira/browse/MYFACES-4605
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 3.0.1, 2.3.10
>Reporter: Joe Crichton
>Assignee: Werner Punz
>Priority: Major
> Fix For: 2.3.11, 3.0.3
>
> Attachments: image-2023-06-20-21-22-50-593.png
>
>
> Seems this is an old issue, which was presumably fixed for MyFaces in 2.2 as 
> discussed here 
> [https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm|https://balusc.omnifaces.org/2011/09/communication-in-jsf-20.html#AjaxRenderingOfContentWhichContainsAnotherForm),]
> and [https://github.com/jakartaee/faces/issues/790]
> Using openliberty with jsf-3.0 feature still has this occurring. Using the 
> workaround outlined by the first link fixes the issue. I believe the same is 
> true for the jsf-2.3 feature as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4610) Fix for issuing element key:value combination breaks Tobago

2023-06-27 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737813#comment-17737813
 ] 

Werner Punz commented on MYFACES-4610:
--

have issued a pull request which soon will be merged, will issue fixes for the 
2.x branches in the upcoming days!

 

> Fix for issuing element key:value combination breaks Tobago
> ---
>
> Key: MYFACES-4610
> URL: https://issues.apache.org/jira/browse/MYFACES-4610
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 3.0.2, 2.3-next-M8, 4.0.2
>Reporter: Werner Punz
>Assignee: Werner Punz
>Priority: Major
>
> This is a follow up issue caused by the fix for 
> https://issues.apache.org/jira/browse/MYFACES-4606
> raised by the Tobago guys.
> The fix broke one of their testcases!
> [https://github.com/henningn/myfaces-tobago.git]
> 4 checkboxes on the page, example does not work anymore because
>  * git checkout jsfjs_next_gen402 
>  * mvn clean install
>  * cd tobago-example/tobago-example-demo 
>  * mvn clean -Pdev -Pjetty jetty:run
>  * open 
> [http://localhost:8080/content/030-select/50-selectManyCheckbox/Multi_Checkbox.xhtml]
> The request adds the issuing element with a null value!
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [myfaces] werpu opened a new pull request, #592: https://issues.apache.org/jira/browse/MYFACES-4610

2023-06-27 Thread via GitHub


werpu opened a new pull request, #592:
URL: https://github.com/apache/myfaces/pull/592

   https://issues.apache.org/jira/browse/MYFACES-4610
   Fix for virtual issuing elements
   
   https://issues.apache.org/jira/browse/MYFACES-4605
   
   Fix for unique identifier number should start at 1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Comment Edited] (MYFACES-4610) Fix for issuing element key:value combination breaks Tobago

2023-06-27 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737688#comment-17737688
 ] 

Werner Punz edited comment on MYFACES-4610 at 6/27/23 3:19 PM:
---

The issue here is indeed the fix we added recently that a key value pair of the 
issuing element is added.

The problem here is that the issuing element has the same id (the virtual 
element tobago-select-many-checkbox but has no value, to make matters worse the 
embedded real inputs have the same name as the input elements id:

 Fix for issuing element key:value combination breaks Tobago
> ---
>
> Key: MYFACES-4610
> URL: https://issues.apache.org/jira/browse/MYFACES-4610
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 3.0.2, 2.3-next-M8, 4.0.2
>Reporter: Werner Punz
>Assignee: Werner Punz
>Priority: Major
>
> This is a follow up issue caused by the fix for 
> https://issues.apache.org/jira/browse/MYFACES-4606
> raised by the Tobago guys.
> The fix broke one of their testcases!
> [https://github.com/henningn/myfaces-tobago.git]
> 4 checkboxes on the page, example does not work anymore because
>  * git checkout jsfjs_next_gen402 
>  * mvn clean install
>  * cd tobago-example/tobago-example-demo 
>  * mvn clean -Pdev -Pjetty jetty:run
>  * open 
> [http://localhost:8080/content/030-select/50-selectManyCheckbox/Multi_Checkbox.xhtml]
> The request adds the issuing element with a null value!
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MYFACES-4610) Fix for issuing element key:value combination breaks Tobago

2023-06-27 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737688#comment-17737688
 ] 

Werner Punz edited comment on MYFACES-4610 at 6/27/23 2:32 PM:
---

The issue here is indeed the fix we added recently that a key value pair of the 
issuing element is added.

The problem here is that the issuing element has the same id (the virtual 
element tobago-select-many-checkbox but has no value, to make matters worse the 
embedded real inputs have the same name as the input elements id:

 Fix for issuing element key:value combination breaks Tobago
> ---
>
> Key: MYFACES-4610
> URL: https://issues.apache.org/jira/browse/MYFACES-4610
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 3.0.2, 2.3-next-M8, 4.0.2
>Reporter: Werner Punz
>Assignee: Werner Punz
>Priority: Major
>
> This is a follow up issue caused by the fix for 
> https://issues.apache.org/jira/browse/MYFACES-4606
> raised by the Tobago guys.
> The fix broke one of their testcases!
> [https://github.com/henningn/myfaces-tobago.git]
> 4 checkboxes on the page, example does not work anymore because
>  * git checkout jsfjs_next_gen402 
>  * mvn clean install
>  * cd tobago-example/tobago-example-demo 
>  * mvn clean -Pdev -Pjetty jetty:run
>  * open 
> [http://localhost:8080/content/030-select/50-selectManyCheckbox/Multi_Checkbox.xhtml]
> The request adds the issuing element with a null value!
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4610) Fix for issuing element key:value combination breaks Tobago

2023-06-27 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737688#comment-17737688
 ] 

Werner Punz commented on MYFACES-4610:
--

The issue here is indeed the fix we added recently that a key value pair of the 
issuing element is added.

The problem here is that the issuing element has the same id (the virtual 
element tobago-select-many-checkbox but has no value, to make matters worse the 
embedded real inputs have the same name as the input elements id:

 Fix for issuing element key:value combination breaks Tobago
> ---
>
> Key: MYFACES-4610
> URL: https://issues.apache.org/jira/browse/MYFACES-4610
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 3.0.2, 2.3-next-M8, 4.0.2
>Reporter: Werner Punz
>Assignee: Werner Punz
>Priority: Major
>
> [https://github.com/henningn/myfaces-tobago.git]
> 4 checkboxes on the page, example does not work anymore because
>  * git checkout jsfjs_next_gen402 
>  * mvn clean install
>  * cd tobago-example/tobago-example-demo 
>  * mvn clean -Pdev -Pjetty jetty:run
>  * open 
> [http://localhost:8080/content/030-select/50-selectManyCheckbox/Multi_Checkbox.xhtml]
> The request adds the issuing element with a null value!
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (TOBAGO-2237) Wrong position for icons in tc:tab bar-facet

2023-06-27 Thread Jira


 [ 
https://issues.apache.org/jira/browse/TOBAGO-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henning Nöth resolved TOBAGO-2237.
--
Fix Version/s: 5.8.0
   Resolution: Fixed

> Wrong position for icons in tc:tab bar-facet
> 
>
> Key: TOBAGO-2237
> URL: https://issues.apache.org/jira/browse/TOBAGO-2237
> Project: MyFaces Tobago
>  Issue Type: Bug
>  Components: Themes
>Affects Versions: 5.7.2
>Reporter: Henning Nöth
>Assignee: Henning Nöth
>Priority: Minor
> Fix For: 5.8.0
>
>
> The tc:link icon in the following code is positioned at the top of the tab 
> label. But it should be placed at the same height as the label.
> {code:xml}
> 
>   
> 
>   
>   Content of tab
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [myfaces-tobago] henningn merged pull request #4151: fix(tabs): position for icons in bar-faces

2023-06-27 Thread via GitHub


henningn merged PR #4151:
URL: https://github.com/apache/myfaces-tobago/pull/4151


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces-tobago] henningn merged pull request #4152: fix(tabs): position for icons in bar-faces

2023-06-27 Thread via GitHub


henningn merged PR #4152:
URL: https://github.com/apache/myfaces-tobago/pull/4152


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces-tobago] henningn opened a new pull request, #4152: fix(tabs): position for icons in bar-faces

2023-06-27 Thread via GitHub


henningn opened a new pull request, #4152:
URL: https://github.com/apache/myfaces-tobago/pull/4152

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces-tobago] henningn opened a new pull request, #4151: fix(tabs): position for icons in bar-faces

2023-06-27 Thread via GitHub


henningn opened a new pull request, #4151:
URL: https://github.com/apache/myfaces-tobago/pull/4151

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (TOBAGO-2238) Tabs cannot be changed by keyboard

2023-06-27 Thread Jira
Henning Nöth created TOBAGO-2238:


 Summary: Tabs cannot be changed by keyboard
 Key: TOBAGO-2238
 URL: https://issues.apache.org/jira/browse/TOBAGO-2238
 Project: MyFaces Tobago
  Issue Type: Bug
  Components: Core, JavaScript
Affects Versions: 5.7.2
Reporter: Henning Nöth


Tabs should be focusable by TAB and selectable with SPACE/ENTER.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [myfaces-tobago] henningn merged pull request #4150: refactor(SCSS): use prefix variable

2023-06-27 Thread via GitHub


henningn merged PR #4150:
URL: https://github.com/apache/myfaces-tobago/pull/4150


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces-tobago] henningn merged pull request #4149: refactor(SCSS): use prefix variable

2023-06-27 Thread via GitHub


henningn merged PR #4149:
URL: https://github.com/apache/myfaces-tobago/pull/4149


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces-tobago] henningn opened a new pull request, #4150: refactor(SCSS): use prefix variable

2023-06-27 Thread via GitHub


henningn opened a new pull request, #4150:
URL: https://github.com/apache/myfaces-tobago/pull/4150

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces-tobago] henningn opened a new pull request, #4149: refactor(SCSS): use prefix variable

2023-06-27 Thread via GitHub


henningn opened a new pull request, #4149:
URL: https://github.com/apache/myfaces-tobago/pull/4149

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Resolved] (TOBAGO-2215) Remove margin for tc:links in a tc:bar

2023-06-27 Thread Jira


 [ 
https://issues.apache.org/jira/browse/TOBAGO-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henning Nöth resolved TOBAGO-2215.
--
Fix Version/s: 5.8.0
   Resolution: Fixed

> Remove margin for tc:links in a tc:bar
> --
>
> Key: TOBAGO-2215
> URL: https://issues.apache.org/jira/browse/TOBAGO-2215
> Project: MyFaces Tobago
>  Issue Type: Bug
>  Components: Themes
>Affects Versions: 5.6.1
>Reporter: Henning Nöth
>Assignee: Henning Nöth
>Priority: Minor
> Fix For: 5.8.0
>
>
> A tc:links in a tc:bar has a margin to the bottom. The links are now 
> positioned at the top of the bar.
> {code:xml}
>   
> 
> 
>   
> {code}
> Current workaround: autoSpacing=false



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [myfaces-tobago] henningn merged pull request #4148: chore(spring-example): remove jackson-databind

2023-06-27 Thread via GitHub


henningn merged PR #4148:
URL: https://github.com/apache/myfaces-tobago/pull/4148


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces-tobago] henningn merged pull request #4147: fix: tc:links in tc:bar

2023-06-27 Thread via GitHub


henningn merged PR #4147:
URL: https://github.com/apache/myfaces-tobago/pull/4147


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces-tobago] henningn merged pull request #4146: fix: tc:links in tc:bar

2023-06-27 Thread via GitHub


henningn merged PR #4146:
URL: https://github.com/apache/myfaces-tobago/pull/4146


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (TOBAGO-2237) Wrong position for icons in tc:tab bar-facet

2023-06-27 Thread Jira
Henning Nöth created TOBAGO-2237:


 Summary: Wrong position for icons in tc:tab bar-facet
 Key: TOBAGO-2237
 URL: https://issues.apache.org/jira/browse/TOBAGO-2237
 Project: MyFaces Tobago
  Issue Type: Bug
  Components: Themes
Affects Versions: 5.7.2
Reporter: Henning Nöth


The tc:link icon in the following code is positioned at the top of the tab 
label. But it should be placed at the same height as the label.

{code:xml}

  

  
  Content of tab

{code}




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [myfaces-tobago] henningn opened a new pull request, #4148: chore(spring-example): remove jackson-databind

2023-06-27 Thread via GitHub


henningn opened a new pull request, #4148:
URL: https://github.com/apache/myfaces-tobago/pull/4148

   because of CVE-2023-35116


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces-tobago] henningn opened a new pull request, #4147: fix: tc:links in tc:bar

2023-06-27 Thread via GitHub


henningn opened a new pull request, #4147:
URL: https://github.com/apache/myfaces-tobago/pull/4147

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces-tobago] henningn opened a new pull request, #4146: fix: tc:links in tc:bar

2023-06-27 Thread via GitHub


henningn opened a new pull request, #4146:
URL: https://github.com/apache/myfaces-tobago/pull/4146

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (TOBAGO-2236) Close dropdown menu of SelectOneList after entry is clicked

2023-06-27 Thread Jira
Henning Nöth created TOBAGO-2236:


 Summary: Close dropdown menu of SelectOneList after entry is 
clicked
 Key: TOBAGO-2236
 URL: https://issues.apache.org/jira/browse/TOBAGO-2236
 Project: MyFaces Tobago
  Issue Type: Bug
  Components: JavaScript
Affects Versions: 5.7.2
Reporter: Henning Nöth


The dropdown menu should behave like an tc:selectOneChoice.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [myfaces-tobago] henningn merged pull request #4143: build(deps): bump frontend-maven-plugin from 1.12.1 to 1.13.3

2023-06-27 Thread via GitHub


henningn merged PR #4143:
URL: https://github.com/apache/myfaces-tobago/pull/4143


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces-tobago] henningn merged pull request #4144: build(deps): bump frontend-maven-plugin from 1.12.1 to 1.13.3

2023-06-27 Thread via GitHub


henningn merged PR #4144:
URL: https://github.com/apache/myfaces-tobago/pull/4144


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces-tobago] henningn merged pull request #4145: build(deps): bump frontend-maven-plugin from 1.12.1 to 1.13.3

2023-06-27 Thread via GitHub


henningn merged PR #4145:
URL: https://github.com/apache/myfaces-tobago/pull/4145


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org