[PR] build(deps-dev): bump postcss from 8.4.18 to 8.4.31 in /tobago-example/tobago-example-demo [myfaces-tobago]
dependabot[bot] opened a new pull request, #4359: URL: https://github.com/apache/myfaces-tobago/pull/4359 Bumps [postcss](https://github.com/postcss/postcss) from 8.4.18 to 8.4.31. Release notes Sourced from https://github.com/postcss/postcss/releases";>postcss's releases. 8.4.31 Fixed \r parsing to fix CVE-2023-44270. 8.4.30 Improved source map performance (by https://github.com/romainmenke";>@romainmenke). 8.4.29 Fixed Node#source.offset (by https://github.com/idoros";>@idoros). Fixed docs (by https://github.com/coliff";>@coliff). 8.4.28 Fixed Root.source.end for better source map (by https://github.com/romainmenke";>@romainmenke). Fixed Result.root types when process() has no parser. 8.4.27 Fixed Container clone methods types. 8.4.26 Fixed clone methods types. 8.4.25 Improve stringify performance (by https://github.com/romainmenke";>@romainmenke). Fixed docs (by https://github.com/vikaskaliramna07";>@vikaskaliramna07). 8.4.24 Fixed Plugin types. 8.4.23 Fixed warnings in TypeDoc. 8.4.22 Fixed TypeScript support with node16 (by https://github.com/remcohaszing";>@remcohaszing). 8.4.21 Fixed Input#error types (by https://github.com/hudochenkov";>@hudochenkov). 8.4.20 Fixed source map generation for childless at-rules like @layer. 8.4.19 Fixed whitespace preserving after AST transformations (by https://github.com/romainmenke";>@romainmenke). Changelog Sourced from https://github.com/postcss/postcss/blob/main/CHANGELOG.md";>postcss's changelog. 8.4.31 Fixed \r parsing to fix CVE-2023-44270. 8.4.30 Improved source map performance (by Romain Menke). 8.4.29 Fixed Node#source.offset (by Ido Rosenthal). Fixed docs (by Christian Oliff). 8.4.28 Fixed Root.source.end for better source map (by Romain Menke). Fixed Result.root types when process() has no parser. 8.4.27 Fixed Container clone methods types. 8.4.26 Fixed clone methods types. 8.4.25 Improve stringify performance (by Romain Menke). Fixed docs (by https://github.com/vikaskaliramna07";>@vikaskaliramna07). 8.4.24 Fixed Plugin types. 8.4.23 Fixed warnings in TypeDoc. 8.4.22 Fixed TypeScript support with node16 (by Remco Haszing). 8.4.21 Fixed Input#error types (by Aleks Hudochenkov). 8.4.20 Fixed source map generation for childless at-rules like @layer. 8.4.19 Fixed whitespace preserving after AST transformations (by Romain Menke). Commits https://github.com/postcss/postcss/commit/90208de8805dd762596c0028b8637ffbed23e371";>90208de Release 8.4.31 version https://github.com/postcss/postcss/commit/58cc860b4c1707510c9cd1bc1fa30b423a9ad6c5";>58cc860 Fix carrier return parsing https://github.com/postcss/postcss/commit/4fff8e4cdc237619df1d73a444c0a8329701c1e2";>4fff8e4 Improve pnpm test output https://github.com/postcss/postcss/commit/cd43ed123274a92ebc13a1e8cccf1d65b8198f84";>cd43ed1 Update dependencies https://github.com/postcss/postcss/commit/caa916bdcbf66c51321574e2dde112ab13e8b306";>caa916b Update dependencies https://github.com/postcss/postcss/commit/8972f76923e921a3c9655822382039b31b1c8e1a";>8972f76 Typo https://github.com/postcss/postcss/commit/11a5286f781d2a637f2c545c5e9cd661055acaab";>11a5286 Typo https://github.com/postcss/postcss/commit/45c55017776fc61f7815d1ea8e92d5291ca5d6c8";>45c5501 Release 8.4.30 version https://github.com/postcss/postcss/commit/bc3c341f589f9c15f1b56838a33d908374e537e0";>bc3c341 Update linter https://github.com/postcss/postcss/commit/b2be58a2eb788d12474ee1335f8ecdb9fa6225aa";>b2be58a Merge pull request https://redirect.github.com/postcss/postcss/issues/1881";>#1881 from romainmenke/improve-sourcemap-performance--phil... Additional commits viewable in https://github.com/postcss/postcss/compare/8.4.18...8.4.31";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this
[PR] build(deps-dev): bump postcss from 8.4.24 to 8.4.31 in /tobago-theme [myfaces-tobago]
dependabot[bot] opened a new pull request, #4358: URL: https://github.com/apache/myfaces-tobago/pull/4358 Bumps [postcss](https://github.com/postcss/postcss) from 8.4.24 to 8.4.31. Release notes Sourced from https://github.com/postcss/postcss/releases";>postcss's releases. 8.4.31 Fixed \r parsing to fix CVE-2023-44270. 8.4.30 Improved source map performance (by https://github.com/romainmenke";>@romainmenke). 8.4.29 Fixed Node#source.offset (by https://github.com/idoros";>@idoros). Fixed docs (by https://github.com/coliff";>@coliff). 8.4.28 Fixed Root.source.end for better source map (by https://github.com/romainmenke";>@romainmenke). Fixed Result.root types when process() has no parser. 8.4.27 Fixed Container clone methods types. 8.4.26 Fixed clone methods types. 8.4.25 Improve stringify performance (by https://github.com/romainmenke";>@romainmenke). Fixed docs (by https://github.com/vikaskaliramna07";>@vikaskaliramna07). Changelog Sourced from https://github.com/postcss/postcss/blob/main/CHANGELOG.md";>postcss's changelog. 8.4.31 Fixed \r parsing to fix CVE-2023-44270. 8.4.30 Improved source map performance (by Romain Menke). 8.4.29 Fixed Node#source.offset (by Ido Rosenthal). Fixed docs (by Christian Oliff). 8.4.28 Fixed Root.source.end for better source map (by Romain Menke). Fixed Result.root types when process() has no parser. 8.4.27 Fixed Container clone methods types. 8.4.26 Fixed clone methods types. 8.4.25 Improve stringify performance (by Romain Menke). Fixed docs (by https://github.com/vikaskaliramna07";>@vikaskaliramna07). Commits https://github.com/postcss/postcss/commit/90208de8805dd762596c0028b8637ffbed23e371";>90208de Release 8.4.31 version https://github.com/postcss/postcss/commit/58cc860b4c1707510c9cd1bc1fa30b423a9ad6c5";>58cc860 Fix carrier return parsing https://github.com/postcss/postcss/commit/4fff8e4cdc237619df1d73a444c0a8329701c1e2";>4fff8e4 Improve pnpm test output https://github.com/postcss/postcss/commit/cd43ed123274a92ebc13a1e8cccf1d65b8198f84";>cd43ed1 Update dependencies https://github.com/postcss/postcss/commit/caa916bdcbf66c51321574e2dde112ab13e8b306";>caa916b Update dependencies https://github.com/postcss/postcss/commit/8972f76923e921a3c9655822382039b31b1c8e1a";>8972f76 Typo https://github.com/postcss/postcss/commit/11a5286f781d2a637f2c545c5e9cd661055acaab";>11a5286 Typo https://github.com/postcss/postcss/commit/45c55017776fc61f7815d1ea8e92d5291ca5d6c8";>45c5501 Release 8.4.30 version https://github.com/postcss/postcss/commit/bc3c341f589f9c15f1b56838a33d908374e537e0";>bc3c341 Update linter https://github.com/postcss/postcss/commit/b2be58a2eb788d12474ee1335f8ecdb9fa6225aa";>b2be58a Merge pull request https://redirect.github.com/postcss/postcss/issues/1881";>#1881 from romainmenke/improve-sourcemap-performance--phil... Additional commits viewable in https://github.com/postcss/postcss/compare/8.4.24...8.4.31";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unl
Re: [PR] build(deps-dev): bump testcontainers.version from 1.19.0 to 1.19.1 [myfaces-tobago]
henningn merged PR #4356: URL: https://github.com/apache/myfaces-tobago/pull/4356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] build(deps-dev): bump testcontainers.version from 1.19.0 to 1.19.1 [myfaces-tobago]
henningn merged PR #4357: URL: https://github.com/apache/myfaces-tobago/pull/4357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Spec 1829 : Deprecate full state saving (FSS) [myfaces]
volosied commented on PR #618: URL: https://github.com/apache/myfaces/pull/618#issuecomment-1745996464 Need to fix the wording in the warning, but is there anything else to be done here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Spec 1342 : Make Flows Injectable [myfaces]
volosied opened a new pull request, #619: URL: https://github.com/apache/myfaces/pull/619 I think this is the right way to do it? The spec issue also requested conversation scopes to be injectable, but that's done via CDI. See https://docs.jboss.org/weld/reference/2.4.0.CR1/en-US/html/scopescontexts.html#_the_conversation_scope ( 5.3.1) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Spec 1829 : Deprecate full state saving (FSS) [myfaces]
volosied opened a new pull request, #618: URL: https://github.com/apache/myfaces/pull/618 for `https://github.com/jakartaee/faces/issues/1829` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Spec 1764 : Add ExternalContext#setResponseContentLengthLong to API [myfaces]
volosied opened a new pull request, #617: URL: https://github.com/apache/myfaces/pull/617 for `https://github.com/jakartaee/faces/issues/1764` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Spec Issue 1584 - Rely on CDI Class Scanning [myfaces]
volosied commented on PR #615: URL: https://github.com/apache/myfaces/pull/615#issuecomment-1745622796 Alternatively, we keep the config and switch it to false for the failng `FacesConfiguratorDefaultValidatorsTestCase` tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Spec Issue 1584 - Rely on CDI Class Scanning [myfaces]
volosied commented on PR #615: URL: https://github.com/apache/myfaces/pull/615#issuecomment-1745618978 Down to 6 failures: ``` [ERROR] Errors: [ERROR] FacesConfiguratorDefaultValidatorsTestCase.testBeanValidationNotAvailable:213 » NullPointer [ERROR] FacesConfiguratorDefaultValidatorsTestCase.testDefaultBeanValidatorDisabled:186 » NullPointer [ERROR] FacesConfiguratorDefaultValidatorsTestCase.testDefaultBeanValidatorDisabledButPresentInFacesConfig:153 » NullPointer [ERROR] FacesConfiguratorDefaultValidatorsTestCase.testDefaultValidatorsClearedByLatterConfigFileWithEmptyElement:251 » NullPointer [ERROR] FacesConfiguratorDefaultValidatorsTestCase.testDefaultValidatorsNotClearedByLatterConfigFileWithNoElement:292 » NullPointer [ERROR] FacesConfiguratorDefaultValidatorsTestCase.testDefaultValidatorsOverwrittenByLatterConfigFile:333 » NullPointer ``` I'm not sure how to enable CDI in the `AbstractJsfConfigurableMockTestCase` super class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Spec 1789 : Make FacesMessage's VALUES / VALUES_MAP generic [myfaces]
volosied opened a new pull request, #616: URL: https://github.com/apache/myfaces/pull/616 for `https://github.com/jakartaee/faces/issues/1789` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Spec Issue 1584 - Rely on CDI Class Scanning [myfaces]
volosied opened a new pull request, #615: URL: https://github.com/apache/myfaces/pull/615 For `https://github.com/jakartaee/faces/issues/1584` Since CDI scanning is default now, I removed the `USE_CDI_FOR_ANNOTATION_SCANNING` configuration. Question: Should we still have fallbacks 2 & 3? TODO: Create JIRA if one doesn't exist. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] build(deps-dev): bump testcontainers.version from 1.19.0 to 1.19.1 [myfaces-tobago]
dependabot[bot] opened a new pull request, #4357: URL: https://github.com/apache/myfaces-tobago/pull/4357 Bumps `testcontainers.version` from 1.19.0 to 1.19.1. Updates `org.testcontainers:testcontainers` from 1.19.0 to 1.19.1 Release notes Sourced from https://github.com/testcontainers/testcontainers-java/releases";>org.testcontainers:testcontainers's releases. 1.19.1 Testcontainers for Java 1.19.1 Core Allow to define a custom ImagePullPolicy via configuration (https://redirect.github.com/testcontainers/testcontainers-java/issues/7520";>#7520) https://github.com/eddumelendez";>@eddumelendez Override ChainedImageNameSubstitutor toString (https://redirect.github.com/testcontainers/testcontainers-java/issues/7522";>#7522) https://github.com/eddumelendez";>@eddumelendez Log image pull and container startup time independently (https://redirect.github.com/testcontainers/testcontainers-java/issues/7455";>#7455) https://github.com/eddumelendez";>@eddumelendez Modules New https://java.testcontainers.org/modules/minio/";>MinIO module (https://redirect.github.com/testcontainers/testcontainers-java/issues/7440";>#7440) https://github.com/frozenwizard";>@frozenwizard Redpanda Additional listener should inherit the configured authentication method (https://redirect.github.com/testcontainers/testcontainers-java/issues/7594";>#7594) https://github.com/lburgazzoli";>@lburgazzoli What's Changed Migrate examples to junit5 (https://redirect.github.com/testcontainers/testcontainers-java/issues/7417";>#7417) https://github.com/samed-bicer";>@samed-bicer ☠️ Deprecations Deprecate CLI utility methods in RabbitMQ module (https://redirect.github.com/testcontainers/testcontainers-java/issues/7588";>#7588) https://github.com/eddumelendez";>@eddumelendez Deprecate withSecretInVault (https://redirect.github.com/testcontainers/testcontainers-java/issues/7576";>#7576) https://github.com/eddumelendez";>@eddumelendez 📖 Documentation Proposing Update to index.md - Env Settings for Rancher Desktop (https://redirect.github.com/testcontainers/testcontainers-java/issues/7591";>#7591) https://github.com/sunilarjun";>@sunilarjun Add docs for copyFile API (https://redirect.github.com/testcontainers/testcontainers-java/issues/4661";>#4661) https://github.com/kiview";>@kiview Add section for dependency upgrades in PR template (https://redirect.github.com/testcontainers/testcontainers-java/issues/7577";>#7577) https://github.com/eddumelendez";>@eddumelendez [Docs] GCloud: Add BigQuery Client creation (https://redirect.github.com/testcontainers/testcontainers-java/issues/7528";>#7528) https://github.com/fabriciorby";>@fabriciorby Add docs to run Testcontainers using Podman (https://redirect.github.com/testcontainers/testcontainers-java/issues/7447";>#7447) https://github.com/eddumelendez";>@eddumelendez 📦 Dependency updates Combined dependencies PR (https://redirect.github.com/testcontainers/testcontainers-java/issues/7587";>#7587) https://github.com/eddumelendez";>@eddumelendez Update guava version to 32.1.2-jre (https://redirect.github.com/testcontainers/testcontainers-java/issues/7534";>#7534) https://github.com/eddumelendez";>@eddumelendez Combined dependencies PR (https://redirect.github.com/testcontainers/testcontainers-java/issues/7584";>#7584) https://github.com/eddumelendez";>@eddumelendez Combined dependencies PR (https://redirect.github.com/testcontainers/testcontainers-java/issues/7519";>#7519) https://github.com/eddumelendez";>@eddumelendez Combined dependencies PR (https://redirect.github.com/testcontainers/testcontainers-java/issues/7500";>#7500) https://github.com/eddumelendez";>@eddumelendez Combined dependencies PR (https://redirect.github.com/testcontainers/testcontainers-java/issues/7496";>#7496) https://github.com/eddumelendez";>@eddumelendez Combined dependencies PR (https://redirect.github.com/testcontainers/testcontainers-java/issues/7494";>#7494) https://github.com/eddumelendez";>@eddumelendez Commits https://github.com/testcontainers/testcontainers-java/commit/dd1427ebd30bbaba7f32184f1376b7c21e725ab5";>dd1427e Add maven central badge in readme file https://github.com/testcontainers/testcontainers-java/commit/4c83a54331a1de3c4c5a71a6a1e2b617cd704dcb";>4c83a54 Deprecate CLI utility methods in RabbitMQ module (https://redirect.github.com/testcontainers/testcontainers-java/issues/7588";>#7588) https://github.com/testcontainers/testcontainers-java/commit/4296b5beb6cb7e072f63a91b1b70f352e80f3ad9";>4296b5b Additional listeners should inherit the configured authentication method (https://redirect.github.com/testcontainers/testcontainers-java/issues/7594";>#7594) https://github.com/testcontainers/testcontainers-java/commit/202680e8a8dfa42b550df508d4e001e0b01eedbb";>202680e Proposing Upd
[PR] build(deps-dev): bump testcontainers.version from 1.19.0 to 1.19.1 [myfaces-tobago]
dependabot[bot] opened a new pull request, #4356: URL: https://github.com/apache/myfaces-tobago/pull/4356 Bumps `testcontainers.version` from 1.19.0 to 1.19.1. Updates `org.testcontainers:testcontainers` from 1.19.0 to 1.19.1 Release notes Sourced from https://github.com/testcontainers/testcontainers-java/releases";>org.testcontainers:testcontainers's releases. 1.19.1 Testcontainers for Java 1.19.1 Core Allow to define a custom ImagePullPolicy via configuration (https://redirect.github.com/testcontainers/testcontainers-java/issues/7520";>#7520) https://github.com/eddumelendez";>@eddumelendez Override ChainedImageNameSubstitutor toString (https://redirect.github.com/testcontainers/testcontainers-java/issues/7522";>#7522) https://github.com/eddumelendez";>@eddumelendez Log image pull and container startup time independently (https://redirect.github.com/testcontainers/testcontainers-java/issues/7455";>#7455) https://github.com/eddumelendez";>@eddumelendez Modules New https://java.testcontainers.org/modules/minio/";>MinIO module (https://redirect.github.com/testcontainers/testcontainers-java/issues/7440";>#7440) https://github.com/frozenwizard";>@frozenwizard Redpanda Additional listener should inherit the configured authentication method (https://redirect.github.com/testcontainers/testcontainers-java/issues/7594";>#7594) https://github.com/lburgazzoli";>@lburgazzoli What's Changed Migrate examples to junit5 (https://redirect.github.com/testcontainers/testcontainers-java/issues/7417";>#7417) https://github.com/samed-bicer";>@samed-bicer ☠️ Deprecations Deprecate CLI utility methods in RabbitMQ module (https://redirect.github.com/testcontainers/testcontainers-java/issues/7588";>#7588) https://github.com/eddumelendez";>@eddumelendez Deprecate withSecretInVault (https://redirect.github.com/testcontainers/testcontainers-java/issues/7576";>#7576) https://github.com/eddumelendez";>@eddumelendez 📖 Documentation Proposing Update to index.md - Env Settings for Rancher Desktop (https://redirect.github.com/testcontainers/testcontainers-java/issues/7591";>#7591) https://github.com/sunilarjun";>@sunilarjun Add docs for copyFile API (https://redirect.github.com/testcontainers/testcontainers-java/issues/4661";>#4661) https://github.com/kiview";>@kiview Add section for dependency upgrades in PR template (https://redirect.github.com/testcontainers/testcontainers-java/issues/7577";>#7577) https://github.com/eddumelendez";>@eddumelendez [Docs] GCloud: Add BigQuery Client creation (https://redirect.github.com/testcontainers/testcontainers-java/issues/7528";>#7528) https://github.com/fabriciorby";>@fabriciorby Add docs to run Testcontainers using Podman (https://redirect.github.com/testcontainers/testcontainers-java/issues/7447";>#7447) https://github.com/eddumelendez";>@eddumelendez 📦 Dependency updates Combined dependencies PR (https://redirect.github.com/testcontainers/testcontainers-java/issues/7587";>#7587) https://github.com/eddumelendez";>@eddumelendez Update guava version to 32.1.2-jre (https://redirect.github.com/testcontainers/testcontainers-java/issues/7534";>#7534) https://github.com/eddumelendez";>@eddumelendez Combined dependencies PR (https://redirect.github.com/testcontainers/testcontainers-java/issues/7584";>#7584) https://github.com/eddumelendez";>@eddumelendez Combined dependencies PR (https://redirect.github.com/testcontainers/testcontainers-java/issues/7519";>#7519) https://github.com/eddumelendez";>@eddumelendez Combined dependencies PR (https://redirect.github.com/testcontainers/testcontainers-java/issues/7500";>#7500) https://github.com/eddumelendez";>@eddumelendez Combined dependencies PR (https://redirect.github.com/testcontainers/testcontainers-java/issues/7496";>#7496) https://github.com/eddumelendez";>@eddumelendez Combined dependencies PR (https://redirect.github.com/testcontainers/testcontainers-java/issues/7494";>#7494) https://github.com/eddumelendez";>@eddumelendez Commits https://github.com/testcontainers/testcontainers-java/commit/dd1427ebd30bbaba7f32184f1376b7c21e725ab5";>dd1427e Add maven central badge in readme file https://github.com/testcontainers/testcontainers-java/commit/4c83a54331a1de3c4c5a71a6a1e2b617cd704dcb";>4c83a54 Deprecate CLI utility methods in RabbitMQ module (https://redirect.github.com/testcontainers/testcontainers-java/issues/7588";>#7588) https://github.com/testcontainers/testcontainers-java/commit/4296b5beb6cb7e072f63a91b1b70f352e80f3ad9";>4296b5b Additional listeners should inherit the configured authentication method (https://redirect.github.com/testcontainers/testcontainers-java/issues/7594";>#7594) https://github.com/testcontainers/testcontainers-java/commit/202680e8a8dfa42b550df508d4e001e0b01eedbb";>202680e Proposing Upd
[jira] [Resolved] (MYFACES-4630) Compressed Files Necessary in 4.0 API?
[ https://issues.apache.org/jira/browse/MYFACES-4630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Werner Punz resolved MYFACES-4630. -- Fix Version/s: 4.0.2 Resolution: Fixed merge pull request form [~volosied] > Compressed Files Necessary in 4.0 API? > -- > > Key: MYFACES-4630 > URL: https://issues.apache.org/jira/browse/MYFACES-4630 > Project: MyFaces Core > Issue Type: Improvement >Affects Versions: 4.0.1 >Reporter: Volodymyr Siedlecki >Assignee: Werner Punz >Priority: Major > Fix For: 4.0.2 > > > The API contains the following files: > META-INF/resources/jakarta.faces/faces.js.br > META-INF/resources/jakarta.faces/faces-development.js.br > META-INF/resources/jakarta.faces/faces.js > META-INF/resources/jakarta.faces/faces-development.js.map > META-INF/resources/jakarta.faces/faces-development.js > META-INF/resources/jakarta.faces/faces.js.gz > META-INF/resources/jakarta.faces/faces.js.map > META-INF/resources/jakarta.faces/faces-development.js.gz > Is it necessary to have the .br, .map, and .gz files? If not, could we > remove them to reduce the API size by a bit? > Thanks! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MYFACES-4630 [myfaces]
volosied merged PR #613: URL: https://github.com/apache/myfaces/pull/613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] MYFACES-4631 [myfaces]
volosied opened a new pull request, #614: URL: https://github.com/apache/myfaces/pull/614 https://issues.apache.org/jira/browse/MYFACES-4631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MYFACES-4630 [myfaces]
werpu commented on PR #613: URL: https://github.com/apache/myfaces/pull/613#issuecomment-1745124779 merging it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MYFACES-4631) DuplicateIdExceptiona via addComponentResource
Volodymyr Siedlecki created MYFACES-4631: Summary: DuplicateIdExceptiona via addComponentResource Key: MYFACES-4631 URL: https://issues.apache.org/jira/browse/MYFACES-4631 Project: MyFaces Core Issue Type: Bug Affects Versions: 4.0.1, 2.3-next-M8, 3.0.2, 2.3.10 Reporter: Volodymyr Siedlecki See Bug Report here: [https://github.com/primefaces-extensions/primefaces-extensions/issues/517] [https://github.com/omnifaces/omnifaces/wiki/Combine-hardcoded-PrimeFaces-resources-using-CombinedResourceHandler] See comment here for root cause: [https://github.com/primefaces-extensions/primefaces-extensions/issues/517#issuecomment-1688911766] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] MYFACES-4630 [myfaces]
volosied opened a new pull request, #613: URL: https://github.com/apache/myfaces/pull/613 https://issues.apache.org/jira/browse/MYFACES-4630 With compressed files: **1392771** Oct 3 09:55 myfaces-api-4.0.2-SNAPSHOT.jar Without: **1201276** Oct 3 09:58 myfaces-api-4.0.2-SNAPSHOT.jar About a 14% decrease. Remaining files would be: META-INF/resources/jakarta.faces/faces.js META-INF/resources/jakarta.faces/faces-development.js.map META-INF/resources/jakarta.faces/faces-development.js META-INF/resources/jakarta.faces/faces.js.map -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MYFACES-4536) PartialResponseWriter: Do no wrap the writer
[
https://issues.apache.org/jira/browse/MYFACES-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771486#comment-17771486
]
Melloware commented on MYFACES-4536:
Thanks for your help! Got to the bottom of it! See my PR and I think all our
integration tests are passing again!
[https://github.com/primefaces/primefaces/pull/10759]
Basically had to get rid of our Wrapper as it was not doing anything and extend
PartialResponseWriter directly. Then I had to make our CSPPartial extend our
PrimePartial so `endDocument` was called correctly.
> PartialResponseWriter: Do no wrap the writer
>
>
> Key: MYFACES-4536
> URL: https://issues.apache.org/jira/browse/MYFACES-4536
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
>Affects Versions: 2.2.14, 2.3.10, 2.3-next-M7, 4.0.0-RC2
>Reporter: Melloware
>Assignee: Werner Punz
>Priority: Major
> Attachments: csp-results.zip, image-2023-10-02-20-33-05-162.png,
> mojarra-csp-new.txt
>
>
> Per BalusC:
> Since JSF 2.3 the default constructor of {{FacesWrapper}} subclasses has been
> deprecated in order to force implementors to instead use the constructor
> taking the wrapped instance (and to raise their awareness), so that logically
> the inherited {{getWrapped()}} method will be used throughout the
> implementation instead of the local {{wrapped}} variable. This will ensure
> that the correct implementation is returned and correct behavior is performed
> might the {{FacesWrapper}} implementation itself being wrapped by yet another
> {{FacesWrapper}} implementation further down the chain. Because, when the
> {{FacesWrapper}} implementation incorrectly/accidentally uses the local
> {{wrapped}} variable instead of the {{getWrapped()}} method, then that other
> {{FacesWrapper}} implementation will basically be completely ignored, hereby
> breaking the decorator pattern.
>
> PrimeFaces ticket: https://github.com/primefaces/primefaces/issues/9518
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4630) Compressed Files Necessary in 4.0 API?
[ https://issues.apache.org/jira/browse/MYFACES-4630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771338#comment-17771338 ] Werner Punz edited comment on MYFACES-4630 at 10/3/23 12:42 PM: No they are more a goody than anything else, you do not necessarily need them, they might save a little bit of bandwith though (not that important but it was a low hanging fruit), you can turn the build off in the webpack file by taking out the plugins which produce them! Shall we turn them off, saves a little bit of space? The map files are mandatory however! Otherwise debugging the scripts wont work (aka wont show the typscript sources during debugging instead of the js sources)! I would not recommend to turn them off for the development version, having a working debugging possibility which shows the typescripts is a must! was (Author: werpu): No they are more a goody than anything else, you do not necessarily need them, they might save a little bit of bandwith though (not that important but it was a low hanging fruit), you can turn the build off in the node file! Shall we turn them off, saves a little bit of space? The map files are mandatory however! Otherwise debugging the scripts wont work (aka wont show the typscript sources during debugging instead of the js sources)! I would not recommend to turn them off for the development version, having a working debugging possibility which shows the typescripts is a must! > Compressed Files Necessary in 4.0 API? > -- > > Key: MYFACES-4630 > URL: https://issues.apache.org/jira/browse/MYFACES-4630 > Project: MyFaces Core > Issue Type: Improvement >Affects Versions: 4.0.1 >Reporter: Volodymyr Siedlecki >Assignee: Werner Punz >Priority: Major > > The API contains the following files: > META-INF/resources/jakarta.faces/faces.js.br > META-INF/resources/jakarta.faces/faces-development.js.br > META-INF/resources/jakarta.faces/faces.js > META-INF/resources/jakarta.faces/faces-development.js.map > META-INF/resources/jakarta.faces/faces-development.js > META-INF/resources/jakarta.faces/faces.js.gz > META-INF/resources/jakarta.faces/faces.js.map > META-INF/resources/jakarta.faces/faces-development.js.gz > Is it necessary to have the .br, .map, and .gz files? If not, could we > remove them to reduce the API size by a bit? > Thanks! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4536) PartialResponseWriter: Do no wrap the writer
[
https://issues.apache.org/jira/browse/MYFACES-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771458#comment-17771458
]
Werner Punz edited comment on MYFACES-4536 at 10/3/23 12:21 PM:
Ok I will alter my test accordingly, lets see!
Still passing:
[https://gist.github.com/werpu/93e05f0cba260be33349afec8564c9d9]
Is producing:
{code:java}
{code}
So no swallowed eval! So, neither the partial response writer nor the
HTMLResponseWriterImpl produce this problem (those are the ones which are in
the chain)
was (Author: werpu):
Ok I will alter my test accordingly, lets see!
Still passing:
[https://gist.github.com/werpu/93e05f0cba260be33349afec8564c9d9]
Is producing:
{code:java}
{code}
So no swallowed eval!
> PartialResponseWriter: Do no wrap the writer
>
>
> Key: MYFACES-4536
> URL: https://issues.apache.org/jira/browse/MYFACES-4536
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
>Affects Versions: 2.2.14, 2.3.10, 2.3-next-M7, 4.0.0-RC2
>Reporter: Melloware
>Assignee: Werner Punz
>Priority: Major
> Attachments: csp-results.zip, image-2023-10-02-20-33-05-162.png,
> mojarra-csp-new.txt
>
>
> Per BalusC:
> Since JSF 2.3 the default constructor of {{FacesWrapper}} subclasses has been
> deprecated in order to force implementors to instead use the constructor
> taking the wrapped instance (and to raise their awareness), so that logically
> the inherited {{getWrapped()}} method will be used throughout the
> implementation instead of the local {{wrapped}} variable. This will ensure
> that the correct implementation is returned and correct behavior is performed
> might the {{FacesWrapper}} implementation itself being wrapped by yet another
> {{FacesWrapper}} implementation further down the chain. Because, when the
> {{FacesWrapper}} implementation incorrectly/accidentally uses the local
> {{wrapped}} variable instead of the {{getWrapped()}} method, then that other
> {{FacesWrapper}} implementation will basically be completely ignored, hereby
> breaking the decorator pattern.
>
> PrimeFaces ticket: https://github.com/primefaces/primefaces/issues/9518
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4536) PartialResponseWriter: Do no wrap the writer
[
https://issues.apache.org/jira/browse/MYFACES-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771458#comment-17771458
]
Werner Punz edited comment on MYFACES-4536 at 10/3/23 12:18 PM:
Ok I will alter my test accordingly, lets see!
Still passing:
[https://gist.github.com/werpu/93e05f0cba260be33349afec8564c9d9]
Is producing:
{code:java}
{code}
So no swallowed eval!
was (Author: werpu):
Ok I will alter my test accordingly, lets see!
> PartialResponseWriter: Do no wrap the writer
>
>
> Key: MYFACES-4536
> URL: https://issues.apache.org/jira/browse/MYFACES-4536
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
>Affects Versions: 2.2.14, 2.3.10, 2.3-next-M7, 4.0.0-RC2
>Reporter: Melloware
>Assignee: Werner Punz
>Priority: Major
> Attachments: csp-results.zip, image-2023-10-02-20-33-05-162.png,
> mojarra-csp-new.txt
>
>
> Per BalusC:
> Since JSF 2.3 the default constructor of {{FacesWrapper}} subclasses has been
> deprecated in order to force implementors to instead use the constructor
> taking the wrapped instance (and to raise their awareness), so that logically
> the inherited {{getWrapped()}} method will be used throughout the
> implementation instead of the local {{wrapped}} variable. This will ensure
> that the correct implementation is returned and correct behavior is performed
> might the {{FacesWrapper}} implementation itself being wrapped by yet another
> {{FacesWrapper}} implementation further down the chain. Because, when the
> {{FacesWrapper}} implementation incorrectly/accidentally uses the local
> {{wrapped}} variable instead of the {{getWrapped()}} method, then that other
> {{FacesWrapper}} implementation will basically be completely ignored, hereby
> breaking the decorator pattern.
>
> PrimeFaces ticket: https://github.com/primefaces/primefaces/issues/9518
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4536) PartialResponseWriter: Do no wrap the writer
[
https://issues.apache.org/jira/browse/MYFACES-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771458#comment-17771458
]
Werner Punz commented on MYFACES-4536:
--
Ok I will alter my test accordingly, lets see!
> PartialResponseWriter: Do no wrap the writer
>
>
> Key: MYFACES-4536
> URL: https://issues.apache.org/jira/browse/MYFACES-4536
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
>Affects Versions: 2.2.14, 2.3.10, 2.3-next-M7, 4.0.0-RC2
>Reporter: Melloware
>Assignee: Werner Punz
>Priority: Major
> Attachments: csp-results.zip, image-2023-10-02-20-33-05-162.png,
> mojarra-csp-new.txt
>
>
> Per BalusC:
> Since JSF 2.3 the default constructor of {{FacesWrapper}} subclasses has been
> deprecated in order to force implementors to instead use the constructor
> taking the wrapped instance (and to raise their awareness), so that logically
> the inherited {{getWrapped()}} method will be used throughout the
> implementation instead of the local {{wrapped}} variable. This will ensure
> that the correct implementation is returned and correct behavior is performed
> might the {{FacesWrapper}} implementation itself being wrapped by yet another
> {{FacesWrapper}} implementation further down the chain. Because, when the
> {{FacesWrapper}} implementation incorrectly/accidentally uses the local
> {{wrapped}} variable instead of the {{getWrapped()}} method, then that other
> {{FacesWrapper}} implementation will basically be completely ignored, hereby
> breaking the decorator pattern.
>
> PrimeFaces ticket: https://github.com/primefaces/primefaces/issues/9518
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4536) PartialResponseWriter: Do no wrap the writer
[
https://issues.apache.org/jira/browse/MYFACES-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771454#comment-17771454
]
Melloware commented on MYFACES-4536:
I see the difference between your code and PrimeFaces code. Your code is
directly calling
{code:java}
_writer.startElement("eval", null); {code}
In PrimeFaces we have a PrimePartialResponseWriter that does this...
{code:java}
@Override
public void startEval() throws IOException {
startMetadataIfNecessary();
super.startEval();
} {code}
Then our code when its encoding is calling the Myfaces startEval and endEval()
directly its not calling start and end element.
{code:java}
protected void encodeScripts(PrimeRequestContext requestContext) throws
IOException {
List initScripts = requestContext.getInitScriptsToExecute();
List scripts = requestContext.getScriptsToExecute();
if (!initScripts.isEmpty() || !scripts.isEmpty()) {
startEval(); // START EVAL inherited
for (int i = 0; i < initScripts.size(); i++) {
getWrapped().write(initScripts.get(i));getWrapped().write(';');
}
for (int i = 0; i < scripts.size(); i++) {
getWrapped().write(scripts.get(i));
getWrapped().write(';');}
endEval(); // START EVAL inherited
}
} {code}
> PartialResponseWriter: Do no wrap the writer
>
>
> Key: MYFACES-4536
> URL: https://issues.apache.org/jira/browse/MYFACES-4536
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
>Affects Versions: 2.2.14, 2.3.10, 2.3-next-M7, 4.0.0-RC2
>Reporter: Melloware
>Assignee: Werner Punz
>Priority: Major
> Attachments: csp-results.zip, image-2023-10-02-20-33-05-162.png,
> mojarra-csp-new.txt
>
>
> Per BalusC:
> Since JSF 2.3 the default constructor of {{FacesWrapper}} subclasses has been
> deprecated in order to force implementors to instead use the constructor
> taking the wrapped instance (and to raise their awareness), so that logically
> the inherited {{getWrapped()}} method will be used throughout the
> implementation instead of the local {{wrapped}} variable. This will ensure
> that the correct implementation is returned and correct behavior is performed
> might the {{FacesWrapper}} implementation itself being wrapped by yet another
> {{FacesWrapper}} implementation further down the chain. Because, when the
> {{FacesWrapper}} implementation incorrectly/accidentally uses the local
> {{wrapped}} variable instead of the {{getWrapped()}} method, then that other
> {{FacesWrapper}} implementation will basically be completely ignored, hereby
> breaking the decorator pattern.
>
> PrimeFaces ticket: https://github.com/primefaces/primefaces/issues/9518
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4536) PartialResponseWriter: Do no wrap the writer
[
https://issues.apache.org/jira/browse/MYFACES-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771441#comment-17771441
]
Melloware commented on MYFACES-4536:
Let me do some more debugging and report back!
> PartialResponseWriter: Do no wrap the writer
>
>
> Key: MYFACES-4536
> URL: https://issues.apache.org/jira/browse/MYFACES-4536
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
>Affects Versions: 2.2.14, 2.3.10, 2.3-next-M7, 4.0.0-RC2
>Reporter: Melloware
>Assignee: Werner Punz
>Priority: Major
> Attachments: csp-results.zip, image-2023-10-02-20-33-05-162.png,
> mojarra-csp-new.txt
>
>
> Per BalusC:
> Since JSF 2.3 the default constructor of {{FacesWrapper}} subclasses has been
> deprecated in order to force implementors to instead use the constructor
> taking the wrapped instance (and to raise their awareness), so that logically
> the inherited {{getWrapped()}} method will be used throughout the
> implementation instead of the local {{wrapped}} variable. This will ensure
> that the correct implementation is returned and correct behavior is performed
> might the {{FacesWrapper}} implementation itself being wrapped by yet another
> {{FacesWrapper}} implementation further down the chain. Because, when the
> {{FacesWrapper}} implementation incorrectly/accidentally uses the local
> {{wrapped}} variable instead of the {{getWrapped()}} method, then that other
> {{FacesWrapper}} implementation will basically be completely ignored, hereby
> breaking the decorator pattern.
>
> PrimeFaces ticket: https://github.com/primefaces/primefaces/issues/9518
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
