[TRINIDAD] testBinaryCompatibility build error

2010-11-08 Thread Jeanne Waldman
Hi,
I got this error while building for my Skin Versioning patch.
testBinaryCompatibility(org.apache.myfaces.trinidad.ClirrRunnerTest)

I built the other day and it was fine.

Did someone add a new test? I did add some new APIs.
What do I have to do to get this to pass? Looking at the ClirrRunnerTest 
file didn't give me any information.

Thanks,
Jeanne


Re: [TRINIDAD] testBinaryCompatibility build error

2010-11-08 Thread Blake Sullivan

Jeanne,

This is the result of the api checks for backwards compatibility.  The 
trinidad-api/src/test/clirr/clirr-runner.txt file acts as a golden file 
for allowed api changes.  If your test fails, the target directory will 
contain the clirr-runner.txt file of all of the api changes found.  You 
can then diff the two files and add any api changes that should be 
allowed to the golden file.


Unfortunately, based on the signatures present in the clirr-runner.txt, 
it looks like clirr is detecting any change, including changes that 
would not affect backwards compatibility, making the feature kind of a pain.


-- Blake Sullivan

On 11/8/10 3:58 PM, Jeanne Waldman wrote:

Hi,
I got this error while building for my Skin Versioning patch.
testBinaryCompatibility(org.apache.myfaces.trinidad.ClirrRunnerTest)

I built the other day and it was fine.

Did someone add a new test? I did add some new APIs.
What do I have to do to get this to pass? Looking at the ClirrRunnerTest
file didn't give me any information.

Thanks,
Jeanne




Re: [TRINIDAD] testBinaryCompatibility build error

2010-11-08 Thread Matthias Wessendorf
Jeanne,

Was there an INFO diff?
Perhaps I should change it to ERROR only ..

-M

sent from my Android phone
On Nov 9, 2010 2:46 AM, Blake Sullivan blake.sulli...@oracle.com wrote:
 Jeanne,

 This is the result of the api checks for backwards compatibility. The
 trinidad-api/src/test/clirr/clirr-runner.txt file acts as a golden file
 for allowed api changes. If your test fails, the target directory will
 contain the clirr-runner.txt file of all of the api changes found. You
 can then diff the two files and add any api changes that should be
 allowed to the golden file.

 Unfortunately, based on the signatures present in the clirr-runner.txt,
 it looks like clirr is detecting any change, including changes that
 would not affect backwards compatibility, making the feature kind of a
pain.

 -- Blake Sullivan

 On 11/8/10 3:58 PM, Jeanne Waldman wrote:
 Hi,
 I got this error while building for my Skin Versioning patch.
 testBinaryCompatibility(org.apache.myfaces.trinidad.ClirrRunnerTest)

 I built the other day and it was fine.

 Did someone add a new test? I did add some new APIs.
 What do I have to do to get this to pass? Looking at the ClirrRunnerTest
 file didn't give me any information.

 Thanks,
 Jeanne