[jira] [Comment Edited] (MYFACES-4610) Fix for issuing element key:value combination breaks Tobago
[ https://issues.apache.org/jira/browse/MYFACES-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740879#comment-17740879 ] Werner Punz edited comment on MYFACES-4610 at 7/7/23 5:32 AM: -- The old code is not affected by it, I did the determination of the origin slightly different there in my fix, am not sure which approach is better, but for now the changes I will do in the old branches are just fixing the id issue so that it starts with a 1 instead of 0 in the identifier number postfix for hidden fields. (the second issue which was discussed recently ) was (Author: werpu): The old code is not affected by it, I did the determination of the origin slightly different there in my fix, am not sure which approach is better, but for now the changes I will do in the old branches are just fixing the id issue so that it starts with a 1 instead of 0 in the identifier number postfix for hidden fields. (the second issue which was discussed recently) > Fix for issuing element key:value combination breaks Tobago > --- > > Key: MYFACES-4610 > URL: https://issues.apache.org/jira/browse/MYFACES-4610 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 3.0.2, 2.3-next-M8, 4.0.2 >Reporter: Werner Punz >Assignee: Werner Punz >Priority: Major > > This is a follow up issue caused by the fix for > https://issues.apache.org/jira/browse/MYFACES-4606 > raised by the Tobago guys. > The fix broke one of their testcases! > [https://github.com/henningn/myfaces-tobago.git] > 4 checkboxes on the page, example does not work anymore because > * git checkout jsfjs_next_gen402 > * mvn clean install > * cd tobago-example/tobago-example-demo > * mvn clean -Pdev -Pjetty jetty:run > * open > [http://localhost:8080/content/030-select/50-selectManyCheckbox/Multi_Checkbox.xhtml] > The request adds the issuing element with a null value! > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4610) Fix for issuing element key:value combination breaks Tobago
[ https://issues.apache.org/jira/browse/MYFACES-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740879#comment-17740879 ] Werner Punz edited comment on MYFACES-4610 at 7/7/23 5:32 AM: -- The old code is not affected by it, I did the determination of the origin slightly different there in my fix, am not sure which approach is better, but for now the changes I will do in the old branches are just fixing the id issue so that it starts with a 1 instead of 0 in the identifier number postfix for hidden fields. (the second issue which was discussed recently https://issues.apache.org/jira/browse/MYFACES-4606) was (Author: werpu): The old code is not affected by it, I did the determination of the origin slightly different there in my fix, am not sure which approach is better, but for now the changes I will do in the old branches are just fixing the id issue so that it starts with a 1 instead of 0 in the identifier number postfix for hidden fields. (the second issue which was discussed recently ) > Fix for issuing element key:value combination breaks Tobago > --- > > Key: MYFACES-4610 > URL: https://issues.apache.org/jira/browse/MYFACES-4610 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 3.0.2, 2.3-next-M8, 4.0.2 >Reporter: Werner Punz >Assignee: Werner Punz >Priority: Major > > This is a follow up issue caused by the fix for > https://issues.apache.org/jira/browse/MYFACES-4606 > raised by the Tobago guys. > The fix broke one of their testcases! > [https://github.com/henningn/myfaces-tobago.git] > 4 checkboxes on the page, example does not work anymore because > * git checkout jsfjs_next_gen402 > * mvn clean install > * cd tobago-example/tobago-example-demo > * mvn clean -Pdev -Pjetty jetty:run > * open > [http://localhost:8080/content/030-select/50-selectManyCheckbox/Multi_Checkbox.xhtml] > The request adds the issuing element with a null value! > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4610) Fix for issuing element key:value combination breaks Tobago
[ https://issues.apache.org/jira/browse/MYFACES-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740879#comment-17740879 ] Werner Punz edited comment on MYFACES-4610 at 7/7/23 5:32 AM: -- The old code is not affected by it, I did the determination of the origin slightly different there in my fix, am not sure which approach is better, but for now the changes I will do in the old branches are just fixing the id issue so that it starts with a 1 instead of 0 in the identifier number postfix for hidden fields. (the second issue which was discussed recently https://issues.apache.org/jira/browse/MYFACES-4605) was (Author: werpu): The old code is not affected by it, I did the determination of the origin slightly different there in my fix, am not sure which approach is better, but for now the changes I will do in the old branches are just fixing the id issue so that it starts with a 1 instead of 0 in the identifier number postfix for hidden fields. (the second issue which was discussed recently https://issues.apache.org/jira/browse/MYFACES-4606) > Fix for issuing element key:value combination breaks Tobago > --- > > Key: MYFACES-4610 > URL: https://issues.apache.org/jira/browse/MYFACES-4610 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 3.0.2, 2.3-next-M8, 4.0.2 >Reporter: Werner Punz >Assignee: Werner Punz >Priority: Major > > This is a follow up issue caused by the fix for > https://issues.apache.org/jira/browse/MYFACES-4606 > raised by the Tobago guys. > The fix broke one of their testcases! > [https://github.com/henningn/myfaces-tobago.git] > 4 checkboxes on the page, example does not work anymore because > * git checkout jsfjs_next_gen402 > * mvn clean install > * cd tobago-example/tobago-example-demo > * mvn clean -Pdev -Pjetty jetty:run > * open > [http://localhost:8080/content/030-select/50-selectManyCheckbox/Multi_Checkbox.xhtml] > The request adds the issuing element with a null value! > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4610) Fix for issuing element key:value combination breaks Tobago
[ https://issues.apache.org/jira/browse/MYFACES-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737688#comment-17737688 ] Werner Punz edited comment on MYFACES-4610 at 6/27/23 3:19 PM: --- The issue here is indeed the fix we added recently that a key value pair of the issuing element is added. The problem here is that the issuing element has the same id (the virtual element tobago-select-many-checkbox but has no value, to make matters worse the embedded real inputs have the same name as the input elements id: Fix for issuing element key:value combination breaks Tobago > --- > > Key: MYFACES-4610 > URL: https://issues.apache.org/jira/browse/MYFACES-4610 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 3.0.2, 2.3-next-M8, 4.0.2 >Reporter: Werner Punz >Assignee: Werner Punz >Priority: Major > > This is a follow up issue caused by the fix for > https://issues.apache.org/jira/browse/MYFACES-4606 > raised by the Tobago guys. > The fix broke one of their testcases! > [https://github.com/henningn/myfaces-tobago.git] > 4 checkboxes on the page, example does not work anymore because > * git checkout jsfjs_next_gen402 > * mvn clean install > * cd tobago-example/tobago-example-demo > * mvn clean -Pdev -Pjetty jetty:run > * open > [http://localhost:8080/content/030-select/50-selectManyCheckbox/Multi_Checkbox.xhtml] > The request adds the issuing element with a null value! > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4610) Fix for issuing element key:value combination breaks Tobago
[ https://issues.apache.org/jira/browse/MYFACES-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737688#comment-17737688 ] Werner Punz edited comment on MYFACES-4610 at 6/27/23 2:32 PM: --- The issue here is indeed the fix we added recently that a key value pair of the issuing element is added. The problem here is that the issuing element has the same id (the virtual element tobago-select-many-checkbox but has no value, to make matters worse the embedded real inputs have the same name as the input elements id: Fix for issuing element key:value combination breaks Tobago > --- > > Key: MYFACES-4610 > URL: https://issues.apache.org/jira/browse/MYFACES-4610 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 3.0.2, 2.3-next-M8, 4.0.2 >Reporter: Werner Punz >Assignee: Werner Punz >Priority: Major > > This is a follow up issue caused by the fix for > https://issues.apache.org/jira/browse/MYFACES-4606 > raised by the Tobago guys. > The fix broke one of their testcases! > [https://github.com/henningn/myfaces-tobago.git] > 4 checkboxes on the page, example does not work anymore because > * git checkout jsfjs_next_gen402 > * mvn clean install > * cd tobago-example/tobago-example-demo > * mvn clean -Pdev -Pjetty jetty:run > * open > [http://localhost:8080/content/030-select/50-selectManyCheckbox/Multi_Checkbox.xhtml] > The request adds the issuing element with a null value! > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)