RE: Patch Branch?
Does anyone know how I can see all the commits I have made since the 1.1.4 release? I'm running cardemo as a portlet on the same page as another JSF portlet. This causes cardemo to break with 1.1.4.1. 1.1.4 Works 1.1.5 Works 1.1.4.1 Breaks Wendy, I assume the patch branch is exactly what was released with 1.1.4 including the shared_impl that went with it? Stan Silvert JBoss, a division of RedHat [EMAIL PROTECTED] -Original Message- From: Stan Silvert [mailto:[EMAIL PROTECTED] Sent: Sunday, January 07, 2007 11:40 PM To: MyFaces Development Subject: RE: Patch Branch? Awesome. I'll apply the patch on Sunday. That didn't go very well. 1.1.5 snapshot works, but not 1.1.4.1 with the patch. I think it's just my environment, but it will probably be a couple of days before I commit this. Stan Silvert JBoss, a division of RedHat [EMAIL PROTECTED] -Original Message- From: Wendy Smoak [mailto:[EMAIL PROTECTED] Sent: Friday, January 05, 2007 10:35 PM To: MyFaces Development Subject: Re: Patch Branch? On 1/5/07, Stan Silvert [EMAIL PROTECTED] wrote: Stan, do you have the JIRA issue and svn revision(s) for the portlet bug fix? I need to know if it affects Shared or just Core. It's just core. http://issues.apache.org/jira/browse/MYFACES-1481 OK, then we can use the released Shared 2.0.3 with it. There having been no objections voiced so far... here's the branch: http://svn.apache.org/repos/asf/myfaces/core/branches/1_1_4_1/ And the release plan: http://wiki.apache.org/myfaces/CoreRelease1141 I added a JIRA version for 1.1.4.1-SNAPSHOT and moved MYFACES-1481 to it. It's ready for someone to apply the fix to the branch, and update the license headers. I'm not sure what in what order those would go best; I'm hoping the relevant commits can be merged to the branch, but I'm not familiar enough with the code to attempt it. Instructions for publishing snapshots (and fixing permissions afterwards) are at the bottom of the release plan. I'll keep an eye on this, but starting next week I won't be available as much during the day. -- Wendy
Re: Patch Branch?
On 1/8/07, Jeff Bischoff [EMAIL PROTECTED] wrote: What will be the compatibility situation between Myfaces Core 1.1.4.1 and Tomahawk 1.1.4/1.1.5? Any trivial fixes we can backport to improve this? I expect 1.1.4.1 to have the same compatibility as 1.1.4. I'd like to keep 1.1.4.1 tightly focused on Stan's portlet issue, and then we can take a look at the 1.1.5 situation and decide whether we need a 1.1.4.2. -- Wendy
Re: Patch Branch?
On 1/9/07, Stan Silvert [EMAIL PROTECTED] wrote: Does anyone know how I can see all the commits I have made since the 1.1.4 release? 1.1.4 was tagged on 9/10. I see four commits from you after that: http://issues.apache.org/jira/browse/MYFACES-660 http://svn.apache.org/viewvc?view=revrev=477350 11/20 https://issues.apache.org/jira/browse/MYFACES-1481 http://svn.apache.org/viewvc?view=revrev=473527 11/10 http://svn.apache.org/viewvc?view=revrev=473555 11/10 http://svn.apache.org/viewvc?view=revrev=485877 12/11 I'm running cardemo as a portlet on the same page as another JSF portlet. This causes cardemo to break with 1.1.4.1. 1.1.4 Works 1.1.5 Works 1.1.4.1 Breaks Wendy, I assume the patch branch is exactly what was released with 1.1.4 including the shared_impl that went with it? That's odd. 1.1.4.1 was copied from the 1.1.4 tag. If you haven't made any changes it should be exactly the same. The only commits I see on the branch are mine: http://svn.apache.org/viewvc?view=revrev=493274 (branch) http://svn.apache.org/viewvc?view=revrev=493277 (update version numbers) So yes, it's pointed at the same Shared 2.0.3 version that 1.1.4 used. -- Wendy
Re: Patch Branch?
Awesome. What will be the compatibility situation between Myfaces Core 1.1.4.1 and Tomahawk 1.1.4/1.1.5? Any trivial fixes we can backport to improve this? Regards, Jeff Bischoff Kenneth L Kurz Associates, Inc. Wendy Smoak wrote: On 1/5/07, Stan Silvert [EMAIL PROTECTED] wrote: Stan, do you have the JIRA issue and svn revision(s) for the portlet bug fix? I need to know if it affects Shared or just Core. It's just core. http://issues.apache.org/jira/browse/MYFACES-1481 OK, then we can use the released Shared 2.0.3 with it. There having been no objections voiced so far... here's the branch: http://svn.apache.org/repos/asf/myfaces/core/branches/1_1_4_1/ And the release plan: http://wiki.apache.org/myfaces/CoreRelease1141 I added a JIRA version for 1.1.4.1-SNAPSHOT and moved MYFACES-1481 to it. It's ready for someone to apply the fix to the branch, and update the license headers. I'm not sure what in what order those would go best; I'm hoping the relevant commits can be merged to the branch, but I'm not familiar enough with the code to attempt it. Instructions for publishing snapshots (and fixing permissions afterwards) are at the bottom of the release plan. I'll keep an eye on this, but starting next week I won't be available as much during the day.
RE: Patch Branch?
Awesome. I'll apply the patch on Sunday. That didn't go very well. 1.1.5 snapshot works, but not 1.1.4.1 with the patch. I think it's just my environment, but it will probably be a couple of days before I commit this. Stan Silvert JBoss, a division of RedHat [EMAIL PROTECTED] -Original Message- From: Wendy Smoak [mailto:[EMAIL PROTECTED] Sent: Friday, January 05, 2007 10:35 PM To: MyFaces Development Subject: Re: Patch Branch? On 1/5/07, Stan Silvert [EMAIL PROTECTED] wrote: Stan, do you have the JIRA issue and svn revision(s) for the portlet bug fix? I need to know if it affects Shared or just Core. It's just core. http://issues.apache.org/jira/browse/MYFACES-1481 OK, then we can use the released Shared 2.0.3 with it. There having been no objections voiced so far... here's the branch: http://svn.apache.org/repos/asf/myfaces/core/branches/1_1_4_1/ And the release plan: http://wiki.apache.org/myfaces/CoreRelease1141 I added a JIRA version for 1.1.4.1-SNAPSHOT and moved MYFACES-1481 to it. It's ready for someone to apply the fix to the branch, and update the license headers. I'm not sure what in what order those would go best; I'm hoping the relevant commits can be merged to the branch, but I'm not familiar enough with the code to attempt it. Instructions for publishing snapshots (and fixing permissions afterwards) are at the bottom of the release plan. I'll keep an eye on this, but starting next week I won't be available as much during the day. -- Wendy
RE: Patch Branch?
Awesome. I'll apply the patch on Sunday. Stan Silvert JBoss, a division of RedHat [EMAIL PROTECTED] -Original Message- From: Wendy Smoak [mailto:[EMAIL PROTECTED] Sent: Friday, January 05, 2007 10:35 PM To: MyFaces Development Subject: Re: Patch Branch? On 1/5/07, Stan Silvert [EMAIL PROTECTED] wrote: Stan, do you have the JIRA issue and svn revision(s) for the portlet bug fix? I need to know if it affects Shared or just Core. It's just core. http://issues.apache.org/jira/browse/MYFACES-1481 OK, then we can use the released Shared 2.0.3 with it. There having been no objections voiced so far... here's the branch: http://svn.apache.org/repos/asf/myfaces/core/branches/1_1_4_1/ And the release plan: http://wiki.apache.org/myfaces/CoreRelease1141 I added a JIRA version for 1.1.4.1-SNAPSHOT and moved MYFACES-1481 to it. It's ready for someone to apply the fix to the branch, and update the license headers. I'm not sure what in what order those would go best; I'm hoping the relevant commits can be merged to the branch, but I'm not familiar enough with the code to attempt it. Instructions for publishing snapshots (and fixing permissions afterwards) are at the bottom of the release plan. I'll keep an eye on this, but starting next week I won't be available as much during the day. -- Wendy
Status of Issue MYFACES-1411 (was Re: Patch Branch?)
Wendy, Is this a blocker or just one we really would like to have fixed prior to a 1.1.5 release? If it is a blocker, please update the issue accordingly. Paul Spencer Wendy Smoak wrote: On 1/4/07, Paul Spencer [EMAIL PROTECTED] wrote: Is their a reason NOT to release 1.1.5? Yes. There are still open issues for 1.1.5. MYFACES-1411 is the one that concerns me. I'm not familiar with the situation, I just flagged it as a contribution of new classes with no CLA on file.
Re: Status of Issue MYFACES-1411 (was Re: Patch Branch?)
On 1/5/07, Paul Spencer [EMAIL PROTECTED] wrote: Wendy, Is this a blocker or just one we really would like to have fixed prior to a 1.1.5 release? If it is a blocker, please update the issue accordingly. I think it is, but it's up to the MyFaces PMC to decide. I have not changed the priority because it will likely send an email to the contributor, and I don't want to make waves if someone is already in contact with him. -- Wendy
RE: Patch Branch?
Stan, do you have the JIRA issue and svn revision(s) for the portlet bug fix? I need to know if it affects Shared or just Core. -- Wendy It's just core. http://issues.apache.org/jira/browse/MYFACES-1481
Re: Patch Branch?
A patch release certainly would be a good idea but it takes time and resources to pull off each release. Its probably worth the effort since we tend to shoot ourselves in the foot when we release a whole set of features that sometimes contain radical changes and have not been tested extensively. Although it takes more effort, it might be nice to always have a patch branch available and then have an informal discussion on the dev list about which fixes belong in the patch vs. the next major release. Its the major refactoring that tends to cause problems due to our lack of unit tests. Sean On 1/5/07, Stan Silvert [EMAIL PROTECTED] wrote: Stan, do you have the JIRA issue and svn revision(s) for the portlet bug fix? I need to know if it affects Shared or just Core. -- Wendy It's just core. http://issues.apache.org/jira/browse/MYFACES-1481
Re: Patch Branch?
On 1/5/07, Sean Schofield [EMAIL PROTECTED] wrote: A patch release certainly would be a good idea but it takes time and resources to pull off each release. Its probably worth the effort since we tend to shoot ourselves in the foot when we release a whole set of features that sometimes contain radical changes and have not been tested extensively. Although it takes more effort, it might be nice to always have a patch branch available and then have an informal discussion on the dev list about which fixes belong in the patch vs. the next major release. Its the major refactoring that tends to cause problems due to our lack of unit tests. FWIW, this is the path we're going to follow for Shale. The 1.0.4 release is about to happen (vote in progress), and we created a SHALE_1_0_X branch to allow us to do any patch releases needed (1.0.5, ...). Feature development (towards a 1.1 release) will *only* happen on the trunk, so the fact that the trunk might be unstable at a particular point in time will have no effect on our ability to, say, fix a security vulnerability quickly. Craig Sean On 1/5/07, Stan Silvert [EMAIL PROTECTED] wrote: Stan, do you have the JIRA issue and svn revision(s) for the portlet bug fix? I need to know if it affects Shared or just Core. -- Wendy It's just core. http://issues.apache.org/jira/browse/MYFACES-1481
Re: Patch Branch?
On 1/5/07, Stan Silvert [EMAIL PROTECTED] wrote: Stan, do you have the JIRA issue and svn revision(s) for the portlet bug fix? I need to know if it affects Shared or just Core. It's just core. http://issues.apache.org/jira/browse/MYFACES-1481 OK, then we can use the released Shared 2.0.3 with it. There having been no objections voiced so far... here's the branch: http://svn.apache.org/repos/asf/myfaces/core/branches/1_1_4_1/ And the release plan: http://wiki.apache.org/myfaces/CoreRelease1141 I added a JIRA version for 1.1.4.1-SNAPSHOT and moved MYFACES-1481 to it. It's ready for someone to apply the fix to the branch, and update the license headers. I'm not sure what in what order those would go best; I'm hoping the relevant commits can be merged to the branch, but I'm not familiar enough with the code to attempt it. Instructions for publishing snapshots (and fixing permissions afterwards) are at the bottom of the release plan. I'll keep an eye on this, but starting next week I won't be available as much during the day. -- Wendy
Re: Patch Branch?
We don't have one. It's frequently requested. +1 on creating a 1.1.4.1 maintenance branch. On 1/4/07, Stan Silvert [EMAIL PROTECTED] wrote: Are we maintaining a service pack type of branch for MyFaces 1.1.4 core? There is a critical portlet bug that is fixed in 1.1.5, but I don't think we are planning a 1.1.5 release any time soon. What do you guys think of starting an SP branch for critical fixes (if we don't already have one)? Stan Silvert JBoss, a division of RedHat [EMAIL PROTECTED]
Re: Patch Branch?
Is their a reason NOT to release 1.1.5? Based on a Tomcat style release model I purposed earlier [1] we can label this release Alpha status and change it's status later. Assuming the current source is stable, which it appeared to be as of this weekend, we can release it meets the requirement for Alpha status. Advantages: 1) Mitigates the need for a 1.1.4.1 branch. 2) No need to run the TCK prior to the release. 3) A release is a sign of progress to the community. 4) Allows Maven based project currently using 1.1.5 functionality a version of MyFaces they can use in a release. (I am in this position) Paul Spencer [1] http://www.mail-archive.com/dev@myfaces.apache.org/msg19257.html Stan Silvert wrote: Are we maintaining a service pack type of branch for MyFaces 1.1.4 core? There is a critical portlet bug that is fixed in 1.1.5, but I don't think we are planning a 1.1.5 release any time soon. What do you guys think of starting an SP branch for critical fixes (if we don't already have one)? Stan Silvert JBoss, a division of RedHat [EMAIL PROTECTED]
Re: Patch Branch?
Hi Paul, 1) Mitigates the need for a 1.1.4.1 branch. There is still some small value for orgs that want the one fix w/out the inherit risk that comes with a new release of any piece of software. I do agree with you that a 1.1.5 release would be a better use of resources though. 2) No need to run the TCK prior to the release. Why would we no longer need this? Did Thomas ever get this running automated? Paul Spencer Dennis Byrne
Re: Patch Branch?
[release 1.1.5 now instead] 1) Mitigates the need for a 1.1.4.1 branch. Not really. In all likelihood, there are always going to be bugs in the latest release since new features are constantly being worked on. Users want to have access to a bug-fix release that does not add new features. 2) No need to run the TCK prior to the release. We have to run the TCK on all releases, whether 1.1.5 or 1.1.4.1. 3) A release is a sign of progress to the community. From the email I've received both on and off list, the community would consider bug fix releases a more practical sign of progress. 4) Allows Maven based project currently using 1.1.5 functionality a version of MyFaces they can use in a release. (I am in this position) Irrelevent. Having a bug fix release of 1.1.4.1 should not impact a release of 1.1.5. On 1/4/07, Paul Spencer [EMAIL PROTECTED] wrote: Is their a reason NOT to release 1.1.5? Based on a Tomcat style release model I purposed earlier [1] we can label this release Alpha status and change it's status later. Assuming the current source is stable, which it appeared to be as of this weekend, we can release it meets the requirement for Alpha status. Advantages: 1) Mitigates the need for a 1.1.4.1 branch. 2) No need to run the TCK prior to the release. 3) A release is a sign of progress to the community. 4) Allows Maven based project currently using 1.1.5 functionality a version of MyFaces they can use in a release. (I am in this position) Paul Spencer [1] http://www.mail-archive.com/dev@myfaces.apache.org/msg19257.html Stan Silvert wrote: Are we maintaining a service pack type of branch for MyFaces 1.1.4 core? There is a critical portlet bug that is fixed in 1.1.5, but I don't think we are planning a 1.1.5 release any time soon. What do you guys think of starting an SP branch for critical fixes (if we don't already have one)? Stan Silvert JBoss, a division of RedHat [EMAIL PROTECTED]
Re: Patch Branch?
Dennis Byrne wrote: Hi Paul, 1) Mitigates the need for a 1.1.4.1 branch. There is still some small value for orgs that want the one fix w/out the inherit risk that comes with a new release of any piece of software. I do agree with you that a 1.1.5 release would be a better use of resources though. I have no objections to a 1.1.4.1 bug fix release. 2) No need to run the TCK prior to the release. Why would we no longer need this? Did Thomas ever get this running automated? I have no idea if the TCK has been automated. If the TCK is, or can be run by Continuum, then that would be a great was of keeping bugs out of the source. BTW: I have been, slowly, adding unit and Selenium tests to Tomahawk. Paul Spencer Dennis Byrne
Re: Patch Branch?
Hello, is the new copyright policy a blocker for a 1.1.4.1 release? See: http://www.apache.org/legal/src-headers.html Regards Bernd Paul Spencer wrote: Dennis Byrne wrote: Hi Paul, 1) Mitigates the need for a 1.1.4.1 branch. There is still some small value for orgs that want the one fix w/out the inherit risk that comes with a new release of any piece of software. I do agree with you that a 1.1.5 release would be a better use of resources though. I have no objections to a 1.1.4.1 bug fix release. 2) No need to run the TCK prior to the release. Why would we no longer need this? Did Thomas ever get this running automated? I have no idea if the TCK has been automated. If the TCK is, or can be run by Continuum, then that would be a great was of keeping bugs out of the source. BTW: I have been, slowly, adding unit and Selenium tests to Tomahawk. Paul Spencer Dennis Byrne
Re: Patch Branch?
Mike Kienenberger wrote: [release 1.1.5 now instead] 1) Mitigates the need for a 1.1.4.1 branch. Not really. In all likelihood, there are always going to be bugs in the latest release since new features are constantly being worked on. Users want to have access to a bug-fix release that does not add new features. Point taken. 2) No need to run the TCK prior to the release. We have to run the TCK on all releases, whether 1.1.5 or 1.1.4.1. I understand this for release we announce as stable, but can we cut a release we believe will pass the TCK, and only announce it as stable after it passes the TCK. Granted we may have gaps in the list of stable version number, but this is what tomcat does today. 3) A release is a sign of progress to the community. From the email I've received both on and off list, the community would consider bug fix releases a more practical sign of progress. Point taken. 4) Allows Maven based project currently using 1.1.5 functionality a version of MyFaces they can use in a release. (I am in this position) Irrelevent. Having a bug fix release of 1.1.4.1 should not impact a release of 1.1.5. Point taken. snip Paul Spencer
Re: Patch Branch?
On 1/4/07, Paul Spencer [EMAIL PROTECTED] wrote: Is their a reason NOT to release 1.1.5? Yes. There are still open issues for 1.1.5. MYFACES-1411 is the one that concerns me. I'm not familiar with the situation, I just flagged it as a contribution of new classes with no CLA on file. -- Wendy
Re: Patch Branch?
On 1/4/07, Bernd Bohmann [EMAIL PROTECTED] wrote: is the new copyright policy a blocker for a 1.1.4.1 release? See: http://www.apache.org/legal/src-headers.html Yes, but it's fairly simple to fix. I think the Maven developers have been using an IDEA plugin to do it, and there are some scripts around (though I haven't tried them.) Stan, do you have the JIRA issue and svn revision(s) for the portlet bug fix? I need to know if it affects Shared or just Core. -- Wendy
