Re: JPA Controller Generation

2020-02-17 Thread Josh Juneau
Thanks Ken, for sending the PDF to me directly.  I agree that if these issues 
can be added to GitHub separately then it may be best.  I am surprised that the 
JIRA will not allow a PDF to be uploaded though?  I still think that it may be 
a good idea to try and attach the PDF to those issues somehow (dropbox link, 
etc.), just so your examples are included with the issues.

Josh Juneau
juneau...@gmail.com
http://jj-blogger.blogspot.com
https://www.apress.com/us/search?query=Juneau

> On Feb 17, 2020, at 8:58 AM, Geertjan Wielenga  wrote:
> 
> Best is to begin by trying to identify the code in Apache NetBeans GitHub
> that you would like to have changed. Then file an issue about that code and
> about how it should be different code.
> 
> Gj
> 
>> On Mon, 17 Feb 2020 at 15:54, Kenneth Fogel 
>> wrote:
>> 
>> The three issues are tied together and that is why I created a document. I
>> will turn them into three submissions to Jira but there are code examples
>> in the doc. Is it appropriate to include a link to them from my OneDrive,
>> Google Drive, or DropBox?
>> 
>> Ken
>> 
>> 
>> -Original Message-
>> From: Geertjan Wielenga 
>> Sent: February 17, 2020 3:17 AM
>> To: dev@netbeans.apache.org
>> Subject: Re: JPA Controller Generation
>> 
>> Indeed. Forget the document and just create an issue for each item
>> separately.
>> 
>> Ideally at least find the files in GitHub that need to be worked on to fix
>> the issues.
>> 
>> Gj
>> 
>>> On Mon, 17 Feb 2020 at 09:14, John Mc  wrote:
>>> 
>>> Hi
>>> 
>>> Might be more worthwhile to allow others to look at the issues your
>>> facing if you have multiple issues in a single word document to break
>>> them up and create a single Jira ticket for each issue. Then you don't
>>> need to upload a word document you can break that out and put each
>>> issue description into Jira.
>>> 
>>> 
>>> Regards
>>> 
>>> John
>>> 
>>> On Mon, 17 Feb 2020, 01:52 Kenneth Fogel, 
>>> wrote:
>>> 
 JIRA refused to accept my upload of a document that outlines my
 issues concerning the JPA generator. The file is available as a PDF
 or a Word docx. Both are refused with a message about a missing
 token. I do have a JIRA login. I will email it directly to you but
 I'd like to have it recorded on JIRA.
 
 Ken
 
 
 -Original Message-
 From: Josh Juneau 
 Sent: February 14, 2020 12:27 PM
 To: dev 
 Subject: Re: JPA Controller Generation
 
 Thanks for reporting this issue Ken.  It would be good to get
 something
>>> in
 the issue tracker for this problem.  I haven't used the
 auto-generation
>>> of
 new JPA controllers.  I usually create my own so I haven't come
 across
>>> this
 issue...but I'll see if I can replicate this problem.  I may not
>>> personally
 be able to make the repairs for this (at least not anytime soon),
 but it should at least get in the tracker so that we can have it in
>> the queue.
>>> It
 does sound like this code needs updating.
 
 It sounds like you have a good strategy for moving forward with your
 class.  Hope all goes well.
 
 Thanks
 
 Josh Juneau
 juneau...@gmail.com
 http://jj-blogger.blogspot.com
 https://www.apress.com/us/search?query=Juneau
 
 
 
 
 On Fri, Feb 14, 2020 at 8:31 AM Kenneth Fogel <
>>> kfo...@dawsoncollege.qc.ca>
 wrote:
 
> I have calmed down and wish to apologize for the harshness of my
> comments last night. I will download the latest source and review
> the code that generates the controllers et all. I will suggest
> that there should be two choices for JPA Controllers, one for
> stand alone and one for application server managed.
> 
> Ken
> 
> 
> From: Kenneth Fogel 
> Sent: Friday, February 14, 2020 12:51:59 AM
> To: dev@netbeans.apache.org 
> Subject: JPA Controller Generation
> 
> I have been using NetBeans, as many of you know, for years. In the
> winter I teach an EE course that uses the JPA. In using the New ->
> JPA Controllers from Entities I couldn’t believe what came out.
> Let’s
>>> review
 two changes:
> 
> If the persistence.xml file does not declare a connection (url,
> user,
> pwd) the generated controllers are empty. When this file is used
> for EE JPA you declare the connection in glassfish-resources.xml
> and not the persistence.xml. Previous versions of NB did show the
> connection details but if I edited for EE JPA and then generated
> the controllers they were still generated. The controllers are
> generated from the entities so why is the generator even looking at
>> persistence.xml.
> 
> Then there are the controllers themselves. They have been
> optimized for stand alone, resource local usage. The
> optimizations, espe

Re: JPA Controller Generation

2020-02-17 Thread Geertjan Wielenga
Best is to begin by trying to identify the code in Apache NetBeans GitHub
that you would like to have changed. Then file an issue about that code and
about how it should be different code.

Gj

On Mon, 17 Feb 2020 at 15:54, Kenneth Fogel 
wrote:

> The three issues are tied together and that is why I created a document. I
> will turn them into three submissions to Jira but there are code examples
> in the doc. Is it appropriate to include a link to them from my OneDrive,
> Google Drive, or DropBox?
>
> Ken
>
>
> -Original Message-
> From: Geertjan Wielenga 
> Sent: February 17, 2020 3:17 AM
> To: dev@netbeans.apache.org
> Subject: Re: JPA Controller Generation
>
> Indeed. Forget the document and just create an issue for each item
> separately.
>
> Ideally at least find the files in GitHub that need to be worked on to fix
> the issues.
>
> Gj
>
> On Mon, 17 Feb 2020 at 09:14, John Mc  wrote:
>
> > Hi
> >
> > Might be more worthwhile to allow others to look at the issues your
> > facing if you have multiple issues in a single word document to break
> > them up and create a single Jira ticket for each issue. Then you don't
> > need to upload a word document you can break that out and put each
> > issue description into Jira.
> >
> >
> > Regards
> >
> > John
> >
> > On Mon, 17 Feb 2020, 01:52 Kenneth Fogel, 
> > wrote:
> >
> > > JIRA refused to accept my upload of a document that outlines my
> > > issues concerning the JPA generator. The file is available as a PDF
> > > or a Word docx. Both are refused with a message about a missing
> > > token. I do have a JIRA login. I will email it directly to you but
> > > I'd like to have it recorded on JIRA.
> > >
> > > Ken
> > >
> > >
> > > -Original Message-
> > > From: Josh Juneau 
> > > Sent: February 14, 2020 12:27 PM
> > > To: dev 
> > > Subject: Re: JPA Controller Generation
> > >
> > > Thanks for reporting this issue Ken.  It would be good to get
> > > something
> > in
> > > the issue tracker for this problem.  I haven't used the
> > > auto-generation
> > of
> > > new JPA controllers.  I usually create my own so I haven't come
> > > across
> > this
> > > issue...but I'll see if I can replicate this problem.  I may not
> > personally
> > > be able to make the repairs for this (at least not anytime soon),
> > > but it should at least get in the tracker so that we can have it in
> the queue.
> > It
> > > does sound like this code needs updating.
> > >
> > > It sounds like you have a good strategy for moving forward with your
> > > class.  Hope all goes well.
> > >
> > > Thanks
> > >
> > > Josh Juneau
> > > juneau...@gmail.com
> > > http://jj-blogger.blogspot.com
> > > https://www.apress.com/us/search?query=Juneau
> > > 
> > >
> > >
> > >
> > > On Fri, Feb 14, 2020 at 8:31 AM Kenneth Fogel <
> > kfo...@dawsoncollege.qc.ca>
> > > wrote:
> > >
> > > > I have calmed down and wish to apologize for the harshness of my
> > > > comments last night. I will download the latest source and review
> > > > the code that generates the controllers et all. I will suggest
> > > > that there should be two choices for JPA Controllers, one for
> > > > stand alone and one for application server managed.
> > > >
> > > > Ken
> > > >
> > > > 
> > > > From: Kenneth Fogel 
> > > > Sent: Friday, February 14, 2020 12:51:59 AM
> > > > To: dev@netbeans.apache.org 
> > > > Subject: JPA Controller Generation
> > > >
> > > > I have been using NetBeans, as many of you know, for years. In the
> > > > winter I teach an EE course that uses the JPA. In using the New ->
> > > > JPA Controllers from Entities I couldn’t believe what came out.
> > > > Let’s
> > review
> > > two changes:
> > > >
> > > > If the persistence.xml file does not declare a connection (url,
> > > > user,
> > > > pwd) the generated controllers are empty. When this file is used
> > > > for EE JPA you declare the connection in glassfish-resources.xml
> > > > and not the persistence.xml. Previous versions of NB did show the
> > > > connection details but if I edited for EE JPA and then generated
> > > > the controllers they were still generated. The controllers are
> > > > generated from the entities so why is the generator even looking at
> persistence.xml.
> > > >
> > > > Then there are the controllers themselves. They have been
> > > > optimized for stand alone, resource local usage. The
> > > > optimizations, especially the use of finally clauses to eliminate
> > > > catch clauses makes no sense to me. Many but not all exceptions
> simply result in an em.close().
> > > > This is effectively the same as having an empty catch clause.
> > > > Plus, with an injected  EntityManager you should not be closing
> > > > it, if I understand how CDI works. There is no rollback anywhere.
> > > > If the JPA now rolls back automatically when an exception occurs
> > > > I’ll withdraw
> > this
> > > complaint but I doubt it does.
> > > >
> > >

RE: JPA Controller Generation

2020-02-17 Thread Kenneth Fogel
The three issues are tied together and that is why I created a document. I will 
turn them into three submissions to Jira but there are code examples in the 
doc. Is it appropriate to include a link to them from my OneDrive, Google 
Drive, or DropBox?

Ken


-Original Message-
From: Geertjan Wielenga  
Sent: February 17, 2020 3:17 AM
To: dev@netbeans.apache.org
Subject: Re: JPA Controller Generation

Indeed. Forget the document and just create an issue for each item separately.

Ideally at least find the files in GitHub that need to be worked on to fix the 
issues.

Gj

On Mon, 17 Feb 2020 at 09:14, John Mc  wrote:

> Hi
>
> Might be more worthwhile to allow others to look at the issues your 
> facing if you have multiple issues in a single word document to break 
> them up and create a single Jira ticket for each issue. Then you don't 
> need to upload a word document you can break that out and put each 
> issue description into Jira.
>
>
> Regards
>
> John
>
> On Mon, 17 Feb 2020, 01:52 Kenneth Fogel, 
> wrote:
>
> > JIRA refused to accept my upload of a document that outlines my 
> > issues concerning the JPA generator. The file is available as a PDF 
> > or a Word docx. Both are refused with a message about a missing 
> > token. I do have a JIRA login. I will email it directly to you but 
> > I'd like to have it recorded on JIRA.
> >
> > Ken
> >
> >
> > -Original Message-
> > From: Josh Juneau 
> > Sent: February 14, 2020 12:27 PM
> > To: dev 
> > Subject: Re: JPA Controller Generation
> >
> > Thanks for reporting this issue Ken.  It would be good to get 
> > something
> in
> > the issue tracker for this problem.  I haven't used the 
> > auto-generation
> of
> > new JPA controllers.  I usually create my own so I haven't come 
> > across
> this
> > issue...but I'll see if I can replicate this problem.  I may not
> personally
> > be able to make the repairs for this (at least not anytime soon), 
> > but it should at least get in the tracker so that we can have it in the 
> > queue.
> It
> > does sound like this code needs updating.
> >
> > It sounds like you have a good strategy for moving forward with your 
> > class.  Hope all goes well.
> >
> > Thanks
> >
> > Josh Juneau
> > juneau...@gmail.com
> > http://jj-blogger.blogspot.com
> > https://www.apress.com/us/search?query=Juneau
> > 
> >
> >
> >
> > On Fri, Feb 14, 2020 at 8:31 AM Kenneth Fogel <
> kfo...@dawsoncollege.qc.ca>
> > wrote:
> >
> > > I have calmed down and wish to apologize for the harshness of my 
> > > comments last night. I will download the latest source and review 
> > > the code that generates the controllers et all. I will suggest 
> > > that there should be two choices for JPA Controllers, one for 
> > > stand alone and one for application server managed.
> > >
> > > Ken
> > >
> > > 
> > > From: Kenneth Fogel 
> > > Sent: Friday, February 14, 2020 12:51:59 AM
> > > To: dev@netbeans.apache.org 
> > > Subject: JPA Controller Generation
> > >
> > > I have been using NetBeans, as many of you know, for years. In the 
> > > winter I teach an EE course that uses the JPA. In using the New -> 
> > > JPA Controllers from Entities I couldn’t believe what came out. 
> > > Let’s
> review
> > two changes:
> > >
> > > If the persistence.xml file does not declare a connection (url, 
> > > user,
> > > pwd) the generated controllers are empty. When this file is used 
> > > for EE JPA you declare the connection in glassfish-resources.xml 
> > > and not the persistence.xml. Previous versions of NB did show the 
> > > connection details but if I edited for EE JPA and then generated 
> > > the controllers they were still generated. The controllers are 
> > > generated from the entities so why is the generator even looking at 
> > > persistence.xml.
> > >
> > > Then there are the controllers themselves. They have been 
> > > optimized for stand alone, resource local usage. The 
> > > optimizations, especially the use of finally clauses to eliminate 
> > > catch clauses makes no sense to me. Many but not all exceptions simply 
> > > result in an em.close().
> > > This is effectively the same as having an empty catch clause. 
> > > Plus, with an injected  EntityManager you should not be closing 
> > > it, if I understand how CDI works. There is no rollback anywhere. 
> > > If the JPA now rolls back automatically when an exception occurs 
> > > I’ll withdraw
> this
> > complaint but I doubt it does.
> > >
> > > I could go on. If you want to see what controllers used to look 
> > > like and what had to be changed for EE look at my blog 
> > > https://www.omniprogrammer.com/?p=383.
> > >
> > > Is the JPA used more extensively on the desktop? I don’t think so.
> > > Here I take the blame for not pointing out that there needs to be 
> > > JPA generation for Application Servers. If you look at my blog you 
> > > can see that the changes were minimal to th

Re: Update centers based on mirrors are a nightmare to support in an enterprise environment

2020-02-17 Thread Jean-Marc Borer
Well, correct me if I am wrong, but the update center index itself is not
hosted on the mirrors. You get redirected from the links provided in the
index. And that is the issue for us.

On Wed, Feb 5, 2020 at 9:06 PM Laszlo Kishalmi 
wrote:

> I think the best way would be mirror the update center from one specific
> mirror (or might be even from the dist) internally in the corporation,
> then set up that one as an update center.
>
> You might wrote a very minimal plugin to set that UC up for everyone if
> there are a lot of people involved.
>
> On 2/5/20 12:00 PM, Neil C Smith wrote:
> > On Wed, 5 Feb 2020, 14:21 Peter Kovacs,  wrote:
> >
> >> The ASF publishes the releases at:
> >>
> >> https://apache.org/dist/netbeans/
> >>
> >> Maybe that is less of an issue?
> >>
> > That's an option, keeping in mind the limits here if there's a lot of
> > corporate use though  - https://www.apache.org/dev/infra-ban.html
> >
> > Otherwise maybe local mirroring?
> >
> > Best wishes,
> >
> > Neil
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
> For additional commands, e-mail: dev-h...@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>


Re: Update centers based on mirrors are a nightmare to support in an enterprise environment

2020-02-17 Thread Jean-Marc Borer
I like Matthias idea. At least with companies with very restrictive
whitelisting policies, you could force the use of a whitelisted mirror.
Sounds good.

Is there a need to write a plugin for that, or change something on the
infra or is it an improvement request for NB?

Cheers,

JMB

On Thu, Feb 6, 2020 at 8:22 AM Andreas Sewe  wrote:

> Geertjan Wielenga wrote:
> > I'm not sure what the solution is.
>
> FYI, the Eclipse Installer (aka Eclipse Oomph) has a "Use mirrors" check
> box, which is checked by default and thus likely being using in the vast
> majority of installs. The traditional Eclipse "Install New Software
> Dialog" doesn't expose such an option, though.
>
> Best wishes,
>
> Andreas
>
> --
> Dr. Andreas Sewe | s...@cqse.eu | +49 152 56342856
> CQSE GmbH | Centa-Hafenbraedl-Strasse 59 | 81249 Muenchen | www.cqse.eu
> Amtsgericht Muenchen | HRB 177678 | GF: F. Deissenboeck, M. Feilkas
>
>


Re: RE: [DISCUSS] Wrapping up Oracle's donation of NetBeans to Apache

2020-02-17 Thread Jesse Glick
On Thu, Feb 13, 2020 at 10:13 PM Eric Bresie  wrote:
> Silly question how easy is it to migrate some contrib code into a module?

If you are talking about contrib *modules*, which most of contrib is,
then…it is already a module. So I am not sure what you mean. How easy
is it to migrate it into the main repo? Just move the directory up,
maybe delete a couple of `../` in some metadata files, adjust
`nbbuild/cluster.properties`. Migrate to an Ant-based external module?
A bit trickier and you need a harness reference. To Maven? Rewrite
`project.xml` to `pom.xml`.

-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Re: JPA Controller Generation

2020-02-17 Thread Geertjan Wielenga
Indeed. Forget the document and just create an issue for each item
separately.

Ideally at least find the files in GitHub that need to be worked on to fix
the issues.

Gj

On Mon, 17 Feb 2020 at 09:14, John Mc  wrote:

> Hi
>
> Might be more worthwhile to allow others to look at the issues your facing
> if you have multiple issues in a single word document to break them up and
> create a single Jira ticket for each issue. Then you don't need to upload a
> word document you can break that out and put each issue description into
> Jira.
>
>
> Regards
>
> John
>
> On Mon, 17 Feb 2020, 01:52 Kenneth Fogel, 
> wrote:
>
> > JIRA refused to accept my upload of a document that outlines my issues
> > concerning the JPA generator. The file is available as a PDF or a Word
> > docx. Both are refused with a message about a missing token. I do have a
> > JIRA login. I will email it directly to you but I'd like to have it
> > recorded on JIRA.
> >
> > Ken
> >
> >
> > -Original Message-
> > From: Josh Juneau 
> > Sent: February 14, 2020 12:27 PM
> > To: dev 
> > Subject: Re: JPA Controller Generation
> >
> > Thanks for reporting this issue Ken.  It would be good to get something
> in
> > the issue tracker for this problem.  I haven't used the auto-generation
> of
> > new JPA controllers.  I usually create my own so I haven't come across
> this
> > issue...but I'll see if I can replicate this problem.  I may not
> personally
> > be able to make the repairs for this (at least not anytime soon), but it
> > should at least get in the tracker so that we can have it in the queue.
> It
> > does sound like this code needs updating.
> >
> > It sounds like you have a good strategy for moving forward with your
> > class.  Hope all goes well.
> >
> > Thanks
> >
> > Josh Juneau
> > juneau...@gmail.com
> > http://jj-blogger.blogspot.com
> > https://www.apress.com/us/search?query=Juneau
> > 
> >
> >
> >
> > On Fri, Feb 14, 2020 at 8:31 AM Kenneth Fogel <
> kfo...@dawsoncollege.qc.ca>
> > wrote:
> >
> > > I have calmed down and wish to apologize for the harshness of my
> > > comments last night. I will download the latest source and review the
> > > code that generates the controllers et all. I will suggest that there
> > > should be two choices for JPA Controllers, one for stand alone and one
> > > for application server managed.
> > >
> > > Ken
> > >
> > > 
> > > From: Kenneth Fogel 
> > > Sent: Friday, February 14, 2020 12:51:59 AM
> > > To: dev@netbeans.apache.org 
> > > Subject: JPA Controller Generation
> > >
> > > I have been using NetBeans, as many of you know, for years. In the
> > > winter I teach an EE course that uses the JPA. In using the New -> JPA
> > > Controllers from Entities I couldn’t believe what came out. Let’s
> review
> > two changes:
> > >
> > > If the persistence.xml file does not declare a connection (url, user,
> > > pwd) the generated controllers are empty. When this file is used for
> > > EE JPA you declare the connection in glassfish-resources.xml and not
> > > the persistence.xml. Previous versions of NB did show the connection
> > > details but if I edited for EE JPA and then generated the controllers
> > > they were still generated. The controllers are generated from the
> > > entities so why is the generator even looking at persistence.xml.
> > >
> > > Then there are the controllers themselves. They have been optimized
> > > for stand alone, resource local usage. The optimizations, especially
> > > the use of finally clauses to eliminate catch clauses makes no sense
> > > to me. Many but not all exceptions simply result in an em.close().
> > > This is effectively the same as having an empty catch clause. Plus,
> > > with an injected  EntityManager you should not be closing it, if I
> > > understand how CDI works. There is no rollback anywhere. If the JPA
> > > now rolls back automatically when an exception occurs I’ll withdraw
> this
> > complaint but I doubt it does.
> > >
> > > I could go on. If you want to see what controllers used to look like
> > > and what had to be changed for EE look at my blog
> > > https://www.omniprogrammer.com/?p=383.
> > >
> > > Is the JPA used more extensively on the desktop? I don’t think so.
> > > Here I take the blame for not pointing out that there needs to be JPA
> > > generation for Application Servers. If you look at my blog you can see
> > > that the changes were minimal to the old generated code. Now the
> > > changes will need to be more extensive.
> > >
> > > I have to stop now because I’m angry. Tomorrow morning I have to face
> > > a class and before that I need to decide if I should tell them to cut
> > > and paste code from my samples and change the names of objects or show
> > > them all the changes needed to make the generated code work.
> > >
> > > Please tell me I have it all wrong and I’ll be happy to apologize for
> > > this missive and never darken thi

Re: JPA Controller Generation

2020-02-17 Thread John Mc
Hi

Might be more worthwhile to allow others to look at the issues your facing
if you have multiple issues in a single word document to break them up and
create a single Jira ticket for each issue. Then you don't need to upload a
word document you can break that out and put each issue description into
Jira.


Regards

John

On Mon, 17 Feb 2020, 01:52 Kenneth Fogel, 
wrote:

> JIRA refused to accept my upload of a document that outlines my issues
> concerning the JPA generator. The file is available as a PDF or a Word
> docx. Both are refused with a message about a missing token. I do have a
> JIRA login. I will email it directly to you but I'd like to have it
> recorded on JIRA.
>
> Ken
>
>
> -Original Message-
> From: Josh Juneau 
> Sent: February 14, 2020 12:27 PM
> To: dev 
> Subject: Re: JPA Controller Generation
>
> Thanks for reporting this issue Ken.  It would be good to get something in
> the issue tracker for this problem.  I haven't used the auto-generation of
> new JPA controllers.  I usually create my own so I haven't come across this
> issue...but I'll see if I can replicate this problem.  I may not personally
> be able to make the repairs for this (at least not anytime soon), but it
> should at least get in the tracker so that we can have it in the queue.  It
> does sound like this code needs updating.
>
> It sounds like you have a good strategy for moving forward with your
> class.  Hope all goes well.
>
> Thanks
>
> Josh Juneau
> juneau...@gmail.com
> http://jj-blogger.blogspot.com
> https://www.apress.com/us/search?query=Juneau
> 
>
>
>
> On Fri, Feb 14, 2020 at 8:31 AM Kenneth Fogel 
> wrote:
>
> > I have calmed down and wish to apologize for the harshness of my
> > comments last night. I will download the latest source and review the
> > code that generates the controllers et all. I will suggest that there
> > should be two choices for JPA Controllers, one for stand alone and one
> > for application server managed.
> >
> > Ken
> >
> > 
> > From: Kenneth Fogel 
> > Sent: Friday, February 14, 2020 12:51:59 AM
> > To: dev@netbeans.apache.org 
> > Subject: JPA Controller Generation
> >
> > I have been using NetBeans, as many of you know, for years. In the
> > winter I teach an EE course that uses the JPA. In using the New -> JPA
> > Controllers from Entities I couldn’t believe what came out. Let’s review
> two changes:
> >
> > If the persistence.xml file does not declare a connection (url, user,
> > pwd) the generated controllers are empty. When this file is used for
> > EE JPA you declare the connection in glassfish-resources.xml and not
> > the persistence.xml. Previous versions of NB did show the connection
> > details but if I edited for EE JPA and then generated the controllers
> > they were still generated. The controllers are generated from the
> > entities so why is the generator even looking at persistence.xml.
> >
> > Then there are the controllers themselves. They have been optimized
> > for stand alone, resource local usage. The optimizations, especially
> > the use of finally clauses to eliminate catch clauses makes no sense
> > to me. Many but not all exceptions simply result in an em.close().
> > This is effectively the same as having an empty catch clause. Plus,
> > with an injected  EntityManager you should not be closing it, if I
> > understand how CDI works. There is no rollback anywhere. If the JPA
> > now rolls back automatically when an exception occurs I’ll withdraw this
> complaint but I doubt it does.
> >
> > I could go on. If you want to see what controllers used to look like
> > and what had to be changed for EE look at my blog
> > https://www.omniprogrammer.com/?p=383.
> >
> > Is the JPA used more extensively on the desktop? I don’t think so.
> > Here I take the blame for not pointing out that there needs to be JPA
> > generation for Application Servers. If you look at my blog you can see
> > that the changes were minimal to the old generated code. Now the
> > changes will need to be more extensive.
> >
> > I have to stop now because I’m angry. Tomorrow morning I have to face
> > a class and before that I need to decide if I should tell them to cut
> > and paste code from my samples and change the names of objects or show
> > them all the changes needed to make the generated code work.
> >
> > Please tell me I have it all wrong and I’ll be happy to apologize for
> > this missive and never darken this mailing list again. I will also be
> > happy to contribute JPA/EE controller templates if my concerns are valid.
> >
> > Ken
> >
> >
> >
> >
> >
> >
>